mirror of
https://github.com/hanzoai/o11y-foundry.git
synced 2026-11-03 02:08:34 +00:00
NageshbansalandGitHub
e8b1b4f653
### Summary - Introduce a `kind` discriminator for Casting. Existing Casting without a kind field keep working, empty kind defaults to `Installation` - New `api/v1alpha1/installation/` subpackage with the Installation Casting, Spec types and holds its own JSON schema from its Go type: `installation/casting.schema.json` - New Machinery interface in `api/v1alpha1/machinery.go` exposes `Kind()` and `TrackableProperties()` so Dispatcher(Getv1alpha1 and Forge/Cast/Gauge) work across any kind without knowing its concrete type. - A root casting.schema.json lists every per-Kind schema to supports IDEs completion from one schema URL - cmd/foundryctl gen schemas reads a list of types from schemaTargets. Adding a kind means adding one entry. Related: https://github.com/SigNoz/platform-pod/issues/1970
327 lines
8.0 KiB
Go
327 lines
8.0 KiB
Go
package yamlconfig
|
|
|
|
import (
|
|
"context"
|
|
"os"
|
|
"path/filepath"
|
|
"testing"
|
|
|
|
"github.com/signoz/foundry/api/v1alpha1"
|
|
"github.com/signoz/foundry/api/v1alpha1/installation"
|
|
"github.com/signoz/foundry/internal/domain"
|
|
"github.com/stretchr/testify/assert"
|
|
"github.com/stretchr/testify/require"
|
|
)
|
|
|
|
func TestGetV1Alpha1(t *testing.T) {
|
|
testCases := []struct {
|
|
name string
|
|
input string
|
|
assert func(t *testing.T, casting installation.Casting)
|
|
}{
|
|
{
|
|
name: "Defaults",
|
|
input: `
|
|
apiVersion: v1alpha1
|
|
metadata:
|
|
name: signoz
|
|
spec:
|
|
deployment:
|
|
mode: docker
|
|
flavor: compose
|
|
`,
|
|
assert: func(t *testing.T, casting installation.Casting) {
|
|
// All moldings should be enabled by default
|
|
assert.True(t, *casting.Spec.Signoz.Spec.Enabled)
|
|
assert.True(t, *casting.Spec.TelemetryStore.Spec.Enabled)
|
|
assert.True(t, *casting.Spec.TelemetryKeeper.Spec.Enabled)
|
|
assert.True(t, *casting.Spec.MetaStore.Spec.Enabled)
|
|
assert.True(t, *casting.Spec.Ingester.Spec.Enabled)
|
|
},
|
|
},
|
|
{
|
|
name: "DisableMetaStore",
|
|
input: `
|
|
apiVersion: v1alpha1
|
|
metadata:
|
|
name: signoz
|
|
spec:
|
|
deployment:
|
|
mode: docker
|
|
flavor: compose
|
|
metastore:
|
|
spec:
|
|
enabled: false
|
|
`,
|
|
assert: func(t *testing.T, casting installation.Casting) {
|
|
assert.False(t, *casting.Spec.MetaStore.Spec.Enabled)
|
|
// Other moldings should remain enabled
|
|
assert.True(t, *casting.Spec.Signoz.Spec.Enabled)
|
|
assert.True(t, *casting.Spec.TelemetryStore.Spec.Enabled)
|
|
assert.True(t, *casting.Spec.TelemetryKeeper.Spec.Enabled)
|
|
assert.True(t, *casting.Spec.Ingester.Spec.Enabled)
|
|
},
|
|
},
|
|
{
|
|
name: "DisableSignoz",
|
|
input: `
|
|
apiVersion: v1alpha1
|
|
metadata:
|
|
name: signoz
|
|
spec:
|
|
deployment:
|
|
mode: docker
|
|
flavor: compose
|
|
signoz:
|
|
spec:
|
|
enabled: false
|
|
`,
|
|
assert: func(t *testing.T, casting installation.Casting) {
|
|
assert.False(t, *casting.Spec.Signoz.Spec.Enabled)
|
|
assert.True(t, *casting.Spec.TelemetryStore.Spec.Enabled)
|
|
assert.True(t, *casting.Spec.TelemetryKeeper.Spec.Enabled)
|
|
assert.True(t, *casting.Spec.MetaStore.Spec.Enabled)
|
|
assert.True(t, *casting.Spec.Ingester.Spec.Enabled)
|
|
},
|
|
},
|
|
{
|
|
name: "DisableIngester",
|
|
input: `
|
|
apiVersion: v1alpha1
|
|
metadata:
|
|
name: signoz
|
|
spec:
|
|
deployment:
|
|
mode: docker
|
|
flavor: compose
|
|
ingester:
|
|
spec:
|
|
enabled: false
|
|
`,
|
|
assert: func(t *testing.T, casting installation.Casting) {
|
|
assert.False(t, *casting.Spec.Ingester.Spec.Enabled)
|
|
assert.True(t, *casting.Spec.Signoz.Spec.Enabled)
|
|
assert.True(t, *casting.Spec.TelemetryStore.Spec.Enabled)
|
|
assert.True(t, *casting.Spec.TelemetryKeeper.Spec.Enabled)
|
|
assert.True(t, *casting.Spec.MetaStore.Spec.Enabled)
|
|
},
|
|
},
|
|
{
|
|
name: "DisableTelemetryStore",
|
|
input: `
|
|
apiVersion: v1alpha1
|
|
metadata:
|
|
name: signoz
|
|
spec:
|
|
deployment:
|
|
mode: docker
|
|
flavor: compose
|
|
telemetrystore:
|
|
spec:
|
|
enabled: false
|
|
`,
|
|
assert: func(t *testing.T, casting installation.Casting) {
|
|
assert.False(t, *casting.Spec.TelemetryStore.Spec.Enabled)
|
|
assert.True(t, *casting.Spec.Signoz.Spec.Enabled)
|
|
assert.True(t, *casting.Spec.TelemetryKeeper.Spec.Enabled)
|
|
assert.True(t, *casting.Spec.MetaStore.Spec.Enabled)
|
|
assert.True(t, *casting.Spec.Ingester.Spec.Enabled)
|
|
},
|
|
},
|
|
{
|
|
name: "DisableTelemetryKeeper",
|
|
input: `
|
|
apiVersion: v1alpha1
|
|
metadata:
|
|
name: signoz
|
|
spec:
|
|
deployment:
|
|
mode: docker
|
|
flavor: compose
|
|
telemetrykeeper:
|
|
spec:
|
|
enabled: false
|
|
`,
|
|
assert: func(t *testing.T, casting installation.Casting) {
|
|
assert.False(t, *casting.Spec.TelemetryKeeper.Spec.Enabled)
|
|
assert.True(t, *casting.Spec.Signoz.Spec.Enabled)
|
|
assert.True(t, *casting.Spec.TelemetryStore.Spec.Enabled)
|
|
assert.True(t, *casting.Spec.MetaStore.Spec.Enabled)
|
|
assert.True(t, *casting.Spec.Ingester.Spec.Enabled)
|
|
},
|
|
},
|
|
{
|
|
name: "DisableMultipleMoldings",
|
|
input: `
|
|
apiVersion: v1alpha1
|
|
metadata:
|
|
name: signoz
|
|
spec:
|
|
deployment:
|
|
mode: docker
|
|
flavor: compose
|
|
metastore:
|
|
spec:
|
|
enabled: false
|
|
telemetrykeeper:
|
|
spec:
|
|
enabled: false
|
|
`,
|
|
assert: func(t *testing.T, casting installation.Casting) {
|
|
assert.False(t, *casting.Spec.MetaStore.Spec.Enabled)
|
|
assert.False(t, *casting.Spec.TelemetryKeeper.Spec.Enabled)
|
|
assert.True(t, *casting.Spec.Signoz.Spec.Enabled)
|
|
assert.True(t, *casting.Spec.TelemetryStore.Spec.Enabled)
|
|
assert.True(t, *casting.Spec.Ingester.Spec.Enabled)
|
|
},
|
|
},
|
|
{
|
|
name: "DisabledWithOtherFields",
|
|
input: `
|
|
apiVersion: v1alpha1
|
|
metadata:
|
|
name: signoz
|
|
spec:
|
|
deployment:
|
|
mode: docker
|
|
flavor: compose
|
|
metastore:
|
|
spec:
|
|
enabled: false
|
|
image: custom:1.0
|
|
`,
|
|
assert: func(t *testing.T, casting installation.Casting) {
|
|
assert.False(t, *casting.Spec.MetaStore.Spec.Enabled)
|
|
assert.Equal(t, "custom:1.0", casting.Spec.MetaStore.Spec.Image)
|
|
},
|
|
},
|
|
{
|
|
name: "ExplicitEnabledTrue",
|
|
input: `
|
|
apiVersion: v1alpha1
|
|
metadata:
|
|
name: signoz
|
|
spec:
|
|
deployment:
|
|
mode: docker
|
|
flavor: compose
|
|
metastore:
|
|
spec:
|
|
enabled: true
|
|
`,
|
|
assert: func(t *testing.T, casting installation.Casting) {
|
|
assert.True(t, *casting.Spec.MetaStore.Spec.Enabled)
|
|
},
|
|
},
|
|
{
|
|
name: "OverrideImageKeepsEnabledDefault",
|
|
input: `
|
|
apiVersion: v1alpha1
|
|
metadata:
|
|
name: signoz
|
|
spec:
|
|
deployment:
|
|
mode: docker
|
|
flavor: compose
|
|
metastore:
|
|
spec:
|
|
image: postgres:15
|
|
`,
|
|
assert: func(t *testing.T, casting installation.Casting) {
|
|
// Enabled should remain true (default) when only image is overridden
|
|
assert.True(t, *casting.Spec.MetaStore.Spec.Enabled)
|
|
assert.Equal(t, "postgres:15", casting.Spec.MetaStore.Spec.Image)
|
|
},
|
|
},
|
|
{
|
|
name: "OverrideVersion",
|
|
input: `
|
|
apiVersion: v1alpha1
|
|
metadata:
|
|
name: signoz
|
|
spec:
|
|
deployment:
|
|
mode: docker
|
|
flavor: compose
|
|
telemetrystore:
|
|
spec:
|
|
version: "24.8"
|
|
`,
|
|
assert: func(t *testing.T, casting installation.Casting) {
|
|
assert.True(t, *casting.Spec.TelemetryStore.Spec.Enabled)
|
|
assert.Equal(t, "24.8", casting.Spec.TelemetryStore.Spec.Version)
|
|
},
|
|
},
|
|
}
|
|
|
|
t.Parallel()
|
|
for _, tc := range testCases {
|
|
t.Run(tc.name, func(t *testing.T) {
|
|
dir := t.TempDir()
|
|
castingPath := filepath.Join(dir, "casting.yaml")
|
|
err := os.WriteFile(castingPath, []byte(tc.input), 0644)
|
|
require.NoError(t, err)
|
|
|
|
cfg := New()
|
|
casting, err := cfg.GetV1Alpha1(context.Background(), castingPath)
|
|
require.NoError(t, err)
|
|
|
|
inst, ok := casting.(*installation.Casting)
|
|
require.True(t, ok, "expected *installation.Casting, got %T", casting)
|
|
tc.assert(t, *inst)
|
|
})
|
|
}
|
|
}
|
|
|
|
func TestGetV1Alpha1Merge(t *testing.T) {
|
|
testCases := []struct {
|
|
name string
|
|
base installation.Casting
|
|
override installation.Casting
|
|
assert func(t *testing.T, casting installation.Casting)
|
|
}{
|
|
{
|
|
name: "EmptyOverride",
|
|
base: *installation.Default(),
|
|
override: installation.Casting{},
|
|
assert: func(t *testing.T, casting installation.Casting) {
|
|
assert.True(t, *casting.Spec.Signoz.Spec.Enabled)
|
|
assert.True(t, *casting.Spec.TelemetryStore.Spec.Enabled)
|
|
assert.True(t, *casting.Spec.MetaStore.Spec.Enabled)
|
|
assert.True(t, *casting.Spec.Ingester.Spec.Enabled)
|
|
},
|
|
},
|
|
{
|
|
name: "DisabledMoldingOverride",
|
|
base: *installation.Default(),
|
|
override: installation.Casting{
|
|
Spec: installation.Spec{
|
|
MetaStore: installation.MetaStore{
|
|
Spec: v1alpha1.MoldingSpec{
|
|
Enabled: domain.NewBoolPtr(false),
|
|
},
|
|
},
|
|
},
|
|
},
|
|
assert: func(t *testing.T, casting installation.Casting) {
|
|
assert.False(t, *casting.Spec.MetaStore.Spec.Enabled)
|
|
// Other moldings should remain enabled
|
|
assert.True(t, *casting.Spec.Signoz.Spec.Enabled)
|
|
assert.True(t, *casting.Spec.TelemetryStore.Spec.Enabled)
|
|
assert.True(t, *casting.Spec.Ingester.Spec.Enabled)
|
|
},
|
|
},
|
|
}
|
|
|
|
t.Parallel()
|
|
for _, tc := range testCases {
|
|
t.Run(tc.name, func(t *testing.T) {
|
|
base := tc.base
|
|
override := tc.override
|
|
err := v1alpha1.Merge(&base, &override)
|
|
require.NoError(t, err)
|
|
tc.assert(t, base)
|
|
})
|
|
}
|
|
}
|