Files
zeekayandHanzo Dev 0f213246d8 routing: one reader for a path segment, and it is not gorilla's
A path segment is a VALUE. Which router matched the route is not, and 140
handler bodies named gorilla/mux to read one — so the router was braided into
every piece of business logic that addresses a resource by id.

coretypes now owns the read (routevalue.go): Param for a path segment,
SetParams for the test that has no router, RoutePath for the route TEMPLATE the
audit record must be keyed on. One reader, one writer, one place that knows who
filled them. PathParam — the authz extractor — reads through the same Param, so
the gate and the handler cannot disagree about which segment they mean.

Converted end to end, both ends of one resource plus the shared plumbing:
llmpricingrule's handler, errortracking's handler AND its test injector, the
SelfAccess gate's id, and audit's route template. Nine tests, and they are not
vacuous: stubbing Param to "" turns eight of them red.

Param answers for a PATH segment only. A query value stays r.URL.Query().Get —
conflating the two is how a route starts reading the wrong half of the URL, and
TestParamIsNotAQueryRead pins it. RoutePath answers "" with no matched route
where the old mux.CurrentRoute(req).GetPathTemplate() dereferenced nil.

Route table unchanged: 367 method+path pairs before and after (353 typed ops,
11 hatches, 3 probes). No registration was touched — that flip is atomic across
the whole tree and is the next commit, not this one.

Co-authored-by: Hanzo Dev <[email protected]>
2026-08-01 18:44:32 -07:00

244 lines
7.2 KiB
Go

package implerrortracking
import (
"context"
"io"
"net/http"
"time"
"github.com/hanzoai/o11y/pkg/errors"
"github.com/hanzoai/o11y/pkg/http/binding"
"github.com/hanzoai/o11y/pkg/http/render"
"github.com/hanzoai/o11y/pkg/modules/errortracking"
"github.com/hanzoai/o11y/pkg/types/authtypes"
"github.com/hanzoai/o11y/pkg/types/coretypes"
"github.com/hanzoai/o11y/pkg/types/errortrackingtypes"
"github.com/hanzoai/o11y/pkg/valuer"
)
const (
viewTimeout = 30 * time.Second
writeTimeout = 15 * time.Second
ingestTimeout = 15 * time.Second
// maxCompressedBody bounds the raw request body before decompression; the
// decoded payload is separately bounded by maxDecodedBytes and the event count
// by maxEventsPerEnvelope.
maxCompressedBody = 6 << 20
)
// eventParser turns a decoded ingest body into events; the two wire formats differ
// only here (envelope framing vs a single store event).
type eventParser func([]byte) ([]*errortrackingtypes.SentryEvent, error)
type handler struct {
module errortracking.Module
// ingestSecret is the KMS-sourced platform ingest secret used to verify DSN
// public keys. Empty => ingest is disabled (fail closed), reads still work.
ingestSecret []byte
capturePII bool
revocations RevocationStore
limiter *rateLimiter
}
// NewHandler builds the HTTP surface. ingestSecret is the KMS-synced platform
// error-ingest secret (empty => ingest fails closed 503); capturePII retains
// end-user PII when true (default false = scrub); revocations resolves per-org key
// rotation (nil => none).
func NewHandler(module errortracking.Module, ingestSecret []byte, capturePII bool, revocations RevocationStore) errortracking.Handler {
if revocations == nil {
revocations = NoopRevocations{}
}
return &handler{
module: module,
ingestSecret: ingestSecret,
capturePII: capturePII,
revocations: revocations,
limiter: newRateLimiter(ingestRatePerSec, ingestBurst),
}
}
// --- ingest (public, DSN-authenticated) ---
func (h *handler) EnvelopeIngest(rw http.ResponseWriter, r *http.Request) {
h.ingest(rw, r, parseEnvelope)
}
func (h *handler) StoreIngest(rw http.ResponseWriter, r *http.Request) {
h.ingest(rw, r, parseStoreBody)
}
// ingest is the shared pipeline: enabled-check → resolve org from the DSN project →
// verify the DSN key at its version (rejecting revoked versions, constant-time) →
// per-org rate limit → bounded read+decode → parse (event-count capped) → normalize
// (scrub) → group+upsert the whole batch in one transaction. Every failure fails
// closed and never leaks internal detail to the untrusted client.
func (h *handler) ingest(rw http.ResponseWriter, r *http.Request, parse eventParser) {
ctx, cancel := context.WithTimeout(r.Context(), ingestTimeout)
defer cancel()
if len(h.ingestSecret) == 0 {
http.Error(rw, "error ingest is not configured", http.StatusServiceUnavailable)
return
}
project := coretypes.Param(r, "project_id")
orgID, ok := orgUUIDFromProject(project)
if !ok {
http.Error(rw, "missing project", http.StatusBadRequest)
return
}
minVersion := h.revocations.MinVersion(ctx, orgID)
if !verifyKey(h.ingestSecret, project, sentryKeyFromRequest(r), minVersion) {
// Sentry SDKs treat 401 as "bad DSN" and drop the event (no retry storm).
http.Error(rw, "invalid ingest key", http.StatusUnauthorized)
return
}
if !h.limiter.allow(orgID) {
rw.Header().Set("Retry-After", "1")
http.Error(rw, "rate limited", http.StatusTooManyRequests)
return
}
r.Body = http.MaxBytesReader(rw, r.Body, maxCompressedBody)
raw, err := io.ReadAll(r.Body)
if err != nil {
http.Error(rw, "payload too large", http.StatusRequestEntityTooLarge)
return
}
decoded, err := decodeBody(raw, r.Header.Get("Content-Encoding"))
if err != nil {
http.Error(rw, "cannot decode body", http.StatusBadRequest)
return
}
events, err := parse(decoded)
if err != nil {
http.Error(rw, "invalid payload", http.StatusBadRequest)
return
}
opts := ingestOpts{capturePII: h.capturePII}
occs := make([]*errortrackingtypes.Occurrence, 0, len(events))
lastID := ""
for _, ev := range events {
occ := normalizeEvent(ev, opts)
if occ.Fingerprint == "" {
continue
}
occs = append(occs, occ)
lastID = occ.EventID
}
if _, err := h.module.Ingest(ctx, orgID, occs); err != nil {
// A store failure is ours, not the client's — 500 so the SDK retries.
http.Error(rw, "ingest failed", http.StatusInternalServerError)
return
}
// Sentry SDKs only require 200; echo the last event id for parity.
render.Success(rw, http.StatusOK, map[string]string{"id": lastID})
}
// --- reads (Hanzo IAM authz, org-scoped) ---
func (h *handler) ListIssues(rw http.ResponseWriter, r *http.Request) {
ctx, cancel := context.WithTimeout(r.Context(), viewTimeout)
defer cancel()
orgID, err := orgFromContext(ctx)
if err != nil {
render.Error(rw, err)
return
}
var q errortrackingtypes.IssuesQuery
if err := binding.Query.BindQuery(r.URL.Query(), &q); err != nil {
render.Error(rw, err)
return
}
items, total, err := h.module.ListIssues(ctx, orgID, &q)
if err != nil {
render.Error(rw, err)
return
}
render.Success(rw, http.StatusOK, &errortrackingtypes.GettableIssues{
Items: items, Total: total, Offset: clampOffset(q.Offset), Limit: clampLimit(q.Limit),
})
}
func (h *handler) GetIssue(rw http.ResponseWriter, r *http.Request) {
ctx, cancel := context.WithTimeout(r.Context(), viewTimeout)
defer cancel()
orgID, err := orgFromContext(ctx)
if err != nil {
render.Error(rw, err)
return
}
id, err := idFromPath(r)
if err != nil {
render.Error(rw, err)
return
}
issue, err := h.module.GetIssue(ctx, orgID, id)
if err != nil {
render.Error(rw, err)
return
}
render.Success(rw, http.StatusOK, issue)
}
func (h *handler) UpdateIssue(rw http.ResponseWriter, r *http.Request) {
ctx, cancel := context.WithTimeout(r.Context(), writeTimeout)
defer cancel()
orgID, err := orgFromContext(ctx)
if err != nil {
render.Error(rw, err)
return
}
id, err := idFromPath(r)
if err != nil {
render.Error(rw, err)
return
}
req := new(errortrackingtypes.UpdateIssue)
if err := binding.JSON.BindBody(r.Body, req); err != nil {
render.Error(rw, err)
return
}
issue, err := h.module.UpdateIssue(ctx, orgID, id, req)
if err != nil {
render.Error(rw, err)
return
}
render.Success(rw, http.StatusOK, issue)
}
// --- shared helpers ---
// orgFromContext resolves the caller's org UUID from the gateway-asserted claims.
// It never panics on a malformed claim (a non-UUID org id fails closed as an
// unauthenticated request rather than crashing the handler).
func orgFromContext(ctx context.Context) (valuer.UUID, error) {
claims, err := authtypes.ClaimsFromContext(ctx)
if err != nil {
return valuer.UUID{}, err
}
orgID, err := valuer.NewUUID(claims.OrgID)
if err != nil {
return valuer.UUID{}, errors.Wrapf(err, errors.TypeUnauthenticated, errortrackingtypes.ErrCodeErrorTrackingUnauthorized, "identity carries no valid org")
}
return orgID, nil
}
func idFromPath(r *http.Request) (valuer.UUID, error) {
id, err := valuer.NewUUID(coretypes.Param(r, "id"))
if err != nil {
return valuer.UUID{}, errors.Wrapf(err, errors.TypeInvalidInput, errortrackingtypes.ErrCodeErrorTrackingInvalidInput, "id is not a valid uuid")
}
return id, nil
}