mirror of
https://github.com/hanzoai/o11y.git
synced 2026-10-15 12:58:33 +00:00
zeekay
c3dc2f1ecf
HIP-0132 unified o11y_logs, o11y_traces and o11y_metrics into one `event`
database and dropped them. The commit that restored the reads repointed
three files and said so; it was thirty. The rest went on naming databases
that no longer exist, so trace funnels, the Kafka and queue panels, the
v3/v4 logs and traces builders and the PromQL adapter each answered
Code: 81 UNKNOWN_DATABASE, and the golden tests agreed with them because
they pinned the same dead SQL.
pkg/telemetryplane is the one address for the name, imports nothing, and
is reachable from every depth that needs it. Its test walks the tree and
fails the build on a literal that names a dropped database, tests
included — a golden encoding broken SQL is a second vote for the bug, not
coverage.
Two service views turned a failed read into an offer to instrument an
already-instrumented application. A failure now shows the failure, and
onboarding is offered on a successful empty read.
Cherry-picked from salvage/blue-wt-o11y-readers 83ecbec03c.
172 lines
5.0 KiB
Go
172 lines
5.0 KiB
Go
package telemetrytraces
|
|
|
|
import (
|
|
"context"
|
|
"strings"
|
|
"testing"
|
|
"time"
|
|
|
|
"github.com/hanzoai/o11y/pkg/flagger/flaggertest"
|
|
"github.com/hanzoai/o11y/pkg/instrumentation/instrumentationtest"
|
|
"github.com/hanzoai/o11y/pkg/querybuilder"
|
|
qbtypes "github.com/hanzoai/o11y/pkg/types/querybuildertypes/querybuildertypesv5"
|
|
"github.com/hanzoai/o11y/pkg/types/telemetrytypes"
|
|
"github.com/hanzoai/o11y/pkg/types/telemetrytypes/telemetrytypestest"
|
|
"github.com/stretchr/testify/assert"
|
|
"github.com/stretchr/testify/require"
|
|
)
|
|
|
|
func TestTraceTimeRangeOptimization(t *testing.T) {
|
|
releaseTime := time.Date(2025, 5, 22, 22, 0, 0, 0, time.UTC)
|
|
|
|
fm := NewFieldMapper()
|
|
cb := NewConditionBuilder(fm)
|
|
mockMetadataStore := telemetrytypestest.NewMockMetadataStore()
|
|
|
|
mockMetadataStore.KeysMap = buildCompleteFieldKeyMap(releaseTime)
|
|
mockMetadataStore.KeysMap["trace_id"] = []*telemetrytypes.TelemetryFieldKey{{
|
|
Name: "trace_id",
|
|
FieldContext: telemetrytypes.FieldContextSpan,
|
|
FieldDataType: telemetrytypes.FieldDataTypeString,
|
|
Signal: telemetrytypes.SignalTraces,
|
|
}}
|
|
mockMetadataStore.KeysMap["name"] = []*telemetrytypes.TelemetryFieldKey{{
|
|
Name: "name",
|
|
FieldContext: telemetrytypes.FieldContextSpan,
|
|
FieldDataType: telemetrytypes.FieldDataTypeString,
|
|
Signal: telemetrytypes.SignalTraces,
|
|
}}
|
|
|
|
fl := flaggertest.New(t)
|
|
aggExprRewriter := querybuilder.NewAggExprRewriter(instrumentationtest.New().ToProviderSettings(), nil, fm, cb, nil, fl)
|
|
|
|
statementBuilder := NewTraceQueryStatementBuilder(
|
|
instrumentationtest.New().ToProviderSettings(),
|
|
mockMetadataStore,
|
|
fm,
|
|
cb,
|
|
aggExprRewriter,
|
|
nil, // telemetryStore is nil - adaptive path is disabled
|
|
fl,
|
|
false,
|
|
100000,
|
|
)
|
|
|
|
tests := []struct {
|
|
name string
|
|
query qbtypes.QueryBuilderQuery[qbtypes.TraceAggregation]
|
|
expectTimeOptimization bool
|
|
}{
|
|
{
|
|
name: "query with trace_id filter",
|
|
query: qbtypes.QueryBuilderQuery[qbtypes.TraceAggregation]{
|
|
Signal: telemetrytypes.SignalTraces,
|
|
Filter: &qbtypes.Filter{
|
|
Expression: "trace_id = '12345abc' AND service.name = 'api'",
|
|
},
|
|
SelectFields: []telemetrytypes.TelemetryFieldKey{
|
|
{Name: "name", FieldContext: telemetrytypes.FieldContextSpan},
|
|
},
|
|
},
|
|
expectTimeOptimization: true, // would optimize if telemetryStore was provided
|
|
},
|
|
{
|
|
name: "query with trace_id IN filter",
|
|
query: qbtypes.QueryBuilderQuery[qbtypes.TraceAggregation]{
|
|
Signal: telemetrytypes.SignalTraces,
|
|
Filter: &qbtypes.Filter{
|
|
Expression: "trace_id IN ['12345abc', '67890def'] AND service.name = 'api'",
|
|
},
|
|
SelectFields: []telemetrytypes.TelemetryFieldKey{
|
|
{Name: "name", FieldContext: telemetrytypes.FieldContextSpan},
|
|
},
|
|
},
|
|
expectTimeOptimization: true, // would optimize if telemetryStore was provided
|
|
},
|
|
{
|
|
name: "query without trace_id filter",
|
|
query: qbtypes.QueryBuilderQuery[qbtypes.TraceAggregation]{
|
|
Signal: telemetrytypes.SignalTraces,
|
|
Filter: &qbtypes.Filter{
|
|
Expression: "service.name = 'api'",
|
|
},
|
|
SelectFields: []telemetrytypes.TelemetryFieldKey{
|
|
{Name: "name", FieldContext: telemetrytypes.FieldContextSpan},
|
|
},
|
|
},
|
|
expectTimeOptimization: false,
|
|
},
|
|
{
|
|
name: "query with empty filter",
|
|
query: qbtypes.QueryBuilderQuery[qbtypes.TraceAggregation]{
|
|
Signal: telemetrytypes.SignalTraces,
|
|
SelectFields: []telemetrytypes.TelemetryFieldKey{
|
|
{Name: "name", FieldContext: telemetrytypes.FieldContextSpan},
|
|
},
|
|
},
|
|
expectTimeOptimization: false,
|
|
},
|
|
}
|
|
|
|
for _, tt := range tests {
|
|
t.Run(tt.name, func(t *testing.T) {
|
|
ctx := context.Background()
|
|
|
|
stmt, err := statementBuilder.Build(
|
|
ctx,
|
|
1747947419000, // start time in ms
|
|
1747983448000, // end time in ms
|
|
qbtypes.RequestTypeRaw,
|
|
tt.query,
|
|
nil,
|
|
)
|
|
|
|
require.NoError(t, err)
|
|
require.NotNil(t, stmt)
|
|
|
|
assert.NotEmpty(t, stmt.Query)
|
|
|
|
if tt.query.Filter != nil && tt.query.Filter.Expression != "" {
|
|
traceIDs, found := ExtractTraceIDsFromFilter(tt.query.Filter.Expression)
|
|
assert.Equal(t, tt.expectTimeOptimization, found && len(traceIDs) > 0)
|
|
}
|
|
})
|
|
}
|
|
}
|
|
|
|
func TestTraceTimeRangeFinderQuery(t *testing.T) {
|
|
expectedQuery := `
|
|
SELECT
|
|
toUnixTimestamp64Nano(min(timestamp)) as start_time,
|
|
toUnixTimestamp64Nano(max(timestamp)) as end_time
|
|
FROM event.span
|
|
WHERE traceID = ?
|
|
AND timestamp >= now() - INTERVAL 30 DAY
|
|
`
|
|
|
|
expectedQuery = normalizeQuery(expectedQuery)
|
|
|
|
actualQuery := `
|
|
SELECT
|
|
toUnixTimestamp64Nano(min(timestamp)) as start_time,
|
|
toUnixTimestamp64Nano(max(timestamp)) as end_time
|
|
FROM event.span
|
|
WHERE traceID = ?
|
|
AND timestamp >= now() - INTERVAL 30 DAY
|
|
`
|
|
actualQuery = normalizeQuery(actualQuery)
|
|
|
|
assert.Equal(t, expectedQuery, actualQuery)
|
|
}
|
|
|
|
func normalizeQuery(query string) string {
|
|
lines := []string{}
|
|
for _, line := range strings.Split(strings.TrimSpace(query), "\n") {
|
|
line = strings.TrimSpace(line)
|
|
if line != "" {
|
|
lines = append(lines, line)
|
|
}
|
|
}
|
|
return strings.Join(lines, " ")
|
|
}
|