mirror of
https://github.com/hanzoai/o11y.git
synced 2026-10-15 12:58:33 +00:00
PandeyandGitHub
180a756982
* feat(instrumentation): add OTel exception semantic convention log handler
Add a loghandler.Wrapper that enriches error log records with OpenTelemetry
exception semantic convention attributes (exception.type, exception.code,
exception.message, exception.stacktrace).
- Add errors.Attr() helper for standardized error logging under "exception" key
- Add exception log handler that replaces raw error attrs with structured group
- Wire exception handler into the instrumentation SDK logger chain
- Remove LogValue() from errors.base as the handler now owns structuring
* refactor: replace "error", err with errors.Attr(err) across codebase
Migrate all slog error logging from ad-hoc "error", err key-value pairs
to the standardized errors.Attr(err) helper, enabling the exception log
handler to enrich these logs with OTel semantic convention attributes.
* refactor: enforce attr-only slog style across codebase
Change sloglint from kv-only to attr-only, requiring all slog calls to
use typed attributes (slog.String, slog.Any, etc.) instead of key-value
pairs. Convert all existing kv-style slog calls in non-excluded paths.
* refactor: tighten slog.Any to specific types and standardize error attrs
- Replace slog.Any with slog.String for string values (action, key, where_clause)
- Replace slog.Any with slog.Uint64 for uint64 values (start, end, step, etc.)
- Replace slog.Any("err", err) with errors.Attr(err) in dispatcher and segment analytics
- Replace slog.Any("error", ctx.Err()) with errors.Attr in factory registry
* fix(instrumentation): use Unwrapb message for exception.message
Use the explicit error message (m) from Unwrapb instead of
foundErr.Error(), which resolves to the inner cause's message
for wrapped errors.
* feat(errors): capture stacktrace at error creation time
Store program counters ([]uintptr) in base errors at creation time
using runtime.Callers, inspired by thanos-io/thanos/pkg/errors. The
exception log handler reads the stacktrace from the error instead of
capturing at log time, showing where the error originated.
* fix(instrumentation): apply default log wrappers uniformly in NewLogger
Move correlation, filtering, and exception wrappers into NewLogger so
all call sites (including CLI loggers in cmd/) get them automatically.
* refactor(instrumentation): remove variadic wrappers from NewLogger
NewLogger no longer accepts arbitrary wrappers. The core wrappers
(correlation, filtering, exception) are hardcoded, preventing callers
from accidentally duplicating behavior.
* refactor: migrate remaining "error", <var> to errors.Attr across legacy paths
Replace all remaining "error", <variable> key-value pairs with
errors.Attr(<variable>) in pkg/query-service/ and ee/query-service/
paths that were missed in the initial migration due to non-standard
variable names (res.Err, filterErr, apiErrorObj.Err, etc).
* refactor(instrumentation): use flat exception.* keys instead of nested group
Use flat keys (exception.type, exception.code, exception.message,
exception.stacktrace) instead of a nested slog.Group in the exception
log handler.
61 lines
1.5 KiB
Go
61 lines
1.5 KiB
Go
// nolint
|
|
package transition
|
|
|
|
import (
|
|
"log/slog"
|
|
|
|
"golang.org/x/net/context"
|
|
)
|
|
|
|
type savedViewMigrateV5 struct {
|
|
migrateCommon
|
|
}
|
|
|
|
func NewSavedViewMigrateV5(logger *slog.Logger, logsDuplicateKeys []string, tracesDuplicateKeys []string) *savedViewMigrateV5 {
|
|
return &savedViewMigrateV5{
|
|
migrateCommon: migrateCommon{ambiguity: make(map[string][]string), logger: logger},
|
|
}
|
|
}
|
|
|
|
func (m *savedViewMigrateV5) Migrate(ctx context.Context, data map[string]any) bool {
|
|
updated := false
|
|
|
|
var version string
|
|
if _, ok := data["version"].(string); ok {
|
|
version = data["version"].(string)
|
|
}
|
|
|
|
if version == "v5" {
|
|
m.logger.InfoContext(ctx, "saved view is already migrated to v5, skipping")
|
|
return false
|
|
}
|
|
|
|
data["queries"] = make([]any, 0)
|
|
|
|
if builderQueries, ok := data["builderQueries"].(map[string]any); ok {
|
|
for name, query := range builderQueries {
|
|
if queryMap, ok := query.(map[string]any); ok {
|
|
var panelType string
|
|
if _, ok := data["panelType"].(string); ok {
|
|
panelType = data["panelType"].(string)
|
|
}
|
|
if m.updateQueryData(ctx, queryMap, "v4", panelType) {
|
|
updated = true
|
|
}
|
|
|
|
m.logger.InfoContext(ctx, "migrated querymap")
|
|
|
|
// wrap it in the v5 envelope
|
|
envelope := m.WrapInV5Envelope(name, queryMap, "builder_query")
|
|
m.logger.InfoContext(ctx, "envelope after wrap", slog.Any("envelope", envelope))
|
|
data["queries"] = append(data["queries"].([]any), envelope)
|
|
}
|
|
}
|
|
}
|
|
delete(data, "builderQueries")
|
|
|
|
data["version"] = "v5"
|
|
|
|
return updated
|
|
}
|