mirror of
https://github.com/hanzoai/o11y.git
synced 2026-10-15 12:58:33 +00:00
All three ZAP receivers narrowed Listen through a port parse into NodeConfig.Port, which threw the host away and made a socket path unrepresentable — the receiver could only ever bind TCP. zap already reads an address's form to choose its network (a leading /, ./, ../ or @ is unix), and BOTH emit sides already passed the address through untouched, so the receiver was the only half that could not say "a path". Nothing failed loudly when it could not: it quietly bound a TCP port instead. Listen is now passed whole. A host:port still binds TCP, so every off-pod sender is unaffected — the otel agent on 28 nodes, the gateway, and another cluster through the otlz door all keep working, and the port parse still refuses a malformed one. The socket is ADDITIVE; anyone planning to move :4317 onto a socket instead would take the fleet's telemetry down. What it buys is the in-pod hop. About 110 plugin processes and the o11y process share a pod and a run directory, and their telemetry crosses loopback TCP today for no reason — on an ear bound to 0.0.0.0 that any pod in the cluster can write to. Over a socket the filesystem's own permissions decide who may write, which is the discipline the rest of the plane already keeps (0700 directory, 0600 socket, SO_PEERCRED). uds_test.go pins the property rather than the reading: a path produces a file that is really a socket AND answers a dial, a port still binds TCP, and a malformed port is still refused.
204 lines
6.8 KiB
Go
204 lines
6.8 KiB
Go
// Copyright (C) 2025-2026, Lux Industries Inc. All rights reserved.
|
|
// SPDX-License-Identifier: BSD-3-Clause
|
|
|
|
// Package zapreceiver is the o11y-side endpoint of the ZAP-native trace
|
|
// transport defined by luxfi/trace.
|
|
//
|
|
// Wire: luxfi/zap envelope, MsgType=MsgSpanBatch, payload is JSON-encoded
|
|
// SpanBatch (see luxfi/trace.SpanBatch for the type definition). No
|
|
// protobuf, no OTLP, no gRPC — the ZAP envelope is the only framing.
|
|
//
|
|
// Usage:
|
|
//
|
|
// rcv, err := zapreceiver.New(zapreceiver.Config{
|
|
// Listen: ":4317",
|
|
// OnBatch: func(ctx context.Context, b *SpanBatch) error {
|
|
// return datastoreWriter.WriteBatch(ctx, b)
|
|
// },
|
|
// })
|
|
// if err != nil { return err }
|
|
// defer rcv.Stop()
|
|
package zapreceiver
|
|
|
|
import (
|
|
"context"
|
|
"encoding/json"
|
|
"errors"
|
|
"fmt"
|
|
"log/slog"
|
|
"strconv"
|
|
"strings"
|
|
"sync/atomic"
|
|
|
|
"github.com/luxfi/zap"
|
|
)
|
|
|
|
// MsgSpanBatch is the canonical ZAP MsgType for trace span batches.
|
|
// Must match luxfi/trace.MsgSpanBatch.
|
|
const MsgSpanBatch uint16 = 1
|
|
|
|
// SpanBatch is the JSON shape decoded out of the ZAP envelope.
|
|
// Field layout mirrors luxfi/trace.SpanBatch — keep these in lockstep.
|
|
type SpanBatch struct {
|
|
AppName string `json:"appName,omitempty"`
|
|
Version string `json:"version,omitempty"`
|
|
Resource map[string]string `json:"resource,omitempty"`
|
|
Spans []Span `json:"spans"`
|
|
}
|
|
|
|
type Span struct {
|
|
TraceID string `json:"traceId"`
|
|
SpanID string `json:"spanId"`
|
|
ParentSpanID string `json:"parentSpanId,omitempty"`
|
|
Name string `json:"name"`
|
|
Kind string `json:"kind,omitempty"`
|
|
StartUnixNs int64 `json:"startUnixNs"`
|
|
EndUnixNs int64 `json:"endUnixNs"`
|
|
Attributes map[string]any `json:"attributes,omitempty"`
|
|
Events []SpanEvent `json:"events,omitempty"`
|
|
StatusCode string `json:"statusCode,omitempty"`
|
|
StatusMsg string `json:"statusMessage,omitempty"`
|
|
}
|
|
|
|
type SpanEvent struct {
|
|
Name string `json:"name"`
|
|
TimeUnixNs int64 `json:"timeUnixNs"`
|
|
Attributes map[string]any `json:"attributes,omitempty"`
|
|
}
|
|
|
|
// Handler ingests one SpanBatch. Implementations should write to the
|
|
// telemetry store; return error to log + drop (the sender doesn't wait
|
|
// on the response).
|
|
type Handler func(ctx context.Context, batch *SpanBatch) error
|
|
|
|
// Config drives the receiver.
|
|
type Config struct {
|
|
// Listen is where the ZAP server binds. A host:port binds TCP; a path —
|
|
// anything starting /, ./, ../ or @ — binds a unix socket, because zap
|
|
// reads the address's form to choose the network. Empty defaults to
|
|
// ":4317", the canonical o11y ZAP port for spans.
|
|
//
|
|
// A socket is the right answer where sender and receiver share a pod: it
|
|
// needs no port, cannot be reached from another pod, and lets the
|
|
// filesystem's permissions say who may write telemetry. A TCP ear is
|
|
// reachable by anything in the cluster.
|
|
Listen string
|
|
// NodeID is the server-side ZAP node identifier (sent in handshake).
|
|
// Empty defaults to "o11y-zapreceiver".
|
|
NodeID string
|
|
// OnBatch is called for every decoded SpanBatch. Must be set.
|
|
OnBatch Handler
|
|
// Logger is used for receive-side warnings. Empty defaults to slog.Default().
|
|
Logger *slog.Logger
|
|
}
|
|
|
|
// Receiver is a running ZAP trace ingestion endpoint.
|
|
type Receiver struct {
|
|
cfg Config
|
|
node *zap.Node
|
|
batches atomic.Uint64
|
|
dropped atomic.Uint64
|
|
}
|
|
|
|
// New constructs and starts a Receiver. Returns immediately once the
|
|
// listener is up; the receiver runs in background goroutines until Stop.
|
|
func New(cfg Config) (*Receiver, error) {
|
|
if cfg.OnBatch == nil {
|
|
return nil, errors.New("zapreceiver: Config.OnBatch is required")
|
|
}
|
|
if cfg.Listen == "" {
|
|
cfg.Listen = ":4317"
|
|
}
|
|
if cfg.NodeID == "" {
|
|
cfg.NodeID = "o11y-zapreceiver"
|
|
}
|
|
if cfg.Logger == nil {
|
|
cfg.Logger = slog.Default()
|
|
}
|
|
|
|
// Listen is passed to zap WHOLE. zap.Network reads its form to choose the
|
|
// network — a leading /, ./, ../ or @ is a unix socket, anything else is
|
|
// TCP — so a path here binds a socket with no other change. This used to
|
|
// narrow the address through parsePort into NodeConfig.Port, which threw
|
|
// the host away and made a socket path unrepresentable: the receiver could
|
|
// only ever bind a TCP port, while both emit sides already spoke either.
|
|
//
|
|
// A socket is what the in-pod hop wants. ~110 plugin processes and the o11y
|
|
// process share a pod and a run directory, so their telemetry crosses
|
|
// loopback TCP today for no reason, unauthenticated on 0.0.0.0. Over a
|
|
// socket the filesystem's own permissions decide who may write, which is
|
|
// the discipline the rest of the plane already keeps (0700 dir, 0600 sock).
|
|
if zap.Network(cfg.Listen) == "tcp" {
|
|
if _, err := parsePort(cfg.Listen); err != nil {
|
|
return nil, fmt.Errorf("zapreceiver: invalid Listen %q: %w", cfg.Listen, err)
|
|
}
|
|
}
|
|
|
|
node := zap.NewNode(zap.NodeConfig{
|
|
NodeID: cfg.NodeID,
|
|
ServiceType: "_o11y._tcp",
|
|
Address: cfg.Listen,
|
|
Logger: cfg.Logger,
|
|
NoDiscovery: true,
|
|
})
|
|
|
|
r := &Receiver{cfg: cfg, node: node}
|
|
node.Handle(MsgSpanBatch, r.handle)
|
|
|
|
if err := node.Start(); err != nil {
|
|
return nil, fmt.Errorf("zapreceiver: zap.Node start: %w", err)
|
|
}
|
|
return r, nil
|
|
}
|
|
|
|
// Stop closes the listener and drains in-flight connections.
|
|
func (r *Receiver) Stop() {
|
|
r.node.Stop()
|
|
}
|
|
|
|
// Stats returns lifetime counters. Useful for metrics endpoints.
|
|
func (r *Receiver) Stats() (batches uint64, dropped uint64) {
|
|
return r.batches.Load(), r.dropped.Load()
|
|
}
|
|
|
|
// handle is the ZAP-level callback. It decodes the JSON payload out of
|
|
// the envelope and hands the batch to the registered Handler. We never
|
|
// return a non-nil error here — that would shut down the connection.
|
|
// Instead, we log and increment the dropped counter, so a misbehaving
|
|
// client doesn't take down the receive loop for everyone.
|
|
func (r *Receiver) handle(ctx context.Context, from string, msg *zap.Message) (*zap.Message, error) {
|
|
payload := msg.Root().Bytes(0)
|
|
if len(payload) == 0 {
|
|
r.cfg.Logger.Warn("zapreceiver: empty span batch payload", "from", from)
|
|
r.dropped.Add(1)
|
|
return nil, nil
|
|
}
|
|
|
|
var batch SpanBatch
|
|
if err := json.Unmarshal(payload, &batch); err != nil {
|
|
r.cfg.Logger.Warn("zapreceiver: unmarshal span batch", "from", from, "err", err)
|
|
r.dropped.Add(1)
|
|
return nil, nil
|
|
}
|
|
|
|
if err := r.cfg.OnBatch(ctx, &batch); err != nil {
|
|
r.cfg.Logger.Warn("zapreceiver: handler returned error", "from", from, "spans", len(batch.Spans), "err", err)
|
|
r.dropped.Add(1)
|
|
return nil, nil
|
|
}
|
|
r.batches.Add(1)
|
|
return nil, nil
|
|
}
|
|
|
|
// parsePort accepts ":4317", "4317", "host:4317" and returns 4317.
|
|
func parsePort(addr string) (int, error) {
|
|
host := addr
|
|
if i := strings.LastIndex(addr, ":"); i >= 0 {
|
|
host = addr[i+1:]
|
|
}
|
|
if host == "" {
|
|
return 0, errors.New("missing port")
|
|
}
|
|
return strconv.Atoi(host)
|
|
}
|