mirror of
https://github.com/hanzoai/otel-collector.git
synced 2026-11-03 02:20:04 +00:00
Piyush SingariyaandGitHub
0ae67739f0
## Pull Request ### Summary Update tests for better sanity about two cases 1. Where parent is updated 2. Where leaf node is Array ## Resource Impact **Will this change affect the application's resource usage?** - [ ] Yes - [x] No If **Yes**, describe: - **Resources impacted:** (CPU, Memory, Disk, Network, etc.) - **Expected change:** (e.g., +10% CPU, -150MB RAM) - **Benchmarks:** Provide before/after results and how they were measured. <!-- Ideally the test should be done where you keep ingestion rate and configuration same and observe the changes in CPU, Memory, Ingestion Rate and the Lag on Kafka>
320 lines
7.9 KiB
Go
320 lines
7.9 KiB
Go
package clickhouselogsexporter
|
|
|
|
import (
|
|
"testing"
|
|
|
|
"github.com/stretchr/testify/assert"
|
|
"go.opentelemetry.io/collector/pdata/pcommon"
|
|
)
|
|
|
|
func TestInvalidBodyType(t *testing.T) {
|
|
body := pcommon.NewValueStr("test log")
|
|
promoted := buildPromoted(body, map[string]struct{}{})
|
|
assert.Equal(t, pcommon.NewValueMap(), promoted)
|
|
}
|
|
|
|
func TestPromotedPathSeparation(t *testing.T) {
|
|
testCases := []struct {
|
|
name string
|
|
body map[string]interface{}
|
|
promotedPaths map[string]struct{}
|
|
expectedPromoted map[string]interface{}
|
|
}{
|
|
{
|
|
name: "simple_literal_key_match",
|
|
body: map[string]interface{}{
|
|
"message": "test log",
|
|
"level": "info",
|
|
"user.id": "123",
|
|
},
|
|
promotedPaths: map[string]struct{}{
|
|
"user.id": {},
|
|
},
|
|
expectedPromoted: map[string]interface{}{
|
|
"user.id": "123",
|
|
},
|
|
},
|
|
{
|
|
name: "nested_path_extraction",
|
|
body: map[string]interface{}{
|
|
"message": "test log",
|
|
"user": map[string]interface{}{
|
|
"id": "123",
|
|
"name": "john",
|
|
"email": "[email protected]",
|
|
},
|
|
},
|
|
promotedPaths: map[string]struct{}{
|
|
"user.id": {},
|
|
"user.name": {},
|
|
},
|
|
expectedPromoted: map[string]interface{}{
|
|
"user.id": "123",
|
|
"user.name": "john",
|
|
},
|
|
},
|
|
{
|
|
name: "parent_is_promoted_but_is_not_leaf_in_data_input",
|
|
body: map[string]interface{}{
|
|
"message": "test log",
|
|
"user": map[string]interface{}{
|
|
"id": "123",
|
|
"name": "john",
|
|
"email": "[email protected]",
|
|
},
|
|
},
|
|
promotedPaths: map[string]struct{}{
|
|
"user": {},
|
|
},
|
|
expectedPromoted: map[string]interface{}{},
|
|
},
|
|
{
|
|
name: "array_leaf_found_promoted",
|
|
body: map[string]interface{}{
|
|
"message": "test log",
|
|
"user": map[string]interface{}{
|
|
"orders": []any{
|
|
map[string]any{
|
|
"id": "1",
|
|
"created_at": "some date",
|
|
},
|
|
},
|
|
"id": "123",
|
|
},
|
|
},
|
|
promotedPaths: map[string]struct{}{
|
|
"user.orders": {},
|
|
},
|
|
expectedPromoted: map[string]interface{}{
|
|
"user.orders": []any{
|
|
map[string]any{
|
|
"id": "1",
|
|
"created_at": "some date",
|
|
},
|
|
},
|
|
},
|
|
},
|
|
// This is likely not happen, but is covered for completeness
|
|
// ClickHouse will fail ingestion if there are multiple occurrences of the same path
|
|
// type_json_skip_duplicated_paths can be enabled during parsing JSON object into JSON type duplicated paths will be ignored and only the first one will be inserted instead of an exception
|
|
// https://clickhouse.com/docs/operations/settings/formats#type_json_skip_duplicated_paths
|
|
{
|
|
name: "ambiguous_dot_notation_literal_preference",
|
|
body: map[string]interface{}{
|
|
"message": "test log",
|
|
"a.b.c": "literal_value", // use first occurrence of the path
|
|
"a": map[string]interface{}{
|
|
"b": map[string]interface{}{
|
|
"c": "nested_value",
|
|
},
|
|
},
|
|
},
|
|
promotedPaths: map[string]struct{}{
|
|
"a.b.c": {},
|
|
},
|
|
expectedPromoted: map[string]interface{}{
|
|
"a.b.c": "literal_value",
|
|
},
|
|
},
|
|
{
|
|
name: "multiple_siblings_same_parent",
|
|
body: map[string]interface{}{
|
|
"message": "test log",
|
|
"user": map[string]interface{}{
|
|
"id": "123",
|
|
"name": "john",
|
|
"email": "[email protected]",
|
|
"address": map[string]interface{}{
|
|
"street": "123 Main St",
|
|
"city": "New York",
|
|
},
|
|
},
|
|
},
|
|
promotedPaths: map[string]struct{}{
|
|
"user.id": {},
|
|
"user.name": {},
|
|
"user.address.city": {},
|
|
},
|
|
expectedPromoted: map[string]interface{}{
|
|
"user.id": "123",
|
|
"user.name": "john",
|
|
"user.address.city": "New York",
|
|
},
|
|
},
|
|
{
|
|
name: "multiple_siblings_same_parent_with_dot_notation",
|
|
body: map[string]interface{}{
|
|
"message": "test log",
|
|
"user": map[string]interface{}{
|
|
"id": "123",
|
|
"name": "john",
|
|
"email": "[email protected]",
|
|
"address.street": "123 Main St",
|
|
"address.city": "New York",
|
|
},
|
|
},
|
|
promotedPaths: map[string]struct{}{
|
|
"user.id": {},
|
|
"user.name": {},
|
|
"user.address.city": {},
|
|
},
|
|
expectedPromoted: map[string]interface{}{
|
|
"user.id": "123",
|
|
"user.name": "john",
|
|
"user.address.city": "New York",
|
|
},
|
|
},
|
|
{
|
|
name: "deeply_nested_paths",
|
|
body: map[string]interface{}{
|
|
"message": "test log",
|
|
"request": map[string]interface{}{
|
|
"headers": map[string]interface{}{
|
|
"authorization": "Bearer token123",
|
|
"content-type": "application/json",
|
|
},
|
|
"body": map[string]interface{}{
|
|
"user": map[string]interface{}{
|
|
"profile": map[string]interface{}{
|
|
"settings": map[string]interface{}{
|
|
"theme": "dark",
|
|
},
|
|
},
|
|
},
|
|
},
|
|
},
|
|
},
|
|
promotedPaths: map[string]struct{}{
|
|
"request.headers.authorization": {},
|
|
"request.body.user.profile.settings.theme": {},
|
|
},
|
|
expectedPromoted: map[string]interface{}{
|
|
"request.headers.authorization": "Bearer token123",
|
|
"request.body.user.profile.settings.theme": "dark",
|
|
},
|
|
},
|
|
{
|
|
name: "no_promoted_paths",
|
|
body: map[string]interface{}{
|
|
"message": "test log",
|
|
"level": "info",
|
|
"user": map[string]interface{}{
|
|
"id": "123",
|
|
},
|
|
},
|
|
promotedPaths: map[string]struct{}{},
|
|
expectedPromoted: map[string]interface{}{},
|
|
},
|
|
{
|
|
name: "non_existent_paths",
|
|
body: map[string]interface{}{
|
|
"message": "test log",
|
|
"level": "info",
|
|
},
|
|
promotedPaths: map[string]struct{}{
|
|
"non.existent.path": {},
|
|
"another.missing": {},
|
|
},
|
|
expectedPromoted: map[string]interface{}{},
|
|
},
|
|
{
|
|
name: "mixed_literal_and_nested",
|
|
body: map[string]interface{}{
|
|
"message": "test log",
|
|
"a.b.c": "literal",
|
|
"a": map[string]interface{}{
|
|
"b": map[string]interface{}{
|
|
"d": "nested",
|
|
},
|
|
},
|
|
},
|
|
promotedPaths: map[string]struct{}{
|
|
"a.b.c": {},
|
|
"a.b.d": {},
|
|
},
|
|
expectedPromoted: map[string]interface{}{
|
|
"a.b.c": "literal",
|
|
"a.b.d": "nested",
|
|
},
|
|
},
|
|
{
|
|
name: "nested_after_match_is_found",
|
|
body: map[string]interface{}{
|
|
"message": "test log",
|
|
"a.b.c": "literal",
|
|
"a": map[string]interface{}{
|
|
"b": map[string]interface{}{
|
|
"d": map[string]interface{}{
|
|
"nested_key": "nested_value",
|
|
},
|
|
},
|
|
},
|
|
},
|
|
promotedPaths: map[string]struct{}{
|
|
"a.b.c": {},
|
|
"a.b.d": {},
|
|
},
|
|
expectedPromoted: map[string]interface{}{
|
|
"a.b.c": "literal",
|
|
},
|
|
},
|
|
{
|
|
name: "nested_after_match_is_found_with_dot_notation",
|
|
body: map[string]interface{}{
|
|
"message": "test log",
|
|
"a.b.c": "literal",
|
|
"a": map[string]interface{}{
|
|
"b.d": map[string]interface{}{
|
|
"nested_key": "nested_value",
|
|
},
|
|
},
|
|
},
|
|
promotedPaths: map[string]struct{}{
|
|
"a.b.c": {},
|
|
"a.b.d": {},
|
|
},
|
|
expectedPromoted: map[string]interface{}{
|
|
"a.b.c": "literal",
|
|
},
|
|
},
|
|
{
|
|
name: "nested_2_matches_found",
|
|
body: map[string]interface{}{
|
|
"message": "test log",
|
|
"a.b.c": map[string]interface{}{
|
|
"nested_key": "nested_value",
|
|
},
|
|
"a": map[string]interface{}{
|
|
"b.c": "literal",
|
|
},
|
|
},
|
|
promotedPaths: map[string]struct{}{
|
|
"a.b.c": {},
|
|
},
|
|
expectedPromoted: map[string]interface{}{
|
|
"a.b.c": "literal",
|
|
},
|
|
},
|
|
}
|
|
|
|
for _, tc := range testCases {
|
|
t.Run(tc.name, func(t *testing.T) {
|
|
// Create pcommon.Value from test body
|
|
body := pcommon.NewValueMap()
|
|
err := body.Map().FromRaw(tc.body)
|
|
assert.NoError(t, err, "failed to convert map to pcommon.Map")
|
|
|
|
// Extract promoted paths
|
|
promoted := buildPromoted(body, tc.promotedPaths)
|
|
|
|
// Convert results back to interface{} for comparison
|
|
actualBody := body.Map().AsRaw()
|
|
actualPromoted := promoted.Map().AsRaw()
|
|
|
|
// Assertions
|
|
assert.Equal(t, tc.body, actualBody, "Body should stay the same after extraction")
|
|
assert.Equal(t, tc.expectedPromoted, actualPromoted, "Promoted should match expected")
|
|
})
|
|
}
|
|
}
|