* Fix `opts` argument cannot be omitted
* Assign default values to `opts` just in case
- The `opts` argument to `Node#error` is currently omissible, but we'll assign a default value just in case.
* Add test cases
* Add test cases for `Node#rangeBy({start, end})`
* Add test cases for offset
* Fix missing offset in `Node#positionInside`, `Node#positionBy` and `Node#rangeBy`
* Fix conflict resolution mistakes
---------
Co-authored-by: Andrey Sitnik <[email protected]>
This allows subclasses to call and override this method. This PR also
adds a shared type declaration for the common argument type used to
add or create new nodes, which eventually gets passed into
`normalize`.
Many files from postcss are exported. Each of this file is written using
the syntax:
```js
module.exports = Thing
```
This should be typed as:
```ts
export = Thing
```
If such a file needs to export additional types, a namespace should be
used.
However, it was typed as:
```ts
export default thing
```
This was solved at the time in #1459 (by me) by adding the following
code to each module:
```js
Thing.default = Thing
```
Whilst affective at the time, this was not the correct solution. The
introduction of the `"module": "node16"` option in TypeScript made this
issue more apparent. I recommend to remove this in a next semver major
release.
Usage has changed as follows:
**cts**
```jsonc
// tsconfig.json
{
"compilerOptions": {
"module": "commonjs",
"moduleResolution": "node16"
}
}
```
```ts
// Old
import postcss = require('postcss')
postcss.default(/* … */)
```
```ts
// New
import postcss = require('postcss')
postcss(/* … */)
```
**cjs**
```jsonc
// tsconfig.json
{
"compilerOptions": {
"checkJs": true,
"module": "commonjs",
"moduleResolution": "node16"
}
}
```
```ts
// Old
const postcss = require('postcss')
postcss.default(/* … */)
```
```ts
// New
const postcss = require('postcss')
postcss(/* … */)
```
**mts** / **mjs**
```jsonc
// tsconfig.json
{
"compilerOptions": {
"module": "node16"
}
}
```
```ts
// Old
import postcss from 'postcss'
postcss.default(/* … */)
```
```ts
// New
import postcss from 'postcss'
postcss(/* … */)
```
**bundler**
```jsonc
// tsconfig.json
{
"compilerOptions": {
"allowSyntheticDefaultImports": true,
"module": "esnext",
"moduleResolution": "node16"
}
}
```
```ts
// Unchanged
import postcss from 'postcss'
postcss(/* … */)
```
**ES module interop** (Not recommended for library code!)
```jsonc
// tsconfig.json
{
"compilerOptions": {
"esModuleInterop": true,
"module": "commonjs",
"moduleResolution": "node16"
}
}
```
```ts
// Unchanged
import postcss from 'postcss'
postcss(/* … */)
```
When compiling to CJS, it is still possible to write ESM-like syntax,
for example:
```jsonc
// Same as import postcss = require('postcss')
import * as postcss from 'postcss'
// Named imports from namespaces are allowed
import { root, Root } from 'postcss'
```
The following changes were made to `tsconfig.json`:
- `lib` was specified explicitly. By default, TypeScript includes the
`dom` types. This is not desirable, it even causes some conflicts with
types used by Postcss.
- `allowJs` was removed. When this is enabled, TypeScript treats `.d.ts`
files matching `.js` files as output. This caused some unexpected
issues where TypeScript simply ignored type errors.
- `skipLibCheck` was removed. Ideally all types just work together. This
can be added again later if necessary.
- `esModuleInterop` was removed. Enabling this option causes TypeScript
to allow code that is otherwise invalid. This may be useful for CLIs
or website, but is dangerous to use for libraries.
Correcting these options also highlighted some issues in the tests.
These have been resolved. `nanodelay@1` has incorrect type definitions,
so it has been marked using `@ts-expect-error` comments.
In `test/errors.ts` were some type errors. These were marked as
`THROWS`, which signals `check-dts` a type error is expected.
This was changed to `@ts-expect-error`, which works too, but it also
works with other TypeScript tooling.
The `Postcss` type was missing some properties. As a side effect of the
corrected types, these are now available. This also affects the `Helper`
type.
Last, but not least, type definitions have been added for `postcss.mjs`.
Closes#1814
The `assign` function lets authors assign multiple properties to a node from a single object.
This can improve code clarity when updating multiple properties while offering a helpful typing experience.
