Files
zeekayandHanzo Dev c80140810a kms: migrate hanzo-kms off Infisical paths onto the luxfi/kms surface
kms.hanzo.ai runs luxfi/kms, which has never served an /api/* route. This
SDK was sending Infisical's: /api/v3/secrets/raw for every secret operation,
/api/v3/auth/login for user auth, /api/v1/auth/kubernetes-auth/login for k8s.
Only one call in the whole package — /v1/kms/auth/login — was ever real.

It stayed invisible because older luxfi/kms builds embedded a console SPA
behind a root catch-all that answered every unmatched path with 200
text/html. A wrong URL came back as a JSON decode error, which reads like a
parsing bug in the client rather than "this endpoint does not exist." That
catch-all is gone (cmd/kms/main.go ends in notFoundJSON), so those paths now
return honest JSON 404s and the SDK fails outright.

The route table is not the only thing that was wrong. The data model was
Infisical's too — project_id, workspace, secret version, secret comment,
shared-vs-personal type — and luxfi/kms has none of those concepts. It keys
one value by (org, path, name, env) in ZapDB at kms/secrets/{path}/{env}/{name}
and a write upserts it in place. Half-migrating would have left response
models that cannot validate what the server sends, so the vocabulary moves
with the paths:

  list_secrets(path, env) -> names   GET  /v1/kms/orgs/{org}/secrets
  get_secret(path, name, env)        GET  /v1/kms/orgs/{org}/secrets/{path}/{name}
  put_secret(path, name, value, env) POST /v1/kms/orgs/{org}/secrets   (create AND replace)
  delete_secret(path, name, env)     DELETE .../secrets/{path}/{name}
  health()                           GET  /v1/kms/healthz

Two server behaviors now have one home, hanzo_kms/routes.py, shared by the
sync and async clients so they stay mirror images:

  - The server splits the trailing path at its LAST slash into (path, name),
    so each segment is escaped individually. Escaping the joined string
    encodes the separators away and the server reads one long name. A name
    containing "/" is rejected outright: it would be written under one key
    and read back under another, so the write looks like it succeeded and
    the read never finds it.
  - There is no versioned read. get_secret(version=N) raises
    VersionUnsupportedError rather than quietly returning the current value.

org is new and required — it scopes both the URL and the JWT owner claim.
Constructor field, HANZO_KMS_ORG, defaults to "hanzo".

Auth collapses to what the server actually offers: client credentials
exchanged at /v1/kms/auth/login, or a pre-issued IAM bearer token. The AWS,
Azure, GCP, Kubernetes and SRP methods were Infisical's and none were served.
That also fixes a divergence where the async client silently ignored
HANZO_KMS_TOKEN — env parsing is now one function.

Callers migrated with it: hanzo-cli's `hanzo kms`, the hanzo-tools-kms MCP
tool, and hanzo-tools-auth's session client, all of which were building the
removed auth models and calling the removed create/update pair. Each now
constructs KMSClient() and lets it read the environment.

Tests: pkg/hanzo-kms/tests pins the wire shape — no request URL may contain
"/api/", per-segment escaping survives the server's last-slash split, sync
and async emit byte-identical request lines, and a decoder rejects the
200-HTML/JSON-404 shapes instead of reading them as empty results. Wired into
hanzo-packages-ci without `|| true`, so a regression turns CI red instead of
waiting for a decode error in production.

hanzo-kms 1.1.0 -> 1.1.1.

Co-authored-by: Hanzo Dev <[email protected]>
2026-07-26 08:29:59 -07:00

51 lines
1.9 KiB
Python

"""Settings and response models for the canonical luxfi/kms surface."""
import os
from pydantic import BaseModel, ConfigDict, Field
DEFAULT_SITE_URL = "https://kms.hanzo.ai"
DEFAULT_ORG = "hanzo"
class ClientSettings(BaseModel):
"""KMS client configuration.
Auth is one of exactly two things: a pre-issued IAM bearer token
(``access_token``), or machine-identity client credentials that
``POST /v1/kms/auth/login`` exchanges for one. luxfi/kms has a single
login route — the AWS / Azure / GCP / Kubernetes / SRP methods this SDK
used to model were Infisical's, and none of them were ever served.
"""
site_url: str = Field(DEFAULT_SITE_URL, description="KMS base URL")
org: str = Field(
DEFAULT_ORG,
description="Organization — scopes both the secret path and the JWT `owner` claim",
)
client_id: str = Field("", description="Machine identity client ID")
client_secret: str = Field("", description="Machine identity client secret")
access_token: str = Field("", description="Pre-issued IAM bearer token; skips login")
user_agent: str = Field("hanzo-kms-python", description="User agent string")
def settings_from_env() -> ClientSettings:
"""Build settings from the ``HANZO_KMS_*`` environment variables."""
return ClientSettings(
site_url=os.getenv("HANZO_KMS_URL", DEFAULT_SITE_URL),
org=os.getenv("HANZO_KMS_ORG", DEFAULT_ORG),
client_id=os.getenv("HANZO_KMS_CLIENT_ID", ""),
client_secret=os.getenv("HANZO_KMS_CLIENT_SECRET", ""),
access_token=os.getenv("HANZO_KMS_TOKEN", ""),
)
class TokenResponse(BaseModel):
"""``POST /v1/kms/auth/login`` response."""
model_config = ConfigDict(populate_by_name=True)
access_token: str = Field(..., alias="accessToken")
expires_in: int = Field(..., alias="expiresIn")
token_type: str = Field("Bearer", alias="tokenType")