Commit Graph
64 Commits
Author SHA1 Message Date
Brian Vaughn 3a0ef57e4a Changed react-window alias 2019-06-05 14:33:24 -07:00
Brian Vaughn 34e1091cac Vendored react-window 2019-06-05 14:27:57 -07:00
Brian Vaughn 066d47a2f5 Lots of tweaks
Remove selected guideline in favor of background color for selected subtree.
Add badges in grid format to selected elements prop panel.
Show badges beside owners list.
2019-06-01 08:24:24 -07:00
Brian Vaughn 9eabd982d5 Profiler properly handles unmounted roots 2019-05-22 10:19:26 -07:00
Brian Vaughn 6ceafb72c1 Upgraded to canary with priority level info 2019-05-20 09:54:07 -07:00
Brian Vaughn 2790e55fec Show commit priority levels in Profiler UI 2019-05-20 09:39:26 -07:00
Brian Vaughn f8a7193935 Custom filters are applied by default after extension reload 2019-05-08 14:22:06 -07:00
Brian Vaughn 72d006340b Merge branch '232-clear-profiling-data-for-unmounted-root' of https://github.com/sompylasar/react-devtools-experimental into sompylasar-232-clear-profiling-data-for-unmounted-root 2019-05-03 09:24:58 -07:00
Brian Vaughn 4afad6b3eb Fixed deploy script 2019-05-03 08:55:31 -07:00
Dan Abramov 02d5899ed4 Use WebpackDevServer for local testing 2019-05-01 17:19:26 +01:00
Ivan Babak be87bc778b Fix profiling screenshots data structure to map rootID to commitIndex
Propagate `rootID` throughout the code for `captureScreenshot`.

Rename private profiling maps of `store` to make relations more clear.

Fix missing cleanup for screenshots data in `set importedProfilingData` of `store`.
2019-05-01 01:07:36 -07:00
Brian VaughnandGitHub 33b1fafd96 Merge pull request #229 from sompylasar/217-workaround-disconnected-port-error
Fix for 'Attempting to use a disconnected port object'
2019-04-30 09:15:52 -07:00
Brian VaughnandGitHub 2b0590d46d Merge pull request #233 from gaearon/preset-env
Start using @babel/preset-env
2019-04-30 08:50:17 -07:00
Ivan Babak 2bf97e8f01 Fix for 'Attempting to use a disconnected port object'
Fixes https://github.com/bvaughn/react-devtools-experimental/issues/217

The error reproduces with any two React websites, e.g. `https://reactjs.org` and `https://nextjs.org`, by keeping the DevTools Components tab open and switching between these websites in the same browser tab.

There are several issues with the code that contribute to this:
1. `Bridge` leaves behind a dangling timer that fires `_flush` after the bridge has been abandoned ("shutdown").
2. `bridge.send('shutdown')` is asynchronous, so the event handlers do not get unsubscribed in time.
3. `port.onDisconnect` does not trigger on in-tab navigation like new URL or back/forward navigation.
4. State management design of the code that uses shared variables and callbacks makes it hard to handle race conditions originating from the browser.

This commit cleans up some of the lacking symmetry when using `addListener`/`removeListener`, but the code in `shells/browser/shared/src/main.js` is hard to reason about with regards to race conditions, and there are many possible race conditions originating from the browser, so maybe there could be a better design paradigm (like a formal state machine) to manage the state changes in response to sequences of events than plain old event listeners, callbacks, and shared variables.

Unrelated, but clicking Chrome Back/Forward/Back/Forward very fast makes the browser and the DevTools and the DevTools of DevTools stall and become unresponsive for some time, then recovers but the Back/Forward/Stop/Refresh button and favicon loading indicator may remain broken. Looks like a Chrome bug, some kind of a temporary deadlock in handling the browser history.
2019-04-28 04:45:57 -07:00
Ivan Babak 7caa534afc Remove Agent addBridge: there can only be one bridge, add in constructor
Let's make impossible states truly impossible, and fix Flow types, too.

All three usages of Agent called addBridge right after constructing it.
Agent has one field `_bridge` which is force-typed as not-null despite
there's a temporary zone between the constructor end and addBridge start
where `_bridge` is null.
2019-04-28 04:03:28 -07:00
Dan Abramov ba655512ca Start using @babel/preset-env 2019-04-26 19:37:23 +01:00
Brian Vaughn 78c2c764fc Node scripts should fail if not NODE_ENV specified 2019-04-18 18:13:34 -07:00
Brian Vaughn 3336acb8ee Deploy production extension builds 2019-04-18 14:45:24 -07:00
Dan Abramov cd26a5c338 Add production mode to dev shell 2019-04-15 15:39:25 +01:00
Brian Vaughn 68532fb2dc Updated React test utils for newer version of act() 2019-04-12 08:55:29 -07:00
Brian Vaughn c7afeb32b1 Add Git revision to build version 2019-04-11 18:44:44 -07:00
Brian Vaughn b6b2fff095 Added ErrorBoundary with GitHub bug link 2019-04-11 17:19:16 -07:00
Dan Abramov f6142d8acf Put DevTools in dev shell above the inspector 2019-04-10 14:26:33 +01:00
Dan 4cd0c76117 Fix profiler and nits 2019-04-05 23:34:27 +01:00
Dan Abramov 85ffb4b23f Expand the test fixture 2019-04-05 21:49:37 +01:00
Dan 2e5e99f968 Fix Suspense fragment edge cases 2019-04-05 21:49:37 +01:00
Dan Abramov 722fb18387 Fix double-adding fibers when traversing 2019-04-05 18:18:39 +01:00
Brian Vaughn 71a38e3841 Added truncation UI indicator for hooks. Addressed lint rule violations. 2019-04-04 14:09:10 -07:00
Dan Abramov 8fa5aa3b44 Don't crash for deeply nested Hooks 2019-04-04 19:28:42 +01:00
Brian Vaughn e16210da59 Added option to disable screenshot capturing while profiling 2019-04-03 14:32:16 -07:00
Brian Vaughn 49f3747446 Fixed editing props for memo and forwardRef components 2019-04-03 09:29:33 -07:00
Brian Vaughn 275f9ce82c Webpack config injects a __DEV_ constant 2019-03-26 13:22:55 -07:00
Brian Vaughn ca8dba85e7 Clicking commits and interactions link to each other 2019-03-24 09:46:54 -07:00
Brian Vaughn 4d24f6a647 Added interaction tracing test harness to shell 2019-03-24 09:21:37 -07:00
Brian Vaughn 972a63bda0 Added suspense to TODO list and added interactions to 'Commit Info' panel 2019-03-20 09:39:14 -07:00
Sriram Thiagarajan 4fb5cd3ac3 fix import file name 2019-03-09 07:03:42 +05:30
Brian Vaughn e5cbf78541 Add placeholders to clarify between empty string, null, and undefined 2019-02-28 10:46:17 -08:00
Brian Vaughn e629cc726d Updated test code to include a deeply nested DIV 2019-02-27 13:05:43 -08:00
Brian Vaughn 19b174ecbb Yarn upgrade 2019-02-24 18:32:29 -08:00
Brian Vaughn 0be48e88e4 Updated deploy scripts and pre-release template 2019-02-23 08:59:21 -08:00
Brian Vaughn 1a0c30f015 Fixed null input value. Tweaked useReducer test harness. 2019-02-21 13:40:23 -08:00
Brian Vaughn a5b8f5fff3 Updated editable hooks UI and added limited undo feature 2019-02-21 13:24:01 -08:00
Brian Vaughn 42d6381d4c Updated flow-bin from 91 -> 93 and removed unnecessary fixmes 2019-02-21 09:15:47 -08:00
Brian Vaughn 43eabe641f Fix hooks warnings identified by prerelease version of react-hooks ESLint plugin 2019-02-19 13:15:57 -08:00
Brian Vaughn a4212dcdce Support editable props, state, and context values 2019-02-17 13:07:39 -08:00
Brian Vaughn 2fbacbff01 Tab bar resizes properly for narrow screens 2019-02-15 11:42:55 -08:00
Brian Vaughn 0008bb00d7 Inspectable complex hook values 2019-02-14 21:55:09 -08:00
Brian Vaughn 15c5396169 Re-added "Settings" panel to browser extension and (hopefully) fixed a lot of sources of error 2019-02-14 11:45:11 -08:00
Brian Vaughn 79f57532b9 Split demo app into multiple roots and fixed a multi-root bug 2019-02-13 11:22:22 -08:00
Brian Vaughn aed1713154 Added NOW config file for dev shell 2019-02-12 21:09:50 -05:00