mirror of
https://github.com/hanzoai/s3-csi.git
synced 2026-09-30 23:52:32 +00:00
Fork of seaweedfs/seaweedfs-csi-driver, renamed seaweedfs -> s3 throughout and ported off protobuf entirely. WHY a fork was unavoidable: hanzoai/s3 serves HanzoFiler over the native ZAP transport on the port still named "grpc" (18888) — s3/command/filer.go binds it with transport.ListenStream and says it "replaces the legacy gRPC HanzoFiler server: the whole filer (28 unary + 5 streaming RPCs) now answers over ZAP, no gRPC". RegisterHanzoFilerServer exists nowhere in that tree. So the upstream driver's gRPC client cannot connect at all; it fails as `Unimplemented: unknown service filer_pb.SeaweedFiler`, which LOOKS like a service-name mismatch but is a gRPC client hitting a non-gRPC port. Renaming the service in the client would not have helped. pkg/filer is the only place this driver touches storage, and it speaks ZAP: Mkdir -> CreateEntry (CreateVolume) Remove -> DeleteEntry (DeleteVolume) Exists -> LookupDirectoryEntry (ValidateVolumeCapabilities) One shared, concurrency-safe client multiplexes over a single ZAP connection, dials lazily so controller start does not depend on filer readiness, and redials exactly once on a transport fault (covers a filer restart closing an idle conn without becoming a retry storm against a struggling backend). pkg/driver/volume.go Quota() likewise moves to s3/wire/mount — the fork generates no mount_pb at all. Dead gRPC plumbing (WithFilerClient, AdjustedUrl, grpcDialOption) is deleted rather than left inert. The kubelet-facing side stays CSI gRPC: that is the Kubernetes contract between kubelet and any CSI driver, not a Hanzo choice. Zero protobuf call sites remain. Whole module compiles clean. Co-authored-by: Hanzo Dev <[email protected]>
193 lines
5.0 KiB
Go
193 lines
5.0 KiB
Go
package driver
|
|
|
|
import (
|
|
"crypto/sha256"
|
|
"encoding/hex"
|
|
"fmt"
|
|
"os"
|
|
"path/filepath"
|
|
"strings"
|
|
"sync"
|
|
|
|
"github.com/container-storage-interface/spec/lib/go/csi"
|
|
"github.com/hanzoai/s3-csi/pkg/datalocality"
|
|
"github.com/hanzoai/s3-csi/pkg/k8s"
|
|
"github.com/hanzoai/s3-csi/pkg/mountmanager"
|
|
"github.com/hanzoai/s3/s3/glog"
|
|
"golang.org/x/net/context"
|
|
"google.golang.org/grpc"
|
|
"k8s.io/mount-utils"
|
|
)
|
|
|
|
func NewNodeServer(n *S3Driver) *NodeServer {
|
|
if n.CacheDir != "" {
|
|
cleanCacheDir := filepath.Clean(n.CacheDir)
|
|
cleanTempDir := filepath.Clean(os.TempDir())
|
|
if cleanCacheDir != cleanTempDir {
|
|
if err := removeDirContent(cleanCacheDir); err != nil {
|
|
glog.Warningf("error cleaning up cache dir %s: %v", cleanCacheDir, err)
|
|
}
|
|
}
|
|
}
|
|
|
|
ns := &NodeServer{
|
|
Driver: n,
|
|
volumeMutexes: NewKeyMutex(),
|
|
stopCh: make(chan struct{}),
|
|
mounterFactory: newMounter,
|
|
capacityFn: func(volumeID string) (int64, error) {
|
|
return k8s.GetVolumeCapacity(n.name, volumeID)
|
|
},
|
|
isHealthyFn: isStagingPathHealthy,
|
|
cleanupStagingFn: cleanupStaleStagingPath,
|
|
unmountFn: mountutil.Unmount,
|
|
bindMountFn: defaultBindMount,
|
|
}
|
|
ns.startHealthMonitor(defaultHealthCheckInterval)
|
|
return ns
|
|
}
|
|
|
|
func GetCacheDir(cacheBase, volumeID string) string {
|
|
if cacheBase == "" {
|
|
cacheBase = os.TempDir()
|
|
}
|
|
// volumeIDs are full paths in s3
|
|
// Use hash value instead to get flat cache dir structure
|
|
h := sha256.Sum256([]byte(volumeID))
|
|
hashStr := hex.EncodeToString(h[:])
|
|
return filepath.Join(cacheBase, hashStr)
|
|
}
|
|
|
|
func GetLocalSocket(volumeSocketDir, volumeID string) string {
|
|
return mountmanager.LocalSocketPath(volumeSocketDir, volumeID)
|
|
}
|
|
|
|
func CleanupVolumeResources(driver *S3Driver, volumeID string) {
|
|
cacheDir := GetCacheDir(driver.CacheDir, volumeID)
|
|
|
|
// Validate that cacheDir is within cacheBase to prevent path traversal
|
|
cacheBase := driver.CacheDir
|
|
if cacheBase == "" {
|
|
cacheBase = os.TempDir()
|
|
}
|
|
cleanCacheBase := filepath.Clean(cacheBase)
|
|
cleanCacheDir := filepath.Clean(cacheDir)
|
|
rel, err := filepath.Rel(cleanCacheBase, cleanCacheDir)
|
|
if err == nil && rel != "." && !strings.HasPrefix(rel, "..") {
|
|
if err := os.RemoveAll(cleanCacheDir); err != nil {
|
|
glog.Warningf("failed to remove cache dir %s for volume %s: %v", cleanCacheDir, volumeID, err)
|
|
}
|
|
} else {
|
|
glog.Warningf("skipping cache dir removal for volume %s: invalid path %s (rel: %s, err: %v)", volumeID, cleanCacheDir, rel, err)
|
|
}
|
|
|
|
localSocket := GetLocalSocket(driver.volumeSocketDir, volumeID)
|
|
if err := os.Remove(localSocket); err != nil && !os.IsNotExist(err) {
|
|
glog.Warningf("failed to remove local socket %s for volume %s: %v", localSocket, volumeID, err)
|
|
}
|
|
}
|
|
|
|
func NewIdentityServer(d *S3Driver) *IdentityServer {
|
|
return &IdentityServer{
|
|
Driver: d,
|
|
}
|
|
}
|
|
|
|
func NewControllerServer(d *S3Driver) *ControllerServer {
|
|
|
|
return &ControllerServer{
|
|
Driver: d,
|
|
}
|
|
}
|
|
|
|
func NewControllerServiceCapability(cap csi.ControllerServiceCapability_RPC_Type) *csi.ControllerServiceCapability {
|
|
return &csi.ControllerServiceCapability{
|
|
Type: &csi.ControllerServiceCapability_Rpc{
|
|
Rpc: &csi.ControllerServiceCapability_RPC{
|
|
Type: cap,
|
|
},
|
|
},
|
|
}
|
|
}
|
|
|
|
func ParseEndpoint(ep string) (string, string, error) {
|
|
if strings.HasPrefix(strings.ToLower(ep), "unix://") || strings.HasPrefix(strings.ToLower(ep), "tcp://") {
|
|
s := strings.SplitN(ep, "://", 2)
|
|
if s[1] != "" {
|
|
return s[0], s[1], nil
|
|
}
|
|
}
|
|
return "", "", fmt.Errorf("invalid endpoint: %v", ep)
|
|
}
|
|
|
|
func logGRPC(ctx context.Context, req interface{}, info *grpc.UnaryServerInfo, handler grpc.UnaryHandler) (interface{}, error) {
|
|
glog.V(3).Infof("GRPC %s request %+v", info.FullMethod, req)
|
|
resp, err := handler(ctx, req)
|
|
if err != nil {
|
|
glog.Errorf("GRPC error: %v", err)
|
|
}
|
|
glog.V(3).Infof("GRPC %s response %+v", info.FullMethod, resp)
|
|
return resp, err
|
|
}
|
|
|
|
func checkMount(targetPath string) (bool, error) {
|
|
isMnt, err := mountutil.IsMountPoint(targetPath)
|
|
if err != nil {
|
|
if os.IsNotExist(err) {
|
|
if err = os.MkdirAll(targetPath, 0750); err != nil {
|
|
return false, err
|
|
}
|
|
isMnt = false
|
|
} else if mount.IsCorruptedMnt(err) {
|
|
if err := mountutil.Unmount(targetPath); err != nil {
|
|
return false, err
|
|
}
|
|
isMnt, err = mountutil.IsMountPoint(targetPath)
|
|
} else {
|
|
return false, err
|
|
}
|
|
}
|
|
return isMnt, nil
|
|
}
|
|
|
|
func removeDirContent(path string) error {
|
|
files, err := filepath.Glob(filepath.Join(path, "*"))
|
|
if err != nil {
|
|
return err
|
|
}
|
|
|
|
for _, file := range files {
|
|
err = os.RemoveAll(file)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
}
|
|
|
|
return nil
|
|
}
|
|
|
|
type KeyMutex struct {
|
|
mutexes sync.Map
|
|
}
|
|
|
|
func NewKeyMutex() *KeyMutex {
|
|
return &KeyMutex{}
|
|
}
|
|
|
|
func (km *KeyMutex) GetMutex(key string) *sync.Mutex {
|
|
m, _ := km.mutexes.LoadOrStore(key, &sync.Mutex{})
|
|
|
|
return m.(*sync.Mutex)
|
|
}
|
|
|
|
func (km *KeyMutex) RemoveMutex(key string) {
|
|
km.mutexes.Delete(key)
|
|
}
|
|
|
|
func CheckDataLocality(dataLocality *datalocality.DataLocality, dataCenter *string) error {
|
|
if *dataLocality != datalocality.None && *dataCenter == "" {
|
|
return fmt.Errorf("dataLocality set, but not all locality-definitions were set")
|
|
}
|
|
return nil
|
|
}
|