mirror of
https://github.com/hanzoai/s3.git
synced 2026-11-02 10:33:22 +00:00
zooqueen
dd74d3e6d6
hanzoai/s3 was an AGPL-3.0 MinIO fork whose network-copyleft blocks embedding
and reselling as a managed service. Replace it wholesale with a fork of
SeaweedFS (github.com/seaweedfs/seaweedfs, Apache-2.0, Go) which ships a
built-in S3 gateway + Filer.
- License: AGPL-3.0 -> Apache-2.0 (upstream LICENSE kept verbatim, incl.
"Copyright 2025 Chris Lu"); NOTICE added crediting SeaweedFS. No AGPL/BUSL/
SSPL/GPL or enterprise ("ee") files remain.
- Module: go.mod path set to github.com/hanzoai/s3 with a self-replace
(replace github.com/seaweedfs/seaweedfs => ./) so the ~1800 internal Go files
keep their upstream import paths with zero churn. Internal identifiers and
import paths are intentionally NOT renamed.
- CLI rebrand: the binary is built as `s3` (was `weed`); root usage, per-command
help/usage/flag strings, shell autocomplete program name, and the product name
in CLI output now read "Hanzo S3" / `s3`. Users never see `weed`.
(e.g. `s3 server`, `s3 filer`, `s3 master`, `s3 volume`, `s3 s3`, `s3 mount`.)
- Build: `make` (or `go build -o s3 ./weed`) builds the `s3` binary green;
`cmd/weed-db` and `cmd/weed-sql` also build; `go vet ./weed/command/` clean.
- README/LLM.md rewritten for Hanzo S3; AGENTS.md/CLAUDE.md symlinks preserved.
- Dropped a 33MB prebuilt Mach-O `stress` binary upstream had committed; `.gitignore`
updated to ignore the `s3` build output.
100 lines
2.9 KiB
Go
100 lines
2.9 KiB
Go
package s3tables
|
|
|
|
import (
|
|
"context"
|
|
"errors"
|
|
"testing"
|
|
|
|
"github.com/seaweedfs/seaweedfs/weed/pb/filer_pb"
|
|
"github.com/seaweedfs/seaweedfs/weed/s3api/s3_constants"
|
|
"github.com/stretchr/testify/assert"
|
|
"github.com/stretchr/testify/require"
|
|
)
|
|
|
|
var errFilerReached = errors.New("filer reached")
|
|
|
|
// recordingFilerClient reports whether the handler reached the filer. The
|
|
// CreateTableBucket handler authorizes before touching the filer, so "filer
|
|
// reached" is a proxy for "authorization passed".
|
|
type recordingFilerClient struct {
|
|
called bool
|
|
}
|
|
|
|
func (c *recordingFilerClient) WithFilerClient(streamingMode bool, fn func(client filer_pb.SeaweedFilerClient) error) error {
|
|
c.called = true
|
|
return errFilerReached
|
|
}
|
|
|
|
// The Manager path (used by the Iceberg catalog) enforces authorization for
|
|
// authenticated callers and only falls open for trusted/zero-config access.
|
|
func TestManagerCreateTableBucketAuthorization(t *testing.T) {
|
|
lowPriv := &testIdentity{
|
|
Name: "alice",
|
|
Account: &testIdentityAccount{Id: s3_constants.AccountAdminId},
|
|
Actions: []string{"Read"},
|
|
}
|
|
|
|
cases := []struct {
|
|
name string
|
|
defaultAllow bool
|
|
trusted bool
|
|
ctx context.Context
|
|
identity string
|
|
wantFiler bool // true => authorization passed (filer reached)
|
|
}{
|
|
{
|
|
name: "authenticated identity struct is enforced",
|
|
defaultAllow: true,
|
|
ctx: s3_constants.SetIdentityInContext(context.Background(), lowPriv),
|
|
identity: "alice",
|
|
wantFiler: false,
|
|
},
|
|
{
|
|
name: "secured manager denies a name without struct",
|
|
defaultAllow: false,
|
|
ctx: context.Background(),
|
|
identity: "alice",
|
|
wantFiler: false,
|
|
},
|
|
{
|
|
name: "untrusted name without struct is enforced",
|
|
defaultAllow: true,
|
|
ctx: context.Background(),
|
|
identity: "alice",
|
|
wantFiler: false,
|
|
},
|
|
{
|
|
name: "trusted manager allows a name without struct",
|
|
defaultAllow: true,
|
|
trusted: true,
|
|
ctx: context.Background(),
|
|
identity: "alice",
|
|
wantFiler: true,
|
|
},
|
|
{
|
|
name: "admin principal is allowed",
|
|
defaultAllow: false,
|
|
ctx: context.Background(),
|
|
identity: s3_constants.AccountAdminId,
|
|
wantFiler: true,
|
|
},
|
|
}
|
|
|
|
for _, tc := range cases {
|
|
t.Run(tc.name, func(t *testing.T) {
|
|
m := NewManager()
|
|
m.SetDefaultAllow(tc.defaultAllow)
|
|
m.SetTrusted(tc.trusted)
|
|
fc := &recordingFilerClient{}
|
|
err := m.Execute(tc.ctx, fc, "CreateTableBucket", &CreateTableBucketRequest{Name: "testbucket"}, nil, tc.identity)
|
|
require.Error(t, err) // denied (403) or the filer sentinel (reached); never nil here
|
|
assert.Equal(t, tc.wantFiler, fc.called, "filer reached should equal authorization passed")
|
|
if !tc.wantFiler {
|
|
var s3Err *S3TablesError
|
|
require.ErrorAs(t, err, &s3Err)
|
|
assert.Equal(t, ErrCodeAccessDenied, s3Err.Type)
|
|
}
|
|
})
|
|
}
|
|
}
|