Files
s3/weed/util/fullpath_test.go
zooqueen dd74d3e6d6 Replace AGPL MinIO fork with Apache-2.0 SeaweedFS fork; rebrand CLI weed->s3
hanzoai/s3 was an AGPL-3.0 MinIO fork whose network-copyleft blocks embedding
and reselling as a managed service. Replace it wholesale with a fork of
SeaweedFS (github.com/seaweedfs/seaweedfs, Apache-2.0, Go) which ships a
built-in S3 gateway + Filer.

- License: AGPL-3.0 -> Apache-2.0 (upstream LICENSE kept verbatim, incl.
  "Copyright 2025 Chris Lu"); NOTICE added crediting SeaweedFS. No AGPL/BUSL/
  SSPL/GPL or enterprise ("ee") files remain.
- Module: go.mod path set to github.com/hanzoai/s3 with a self-replace
  (replace github.com/seaweedfs/seaweedfs => ./) so the ~1800 internal Go files
  keep their upstream import paths with zero churn. Internal identifiers and
  import paths are intentionally NOT renamed.
- CLI rebrand: the binary is built as `s3` (was `weed`); root usage, per-command
  help/usage/flag strings, shell autocomplete program name, and the product name
  in CLI output now read "Hanzo S3" / `s3`. Users never see `weed`.
  (e.g. `s3 server`, `s3 filer`, `s3 master`, `s3 volume`, `s3 s3`, `s3 mount`.)
- Build: `make` (or `go build -o s3 ./weed`) builds the `s3` binary green;
  `cmd/weed-db` and `cmd/weed-sql` also build; `go vet ./weed/command/` clean.
- README/LLM.md rewritten for Hanzo S3; AGENTS.md/CLAUDE.md symlinks preserved.
- Dropped a 33MB prebuilt Mach-O `stress` binary upstream had committed; `.gitignore`
  updated to ignore the `s3` build output.
2026-06-18 23:41:25 -07:00

85 lines
3.0 KiB
Go

package util
import (
"strings"
"testing"
"unicode/utf8"
)
// TestSanitizeUTF8Name_ValidPassThrough asserts the fast path returns the
// input unchanged (no allocation, no byte alteration).
func TestSanitizeUTF8Name_ValidPassThrough(t *testing.T) {
for _, s := range []string{
"",
"plain.txt",
"日本語.txt",
"🦑 squid",
} {
if got := SanitizeUTF8Name(s); got != s {
t.Fatalf("SanitizeUTF8Name(%q) = %q, want unchanged", s, got)
}
}
}
// TestSanitizeUTF8Name_InvalidBytes asserts invalid bytes are replaced with a
// single '_' (URL-safe, single-byte) and the output is valid UTF-8. The
// replacement char is load-bearing — downstream code places these strings in
// HTTP URLs, where '?' would be parsed as the query delimiter.
func TestSanitizeUTF8Name_InvalidBytes(t *testing.T) {
out := SanitizeUTF8Name("foo\x80bar")
if !utf8.ValidString(out) {
t.Fatalf("result is not valid UTF-8: %q", out)
}
if out != "foo_bar" {
t.Fatalf("SanitizeUTF8Name = %q, want %q", out, "foo_bar")
}
if strings.ContainsRune(out, '?') {
t.Fatalf("replacement must be URL-safe, got %q", out)
}
}
// TestFullPathSanitized_WholePath ensures Sanitized() scrubs invalid bytes in
// every component, not just the last — that's the difference from Name() and
// the reason call sites that need to pass a full path to a proto field must
// use Sanitized(), not (dir, _) := DirAndName().
func TestFullPathSanitized_WholePath(t *testing.T) {
// Invalid byte sits in the middle component.
fp := FullPath("/home/bad\x80dir/file.txt")
got := fp.Sanitized()
want := "/home/bad_dir/file.txt"
if got != want {
t.Fatalf("Sanitized() = %q, want %q", got, want)
}
// Bytes in every component — all get replaced, structure preserved.
fp = FullPath("/a\xffb/c\xffd/e\xfff")
got = fp.Sanitized()
want = "/a_b/c_d/e_f"
if got != want {
t.Fatalf("Sanitized() = %q, want %q", got, want)
}
if !utf8.ValidString(got) {
t.Fatalf("Sanitized() returned non-UTF-8: %q", got)
}
}
// TestFullPathDirAndName_OnlyNameSanitized documents a (deliberate) sharp
// edge: DirAndName() sanitizes only the trailing name, not dir. Callers who
// need a sanitized full path must use Sanitized(); using dir from DirAndName
// will still carry invalid bytes in parent components. This test pins the
// existing behavior so it is not accidentally "fixed" in a way that changes
// the (dir, name) semantics that everything else depends on.
func TestFullPathDirAndName_OnlyNameSanitized(t *testing.T) {
fp := FullPath("/home/bad\x80dir/child\xffname")
dir, name := fp.DirAndName()
if !utf8.ValidString(name) {
t.Fatalf("name must be sanitized: %q", name)
}
// dir still contains the invalid byte — this is by design, because dir is
// used positionally (e.g. as a parent key) and changing its bytes would
// change identity. Sanitized() is the method to use for proto fields.
if utf8.ValidString(dir) {
t.Fatalf("regression: dir should remain raw (%q); callers needing a clean path must use Sanitized()", dir)
}
}