Files
sentinel/static/app/components/group/sentryAppExternalIssueForm.spec.tsx
zeekayandHanzo Dev f888991a7a drop the Sentry wordmark from the react app
FSL-1.0-Apache-2.0 grants us the code, not the name. "Sentry" is
Functional Software's trademark, so every place the running app says it
to a user -- page titles, onboarding, empty states, toasts, settings
copy, the self-hosted footer -- now says Sentinel.

Attribution is the other half of the deal and stays untouched: upstream
copyright headers, LICENSE, NOTICE. So does anything where the mark is a
fact rather than a brand -- @sentry/* packages, sentry-cli, the wizard
and bundler plugins, docs.sentry.io, the whole gettingStartedDocs tree.
Renaming those would leave instructions that no longer work.

Nothing structural moved. No import, identifier, route path, feature
flag, API field or test id changed; the diff is 312 lines in and 312
out. Colocated specs were updated in lockstep with the copy they assert.
Marketing and community links point at hanzo.ai, only where a real page
exists to point at.

Co-authored-by: Hanzo Dev <[email protected]>
2026-08-10 18:01:22 -07:00

281 lines
8.9 KiB
TypeScript

import selectEvent from 'react-select-event';
import {EventFixture} from 'sentry-fixture/event';
import {GroupFixture} from 'sentry-fixture/group';
import {SentryAppFixture} from 'sentry-fixture/sentryApp';
import {
SentryAppComponentAsyncFixture,
SentryAppComponentDependentFixture,
SentryAppComponentFixture,
} from 'sentry-fixture/sentryAppComponent';
import {SentryAppInstallationFixture} from 'sentry-fixture/sentryAppInstallation';
import {render, screen, userEvent} from 'sentry-test/reactTestingLibrary';
import SentryAppExternalIssueForm from 'sentry/components/group/sentryAppExternalIssueForm';
import {addQueryParamsToExistingUrl} from 'sentry/utils/queryString';
describe('SentryAppExternalIssueForm', () => {
const group = GroupFixture({
title: 'ApiError: Broken',
shortId: 'SEN123',
permalink: 'https://sentry.io/organizations/sentry/issues/123/?project=1',
});
const component = SentryAppComponentFixture();
const sentryApp = SentryAppFixture();
const sentryAppInstallation = SentryAppInstallationFixture({});
const submitUrl = `/sentry-app-installations/${sentryAppInstallation.uuid}/external-issue-actions/`;
let externalIssueRequest;
beforeEach(() => {
externalIssueRequest = MockApiClient.addMockResponse({
url: submitUrl,
method: 'POST',
body: {},
});
});
afterEach(() => {
MockApiClient.clearMockResponses();
});
describe('create', () => {
it('can create a new issue', async () => {
render(
<SentryAppExternalIssueForm
event={EventFixture()}
onSubmitSuccess={jest.fn()}
group={group}
sentryAppInstallation={sentryAppInstallation}
appName={sentryApp.name}
config={component.schema.create}
action="create"
/>
);
// renders each required_fields field
expect(component.schema.create.required_fields).toHaveLength(3);
for (const field of component.schema.create.required_fields) {
expect(screen.getByRole('textbox', {name: field.label})).toBeInTheDocument();
}
// Prevents submission if required fields are not set
await userEvent.clear(screen.getByRole('textbox', {name: 'Title'}));
await userEvent.click(screen.getByRole('button', {name: 'Save Changes'}));
expect(externalIssueRequest).not.toHaveBeenCalled();
selectEvent.openMenu(screen.getByRole('textbox', {name: 'Numbers'}));
await userEvent.type(screen.getByRole('textbox', {name: 'Numbers'}), '1');
await userEvent.click(screen.getByText('one'));
// Sets required fields
await userEvent.type(
screen.getByRole('textbox', {name: 'Title'}),
'ApiError: Broken'
);
await userEvent.click(screen.getByRole('button', {name: 'Save Changes'}));
expect(externalIssueRequest).toHaveBeenCalledWith(
submitUrl,
expect.objectContaining({
data: {
action: 'create',
description:
'Sentinel Issue: [SEN123](https://sentry.io/organizations/sentry/issues/123/?project=1&referrer=Sample%20App)',
groupId: '1',
numbers: 'number_1',
title: 'ApiError: Broken',
uri: '',
},
method: 'POST',
})
);
});
it('renders prepopulated defaults', () => {
render(
<SentryAppExternalIssueForm
event={EventFixture()}
onSubmitSuccess={jest.fn()}
group={group}
sentryAppInstallation={sentryAppInstallation}
appName={sentryApp.name}
config={component.schema.create}
action="create"
/>
);
expect(screen.getByRole('textbox', {name: 'Title'})).toHaveValue(`${group.title}`);
const url = addQueryParamsToExistingUrl(group.permalink, {
referrer: sentryApp.name,
});
expect(screen.getByRole('textbox', {name: 'Description'})).toHaveValue(
`Sentinel Issue: [${group.shortId}](${url})`
);
});
});
describe('link', () => {
it('can link an issue', async () => {
render(
<SentryAppExternalIssueForm
event={EventFixture()}
onSubmitSuccess={jest.fn()}
group={group}
sentryAppInstallation={sentryAppInstallation}
appName={sentryApp.name}
config={component.schema.link}
action="link"
/>
);
// renders each required_fields field
expect(component.schema.link.required_fields).toHaveLength(1);
for (const field of component.schema.link.required_fields) {
expect(screen.getByRole('textbox', {name: field.label})).toBeInTheDocument();
}
await userEvent.type(screen.getByRole('textbox', {name: 'Issue'}), 'my issue');
await userEvent.click(screen.getByRole('button', {name: 'Save Changes'}));
expect(externalIssueRequest).toHaveBeenCalledWith(
submitUrl,
expect.objectContaining({
data: {
action: 'link',
groupId: '1',
issue: 'my issue',
uri: '',
},
method: 'POST',
})
);
});
});
});
describe('SentryAppExternalIssueForm Async Field', () => {
const component = SentryAppComponentAsyncFixture();
const group = GroupFixture({
title: 'ApiError: Broken',
shortId: 'SEN123',
permalink: 'https://sentry.io/organizations/sentry/issues/123/?project=1',
});
const sentryApp = SentryAppFixture();
const sentryAppInstallation = SentryAppInstallationFixture({});
afterEach(() => {
MockApiClient.clearMockResponses();
});
it('renders each required_fields field', async function () {
const mockGetOptions = MockApiClient.addMockResponse({
method: 'GET',
url: '/sentry-app-installations/d950595e-cba2-46f6-8a94-b79e42806f98/external-requests/',
body: {
choices: [
[1, 'Issue 1'],
[2, 'Issue 2'],
],
},
});
render(
<SentryAppExternalIssueForm
event={EventFixture()}
onSubmitSuccess={jest.fn()}
group={group}
sentryAppInstallation={sentryAppInstallation}
appName={sentryApp.name}
config={component.schema.create}
action="create"
/>
);
selectEvent.openMenu(screen.getByText('Numbers'));
await userEvent.type(screen.getByRole('textbox'), 'I');
expect(mockGetOptions).toHaveBeenCalled();
expect(await screen.findByText('Issue 1')).toBeInTheDocument();
expect(await screen.findByText('Issue 2')).toBeInTheDocument();
});
});
describe('SentryAppExternalIssueForm Dependent fields', () => {
const group = GroupFixture({
title: 'ApiError: Broken',
shortId: 'SEN123',
permalink: 'https://sentry.io/organizations/sentry/issues/123/?project=1',
});
const sentryApp = SentryAppFixture();
const sentryAppInstallation = SentryAppInstallationFixture({});
const component = SentryAppComponentDependentFixture();
afterEach(() => {
MockApiClient.clearMockResponses();
});
it('load options for field that has dependencies when the dependent option is selected', async () => {
const url = `/sentry-app-installations/${sentryAppInstallation.uuid}/external-requests/`;
MockApiClient.addMockResponse({
method: 'GET',
url,
body: {
choices: [
['A', 'project A'],
['B', 'project B'],
],
},
match: [MockApiClient.matchQuery({uri: '/integrations/sentry/projects'})],
});
const boardMock = MockApiClient.addMockResponse({
method: 'GET',
url,
body: {
choices: [
['R', 'board R'],
['S', 'board S'],
],
},
match: [
MockApiClient.matchQuery({
uri: '/integrations/sentry/boards',
dependentData: JSON.stringify({project_id: 'A'}),
}),
],
});
render(
<SentryAppExternalIssueForm
event={EventFixture()}
onSubmitSuccess={jest.fn()}
group={group}
sentryAppInstallation={sentryAppInstallation}
appName={sentryApp.name}
config={component.schema.create}
action="create"
/>
);
await userEvent.type(screen.getByRole('textbox', {name: 'Project'}), 'p');
expect(await screen.findByText('project A')).toBeInTheDocument();
expect(screen.getByText('project B')).toBeInTheDocument();
// project select should be disabled and we shouldn't fetch the options yet
expect(screen.getByRole('textbox', {name: 'Board'})).toBeDisabled();
expect(boardMock).not.toHaveBeenCalled();
// when we set the value for project we should get the values for the board
await selectEvent.select(screen.getByRole('textbox', {name: 'Project'}), 'project A');
expect(boardMock).toHaveBeenCalled();
expect(screen.getByRole('textbox', {name: 'Board'})).toBeEnabled();
await userEvent.type(screen.getByRole('textbox', {name: 'Board'}), 'b');
expect(await screen.findByText('board R')).toBeInTheDocument();
expect(screen.getByText('board S')).toBeInTheDocument();
});
});