Files
2024-02-15 17:01:50 +00:00

2558 lines
97 KiB
Python

import os.path
import zipfile
from base64 import b64encode
from datetime import timedelta
from hashlib import sha1
from io import BytesIO
from uuid import uuid4
import pytest
import responses
from django.conf import settings
from django.core.files.base import ContentFile
from django.utils import timezone
from sentry.debug_files.artifact_bundles import refresh_artifact_bundles_in_use
from sentry.models.artifactbundle import (
ArtifactBundle,
DebugIdArtifactBundle,
ProjectArtifactBundle,
ReleaseArtifactBundle,
SourceFileType,
)
from sentry.models.files.file import File
from sentry.models.files.fileblob import FileBlob
from sentry.models.release import Release
from sentry.models.releasefile import ReleaseFile, update_artifact_index
from sentry.tasks.assemble import assemble_artifacts
from sentry.testutils.helpers.datetime import before_now, iso_format
from sentry.testutils.helpers.features import with_feature
from sentry.testutils.helpers.options import override_options
from sentry.testutils.pytest.fixtures import django_db_all
from sentry.testutils.relay import RelayStoreHelper
from sentry.testutils.skips import requires_kafka, requires_symbolicator
from sentry.utils import json
# IMPORTANT:
#
# This test suite requires Symbolicator in order to run correctly.
# Set `symbolicator.enabled: true` in your `~/.sentry/config.yml` and run `sentry devservices up`
#
# If you are using a local instance of Symbolicator, you need to either change `system.url-prefix`
# to `system.internal-url-prefix` inside `initialize` method below, or add `127.0.0.1 host.docker.internal`
# entry to your `/etc/hosts`
pytestmark = [requires_symbolicator, requires_kafka]
BASE64_SOURCEMAP = "data:application/json;base64," + (
b64encode(
b'{"version":3,"file":"generated.js","sources":["/test.js"],"names":[],"mappings":"AAAA","sourcesContent":['
b'"console.log(\\"hello, World!\\")"]}'
)
.decode("utf-8")
.replace("\n", "")
)
INVALID_BASE64_SOURCEMAP = "data:application/json;base64,A"
def get_fixture_path(name):
return os.path.join(os.path.dirname(__file__), "fixtures", name)
def load_fixture(name):
with open(get_fixture_path(name), "rb") as fp:
return fp.read()
def make_compressed_zip_file(files):
def remove_and_return(dictionary, key):
dictionary.pop(key)
return dictionary
compressed = BytesIO(b"SYSB")
with zipfile.ZipFile(compressed, "a") as zip_file:
for file_path, info in files.items():
zip_file.writestr(file_path, bytes(info["content"]))
zip_file.writestr(
"manifest.json",
json.dumps(
{
# We remove the "content" key in the original dict, thus no subsequent calls should be made.
"files": {
file_path: remove_and_return(info, "content")
for file_path, info in files.items()
}
}
),
)
compressed.seek(0)
return compressed.getvalue()
def upload_bundle(bundle_file, project, release=None, dist=None, upload_as_artifact_bundle=True):
blob1 = FileBlob.from_file(ContentFile(bundle_file))
total_checksum = sha1(bundle_file).hexdigest()
return assemble_artifacts(
org_id=project.organization.id,
project_ids=[project.id],
version=release,
dist=dist,
checksum=total_checksum,
chunks=[blob1.checksum],
upload_as_artifact_bundle=upload_as_artifact_bundle,
)
@django_db_all(transaction=True)
class TestJavascriptIntegration(RelayStoreHelper):
@pytest.fixture(autouse=True)
def initialize(self, default_projectkey, default_project, set_sentry_option, live_server):
self.project = default_project
self.projectkey = default_projectkey
self.organization = self.project.organization
self.min_ago = iso_format(before_now(minutes=1))
# We disable scraping per-test when necessary.
self.project.update_option("sentry:scrape_javascript", True)
with set_sentry_option("system.url-prefix", live_server.url):
# Run test case
yield
@requires_symbolicator
@pytest.mark.symbolicator
def test_adds_contexts_without_device(self):
data = {
"timestamp": self.min_ago,
"message": "hello",
"platform": "javascript",
"request": {
"url": "http://example.com",
"headers": [
[
"User-Agent",
"Mozilla/5.0 (Windows NT 6.2; WOW64) AppleWebKit/537.36 (KHTML, like Gecko) "
"Chrome/28.0.1500.72 Safari/537.36",
]
],
},
}
event = self.post_and_retrieve_event(data)
contexts = event.interfaces["contexts"].to_json()
assert contexts.get("os") == {"name": "Windows", "version": "8", "type": "os"}
assert contexts.get("device") is None
@requires_symbolicator
@pytest.mark.symbolicator
def test_adds_contexts_with_device(self):
data = {
"timestamp": self.min_ago,
"message": "hello",
"platform": "javascript",
"request": {
"url": "http://example.com",
"headers": [
[
"User-Agent",
"Mozilla/5.0 (Linux; U; Android 4.3; en-us; SCH-R530U Build/JSS15J) AppleWebKit/534.30 ("
"KHTML, like Gecko) Version/4.0 Mobile Safari/534.30 USCC-R530U",
]
],
},
}
event = self.post_and_retrieve_event(data)
contexts = event.interfaces["contexts"].to_json()
assert contexts.get("os") == {"name": "Android", "type": "os", "version": "4.3"}
assert contexts.get("browser") == {"name": "Android", "type": "browser", "version": "4.3"}
assert contexts.get("device") == {
"family": "Samsung SCH-R530U",
"type": "device",
"model": "SCH-R530U",
"name": "Galaxy S3",
"brand": "Samsung",
}
@requires_symbolicator
@pytest.mark.symbolicator
def test_adds_contexts_with_ps4_device(self):
data = {
"timestamp": self.min_ago,
"message": "hello",
"platform": "javascript",
"request": {
"url": "http://example.com",
"headers": [
[
"User-Agent",
"Mozilla/5.0 (PlayStation 4 3.55) AppleWebKit/537.78 (KHTML, like Gecko)",
]
],
},
}
event = self.post_and_retrieve_event(data)
contexts = event.interfaces["contexts"].to_json()
assert contexts.get("os") is None
assert contexts.get("browser") is None
assert contexts.get("device") == {
"family": "PlayStation 4",
"type": "device",
"model": "PlayStation 4",
"brand": "Sony",
}
@requires_symbolicator
@pytest.mark.symbolicator
def test_error_message_translations(self):
data = {
"timestamp": self.min_ago,
"message": "hello",
"platform": "javascript",
"logentry": {
"formatted": "ReferenceError: Impossible de d\xe9finir une propri\xe9t\xe9 \xab foo \xbb : objet non "
"extensible"
},
"exception": {
"values": [
{"type": "Error", "value": "P\u0159\xedli\u0161 mnoho soubor\u016f"},
{
"type": "Error",
"value": "foo: wyst\u0105pi\u0142 nieoczekiwany b\u0142\u0105d podczas pr\xf3by uzyskania "
"informacji o metadanych",
},
]
},
}
event = self.post_and_retrieve_event(data)
message = event.interfaces["logentry"]
assert (
message.formatted
== "ReferenceError: Cannot define property 'foo': object is not extensible"
)
exception = event.interfaces["exception"]
assert exception.values[0].value == "Too many files"
assert (
exception.values[1].value
== "foo: an unexpected failure occurred while trying to obtain metadata information"
)
@requires_symbolicator
@pytest.mark.symbolicator
def test_nonhandled_frames_inapp_normalization(self):
data = {
"timestamp": self.min_ago,
"message": "hello",
"platform": "node",
"exception": {
"values": [
{
"type": "Error",
"stacktrace": {
"frames": [
{
"abs_path": "native",
"lineno": 1,
"colno": 1,
"in_app": True,
},
{
"abs_path": "[native code]",
"lineno": 1,
"colno": 1,
"in_app": True,
},
{
"abs_path": "app://dist/bundle/file.min.js",
"lineno": 1,
"colno": 1,
"in_app": True,
},
]
},
}
]
},
}
event = self.post_and_retrieve_event(data)
exception = event.interfaces["exception"]
frame_list = exception.values[0].stacktrace.frames
assert not frame_list[0].in_app # should be overwritten due to `native` abs_path
assert not frame_list[1].in_app # should be overwritten due to `[native code]` abs_path
assert frame_list[2].in_app # should not be touched and retain `in_app: true`
raw_frame_list = exception.values[0].raw_stacktrace.frames
# none of the raw frames should be altered
assert raw_frame_list[0].in_app
assert raw_frame_list[1].in_app
assert raw_frame_list[2].in_app
@requires_symbolicator
@pytest.mark.symbolicator
def test_sourcemap_source_expansion(self):
self.project.update_option("sentry:scrape_javascript", False)
release = Release.objects.create(
organization_id=self.project.organization_id, version="abc"
)
release.add_project(self.project)
for file in ["file.min.js", "file1.js", "file2.js", "file.sourcemap.js"]:
with open(get_fixture_path(file), "rb") as f:
f1 = File.objects.create(
name=file,
type="release.file",
headers={},
)
f1.putfile(f)
ReleaseFile.objects.create(
name=f"http://example.com/{f1.name}",
release_id=release.id,
organization_id=self.project.organization_id,
file=f1,
)
data = {
"timestamp": self.min_ago,
"message": "hello",
"platform": "javascript",
"release": "abc",
"exception": {
"values": [
{
"type": "Error",
"stacktrace": {
"frames": [
{
"abs_path": "http://example.com/file.min.js",
"filename": "file.min.js",
"lineno": 1,
"colno": 39,
},
# NOTE: Intentionally source is not retrieved from this HTML file
{
"function": 'function: "HTMLDocument.<anonymous>"',
"abs_path": "http//example.com/index.html",
"filename": "index.html",
"lineno": 283,
"colno": 17,
"in_app": False,
},
# NOTE: a mixed stack trace with a native frame:
{
"instruction_addr": "0xd10349",
},
]
},
}
]
},
}
event = self.post_and_retrieve_event(data)
assert event.data["errors"] == [
{
"type": "js_no_source",
"symbolicator_type": "missing_source",
"url": "http//example.com/index.html",
}
]
assert event.data["scraping_attempts"] == [
{"status": "not_attempted", "url": "http://example.com/file.min.js"},
{"status": "not_attempted", "url": "http://example.com/file.sourcemap.js"},
{"status": "not_attempted", "url": "http://example.com/file1.js"},
]
exception = event.interfaces["exception"]
frame_list = exception.values[0].stacktrace.frames
frame = frame_list[0]
assert frame.data["resolved_with"] == "release-old"
assert frame.data["symbolicated"]
assert frame.pre_context == ["function add(a, b) {", '\t"use strict";']
expected = "\treturn a + b; // fôo"
assert frame.context_line == expected
assert frame.post_context == ["}"]
raw_frame_list = exception.values[0].raw_stacktrace.frames
raw_frame = raw_frame_list[0]
assert not raw_frame.pre_context
assert (
raw_frame.context_line
== 'function add(a,b){"use strict";return a+b}function multiply(a,b){"use strict";return a*b}function '
'divide(a,b){"use strict";try{return multip {snip}'
)
assert raw_frame.post_context == ["//@ sourceMappingURL=file.sourcemap.js"]
assert raw_frame.lineno == 1
# Since we couldn't expand source for the 2nd frame, both
# its raw and original form should be identical
assert raw_frame_list[1] == frame_list[1]
# The second non-js frame should be untouched
assert raw_frame_list[2] == frame_list[2]
@requires_symbolicator
@pytest.mark.symbolicator
def test_sourcemap_webpack(self):
self.project.update_option("sentry:scrape_javascript", False)
release = Release.objects.create(
organization_id=self.project.organization_id, version="abc"
)
release.add_project(self.project)
for file in [
"webpack1.min.js",
"webpack2.min.js",
"webpack1.min.js.map",
"webpack2.min.js.map",
]:
with open(get_fixture_path(file), "rb") as f:
f1 = File.objects.create(
name=file,
type="release.file",
headers={},
)
f1.putfile(f)
ReleaseFile.objects.create(
name=f"http://example.com/{f1.name}",
release_id=release.id,
organization_id=self.project.organization_id,
file=f1,
)
data = {
"timestamp": self.min_ago,
"message": "hello",
"platform": "javascript",
"release": "abc",
"exception": {
"values": [
{
"type": "Error",
"stacktrace": {
"frames": [
{
"abs_path": "http://example.com/webpack1.min.js",
"filename": "webpack1.min.js",
"lineno": 1,
"colno": 183,
"function": "i",
},
{
"abs_path": "http://example.com/webpack2.min.js",
"filename": "webpack2.min.js",
"lineno": 1,
"colno": 183,
"function": "i",
},
]
},
}
]
},
}
event = self.post_and_retrieve_event(data)
exception = event.interfaces["exception"]
frame_list = exception.values[0].stacktrace.frames
assert event.data["scraping_attempts"] == [
{"url": "http://example.com/webpack1.min.js", "status": "not_attempted"},
{"url": "http://example.com/webpack1.min.js.map", "status": "not_attempted"},
{"url": "http://example.com/webpack2.min.js", "status": "not_attempted"},
{"url": "http://example.com/webpack2.min.js.map", "status": "not_attempted"},
]
# The first frame should be in_app.
first_frame = frame_list[0]
assert first_frame.in_app
assert first_frame.function == "test"
assert first_frame.pre_context == [
" cb(data);",
" }",
"",
" function test() {",
" var data = {failed: true, value: 42};",
]
assert first_frame.context_line == " invoke(data);"
assert first_frame.post_context == [
" }",
"",
" return test;",
"})();",
]
# The second frame should be identical to the first, except not in_app.
second_frame = frame_list[1]
assert not second_frame.in_app
assert second_frame.function == first_frame.function
assert second_frame.context_line == first_frame.context_line
assert second_frame.pre_context == first_frame.pre_context
assert second_frame.post_context == first_frame.post_context
@requires_symbolicator
@pytest.mark.symbolicator
def test_sourcemap_embedded_source_expansion(self):
self.project.update_option("sentry:scrape_javascript", False)
release = Release.objects.create(
organization_id=self.project.organization_id, version="abc"
)
release.add_project(self.project)
for file in ["embedded.js", "embedded.js.map"]:
with open(get_fixture_path(file), "rb") as f:
f1 = File.objects.create(
name=file,
type="release.file",
headers={},
)
f1.putfile(f)
ReleaseFile.objects.create(
name=f"http://example.com/{f1.name}",
release_id=release.id,
organization_id=self.project.organization_id,
file=f1,
)
data = {
"timestamp": self.min_ago,
"message": "hello",
"platform": "javascript",
"release": "abc",
"exception": {
"values": [
{
"type": "Error",
"stacktrace": {
"frames": [
{
"abs_path": "http://example.com/embedded.js",
"filename": "file.min.js",
"lineno": 1,
"colno": 39,
},
# NOTE: Intentionally source is not retrieved from this HTML file
{
"function": 'function: "HTMLDocument.<anonymous>"',
"abs_path": "http//example.com/index.html",
"filename": "index.html",
"lineno": 283,
"colno": 17,
"in_app": False,
},
]
},
}
]
},
}
event = self.post_and_retrieve_event(data)
assert event.data["errors"] == [
{
"type": "js_no_source",
"symbolicator_type": "missing_source",
"url": "http//example.com/index.html",
}
]
assert event.data["scraping_attempts"] == [
{"status": "not_attempted", "url": "http://example.com/embedded.js"},
{"status": "not_attempted", "url": "http://example.com/embedded.js.map"},
]
exception = event.interfaces["exception"]
frame_list = exception.values[0].stacktrace.frames
frame = frame_list[0]
assert frame.data["resolved_with"] == "release-old"
assert frame.data["symbolicated"]
assert frame.pre_context == ["function add(a, b) {", '\t"use strict";']
expected = "\treturn a + b; // fôo"
assert frame.context_line == expected
assert frame.post_context == ["}"]
@requires_symbolicator
@pytest.mark.symbolicator
def test_sourcemap_nofiles_source_expansion(self):
project = self.project
release = Release.objects.create(organization_id=project.organization_id, version="abc")
release.add_project(project)
with open(get_fixture_path("nofiles.js"), "rb") as f:
f_minified = File.objects.create(
name="nofiles.js", type="release.file", headers={"Content-Type": "application/json"}
)
f_minified.putfile(f)
ReleaseFile.objects.create(
name=f"~/{f_minified.name}",
release_id=release.id,
organization_id=project.organization_id,
file=f_minified,
)
with open(get_fixture_path("nofiles.js.map"), "rb") as f:
f_sourcemap = File.objects.create(
name="nofiles.js.map",
type="release.file",
headers={"Content-Type": "application/json"},
)
f_sourcemap.putfile(f)
ReleaseFile.objects.create(
name=f"app:///{f_sourcemap.name}",
release_id=release.id,
organization_id=project.organization_id,
file=f_sourcemap,
)
data = {
"timestamp": self.min_ago,
"message": "hello",
"platform": "javascript",
"release": "abc",
"exception": {
"values": [
{
"type": "Error",
"stacktrace": {
"frames": [{"abs_path": "app:///nofiles.js", "lineno": 1, "colno": 39}]
},
}
]
},
}
event = self.post_and_retrieve_event(data)
assert "errors" not in event.data
assert event.data["scraping_attempts"] == [
{"url": "app:///nofiles.js", "status": "not_attempted"},
{"url": "app:///nofiles.js.map", "status": "not_attempted"},
]
exception = event.interfaces["exception"]
frame_list = exception.values[0].stacktrace.frames
assert len(frame_list) == 1
frame = frame_list[0]
assert frame.data["resolved_with"] == "release-old"
assert frame.data["symbolicated"]
assert frame.abs_path == "app:///nofiles.js"
assert frame.pre_context == ["function add(a, b) {", '\t"use strict";']
assert frame.context_line == "\treturn a + b; // fôo"
assert frame.post_context == ["}"]
@requires_symbolicator
@pytest.mark.symbolicator
def test_indexed_sourcemap_source_expansion(self):
self.project.update_option("sentry:scrape_javascript", False)
release = Release.objects.create(
organization_id=self.project.organization_id, version="abc"
)
release.add_project(self.project)
for file in ["indexed.min.js", "file1.js", "file2.js", "indexed.sourcemap.js"]:
with open(get_fixture_path(file), "rb") as f:
f1 = File.objects.create(
name=file,
type="release.file",
headers={},
)
f1.putfile(f)
ReleaseFile.objects.create(
name=f"http://example.com/{f1.name}",
release_id=release.id,
organization_id=self.project.organization_id,
file=f1,
)
data = {
"timestamp": self.min_ago,
"message": "hello",
"platform": "javascript",
"release": "abc",
"exception": {
"values": [
{
"type": "Error",
"stacktrace": {
"frames": [
{
"abs_path": "http://example.com/indexed.min.js",
"filename": "indexed.min.js",
"lineno": 1,
"colno": 39,
},
{
"abs_path": "http://example.com/indexed.min.js",
"filename": "indexed.min.js",
"lineno": 2,
"colno": 44,
},
]
},
}
]
},
}
event = self.post_and_retrieve_event(data)
assert "errors" not in event.data
assert event.data["scraping_attempts"] == [
{"status": "not_attempted", "url": "http://example.com/indexed.min.js"},
{"status": "not_attempted", "url": "http://example.com/indexed.sourcemap.js"},
{"status": "not_attempted", "url": "http://example.com/file1.js"},
{"status": "not_attempted", "url": "http://example.com/file2.js"},
]
exception = event.interfaces["exception"]
frame_list = exception.values[0].stacktrace.frames
frame = frame_list[0]
assert frame.data["resolved_with"] == "release-old"
assert frame.data["symbolicated"]
assert frame.pre_context == ["function add(a, b) {", '\t"use strict";']
expected = "\treturn a + b; // fôo"
assert frame.context_line == expected
assert frame.post_context == ["}"]
raw_frame_list = exception.values[0].raw_stacktrace.frames
raw_frame = raw_frame_list[0]
assert not raw_frame.pre_context
assert raw_frame.context_line == 'function add(a,b){"use strict";return a+b}'
assert raw_frame.post_context == [
'function multiply(a,b){"use strict";return a*b}function divide(a,b){"use strict";try{return multiply('
"add(a,b),a,b)/c}catch(e){Raven.captureE {snip}",
"//# sourceMappingURL=indexed.sourcemap.js",
]
assert raw_frame.lineno == 1
frame = frame_list[1]
assert frame.data["resolved_with"] == "release-old"
assert frame.data["symbolicated"]
assert frame.pre_context == ["function multiply(a, b) {", '\t"use strict";']
assert frame.context_line == "\treturn a * b;"
assert frame.post_context == [
"}",
"function divide(a, b) {",
'\t"use strict";',
"\ttry {",
"\t\treturn multiply(add(a, b), a, b) / c;",
]
raw_frame = raw_frame_list[1]
assert raw_frame.pre_context == ['function add(a,b){"use strict";return a+b}']
assert (
raw_frame.context_line
== 'function multiply(a,b){"use strict";return a*b}function divide(a,b){"use strict";try{return multiply('
"add(a,b),a,b)/c}catch(e){Raven.captureE {snip}"
)
assert raw_frame.post_context == ["//# sourceMappingURL=indexed.sourcemap.js"]
assert raw_frame.lineno == 2
@requires_symbolicator
@pytest.mark.symbolicator
def test_expansion_via_debug(self):
project = self.project
release = Release.objects.create(organization_id=project.organization_id, version="abc")
release.add_project(project)
# file.min.js
# ------------
with open(get_fixture_path("file.min.js"), "rb") as f:
f_minified = File.objects.create(
name="file.min.js",
type="release.file",
headers={"Content-Type": "application/json"},
)
f_minified.putfile(f)
# Intentionally omit hostname - use alternate artifact path lookup instead
# /file1.js vs http://example.com/file1.js
ReleaseFile.objects.create(
name=f"~/{f_minified.name}?foo=bar",
release_id=release.id,
organization_id=project.organization_id,
file=f_minified,
)
# file1.js
# ---------
with open(get_fixture_path("file1.js"), "rb") as f:
f1 = File.objects.create(
name="file1.js", type="release.file", headers={"Content-Type": "application/json"}
)
f1.putfile(f)
ReleaseFile.objects.create(
name=f"http://example.com/{f1.name}",
release_id=release.id,
organization_id=project.organization_id,
file=f1,
)
# file2.js
# ----------
with open(get_fixture_path("file2.js"), "rb") as f:
f2 = File.objects.create(
name="file2.js", type="release.file", headers={"Content-Type": "application/json"}
)
f2.putfile(f)
ReleaseFile.objects.create(
name=f"http://example.com/{f2.name}",
release_id=release.id,
organization_id=project.organization_id,
file=f2,
)
# To verify that the full url has priority over the relative url,
# we will also add a second ReleaseFile alias for file2.js (f3) w/o
# hostname that points to an empty file. If the processor chooses
# this empty file over the correct file2.js, it will not locate
# context for the 2nd frame.
with open(get_fixture_path("empty.js"), "rb") as f:
f2_empty = File.objects.create(
name="empty.js", type="release.file", headers={"Content-Type": "application/json"}
)
f2_empty.putfile(f)
ReleaseFile.objects.create(
name=f"~/{f2.name}", # intentionally using f2.name ("file2.js")
release_id=release.id,
organization_id=project.organization_id,
file=f2_empty,
)
# sourcemap
# ----------
with open(get_fixture_path("file.sourcemap.js"), "rb") as f:
f_sourcemap = File.objects.create(
name="file.sourcemap.js",
type="release.file",
headers={"Content-Type": "application/json"},
)
f_sourcemap.putfile(f)
ReleaseFile.objects.create(
name=f"http://example.com/{f_sourcemap.name}",
release_id=release.id,
organization_id=project.organization_id,
file=f_sourcemap,
)
data = {
"timestamp": self.min_ago,
"message": "hello",
"platform": "javascript",
"release": "abc",
"exception": {
"values": [
{
"type": "Error",
"stacktrace": {
"frames": [
{
"abs_path": "http://example.com/file.min.js?foo=bar",
"filename": "file.min.js",
"lineno": 1,
"colno": 39,
},
{
"abs_path": "http://example.com/file.min.js?foo=bar",
"filename": "file.min.js",
"lineno": 1,
"colno": 79,
},
]
},
}
]
},
}
event = self.post_and_retrieve_event(data)
assert "errors" not in event.data
exception = event.interfaces["exception"]
frame_list = exception.values[0].stacktrace.frames
frame = frame_list[0]
assert frame.data["resolved_with"] == "release-old"
assert frame.data["symbolicated"]
assert frame.pre_context == ["function add(a, b) {", '\t"use strict";']
assert frame.context_line == "\treturn a + b; // fôo"
assert frame.post_context == ["}"]
frame = frame_list[1]
assert frame.data["resolved_with"] == "release-old"
assert frame.data["symbolicated"]
assert frame.pre_context == ["function multiply(a, b) {", '\t"use strict";']
assert frame.context_line == "\treturn a * b;"
assert frame.post_context == [
"}",
"function divide(a, b) {",
'\t"use strict";',
"\ttry {",
"\t\treturn multiply(add(a, b), a, b) / c;",
]
@requires_symbolicator
@pytest.mark.symbolicator
def test_expansion_via_distribution_release_artifacts(self):
project = self.project
release = Release.objects.create(organization_id=project.organization_id, version="abc")
release.add_project(project)
dist = release.add_dist("foo")
# file.min.js
# ------------
with open(get_fixture_path("file.min.js"), "rb") as f:
f_minified = File.objects.create(
name="file.min.js",
type="release.file",
headers={"Content-Type": "application/json"},
)
f_minified.putfile(f)
# Intentionally omit hostname - use alternate artifact path lookup instead
# /file1.js vs http://example.com/file1.js
ReleaseFile.objects.create(
name=f"~/{f_minified.name}?foo=bar",
release_id=release.id,
dist_id=dist.id,
organization_id=project.organization_id,
file=f_minified,
)
# file1.js
# ---------
with open(get_fixture_path("file1.js"), "rb") as f:
f1 = File.objects.create(
name="file1.js",
type="release.file",
headers={"Content-Type": "application/json"},
)
f1.putfile(f)
ReleaseFile.objects.create(
name=f"http://example.com/{f1.name}",
release_id=release.id,
dist_id=dist.id,
organization_id=project.organization_id,
file=f1,
)
# file2.js
# ----------
with open(get_fixture_path("file2.js"), "rb") as f:
f2 = File.objects.create(
name="file2.js",
type="release.file",
headers={"Content-Type": "application/json"},
)
f2.putfile(f)
ReleaseFile.objects.create(
name=f"http://example.com/{f2.name}",
release_id=release.id,
dist_id=dist.id,
organization_id=project.organization_id,
file=f2,
)
# To verify that the full url has priority over the relative url,
# we will also add a second ReleaseFile alias for file2.js (f3) w/o
# hostname that points to an empty file. If the processor chooses
# this empty file over the correct file2.js, it will not locate
# context for the 2nd frame.
with open(get_fixture_path("empty.js"), "rb") as f:
f2_empty = File.objects.create(
name="empty.js",
type="release.file",
headers={"Content-Type": "application/json"},
)
f2_empty.putfile(f)
ReleaseFile.objects.create(
name=f"~/{f2.name}", # intentionally using f2.name ("file2.js")
release_id=release.id,
dist_id=dist.id,
organization_id=project.organization_id,
file=f2_empty,
)
# sourcemap
# ----------
with open(get_fixture_path("file.sourcemap.js"), "rb") as f:
f_sourcemap = File.objects.create(
name="file.sourcemap.js",
type="release.file",
headers={"Content-Type": "application/json"},
)
f_sourcemap.putfile(f)
ReleaseFile.objects.create(
name=f"http://example.com/{f_sourcemap.name}",
release_id=release.id,
dist_id=dist.id,
organization_id=project.organization_id,
file=f_sourcemap,
)
data = {
"timestamp": self.min_ago,
"message": "hello",
"platform": "javascript",
"release": "abc",
"dist": "foo",
"exception": {
"values": [
{
"type": "Error",
"stacktrace": {
"frames": [
{
"abs_path": "http://example.com/file.min.js?foo=bar",
"filename": "file.min.js",
"lineno": 1,
"colno": 39,
},
{
"abs_path": "http://example.com/file.min.js?foo=bar",
"filename": "file.min.js",
"lineno": 1,
"colno": 79,
},
]
},
}
]
},
}
event = self.post_and_retrieve_event(data)
assert "errors" not in event.data
exception = event.interfaces["exception"]
frame_list = exception.values[0].stacktrace.frames
frame = frame_list[0]
assert frame.data["resolved_with"] == "release-old"
assert frame.data["symbolicated"]
assert frame.pre_context == ["function add(a, b) {", '\t"use strict";']
assert frame.context_line == "\treturn a + b; // fôo"
assert frame.post_context == ["}"]
frame = frame_list[1]
assert frame.data["resolved_with"] == "release-old"
assert frame.data["symbolicated"]
assert frame.pre_context == ["function multiply(a, b) {", '\t"use strict";']
assert frame.context_line == "\treturn a * b;"
assert frame.post_context == [
"}",
"function divide(a, b) {",
'\t"use strict";',
"\ttry {",
"\t\treturn multiply(add(a, b), a, b) / c;",
]
def _test_expansion_via_release_archive(self, link_sourcemaps: bool):
project = self.project
release = Release.objects.create(organization_id=project.organization_id, version="abc")
release.add_project(project)
manifest = {
"org": self.organization.slug,
"release": release.version,
"files": {
"files/_/_/file.min.js": {
"url": "http://example.com/file.min.js",
"type": "minified_source",
},
"files/_/_/file1.js": {
"url": "http://example.com/file1.js",
"type": "source",
},
"files/_/_/file2.js": {
"url": "http://example.com/file2.js",
"type": "source",
},
"files/_/_/file.sourcemap.js": {
"url": "http://example.com/file.sourcemap.js",
"type": "source_map",
},
},
}
compressed = BytesIO(b"SYSB")
with zipfile.ZipFile(compressed, "a") as zip_file:
for rel_path, entry in manifest["files"].items():
name = os.path.basename(rel_path)
content = load_fixture(name)
if name == "file.min.js" and not link_sourcemaps:
# Remove link to source map, add to header instead
content = content.replace(b"//@ sourceMappingURL=file.sourcemap.js", b"")
entry["headers"] = {"Sourcemap": "file.sourcemap.js"}
zip_file.writestr(rel_path, content)
zip_file.writestr("manifest.json", json.dumps(manifest))
compressed.seek(0)
file = File.objects.create(name="doesnt_matter", type="release.bundle")
file.putfile(compressed)
update_artifact_index(release, None, file)
data = {
"timestamp": self.min_ago,
"message": "hello",
"platform": "javascript",
"release": "abc",
"exception": {
"values": [
{
"type": "Error",
"stacktrace": {
"frames": [
{
"abs_path": "http://example.com/file.min.js",
"filename": "file.min.js",
"lineno": 1,
"colno": 39,
},
{
"abs_path": "http://example.com/file.min.js",
"filename": "file.min.js",
"lineno": 1,
"colno": 79,
},
]
},
}
]
},
}
event = self.post_and_retrieve_event(data)
assert "errors" not in event.data
exception = event.interfaces["exception"]
frame_list = exception.values[0].stacktrace.frames
frame = frame_list[0]
assert frame.data["resolved_with"] == "release-old"
assert frame.data["symbolicated"]
assert frame.pre_context == ["function add(a, b) {", '\t"use strict";']
assert frame.context_line == "\treturn a + b; // fôo"
assert frame.post_context == ["}"]
frame = frame_list[1]
assert frame.data["resolved_with"] == "release-old"
assert frame.data["symbolicated"]
assert frame.pre_context == ["function multiply(a, b) {", '\t"use strict";']
assert frame.context_line == "\treturn a * b;"
assert frame.post_context == [
"}",
"function divide(a, b) {",
'\t"use strict";',
"\ttry {",
"\t\treturn multiply(add(a, b), a, b) / c;",
]
@requires_symbolicator
@pytest.mark.symbolicator
def test_expansion_via_release_archive(self):
self._test_expansion_via_release_archive(link_sourcemaps=True)
@requires_symbolicator
@pytest.mark.symbolicator
def test_expansion_via_release_archive_no_sourcemap_link(self):
self._test_expansion_via_release_archive(link_sourcemaps=False)
@requires_symbolicator
@pytest.mark.symbolicator
def test_node_processing(self):
project = self.project
release = Release.objects.create(
organization_id=project.organization_id, version="nodeabc123"
)
release.add_project(project)
with open(get_fixture_path("dist.bundle.js"), "rb") as f:
f_minified = File.objects.create(
name="dist.bundle.js",
type="release.file",
headers={"Content-Type": "application/javascript"},
)
f_minified.putfile(f)
ReleaseFile.objects.create(
name=f"~/{f_minified.name}",
release_id=release.id,
organization_id=project.organization_id,
file=f_minified,
)
with open(get_fixture_path("dist.bundle.js.map"), "rb") as f:
f_sourcemap = File.objects.create(
name="dist.bundle.js.map",
type="release.file",
headers={"Content-Type": "application/javascript"},
)
f_sourcemap.putfile(f)
ReleaseFile.objects.create(
name=f"~/{f_sourcemap.name}",
release_id=release.id,
organization_id=project.organization_id,
file=f_sourcemap,
)
data = {
"timestamp": self.min_ago,
"message": "hello",
"platform": "node",
"release": "nodeabc123",
"exception": {
"values": [
{
"type": "Error",
"stacktrace": {
"frames": [
{
"filename": "app:///dist.bundle.js",
"function": "bar",
"lineno": 9,
"colno": 2321,
},
{
"filename": "app:///dist.bundle.js",
"function": "foo",
"lineno": 3,
"colno": 2308,
},
{
"filename": "app:///dist.bundle.js",
"function": "App",
"lineno": 3,
"colno": 1011,
},
{
"filename": "app:///dist.bundle.js",
"function": "Object.<anonymous>",
"lineno": 1,
"colno": 1014,
},
{
"filename": "app:///dist.bundle.js",
"function": "__webpack_require__",
"lineno": 20,
"colno": 30,
},
{
"filename": "app:///dist.bundle.js",
"function": "<unknown>",
"lineno": 18,
"colno": 63,
},
]
},
}
]
},
}
event = self.post_and_retrieve_event(data)
exception = event.interfaces["exception"]
frame_list = exception.values[0].stacktrace.frames
assert len(frame_list) == 6
def assert_abs_path(abs_path):
# This makes the test assertion forward compatible with percent-encoded URLs
# See https://github.com/getsentry/symbolicator/pull/1137
assert abs_path in (
"webpack:///webpack/bootstrap d9a5a31d9276b73873d3",
"webpack:///webpack/bootstrap%20d9a5a31d9276b73873d3",
)
assert_abs_path(frame_list[0].abs_path)
assert frame_list[0].function == "bar"
assert frame_list[0].lineno == 8
assert_abs_path(frame_list[1].abs_path)
assert frame_list[1].function == "foo"
assert frame_list[1].lineno == 2
assert_abs_path(frame_list[2].abs_path)
assert frame_list[2].function == "App"
assert frame_list[2].lineno == 2
assert_abs_path(frame_list[3].abs_path)
assert frame_list[3].function == "Object.<anonymous>"
assert frame_list[3].lineno == 1
assert_abs_path(frame_list[4].abs_path)
assert frame_list[4].function == "__webpack_require__"
assert frame_list[4].lineno == 19
assert_abs_path(frame_list[5].abs_path)
assert frame_list[5].function == "<unknown>"
assert frame_list[5].lineno == 16
@responses.activate
def test_no_fetch_from_http(self):
responses.add(
responses.GET,
"http://example.com/node_app.min.js",
body=load_fixture("node_app.min.js"),
content_type="application/javascript; charset=utf-8",
)
responses.add(
responses.GET,
"http://example.com/node_app.min.js.map",
body=load_fixture("node_app.min.js.map"),
content_type="application/javascript; charset=utf-8",
)
responses.add_passthru(
settings.SENTRY_SNUBA + "/tests/entities/generic_metrics_counters/insert",
)
data = {
"timestamp": self.min_ago,
"message": "hello",
"platform": "node",
"exception": {
"values": [
{
"type": "Error",
"stacktrace": {
"frames": [
{
"abs_path": "node_bootstrap.js",
"filename": "node_bootstrap.js",
"lineno": 1,
"colno": 38,
},
{
"abs_path": "timers.js",
"filename": "timers.js",
"lineno": 1,
"colno": 39,
},
{
"abs_path": "webpack:///internal",
"filename": "internal",
"lineno": 1,
"colno": 43,
},
{
"abs_path": "webpack:///~/some_dep/file.js",
"filename": "file.js",
"lineno": 1,
"colno": 41,
},
{
"abs_path": "webpack:///./node_modules/file.js",
"filename": "file.js",
"lineno": 1,
"colno": 42,
},
{
"abs_path": "http://example.com/node_app.min.js",
"filename": "node_app.min.js",
"lineno": 1,
"colno": 40,
},
]
},
}
]
},
}
event = self.post_and_retrieve_event(data)
exception = event.interfaces["exception"]
frame_list = exception.values[0].stacktrace.frames
# This one should not process, so this one should be none.
assert exception.values[0].raw_stacktrace is None
# None of the in app should update
for x in range(6):
assert not frame_list[x].in_app
@responses.activate
def test_html_file_with_query_param_ending_with_js_extension(self):
responses.add(
responses.GET,
"http://example.com/file.html",
body=(
"<!doctype html><html><head></head><body><script>/*legit case*/</script></body></html>"
),
)
responses.add_passthru(
settings.SENTRY_SNUBA + "/tests/entities/generic_metrics_counters/insert",
)
data = {
"timestamp": self.min_ago,
"message": "hello",
"platform": "javascript",
"exception": {
"values": [
{
"type": "Error",
"stacktrace": {
"frames": [
{
"abs_path": "http://example.com/file.html?sw=iddqd1337.js",
"filename": "file.html",
"lineno": 1,
"colno": 1,
},
]
},
}
]
},
}
event = self.post_and_retrieve_event(data)
assert "errors" not in event.data
@requires_symbolicator
@pytest.mark.symbolicator
def test_expansion_with_debug_id(self):
project = self.project
release = Release.objects.create(organization_id=project.organization_id, version="abc")
release.add_project(project)
debug_id = "c941d872-af1f-4f0c-a7ff-ad3d295fe153"
compressed = BytesIO(b"SYSB")
with zipfile.ZipFile(compressed, "a") as zip_file:
zip_file.writestr("files/_/_/file.min.js", load_fixture("file.min.js"))
zip_file.writestr("files/_/_/file1.js", load_fixture("file1.js"))
zip_file.writestr("files/_/_/file2.js", load_fixture("file2.js"))
zip_file.writestr("files/_/_/empty.js", load_fixture("empty.js"))
zip_file.writestr(
"files/_/_/file.wc.sourcemap.js", load_fixture("file.wc.sourcemap.js")
)
zip_file.writestr(
"manifest.json",
json.dumps(
{
"org": self.organization.slug,
"release": release.version,
"files": {
"files/_/_/file.min.js": {
"url": "~/file.min.js",
"type": "minified_source",
"headers": {
"content-type": "application/json",
"debug-id": debug_id,
"sourcemap": "file.sourcemap.js",
},
},
"files/_/_/file1.js": {
"url": "~/file1.js",
"type": "source",
"headers": {
"content-type": "application/json",
},
},
"files/_/_/file2.js": {
"url": "~/file2.js",
"type": "source",
"headers": {
"content-type": "application/json",
},
},
"files/_/_/empty.js": {
"url": "~/empty.js",
"type": "source",
"headers": {
"content-type": "application/json",
},
},
"files/_/_/file.wc.sourcemap.js": {
"url": "~/file.wc.sourcemap.js",
"type": "source_map",
"headers": {
"content-type": "application/json",
"debug-id": debug_id,
},
},
},
}
),
)
compressed.seek(0)
file = File.objects.create(name="bundle.zip", type="artifact.bundle")
file.putfile(compressed)
# We want to also store the release files for this bundle, to check if they work together.
compressed.seek(0)
file_for_release = File.objects.create(name="bundle.zip", type="release.bundle")
file_for_release.putfile(compressed)
update_artifact_index(release, None, file_for_release)
artifact_bundle = ArtifactBundle.objects.create(
organization_id=self.organization.id, bundle_id=uuid4(), file=file, artifact_count=5
)
ProjectArtifactBundle.objects.create(
organization_id=self.organization.id,
project_id=self.project.id,
artifact_bundle=artifact_bundle,
)
DebugIdArtifactBundle.objects.create(
organization_id=self.organization.id,
debug_id=debug_id,
artifact_bundle=artifact_bundle,
source_file_type=SourceFileType.MINIFIED_SOURCE.value,
)
DebugIdArtifactBundle.objects.create(
organization_id=self.organization.id,
debug_id=debug_id,
artifact_bundle=artifact_bundle,
source_file_type=SourceFileType.SOURCE_MAP.value,
)
data = {
"timestamp": self.min_ago,
"message": "hello",
"platform": "javascript",
"release": "abc",
"exception": {
"values": [
{
"type": "Error",
"stacktrace": {
"frames": [
{
"abs_path": "http://example.com/file.min.js",
"filename": "file.min.js",
"lineno": 1,
"colno": 39,
},
{
"abs_path": "http://example.com/file.min.js",
"filename": "file.min.js",
"lineno": 1,
"colno": 79,
},
# We want also to test the source without minification.
{
"abs_path": "http://example.com/file1.js",
"filename": "file1.js",
"lineno": 3,
"colno": 12,
},
]
},
}
]
},
"debug_meta": {
"images": [
{
"type": "sourcemap",
"debug_id": debug_id,
"code_file": "http://example.com/file.min.js",
}
]
},
}
event = self.post_and_retrieve_event(data)
assert "errors" not in event.data
exception = event.interfaces["exception"]
frame_list = exception.values[0].stacktrace.frames
frame = frame_list[0]
assert frame.data["resolved_with"] == "debug-id"
assert frame.data["symbolicated"]
assert frame.pre_context == ["function add(a, b) {", '\t"use strict";']
assert frame.context_line == "\treturn a + b; // fôo"
assert frame.post_context == ["}"]
frame = frame_list[1]
assert frame.data["resolved_with"] == "debug-id"
assert frame.data["symbolicated"]
assert frame.pre_context == ["function multiply(a, b) {", '\t"use strict";']
assert frame.context_line == "\treturn a * b;"
assert frame.post_context == [
"}",
"function divide(a, b) {",
'\t"use strict";',
"\ttry {",
"\t\treturn multiply(add(a, b), a, b) / c;",
]
frame = frame_list[2]
assert "resolved_with" not in frame.data
assert "symbolicated" not in frame.data
assert frame.pre_context == ["function add(a, b) {", '\t"use strict";']
assert frame.context_line == "\treturn a + b; // fôo"
assert frame.post_context == ["}"]
@requires_symbolicator
@pytest.mark.symbolicator
def test_expansion_with_debug_id_and_sourcemap_without_sources_content(self):
debug_id = "c941d872-af1f-4f0c-a7ff-ad3d295fe153"
compressed = BytesIO(b"SYSB")
with zipfile.ZipFile(compressed, "a") as zip_file:
zip_file.writestr("files/_/_/file.min.js", load_fixture("file.min.js"))
zip_file.writestr("files/_/_/file1.js", load_fixture("file1.js"))
zip_file.writestr("files/_/_/file2.js", load_fixture("file2.js"))
zip_file.writestr("files/_/_/empty.js", load_fixture("empty.js"))
zip_file.writestr("files/_/_/file.sourcemap.js", load_fixture("file.sourcemap.js"))
zip_file.writestr(
"manifest.json",
json.dumps(
{
"files": {
"files/_/_/file.min.js": {
"url": "~/file.min.js",
"type": "minified_source",
"headers": {
"content-type": "application/json",
"debug-id": debug_id,
"sourcemap": "file.sourcemap.js",
},
},
"files/_/_/file1.js": {
"url": "~/file1.js",
"type": "source",
"headers": {
"content-type": "application/json",
},
},
"files/_/_/file2.js": {
"url": "~/file2.js",
"type": "source",
"headers": {
"content-type": "application/json",
},
},
"files/_/_/empty.js": {
"url": "~/empty.js",
"type": "source",
"headers": {
"content-type": "application/json",
},
},
"files/_/_/file.sourcemap.js": {
"url": "~/file.sourcemap.js",
"type": "source_map",
"headers": {
"content-type": "application/json",
"debug-id": debug_id,
},
},
}
}
),
)
compressed.seek(0)
file = File.objects.create(name="bundle.zip", type="artifact.bundle")
file.putfile(compressed)
artifact_bundle = ArtifactBundle.objects.create(
organization_id=self.organization.id, bundle_id=uuid4(), file=file, artifact_count=5
)
ProjectArtifactBundle.objects.create(
organization_id=self.organization.id,
project_id=self.project.id,
artifact_bundle=artifact_bundle,
)
DebugIdArtifactBundle.objects.create(
organization_id=self.organization.id,
debug_id=debug_id,
artifact_bundle=artifact_bundle,
source_file_type=SourceFileType.MINIFIED_SOURCE.value,
)
DebugIdArtifactBundle.objects.create(
organization_id=self.organization.id,
debug_id=debug_id,
artifact_bundle=artifact_bundle,
source_file_type=SourceFileType.SOURCE_MAP.value,
)
data = {
"timestamp": self.min_ago,
"message": "hello",
"platform": "javascript",
"release": "abc",
"exception": {
"values": [
{
"type": "Error",
"stacktrace": {
"frames": [
{
"abs_path": "http://example.com/file.min.js",
"filename": "file.min.js",
"lineno": 1,
"colno": 39,
},
{
"abs_path": "http://example.com/file.min.js",
"filename": "file.min.js",
"lineno": 1,
"colno": 79,
},
]
},
}
]
},
"debug_meta": {
"images": [
{
"type": "sourcemap",
"debug_id": debug_id,
"code_file": "http://example.com/file.min.js",
}
]
},
}
event = self.post_and_retrieve_event(data)
assert "errors" not in event.data
exception = event.interfaces["exception"]
frame_list = exception.values[0].stacktrace.frames
frame = frame_list[0]
assert frame.data["resolved_with"] == "debug-id"
assert frame.data["symbolicated"]
assert frame.pre_context == ["function add(a, b) {", '\t"use strict";']
assert frame.context_line == "\treturn a + b; // fôo"
assert frame.post_context == ["}"]
frame = frame_list[1]
assert frame.data["resolved_with"] == "debug-id"
assert frame.data["symbolicated"]
assert frame.pre_context == ["function multiply(a, b) {", '\t"use strict";']
assert frame.context_line == "\treturn a * b;"
assert frame.post_context == [
"}",
"function divide(a, b) {",
'\t"use strict";',
"\ttry {",
"\t\treturn multiply(add(a, b), a, b) / c;",
]
@requires_symbolicator
@pytest.mark.symbolicator
def test_expansion_with_debug_id_and_malformed_sourcemap(self):
debug_id = "c941d872-af1f-4f0c-a7ff-ad3d295fe153"
compressed = BytesIO(b"SYSB")
with zipfile.ZipFile(compressed, "a") as zip_file:
zip_file.writestr("files/_/_/file.min.js", load_fixture("file.min.js"))
zip_file.writestr("files/_/_/file1.js", load_fixture("file1.js"))
zip_file.writestr("files/_/_/file2.js", load_fixture("file2.js"))
zip_file.writestr("files/_/_/empty.js", load_fixture("empty.js"))
zip_file.writestr(
"files/_/_/file.malformed.sourcemap.js", load_fixture("file.malformed.sourcemap.js")
)
zip_file.writestr(
"manifest.json",
json.dumps(
{
"files": {
"files/_/_/file.min.js": {
"url": "~/file.min.js",
"type": "minified_source",
"headers": {
"content-type": "application/json",
"debug-id": debug_id,
"sourcemap": "file.malformed.sourcemap.js",
},
},
"files/_/_/file1.js": {
"url": "~/file1.js",
"type": "source",
"headers": {
"content-type": "application/json",
},
},
"files/_/_/file2.js": {
"url": "~/file2.js",
"type": "source",
"headers": {
"content-type": "application/json",
},
},
"files/_/_/empty.js": {
"url": "~/empty.js",
"type": "source",
"headers": {
"content-type": "application/json",
},
},
"files/_/_/file.malformed.sourcemap.js": {
"url": "~/file.malformed.sourcemap.js",
"type": "source_map",
"headers": {
"content-type": "application/json",
"debug-id": debug_id,
},
},
}
}
),
)
compressed.seek(0)
file = File.objects.create(name="bundle.zip", type="artifact.bundle")
file.putfile(compressed)
artifact_bundle = ArtifactBundle.objects.create(
organization_id=self.organization.id, bundle_id=uuid4(), file=file, artifact_count=5
)
ProjectArtifactBundle.objects.create(
organization_id=self.organization.id,
project_id=self.project.id,
artifact_bundle=artifact_bundle,
)
DebugIdArtifactBundle.objects.create(
organization_id=self.organization.id,
debug_id=debug_id,
artifact_bundle=artifact_bundle,
source_file_type=SourceFileType.MINIFIED_SOURCE.value,
)
DebugIdArtifactBundle.objects.create(
organization_id=self.organization.id,
debug_id=debug_id,
artifact_bundle=artifact_bundle,
source_file_type=SourceFileType.SOURCE_MAP.value,
)
data = {
"timestamp": self.min_ago,
"message": "hello",
"platform": "javascript",
"release": "abc",
"exception": {
"values": [
{
"type": "Error",
"stacktrace": {
"frames": [
{
"abs_path": "http://example.com/file.min.js",
"filename": "file.min.js",
"lineno": 1,
"colno": 39,
},
{
"abs_path": "http://example.com/file.min.js",
"filename": "file.min.js",
"lineno": 1,
"colno": 79,
},
]
},
}
]
},
"debug_meta": {
"images": [
{
"type": "sourcemap",
"debug_id": debug_id,
"code_file": "http://example.com/file.min.js",
}
]
},
}
event = self.post_and_retrieve_event(data)
assert len(event.data["errors"]) == 1
assert event.data["errors"][0] == {
"type": "js_invalid_source",
"symbolicator_type": "malformed_sourcemap",
"url": "http://example.com/file.malformed.sourcemap.js",
}
@requires_symbolicator
@pytest.mark.symbolicator
def test_expansion_with_debug_id_not_found(self):
project = self.project
release = Release.objects.create(organization_id=project.organization_id, version="abc")
release.add_project(project)
manifest = {
"org": self.organization.slug,
"release": release.version,
"files": {
"files/_/_/file.min.js": {
"url": "http://example.com/file.min.js",
"type": "minified_source",
},
"files/_/_/file1.js": {
"url": "http://example.com/file1.js",
"type": "source",
},
"files/_/_/file2.js": {
"url": "http://example.com/file2.js",
"type": "source",
},
"files/_/_/file.sourcemap.js": {
"url": "http://example.com/file.sourcemap.js",
"type": "source_map",
},
},
}
compressed = BytesIO(b"SYSB")
with zipfile.ZipFile(compressed, "a") as zip_file:
for rel_path, entry in manifest["files"].items():
name = os.path.basename(rel_path)
content = load_fixture(name)
if name == "file.min.js":
# Remove link to source map, add to header instead
content = content.replace(b"//@ sourceMappingURL=file.sourcemap.js", b"")
entry["headers"] = {"Sourcemap": "file.sourcemap.js"}
zip_file.writestr(rel_path, content)
zip_file.writestr("manifest.json", json.dumps(manifest))
compressed.seek(0)
file = File.objects.create(name="release_bundle.zip", type="release.bundle")
file.putfile(compressed)
update_artifact_index(release, None, file)
debug_id = "c941d872-af1f-4f0c-a7ff-ad3d295fe153"
data = {
"timestamp": self.min_ago,
"message": "hello",
"platform": "javascript",
"release": "abc",
"exception": {
"values": [
{
"type": "Error",
"stacktrace": {
"frames": [
{
"abs_path": "http://example.com/file.min.js",
"filename": "file.min.js",
"lineno": 1,
"colno": 39,
},
{
"abs_path": "http://example.com/file.min.js",
"filename": "file.min.js",
"lineno": 1,
"colno": 79,
},
# We want also to test the source without minification.
{
"abs_path": "http://example.com/file1.js",
"filename": "file1.js",
"lineno": 3,
"colno": 12,
},
]
},
}
]
},
"debug_meta": {
"images": [
{
"type": "sourcemap",
"debug_id": debug_id,
"code_file": "http://example.com/file.min.js",
}
]
},
}
event = self.post_and_retrieve_event(data)
exception = event.interfaces["exception"]
frame_list = exception.values[0].stacktrace.frames
frame = frame_list[0]
assert frame.pre_context == ["function add(a, b) {", '\t"use strict";']
assert frame.context_line == "\treturn a + b; // fôo"
assert frame.post_context == ["}"]
frame = frame_list[1]
assert frame.pre_context == ["function multiply(a, b) {", '\t"use strict";']
assert frame.context_line == "\treturn a * b;"
assert frame.post_context == [
"}",
"function divide(a, b) {",
'\t"use strict";',
"\ttry {",
"\t\treturn multiply(add(a, b), a, b) / c;",
]
frame = frame_list[2]
assert frame.pre_context == ["function add(a, b) {", '\t"use strict";']
assert frame.context_line == "\treturn a + b; // fôo"
assert frame.post_context == ["}"]
@requires_symbolicator
@pytest.mark.symbolicator
def test_expansion_with_release_dist_pair_x(self):
project = self.project
release = Release.objects.create(organization_id=project.organization_id, version="abc")
release.add_project(project)
dist = release.add_dist("android")
# We want to also add debug_id information inside the manifest but not in the stack trace to replicate a
# real edge case that we can incur in.
debug_id = "c941d872-af1f-4f0c-a7ff-ad3d295fe153"
compressed = BytesIO(b"SYSB")
with zipfile.ZipFile(compressed, "a") as zip_file:
zip_file.writestr("files/_/_/file.min.js", load_fixture("file.min.js"))
zip_file.writestr("files/_/_/file1.js", load_fixture("file1.js"))
zip_file.writestr("files/_/_/file2.js", load_fixture("file2.js"))
zip_file.writestr("files/_/_/empty.js", load_fixture("empty.js"))
zip_file.writestr(
"files/_/_/file.wc.sourcemap.js", load_fixture("file.wc.sourcemap.js")
)
zip_file.writestr(
"manifest.json",
json.dumps(
{
"files": {
"files/_/_/file.min.js": {
"url": "~/file.min.js",
"type": "minified_source",
"headers": {
"content-type": "application/json",
"sourcemap": "file.wc.sourcemap.js",
"debug-id": debug_id,
},
},
"files/_/_/file1.js": {
"url": "~/file1.js",
"type": "source",
"headers": {
"content-type": "application/json",
},
},
"files/_/_/file2.js": {
"url": "~/file2.js",
"type": "source",
"headers": {
"content-type": "application/json",
},
},
"files/_/_/empty.js": {
"url": "~/empty.js",
"type": "source",
"headers": {
"content-type": "application/json",
},
},
"files/_/_/file.wc.sourcemap.js": {
"url": "~/file.wc.sourcemap.js",
"type": "source_map",
"headers": {
"content-type": "application/json",
"debug-id": debug_id,
},
},
},
}
),
)
compressed.seek(0)
file = File.objects.create(name="bundle.zip", type="artifact.bundle")
file.putfile(compressed)
artifact_bundle = ArtifactBundle.objects.create(
organization_id=self.organization.id, bundle_id=uuid4(), file=file, artifact_count=5
)
ProjectArtifactBundle.objects.create(
organization_id=self.organization.id,
project_id=self.project.id,
artifact_bundle=artifact_bundle,
)
ReleaseArtifactBundle.objects.create(
organization_id=self.organization.id,
release_name=release.version,
dist_name=dist.name,
artifact_bundle=artifact_bundle,
)
data = {
"timestamp": self.min_ago,
"message": "hello",
"platform": "javascript",
"release": release.version,
"dist": dist.name,
"exception": {
"values": [
{
"type": "Error",
"stacktrace": {
"frames": [
{
"abs_path": "http://example.com/file.min.js",
"filename": "file.min.js",
"lineno": 1,
"colno": 39,
},
{
"abs_path": "http://example.com/file.min.js",
"filename": "file.min.js",
"lineno": 1,
"colno": 79,
},
# We want also to test the source without minification.
{
"abs_path": "http://example.com/file1.js",
"filename": "file1.js",
"lineno": 3,
"colno": 12,
},
]
},
}
]
},
}
event = self.post_and_retrieve_event(data)
assert "errors" not in event.data
exception = event.interfaces["exception"]
frame_list = exception.values[0].stacktrace.frames
frame = frame_list[0]
assert frame.data["resolved_with"] == "release"
assert frame.data["symbolicated"]
assert frame.pre_context == ["function add(a, b) {", '\t"use strict";']
assert frame.context_line == "\treturn a + b; // fôo"
assert frame.post_context == ["}"]
frame = frame_list[1]
assert frame.data["resolved_with"] == "release"
assert frame.data["symbolicated"]
assert frame.pre_context == ["function multiply(a, b) {", '\t"use strict";']
assert frame.context_line == "\treturn a * b;"
assert frame.post_context == [
"}",
"function divide(a, b) {",
'\t"use strict";',
"\ttry {",
"\t\treturn multiply(add(a, b), a, b) / c;",
]
frame = frame_list[2]
assert frame.pre_context == ["function add(a, b) {", '\t"use strict";']
assert frame.context_line == "\treturn a + b; // fôo"
assert frame.post_context == ["}"]
@requires_symbolicator
@pytest.mark.symbolicator
def test_expansion_with_release_dist_pair_and_sourcemap_without_sources_content(self):
project = self.project
release = Release.objects.create(organization_id=project.organization_id, version="abc")
release.add_project(project)
dist = release.add_dist("android")
compressed = BytesIO(b"SYSB")
with zipfile.ZipFile(compressed, "a") as zip_file:
zip_file.writestr("files/_/_/file.min.js", load_fixture("file.min.js"))
zip_file.writestr("files/_/_/file1.js", load_fixture("file1.js"))
zip_file.writestr("files/_/_/file2.js", load_fixture("file2.js"))
zip_file.writestr("files/_/_/empty.js", load_fixture("empty.js"))
zip_file.writestr("files/_/_/file.sourcemap.js", load_fixture("file.sourcemap.js"))
zip_file.writestr(
"manifest.json",
json.dumps(
{
"files": {
"files/_/_/file.min.js": {
"url": "~/file.min.js",
"type": "minified_source",
"headers": {
"content-type": "application/json",
"sourcemap": "file.sourcemap.js",
},
},
"files/_/_/file1.js": {
"url": "~/file1.js",
"type": "source",
"headers": {
"content-type": "application/json",
},
},
"files/_/_/file2.js": {
"url": "~/file2.js",
"type": "source",
"headers": {
"content-type": "application/json",
},
},
"files/_/_/empty.js": {
"url": "~/empty.js",
"type": "source",
"headers": {
"content-type": "application/json",
},
},
"files/_/_/file.sourcemap.js": {
"url": "~/file.sourcemap.js",
"type": "source_map",
"headers": {
"content-type": "application/json",
},
},
}
}
),
)
compressed.seek(0)
file = File.objects.create(name="bundle.zip", type="artifact.bundle")
file.putfile(compressed)
artifact_bundle = ArtifactBundle.objects.create(
organization_id=self.organization.id, bundle_id=uuid4(), file=file, artifact_count=5
)
ProjectArtifactBundle.objects.create(
organization_id=self.organization.id,
project_id=self.project.id,
artifact_bundle=artifact_bundle,
)
ReleaseArtifactBundle.objects.create(
organization_id=self.organization.id,
release_name=release.version,
dist_name=dist.name,
artifact_bundle=artifact_bundle,
)
data = {
"timestamp": self.min_ago,
"message": "hello",
"platform": "javascript",
"release": release.version,
"dist": dist.name,
"exception": {
"values": [
{
"type": "Error",
"stacktrace": {
"frames": [
{
"abs_path": "http://example.com/file.min.js",
"filename": "file.min.js",
"lineno": 1,
"colno": 39,
},
{
"abs_path": "http://example.com/file.min.js",
"filename": "file.min.js",
"lineno": 1,
"colno": 79,
},
]
},
}
]
},
}
event = self.post_and_retrieve_event(data)
assert "errors" not in event.data
exception = event.interfaces["exception"]
frame_list = exception.values[0].stacktrace.frames
frame = frame_list[0]
assert frame.data["resolved_with"] == "release"
assert frame.data["symbolicated"]
assert frame.pre_context == ["function add(a, b) {", '\t"use strict";']
assert frame.context_line == "\treturn a + b; // fôo"
assert frame.post_context == ["}"]
frame = frame_list[1]
assert frame.data["resolved_with"] == "release"
assert frame.data["symbolicated"]
assert frame.pre_context == ["function multiply(a, b) {", '\t"use strict";']
assert frame.context_line == "\treturn a * b;"
assert frame.post_context == [
"}",
"function divide(a, b) {",
'\t"use strict";',
"\ttry {",
"\t\treturn multiply(add(a, b), a, b) / c;",
]
@requires_symbolicator
@pytest.mark.symbolicator
def test_expansion_with_release_and_malformed_sourcemap(self):
project = self.project
release = Release.objects.create(organization_id=project.organization_id, version="abc")
release.add_project(project)
compressed = BytesIO(b"SYSB")
with zipfile.ZipFile(compressed, "a") as zip_file:
zip_file.writestr("files/_/_/file.min.js", load_fixture("file.min.js"))
zip_file.writestr("files/_/_/file1.js", load_fixture("file1.js"))
zip_file.writestr("files/_/_/file2.js", load_fixture("file2.js"))
zip_file.writestr("files/_/_/empty.js", load_fixture("empty.js"))
zip_file.writestr(
"files/_/_/file.malformed.sourcemap.js", load_fixture("file.malformed.sourcemap.js")
)
zip_file.writestr(
"manifest.json",
json.dumps(
{
"files": {
"files/_/_/file.min.js": {
"url": "~/file.min.js",
"type": "minified_source",
"headers": {
"content-type": "application/json",
"sourcemap": "file.malformed.sourcemap.js",
},
},
"files/_/_/file1.js": {
"url": "~/file1.js",
"type": "source",
"headers": {
"content-type": "application/json",
},
},
"files/_/_/file2.js": {
"url": "~/file2.js",
"type": "source",
"headers": {
"content-type": "application/json",
},
},
"files/_/_/empty.js": {
"url": "~/empty.js",
"type": "source",
"headers": {
"content-type": "application/json",
},
},
"files/_/_/file.malformed.sourcemap.js": {
"url": "~/file.malformed.sourcemap.js",
"type": "source_map",
"headers": {
"content-type": "application/json",
},
},
}
}
),
)
compressed.seek(0)
file = File.objects.create(name="bundle.zip", type="artifact.bundle")
file.putfile(compressed)
artifact_bundle = ArtifactBundle.objects.create(
organization_id=self.organization.id, bundle_id=uuid4(), file=file, artifact_count=5
)
ProjectArtifactBundle.objects.create(
organization_id=self.organization.id,
project_id=self.project.id,
artifact_bundle=artifact_bundle,
)
ReleaseArtifactBundle.objects.create(
organization_id=self.organization.id,
release_name=release.version,
artifact_bundle=artifact_bundle,
)
data = {
"timestamp": self.min_ago,
"message": "hello",
"platform": "javascript",
"release": release.version,
"exception": {
"values": [
{
"type": "Error",
"stacktrace": {
"frames": [
{
"abs_path": "http://example.com/file.min.js",
"filename": "file.min.js",
"lineno": 1,
"colno": 39,
},
{
"abs_path": "http://example.com/file.min.js",
"filename": "file.min.js",
"lineno": 1,
"colno": 79,
},
]
},
}
]
},
}
event = self.post_and_retrieve_event(data)
assert len(event.data["errors"]) == 1
assert event.data["errors"][0] == {
"type": "js_invalid_source",
"symbolicator_type": "malformed_sourcemap",
"url": "http://example.com/file.malformed.sourcemap.js",
}
@requires_symbolicator
@pytest.mark.symbolicator
@with_feature("organizations:sourcemaps-bundle-flat-file-indexing")
@override_options(
{
"symbolicator.sourcemaps-bundle-index-sample-rate": 1.0,
"symbolicator.sourcemaps-bundle-index-refresh-sample-rate": 1.0,
}
)
def test_bundle_index(self):
project = self.project
release = Release.objects.create(organization_id=project.organization_id, version="abc")
release.add_project(project)
file_a = make_compressed_zip_file(
{
"files/_/_/file.min.js": {
"url": "~/file.min.js",
"type": "minified_source",
"content": load_fixture("file.min.js"),
"headers": {
"sourcemap": "file.sourcemap.js",
},
},
"files/_/_/file.sourcemap.js": {
"url": "~/file.sourcemap.js",
"type": "source_map",
"content": load_fixture("file.wc.sourcemap.js"),
},
},
)
upload_bundle(file_a, self.project, release.version)
# set the bundle date to something in the past so that it is being refreshed automatically
now = timezone.now()
ArtifactBundle.objects.filter(
organization_id=self.organization.id,
).update(date_added=now - timedelta(days=45))
data = {
"timestamp": self.min_ago,
"message": "hello",
"platform": "javascript",
"release": "abc",
"exception": {
"values": [
{
"type": "Error",
"stacktrace": {
"frames": [
{
"abs_path": "http://example.com/file.min.js",
"filename": "file.min.js",
"lineno": 1,
"colno": 39,
},
]
},
}
]
},
}
event = self.post_and_retrieve_event(data)
assert "errors" not in event.data
exception = event.interfaces["exception"]
frame_list = exception.values[0].stacktrace.frames
frame = frame_list[0]
assert frame.function == "add"
assert frame.filename == "file1.js"
assert frame.lineno == 3
assert frame.colno == 9
assert frame.data["resolved_with"] == "index"
assert frame.data["symbolicated"]
# explicitly trigger the task that is refreshing bundles, usually this
# happens on a schedule:
refresh_artifact_bundles_in_use()
artifact_bundles = ArtifactBundle.objects.filter(
organization_id=self.organization.id,
)
assert len(artifact_bundles) == 1
assert artifact_bundles[0].date_added >= now