sentinel/tests/sentry/lang/native/test_appconnect.py

import pathlib
import uuid
from datetime import datetime
from typing import TYPE_CHECKING
from unittest import mock

import pytest
from django.utils import timezone

from sentry.lang.native import appconnect
from sentry.testutils.pytest.fixtures import django_db_all
from sentry.utils import json
from sentry.utils.appleconnect import appstore_connect

if TYPE_CHECKING:
    from sentry.models.project import Project


class TestAppStoreConnectConfig:
    @pytest.fixture
    def now(self) -> datetime:
        # Fixture so we can have one "now" for the entire test and its fixtures.
        return datetime.utcnow()

    @pytest.fixture
    def data(self, now: datetime) -> json.JSONData:
        return {
            "type": "appStoreConnect",
            "id": "abc123",
            "name": "Apple App Store Connect",
            "appconnectIssuer": "abc123" * 6,
            "appconnectKey": "abc123",
            "appconnectPrivateKey": "---- BEGIN PRIVATE KEY ---- ABC123...",
            "appName": "Sample Application",
            "appId": "1234",
            "bundleId": "com.example.app",
        }

    def test_from_json_basic(self, data: json.JSONData, now: datetime) -> None:
        config = appconnect.AppStoreConnectConfig.from_json(data)
        assert config.type == "appStoreConnect"
        assert config.id == data["id"]
        assert config.name == data["name"]
        assert config.appconnectIssuer == data["appconnectIssuer"]
        assert config.appconnectPrivateKey == data["appconnectPrivateKey"]
        assert config.appName == data["appName"]
        assert config.bundleId == data["bundleId"]

    def test_to_json(self, data: json.JSONData, now: datetime) -> None:
        config = appconnect.AppStoreConnectConfig.from_json(data)
        new_data = config.to_json()

        assert new_data == data

    def test_to_redacted_json(self, data: json.JSONData, now: datetime) -> None:
        config = appconnect.AppStoreConnectConfig.from_json(data)
        new_data = config.to_redacted_json()

        # Redacted secrets
        data["appconnectPrivateKey"] = {"hidden-secret": True}

        assert new_data == data

    @django_db_all
    def test_from_project_config_empty_sources(
        self, default_project: "Project", data: json.JSONData
    ) -> None:
        with pytest.raises(KeyError):
            appconnect.AppStoreConnectConfig.from_project_config(default_project, "not-an-id")


class TestAppStoreConnectConfigUpdateProjectSymbolSource:
    @pytest.fixture
    def config(self) -> appconnect.AppStoreConnectConfig:
        return appconnect.AppStoreConnectConfig(
            type="appStoreConnect",
            id=uuid.uuid4().hex,
            name="Apple App Store Connect",
            appconnectIssuer="abc123" * 6,
            appconnectKey="abc123key",
            appconnectPrivateKey="----BEGIN PRIVATE KEY---- blabla",
            appName="My App",
            appId="123",
            bundleId="com.example.app",
        )

    @django_db_all
    def test_new_source(
        self, default_project: "Project", config: appconnect.AppStoreConnectConfig
    ) -> None:
        sources = config.update_project_symbol_source(default_project, allow_multiple=False)

        cfg = appconnect.AppStoreConnectConfig.from_json(sources[0].copy())
        assert cfg == config

        raw = default_project.get_option(appconnect.SYMBOL_SOURCES_PROP_NAME, default="[]")
        stored_sources = json.loads(raw)
        assert stored_sources == sources

    @django_db_all
    def test_new_sources_with_existing(
        self, default_project: "Project", config: appconnect.AppStoreConnectConfig
    ) -> None:
        old_sources = json.dumps(
            [{"type": "not-this-one", "id": "a"}, {"type": "not-this-one", "id": "b"}]
        )
        default_project.update_option(appconnect.SYMBOL_SOURCES_PROP_NAME, old_sources)

        sources = config.update_project_symbol_source(default_project, allow_multiple=False)

        cfg = appconnect.AppStoreConnectConfig.from_project_config(default_project, config.id)
        assert cfg == config

        raw = default_project.get_option(appconnect.SYMBOL_SOURCES_PROP_NAME, default="[]")
        stored_sources = json.loads(raw)
        assert stored_sources == sources

        new_sources = json.loads(old_sources)
        new_sources.append(cfg.to_json())
        assert stored_sources == new_sources

    @django_db_all
    def test_update(
        self, default_project: "Project", config: appconnect.AppStoreConnectConfig
    ) -> None:
        config.update_project_symbol_source(default_project, allow_multiple=False)

        updated = appconnect.AppStoreConnectConfig(
            type=config.type,
            id=config.id,
            name=config.name,
            appconnectIssuer=config.appconnectIssuer,
            appconnectKey=config.appconnectKey,
            appconnectPrivateKey="A NEW KEY",
            appName=config.appName,
            appId=config.appId,
            bundleId=config.bundleId,
        )

        updated.update_project_symbol_source(default_project, allow_multiple=False)

        current = appconnect.AppStoreConnectConfig.from_project_config(default_project, config.id)
        assert current.appconnectPrivateKey == "A NEW KEY"

    @django_db_all
    def test_update_no_matching_id(
        self, default_project: "Project", config: appconnect.AppStoreConnectConfig
    ) -> None:
        config.update_project_symbol_source(default_project, allow_multiple=False)

        updated = appconnect.AppStoreConnectConfig(
            type=config.type,
            id=uuid.uuid4().hex,
            name=config.name,
            appconnectIssuer=config.appconnectIssuer,
            appconnectKey=config.appconnectKey,
            appconnectPrivateKey="A NEW KEY",
            appName=config.appName,
            appId=config.appId,
            bundleId=config.bundleId,
        )

        with pytest.raises(ValueError):
            updated.update_project_symbol_source(default_project, allow_multiple=False)


class TestDownloadDsyms:
    @pytest.fixture
    def client(self) -> appconnect.AppConnectClient:
        return appconnect.AppConnectClient(
            app_id="honk",
            api_credentials=appstore_connect.AppConnectCredentials(
                key_id="beep",
                key="honkbeep",
                issuer_id="beeper",
            ),
        )

    def build_with_url(self, url: str | appconnect.NoDsymUrl) -> appconnect.BuildInfo:
        return appconnect.BuildInfo(
            app_id="honk",
            platform="macOS",
            version="3.1.0",
            build_number="20101010",
            uploaded_date=timezone.now(),
            dsym_url=url,
        )

    def test_empty_string_url(
        self, client: appconnect.AppConnectClient, tmp_path: pathlib.Path
    ) -> None:
        build_info = self.build_with_url("")

        with mock.patch(
            "sentry.utils.appleconnect.appstore_connect.download_dsyms"
        ) as mock_api_download_dsyms:
            client.download_dsyms(build_info, tmp_path / "dsyms.zip")

            assert mock_api_download_dsyms.call_count == 1

    def test_no_dsyms(self, client: appconnect.AppConnectClient, tmp_path: pathlib.Path) -> None:
        build_info = self.build_with_url(appconnect.NoDsymUrl.NOT_NEEDED)

        with mock.patch(
            "sentry.utils.appleconnect.appstore_connect.download_dsyms"
        ) as mock_api_download_dsyms:
            with pytest.raises(appconnect.NoDsymsError):
                client.download_dsyms(build_info, tmp_path / "dsyms.zip")

            assert mock_api_download_dsyms.call_count == 0

    def test_no_unfetched(
        self, client: appconnect.AppConnectClient, tmp_path: pathlib.Path
    ) -> None:
        build_info = self.build_with_url(appconnect.NoDsymUrl.PENDING)

        with mock.patch(
            "sentry.utils.appleconnect.appstore_connect.download_dsyms"
        ) as mock_api_download_dsyms:
            with pytest.raises(appconnect.PendingDsymsError):
                client.download_dsyms(build_info, tmp_path / "dsyms.zip")

            assert mock_api_download_dsyms.call_count == 0

    def test_valid_url(self, client: appconnect.AppConnectClient, tmp_path: pathlib.Path) -> None:
        build_info = self.build_with_url(
            "http://iosapps.itunes.apple.com/itunes-assets/very-real-url"
        )

        with mock.patch(
            "sentry.utils.appleconnect.appstore_connect.download_dsyms"
        ) as mock_api_download_dsyms:
            client.download_dsyms(build_info, tmp_path / "dsyms.zip")

            assert mock_api_download_dsyms.call_count == 1