Files
skills/public/collaboration-github-pull-requests.html
zeekayandHanzo Dev 9e10c1c10e Each llms index points at the other two
hanzoskills.com/llms.txt now opens with the install line, the API
reference index and the company index, so an agent that lands on any
one of the three can find the rest.

robots.txt claimed 537 documents while llms.txt counts 920. The number
is gone from robots.txt; llms.txt derives it.

public/ is regenerated from scripts/site.py, which it had fallen
behind: the copy-prompt menu and agent bar were in the generator and
not in the committed pages. tests/site.mjs passes against the result.

Co-authored-by: Hanzo Dev <[email protected]>
2026-09-11 00:27:59 -07:00

636 lines
29 KiB
HTML

<!doctype html>
<html lang="en"><head>
<meta charset="utf-8"><meta name="viewport" content="width=device-width,initial-scale=1">
<title>collaboration-github-pull-requests</title>
<meta name="color-scheme" content="dark">
<style>
/* Committed to one visual world: a dark instrument panel. No light variant —
the dot field and the hairline rules only read on black, and a naive
inversion would wash both out. Every colour is painted explicitly so the page
never borrows a host background. */
@font-face{font-family:'Zen';src:url('/fonts/Zen-Variable.woff2') format('woff2');font-weight:100 900;font-style:normal;font-display:swap}
@font-face{font-family:'Zen';src:url('/fonts/Zen-Italic-Variable.woff2') format('woff2');font-weight:100 900;font-style:italic;font-display:swap}
@font-face{font-family:'Zen Mono';src:url('/fonts/ZenMono-Variable.woff2') format('woff2');font-weight:100 900;font-style:normal;font-display:swap}
@font-face{font-family:'Zen Mono';src:url('/fonts/ZenMono-Italic-Variable.woff2') format('woff2');font-weight:100 900;font-style:italic;font-display:swap}
@font-face{font-family:'Zen Pixel Square';src:url('/fonts/ZenPixel-Square.woff2') format('woff2');font-style:normal;font-display:swap}
:root{
--ink:#f4f4f2; --soft:#9c9c98; --faint:#6a6a66; --ground:#000; --panel:#0a0a0a;
--line:#232323; --line-hi:#3a3a3a; --accent:#f4f4f2;
--font-zen-sans:'Zen',-apple-system,BlinkMacSystemFont,"Segoe UI",Helvetica,Arial,sans-serif;
--font-zen-mono:'Zen Mono',ui-monospace,"SF Mono",SFMono-Regular,Menlo,Consolas,monospace;
--font-zen-pixel-square:'Zen Pixel Square',monospace;
--mono:var(--font-zen-mono);
--sans:var(--font-zen-sans);
/* Controls are pills and surfaces are soft, as on hanzo.ai. */
--r:999px; --r-soft:14px;
}
*{box-sizing:border-box}
html{-webkit-text-size-adjust:100%}
body{margin:0;background:var(--ground);color:var(--ink);font-family:var(--sans);
font-size:16px;line-height:1.65;-webkit-font-smoothing:antialiased}
.wrap{max-width:60rem;margin:0 auto;padding:0 1.75rem}
/* The dot field. A halftone made of one repeating radial-gradient, faded out
along the diagonal by a mask so it reads as a wave rather than wallpaper. */
/* No overflow clip here: the dot field is inset to the box already, and a clip
would cut off the copy-prompt menu. */
.hero{position:relative;border-bottom:1px solid var(--line)}
.hero::before{content:"";position:absolute;inset:0;
background-image:radial-gradient(var(--line-hi) 1px, transparent 1px);
background-size:7px 7px;
-webkit-mask-image:linear-gradient(115deg,#000 0%,rgba(0,0,0,.55) 38%,transparent 72%);
mask-image:linear-gradient(115deg,#000 0%,rgba(0,0,0,.55) 38%,transparent 72%);
pointer-events:none}
.hero .wrap{position:relative;padding-top:5.5rem;padding-bottom:4rem}
nav{border-bottom:1px solid var(--line)}
nav .in{max-width:60rem;margin:0 auto;padding:1.1rem 1.75rem;display:flex;
justify-content:space-between;align-items:center;gap:1rem}
.brand{font-family:var(--mono);font-size:.85rem;letter-spacing:.14em;
text-transform:uppercase;color:var(--ink);text-decoration:none;
display:inline-flex;align-items:center;gap:.6rem}
.brand i{font-style:normal;color:var(--faint)}
.mark{width:1.15em;height:1.15em;display:block;flex:0 0 auto}
nav a.up{font-family:var(--mono);font-size:.72rem;letter-spacing:.14em;
text-transform:uppercase;color:var(--soft);text-decoration:none}
nav a.up:hover{color:var(--ink)}
h1{font-family:var(--mono);font-size:clamp(2rem,5.4vw,3.4rem);line-height:1.12;
letter-spacing:-.02em;margin:0 0 1.1rem;font-weight:500;text-wrap:balance}
h1 em{font-style:normal;color:var(--faint)}
.lede{color:var(--soft);font-size:1.05rem;max-width:52ch;margin:0 0 2.25rem}
.btns{display:flex;flex-wrap:wrap;gap:.7rem;margin:0 0 .5rem;align-items:center}
.btn{display:inline-flex;align-items:center;gap:.5rem;font-family:var(--mono);
font-size:.72rem;letter-spacing:.14em;text-transform:uppercase;
padding:.8rem 1.4rem;border:1px solid var(--line-hi);border-radius:var(--r);
color:var(--ink);text-decoration:none;background:transparent;cursor:pointer;
line-height:1.2;font-weight:400}
.btn:hover{background:#141414;text-decoration:none;border-color:var(--soft)}
.btn.solid{background:var(--ink);color:#000;border-color:var(--ink)}
.btn.solid:hover{background:#d8d8d4}
.btn .chev{width:.7em;height:.7em;flex:0 0 auto;transition:transform .15s ease}
.btn[aria-expanded="true"] .chev{transform:rotate(180deg)}
/* Copy-prompt selector. Each row copies the prompt for its own target. */
.copy{position:relative;display:inline-flex}
.menu{position:absolute;top:calc(100% + .5rem);left:0;z-index:20;min-width:21rem;
background:var(--panel);border:1px solid var(--line-hi);border-radius:var(--r-soft);
padding:.4rem;display:flex;flex-direction:column;
box-shadow:0 12px 32px rgba(0,0,0,.75)}
.menu[hidden]{display:none}
.mi{display:flex;align-items:center;gap:.7rem;width:100%;text-align:left;
padding:.62rem .8rem;border:0;border-radius:calc(var(--r-soft) - .35rem);
background:transparent;color:var(--ink);font-family:var(--mono);font-size:.76rem;
letter-spacing:.04em;text-decoration:none;cursor:pointer;line-height:1.3;
white-space:nowrap}
.mi:hover,.mi:focus-visible{background:#181818;outline:none}
.mi .mark{width:1.05rem;height:1.05rem;color:var(--soft)}
.mi:hover .mark{color:var(--ink)}
.mi u{margin-left:auto;color:var(--faint);text-decoration:none;font-size:.68rem;
letter-spacing:.1em;text-transform:uppercase}
/* Works-with bar: one scrolling row, name and mark per agent. */
.strip{border-bottom:1px solid var(--line);background:var(--panel)}
.strip .in{max-width:60rem;margin:0 auto;padding:.9rem 1.75rem;display:flex;
align-items:center;gap:1.25rem;font-family:var(--mono);font-size:.72rem;
letter-spacing:.1em;text-transform:uppercase;color:var(--faint)}
.strip b{color:var(--soft);font-weight:400;flex:0 0 auto;
border-right:1px solid var(--line);padding-right:1.25rem;align-self:stretch;
display:flex;align-items:center}
.bar{display:flex;align-items:center;gap:.5rem;flex:1 1 auto;min-width:0;
overflow-x:auto;scrollbar-width:none;scroll-snap-type:x proximity;
-webkit-overflow-scrolling:touch;
-webkit-mask-image:linear-gradient(90deg,#000 calc(100% - 3rem),transparent);
mask-image:linear-gradient(90deg,#000 calc(100% - 3rem),transparent)}
.bar::-webkit-scrollbar{display:none}
.agent{display:inline-flex;align-items:center;gap:.45rem;flex:0 0 auto;
padding:.4rem .85rem;border:1px solid var(--line);border-radius:var(--r);
color:var(--soft);white-space:nowrap;scroll-snap-align:start;
text-decoration:none;background:var(--ground)}
.agent:hover{color:var(--ink);border-color:var(--line-hi);text-decoration:none}
.agent .mark{width:.95rem;height:.95rem}
h2{font-family:var(--mono);font-size:1.1rem;letter-spacing:-.01em;margin:2.75rem 0 .75rem;font-weight:500}
h3{font-size:1rem;margin:2rem 0 .5rem;font-weight:600}
h4,h5,h6{font-size:.94rem;margin:1.5rem 0 .5rem;font-weight:600}
p{margin:0 0 1rem;max-width:70ch}
ul,ol{margin:0 0 1rem;padding-left:1.35rem;max-width:70ch}
li{margin:.22rem 0}
a{color:var(--ink);text-decoration:underline;text-underline-offset:3px;
text-decoration-color:var(--line-hi)}
a:hover{text-decoration-color:var(--ink)}
a:focus-visible{outline:1px solid var(--ink);outline-offset:3px}
code{font-family:var(--mono);font-size:.85em;background:var(--panel);
border:1px solid var(--line);border-radius:5px;padding:.1em .36em}
pre{background:var(--panel);border:1px solid var(--line);padding:1rem 1.1rem;
border-radius:var(--r-soft);overflow-x:auto;margin:0 0 1.25rem}
pre code{background:none;border:0;padding:0;font-size:.82rem;line-height:1.7}
blockquote{margin:0 0 1rem;padding-left:1rem;border-left:1px solid var(--line-hi);color:var(--soft)}
hr{border:0;border-top:1px solid var(--line);margin:2.5rem 0}
table{border-collapse:collapse;width:100%;margin:0 0 1.25rem;font-size:.92rem;
display:block;overflow-x:auto}
th,td{border:1px solid var(--line);padding:.5rem .7rem;text-align:left}
.curl{display:block;background:var(--panel);border:1px solid var(--line);
border-radius:var(--r-soft);padding:.95rem 1.1rem;font-family:var(--mono);
font-size:.8rem;color:var(--soft);overflow-x:auto;margin:0 0 2.5rem;
white-space:pre;line-height:1.9}
.curl b{color:var(--ink);font-weight:400}
.curl i{font-style:normal;color:var(--faint)}
/* index */
#q{width:100%;padding:.85rem 1.2rem;font-family:var(--mono);font-size:.85rem;color:var(--ink);
background:var(--panel);border:1px solid var(--line);border-radius:var(--r);margin:0 0 .6rem}
#q::placeholder{color:var(--faint);text-transform:uppercase;letter-spacing:.1em;font-size:.72rem}
#q:focus{outline:none;border-color:var(--soft)}
#count{color:var(--faint);font-family:var(--mono);font-size:.72rem;letter-spacing:.1em;
text-transform:uppercase;margin:0 0 2rem}
.cat{margin:2.5rem 0 .5rem;font-family:var(--mono);font-size:.7rem;letter-spacing:.16em;
text-transform:uppercase;color:var(--faint);border-bottom:1px solid var(--line);
padding-bottom:.45rem}
.row{display:block;padding:.6rem .9rem;margin:0 -.9rem;border-bottom:1px solid var(--line);
border-radius:var(--r-soft);text-decoration:none}
.row:hover{background:#0a0a0a}
.nm{font-family:var(--mono);font-size:.84rem;color:var(--ink);display:block}
.ds{color:var(--soft);font-size:.9rem;display:block;margin-top:.12rem}
footer{margin-top:4rem;padding:2rem 0 4rem;border-top:1px solid var(--line);
color:var(--faint);font-size:.85rem}
footer a{color:var(--soft)}
.fmap{display:grid;gap:1.75rem;grid-template-columns:repeat(auto-fit,minmax(11rem,1fr));
margin:0 0 2rem;font-size:.85rem}
.fmap b{display:block;font-family:var(--mono);font-size:.68rem;letter-spacing:.16em;
text-transform:uppercase;color:var(--faint);font-weight:400;margin:0 0 .6rem;
border-bottom:1px solid var(--line);padding-bottom:.4rem}
.fmap a{display:inline-block;color:var(--ink);text-decoration:none;margin:.3rem .35rem 0 0}
.fmap a:hover{text-decoration:underline}
.fmap div{color:var(--faint);line-height:1.5}
.fend{border-top:1px solid var(--line);padding-top:1.25rem;font-size:.82rem}
@media (max-width:640px){
.hero .wrap{padding-top:3.25rem;padding-bottom:2.75rem}
.btns{gap:.5rem}
.btn{padding:.75rem 1.15rem;font-size:.68rem}
.copy,.copy .btn{width:100%;justify-content:center}
.menu{left:0;right:0;min-width:0}
.strip .in{flex-direction:column;align-items:flex-start;gap:.6rem;padding:.9rem 1.75rem}
.strip b{border-right:0;padding-right:0}
.bar{width:100%}
}
</style>
<link rel="alternate" type="text/markdown" href="/collaboration-github-pull-requests.md">
<link rel="icon" href="/favicon.svg">
<link rel="canonical" href="https://hanzoskills.com/collaboration-github-pull-requests">
</head>
<!-- Reading this with a machine? Every page here is also plain markdown.
This one: https://hanzoskills.com/collaboration-github-pull-requests.md
Index: https://hanzoskills.com/llms.txt
Corpus: https://hanzoskills.com/all.md
Append .md to any path for the markdown twin. -->
<body>
<nav><div class="in">
<a class="brand" href="/"><svg class="mark" viewBox="0 0 67 67" fill="currentColor" aria-hidden="true"><path d="M22.21 67V44.6369H0V67H22.21Z"/><path d="M66.7038 22.3184H22.2534L0.0878906 44.6367H44.4634L66.7038 22.3184Z"/><path d="M22.21 0H0V22.3184H22.21V0Z"/><path d="M66.7198 0H44.5098V22.3184H66.7198V0Z"/><path d="M66.7198 67V44.6369H44.5098V67H66.7198Z"/></svg> HANZO<i>SKILLS</i></a>
<a class="up" href="/">All skills</a>
</div></nav>
<div class="wrap">
<h1>collaboration-github-pull-requests</h1><p class="lede">Pull request workflow, code review, merge strategies, PR checks, and collaboration best practices</p><h1>GitHub Pull Requests</h1>
<p><strong>Scope</strong>: PR workflow, draft PRs, code review process, merge strategies, PR checks, auto-merge, PR templates, and collaboration best practices</p>
<p><strong>Lines</strong>: ~320</p>
<p><strong>Last Updated</strong>: 2025-10-25</p>
<p><strong>Format Version</strong>: 1.0 (Atomic)</p>
<hr>
<h2>When to Use This Skill</h2>
<p>Activate this skill when:</p>
<ul><li>Creating pull requests for code review</li><li>Reviewing code and providing feedback</li><li>Choosing merge strategies (merge commit, squash, rebase)</li><li>Setting up required status checks and CODEOWNERS</li><li>Configuring auto-merge and merge queues</li><li>Creating PR templates and conventions</li><li>Managing PR lifecycle from draft to merged</li><li>Responding to review feedback and resolving conversations</li></ul>
<hr>
<h2>Core Concepts</h2>
<h3>Pull Request Lifecycle</h3>
<pre><code>Feature Branch → Draft PR → Ready for Review → Reviews → Approved → Merged
↓ ↓ ↓ ↓
Comments Requested Changes Status
Changes Made Checks</code></pre>
<p><strong>States</strong>:</p>
<ul><li><strong>Draft</strong>: Work in progress, not ready for review</li><li><strong>Open</strong>: Ready for review, awaiting feedback</li><li><strong>Changes requested</strong>: Reviewer requested modifications</li><li><strong>Approved</strong>: Reviewer approved changes</li><li><strong>Merged</strong>: PR integrated into target branch</li><li><strong>Closed</strong>: PR rejected or abandoned</li></ul>
<h3>Code Review Process</h3>
<p><strong>Review types</strong>:</p>
<ul><li><strong>Comment</strong>: General feedback without approval</li><li><strong>Approve</strong>: Changes look good, ready to merge</li><li><strong>Request changes</strong>: Must address issues before merging</li></ul>
<p><strong>Review scope</strong>:</p>
<ul><li>Code correctness and logic</li><li>Test coverage</li><li>Performance implications</li><li>Security considerations</li><li>Code style and readability</li><li>Documentation completeness</li></ul>
<h3>Merge Strategies</h3>
<p><strong>Merge commit</strong> (preserves full history):</p>
<pre><code>feature-branch: A → B → C
↓
main: D → E → M (merge commit)</code></pre>
<p><strong>Squash merge</strong> (single commit):</p>
<pre><code>feature-branch: A → B → C
↓ squash
main: D → E → S (squashed commit)</code></pre>
<p><strong>Rebase merge</strong> (linear history):</p>
<pre><code>feature-branch: A → B → C
↓ rebase
main: D → E → A&#x27; → B&#x27; → C&#x27;</code></pre>
<hr>
<h2>Patterns</h2>
<h3>Creating Pull Requests with GitHub CLI</h3>
<pre><code class="lang-bash"># Create PR from current branch
gh pr create
# Create with title and body
gh pr create \
--title &quot;Add user authentication&quot; \
--body &quot;Implements JWT-based authentication&quot;
# Create from specific branch
gh pr create \
--base main \
--head feature/auth
# Create draft PR
gh pr create \
--draft \
--title &quot;WIP: Add authentication&quot;
# Create with template
gh pr create \
--fill # Use PR template
# Create and assign reviewers
gh pr create \
--reviewer user1,user2 \
--assignee @me
# Create with labels
gh pr create \
--label &quot;enhancement&quot; \
--label &quot;needs-review&quot;
# Create PR from issue
gh pr create \
--title &quot;Fix login bug&quot; \
--body &quot;Closes #123&quot;</code></pre>
<h3>Managing Pull Requests</h3>
<pre><code class="lang-bash"># List open PRs
gh pr list
# List PRs by state
gh pr list --state merged
gh pr list --state closed
# View PR details
gh pr view 42
# View PR in browser
gh pr view 42 --web
# Check PR status
gh pr status
# Checkout PR locally
gh pr checkout 42
# Update PR
gh pr edit 42 \
--title &quot;New title&quot; \
--add-reviewer user3
# Close PR
gh pr close 42
# Reopen PR
gh pr reopen 42</code></pre>
<h3>Code Review Workflow</h3>
<p><strong>Requesting reviews</strong>:</p>
<pre><code class="lang-bash"># Request review from users
gh pr edit 42 --add-reviewer user1,user2
# Request review from team
gh api repos/owner/repo/pulls/42/requested_reviewers \
--method POST \
--field team_reviewers[]=&quot;backend-team&quot;</code></pre>
<p><strong>Providing reviews</strong>:</p>
<pre><code class="lang-bash"># Approve PR
gh pr review 42 --approve
# Request changes
gh pr review 42 --request-changes \
--body &quot;Please add tests for edge cases&quot;
# Comment without approval
gh pr review 42 --comment \
--body &quot;Looks good overall, minor suggestions&quot;
# Review with inline comments (interactive)
gh pr review 42</code></pre>
<p><strong>Review best practices</strong>:</p>
<pre><code class="lang-markdown">## Good Review Comment
**Issue**: The error handling doesn&#x27;t cover network timeouts.
**Suggestion**: Add timeout handling:</code></pre>
<p>try: response = requests.get(url, timeout=30) except requests.Timeout: logger.error(f&quot;Timeout fetching {url}&quot;) raise</p>
<pre><code>
**Why**: Prevents hanging requests and improves debugging.</code></pre>
<p><strong>Bad review comment</strong>:</p>
<pre><code class="lang-markdown">This is wrong.</code></pre>
<p>(No context, no suggestion, not constructive)</p>
<h3>Merge Strategies</h3>
<p><strong>When to use each strategy</strong>:</p>
<p><strong>Merge commit</strong> - Use when:</p>
<ul><li>Preserving detailed commit history matters</li><li>Feature branch has meaningful commit messages</li><li>Need to track when feature was integrated</li><li>Multiple developers collaborated on branch</li></ul>
<pre><code class="lang-bash"># Merge with merge commit
gh pr merge 42 --merge
# Or via API
gh api repos/owner/repo/pulls/42/merge \
--method PUT \
--field merge_method=merge</code></pre>
<p><strong>Squash merge</strong> - Use when:</p>
<ul><li>Feature branch has messy commit history</li><li>Want clean main branch with one commit per feature</li><li>Commit messages like &quot;fix typo&quot;, &quot;wip&quot;, etc.</li><li>Small features or bug fixes</li></ul>
<pre><code class="lang-bash"># Squash and merge
gh pr merge 42 --squash
# Customize squash commit message
gh pr merge 42 --squash \
--subject &quot;Add user authentication&quot; \
--body &quot;Implements JWT-based auth with refresh tokens&quot;</code></pre>
<p><strong>Rebase merge</strong> - Use when:</p>
<ul><li>Want linear history without merge commits</li><li>Commits are well-crafted and meaningful</li><li>Project requires linear git history</li><li>Each commit is atomic and tested</li></ul>
<pre><code class="lang-bash"># Rebase and merge
gh pr merge 42 --rebase</code></pre>
<h3>Auto-Merge Configuration</h3>
<pre><code class="lang-bash"># Enable auto-merge when checks pass
gh pr merge 42 --auto --squash
# Auto-merge with merge commit
gh pr merge 42 --auto --merge
# Disable auto-merge
gh api repos/owner/repo/pulls/42 \
--method DELETE \
-f auto_merge=null</code></pre>
<p><strong>Auto-merge requirements</strong>:</p>
<ul><li>All required status checks pass</li><li>Required reviews approved</li><li>No conflicting changes</li><li>Branch is up to date (if required)</li></ul>
<h3>PR Checks and Status</h3>
<p><strong>Required checks</strong> (configure in branch protection):</p>
<pre><code class="lang-yaml"># Example: GitHub Actions workflow
name: PR Checks
on: pull_request
jobs:
lint:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- run: npm run lint
test:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- run: npm test
build:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- run: npm run build</code></pre>
<p><strong>Check PR status</strong>:</p>
<pre><code class="lang-bash"># View PR checks
gh pr checks 42
# Wait for checks to complete
gh pr checks 42 --watch
# View specific check logs
gh run view &lt;run-id&gt;</code></pre>
<h3>CODEOWNERS File</h3>
<p><strong>Configuration</strong> (.github/CODEOWNERS):</p>
<pre><code># Global owners
* @org/core-team
# Frontend code
/src/frontend/** @org/frontend-team
*.tsx @org/frontend-team
*.css @org/design-team
# Backend code
/src/backend/** @org/backend-team
/src/api/** @org/api-team
# Infrastructure
/infrastructure/** @org/devops-team
/.github/workflows/** @org/devops-team
# Documentation
/docs/** @org/docs-team
*.md @org/docs-team
# Specific files require multiple approvals
/SECURITY.md @org/security-team @org/core-team
/package.json @org/core-team</code></pre>
<p><strong>Benefits</strong>:</p>
<ul><li>Automatic reviewer assignment</li><li>Ensures domain experts review changes</li><li>Enforces required reviews for critical files</li><li>Distributes review workload</li></ul>
<h3>PR Templates</h3>
<p><strong>Basic PR template</strong> (.github/PULL_REQUEST_TEMPLATE.md):</p>
<pre><code class="lang-markdown">## Description
What does this PR do?
## Motivation and Context
Why is this change needed? What problem does it solve?
## Type of Change
- [ ] Bug fix (non-breaking change)
- [ ] New feature (non-breaking change)
- [ ] Breaking change (fix or feature that breaks existing functionality)
- [ ] Documentation update
- [ ] Performance improvement
- [ ] Code refactoring
## How Has This Been Tested?
- [ ] Unit tests
- [ ] Integration tests
- [ ] Manual testing
- [ ] Not applicable
## Checklist
- [ ] My code follows the project&#x27;s style guidelines
- [ ] I have performed a self-review of my code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [ ] My changes generate no new warnings or errors
- [ ] I have added tests that prove my fix is effective or that my feature works
- [ ] New and existing unit tests pass locally with my changes
- [ ] Any dependent changes have been merged and published
## Screenshots (if applicable)
&lt;!-- Add screenshots here --&gt;
## Related Issues
Closes #&lt;issue_number&gt;
Related to #&lt;issue_number&gt;</code></pre>
<p><strong>Multiple templates</strong> (.github/PULL_REQUEST_TEMPLATE/):</p>
<pre><code>.github/
└── PULL_REQUEST_TEMPLATE/
├── feature.md # For new features
├── bugfix.md # For bug fixes
└── hotfix.md # For urgent production fixes</code></pre>
<p><strong>Usage</strong>:</p>
<pre><code class="lang-bash"># Create PR with specific template
gh pr create --template feature.md</code></pre>
<hr>
<h2>Quick Reference</h2>
<h3>GitHub CLI PR Commands</h3>
<pre><code class="lang-bash"># Create and manage
gh pr create [flags] # Create pull request
gh pr list # List open PRs
gh pr view &lt;number&gt; # View PR details
gh pr checkout &lt;number&gt; # Check out PR locally
gh pr status # Show status of relevant PRs
# Review workflow
gh pr review &lt;number&gt; [flags] # Review PR (approve/comment/request changes)
gh pr checks &lt;number&gt; # Show PR status checks
gh pr diff &lt;number&gt; # View PR diff
# Merge and close
gh pr merge &lt;number&gt; [flags] # Merge PR (--merge/--squash/--rebase)
gh pr close &lt;number&gt; # Close PR
gh pr reopen &lt;number&gt; # Reopen closed PR
# Modifications
gh pr edit &lt;number&gt; [flags] # Edit PR (title, body, reviewers, etc.)
gh pr ready &lt;number&gt; # Mark draft PR as ready</code></pre>
<h3>Merge Strategy Decision Tree</h3>
<pre><code>Do commits have meaningful messages?
├─ Yes: Preserve them?
│ ├─ Yes: merge commit or rebase
│ └─ No: squash
└─ No: squash
Need to track when feature was merged?
├─ Yes: merge commit
└─ No: squash or rebase
Project requires linear history?
├─ Yes: rebase (or squash)
└─ No: any strategy works</code></pre>
<h3>Review Best Practices</h3>
<pre><code>✅ DO: Be specific about what needs to change
✅ DO: Provide code suggestions when possible
✅ DO: Explain why changes are needed
✅ DO: Acknowledge good code
✅ DO: Ask questions instead of demanding changes
✅ DO: Review within 24-48 hours
❌ DON&#x27;T: Use vague comments like &quot;this is wrong&quot;
❌ DON&#x27;T: Nitpick over minor style issues (use linters)
❌ DON&#x27;T: Block PRs for personal preferences
❌ DON&#x27;T: Approve without actually reviewing
❌ DON&#x27;T: Request changes without explanation</code></pre>
<hr>
<h2>Anti-Patterns</h2>
<h3>❌ Large, Monolithic PRs</h3>
<pre><code class="lang-bash"># WRONG: 50 files changed, 5000 lines added
# Touches frontend, backend, database, and infrastructure
# Impossible to review effectively</code></pre>
<p><strong>Problems</strong>:</p>
<ul><li>Difficult to review thoroughly</li><li>Higher chance of bugs slipping through</li><li>Long review cycles</li><li>Merge conflicts likely</li></ul>
<pre><code class="lang-bash"># CORRECT: Break into smaller PRs
# PR 1: Database schema changes
# PR 2: Backend API updates
# PR 3: Frontend integration
# PR 4: Documentation updates
# Each PR: 3-5 files, 200-400 lines</code></pre>
<p><strong>Guidelines</strong>:</p>
<ul><li>Keep PRs under 400 lines of code</li><li>One feature/fix per PR</li><li>Split large features into incremental PRs</li><li>Use feature flags for incomplete features</li></ul>
<h3>❌ No PR Description</h3>
<pre><code class="lang-markdown"># WRONG
Title: Update code
Description: (empty)</code></pre>
<p><strong>Problems</strong>:</p>
<ul><li>Reviewers don&#x27;t understand context</li><li>No record of why changes were made</li><li>Difficult to search git history later</li></ul>
<pre><code class="lang-markdown"># CORRECT
Title: Add rate limiting to API endpoints
Description:
Implements rate limiting to prevent API abuse.
- Adds Redis-based rate limiter
- Configurable limits per endpoint
- Returns 429 status when exceeded
- Includes tests for rate limit enforcement
Closes #456
Related to #123</code></pre>
<h3>❌ Ignoring Review Feedback</h3>
<pre><code class="lang-bash"># WRONG: Mark PR as ready without addressing comments
# Reviewer: &quot;Please add error handling&quot;
# Author: (ignores feedback and merges)</code></pre>
<p><strong>Problems</strong>:</p>
<ul><li>Disrespects reviewer&#x27;s time</li><li>Introduces known issues</li><li>Damages team collaboration</li><li>Defeats purpose of code review</li></ul>
<pre><code class="lang-bash"># CORRECT: Address all feedback
# 1. Make requested changes
# 2. Respond to comments
# 3. Request re-review
# 4. Wait for approval
# If you disagree:
# - Explain your reasoning
# - Discuss alternatives
# - Seek consensus
# - Don&#x27;t merge until resolved</code></pre>
<h3>❌ Force Pushing After Reviews</h3>
<pre><code class="lang-bash"># WRONG: Rewrite history after review started
git push --force origin feature/auth</code></pre>
<p><strong>Problems</strong>:</p>
<ul><li>Invalidates existing reviews</li><li>Reviewers lose context</li><li>Inline comments become orphaned</li><li>Difficult to see what changed</li></ul>
<pre><code class="lang-bash"># CORRECT: Add fixup commits during review
git commit -m &quot;Address review feedback: add tests&quot;
git push origin feature/auth
# Squash when merging (if using squash merge)
gh pr merge 42 --squash</code></pre>
<h3>❌ Merging Without Status Checks</h3>
<pre><code class="lang-bash"># WRONG: Override failing checks and merge
# Tests failing, linter errors, build broken
# Merge anyway because &quot;it works on my machine&quot;</code></pre>
<p><strong>Problems</strong>:</p>
<ul><li>Breaks main branch</li><li>Blocks other developers</li><li>Erodes confidence in CI/CD</li><li>Creates firefighting situations</li></ul>
<pre><code class="lang-bash"># CORRECT: Fix issues before merging
# 1. Ensure all status checks pass
# 2. Fix failing tests
# 3. Resolve linter errors
# 4. Update branch if behind main
# 5. Merge only when green
# Enable branch protection to prevent this
# Settings → Branches → Require status checks</code></pre>
<hr>
<h2>Related Skills</h2>
<ul><li><code>collaboration/github/github-repository-management.md</code> - Branch protection and CODEOWNERS setup</li><li><code>collaboration/github/github-actions-workflows.md</code> - CI/CD checks for PRs</li><li><code>collaboration/github/github-issues-projects.md</code> - Linking PRs to issues</li><li><code>version-control/git-branching-strategies.md</code> - Feature branch workflows</li><li><code>cicd/ci-testing-strategy.md</code> - Running tests in PR checks</li><li><code>code-review/effective-code-review.md</code> - Code review best practices</li></ul>
<hr>
<p><strong>Last Updated</strong>: 2025-10-25</p>
<p><strong>Format Version</strong>: 1.0 (Atomic)</p>
<footer>
<div class="fmap">
<div><b>Build</b>
<a href="https://hanzo.app">hanzo.app</a> app builder
<a href="https://hanzo.codes">hanzo.codes</a> code with an agent
<a href="https://hanzoskills.com">hanzoskills.com</a> what an agent reads</div>
<div><b>Run</b>
<a href="https://console.hanzo.ai">console.hanzo.ai</a> cloud console
<a href="https://api.hanzo.ai">api.hanzo.ai</a> the API</div>
<div><b>Account</b>
<a href="https://hanzo.id">hanzo.id</a> sign in
<a href="https://pay.hanzo.ai">pay.hanzo.ai</a> top up
<a href="https://billing.hanzo.ai">billing.hanzo.ai</a> invoices and usage</div>
<div><b>Company</b>
<a href="https://hanzo.ai">hanzo.ai</a> canonical
<a href="https://hanzo.ventures">hanzo.ventures</a> ventures</div>
</div>
<div class="fend"><a href="/collaboration-github-pull-requests.md">This page as plain text</a> · <a href="/llms.txt">Index for agents</a></div>
</footer>
</div></body></html>