Files
zeekayandHanzo Dev 55bb7bb42d e2e: a real Kafka client against the real store, in one process
test/e2e now spins hanzoai/pubsub/embed plus the broker in-process and
drives them with franz-go — no external kafka distribution, no external
NATS, one 'go test'. The old harness needed ~/kafka_2.13-3.9.0 binaries
and a hand-run server, so it proved nothing anywhere but one laptop.

Every 2026-07 outage regression is pinned: compression round-trips,
consume across sequence holes, poison messages skipped end-to-end, an
e18 committed offset accepted and read back, OFFSET_OUT_OF_RANGE
engaging the client's reset policy, group resume across a broker
restart, a 1.5MiB record, and two gateways over one store.

What the client's strictness flushed out, fixed here:
- OffsetFetch with a null topics array means 'everything the group has
  committed' — now enumerated from the KV bucket (both wire shapes).
- LeaveGroup (key 13) is handled and advertised; every client sends it
  on close and the unknown-key path panicked the connection goroutine.
- Serve with port 0 publishes the kernel-assigned port into Metadata/
  FindCoordinator and exposes Addr(); Shutdown is idempotent.

Co-authored-by: Hanzo Dev <[email protected]>
2026-07-30 06:33:39 -07:00

131 lines
3.6 KiB
Go

package pubsub
import (
"fmt"
"strconv"
"strings"
log "github.com/hanzoai/kafka/logging"
"github.com/nats-io/nats.go"
)
const offsetBucketName = "kafka-consumer-offsets"
// EnsureOffsetBucket creates the KV bucket for consumer group offsets if it doesn't exist
func (c *Client) EnsureOffsetBucket() error {
_, err := c.JS.KeyValue(offsetBucketName)
if err != nil {
_, err = c.JS.CreateKeyValue(&nats.KeyValueConfig{
Bucket: offsetBucketName,
Storage: nats.FileStorage,
})
if err != nil {
return fmt.Errorf("failed to create offset KV bucket: %w", err)
}
log.Info("Created KV bucket %s", offsetBucketName)
}
return nil
}
func offsetKey(group, topic string, partition uint32) string {
return fmt.Sprintf("%s.%s.%d", group, topic, partition)
}
// CommitOffset durably stores the committed offset for a consumer group.
// Any non-negative int64 is a valid offset: offsets are stamped from the
// partition's own log positions, which on Hanzo PubSub live in a sparse space
// that reaches e18. A magnitude ceiling ("reject absurdly large") once lived
// here and rejected every real commit — offsets are opaque, never plausible.
func (c *Client) CommitOffset(group, topic string, partition uint32, offset int64) error {
if offset < 0 {
return fmt.Errorf("negative offset: %d", offset)
}
kv, err := c.JS.KeyValue(offsetBucketName)
if err != nil {
return err
}
_, err = kv.PutString(offsetKey(group, topic, partition), strconv.FormatInt(offset, 10))
return err
}
// GetCommittedOffset returns the committed offset, or -1 if none.
func (c *Client) GetCommittedOffset(group, topic string, partition uint32) (int64, error) {
kv, err := c.JS.KeyValue(offsetBucketName)
if err != nil {
return -1, nil
}
entry, err := kv.Get(offsetKey(group, topic, partition))
if err != nil {
return -1, nil
}
offset, err := strconv.ParseInt(string(entry.Value()), 10, 64)
if err != nil || offset < 0 {
return -1, nil
}
return offset, nil
}
// CommittedOffsets returns every topic/partition the group has a committed
// offset for — the answer to an OffsetFetch with a null topics array ("all").
// Keys are "group.topic.partition"; with the group prefix fixed, the LAST dot
// splits topic from partition, so dotted topic names survive. (A group id that
// is itself a dot-prefix of another group's id would alias here; group ids in
// this fleet are service names and do not contain dots.)
func (c *Client) CommittedOffsets(group string) (map[string]map[uint32]int64, error) {
kv, err := c.JS.KeyValue(offsetBucketName)
if err != nil {
return nil, nil
}
keys, err := kv.Keys()
if err != nil {
return nil, nil // an empty bucket reports as an error; same answer
}
out := map[string]map[uint32]int64{}
prefix := group + "."
for _, key := range keys {
if !strings.HasPrefix(key, prefix) {
continue
}
rest := key[len(prefix):]
i := strings.LastIndex(rest, ".")
if i < 1 {
continue
}
part, perr := strconv.ParseUint(rest[i+1:], 10, 32)
if perr != nil {
continue
}
entry, gerr := kv.Get(key)
if gerr != nil {
continue
}
offset, perr2 := strconv.ParseInt(string(entry.Value()), 10, 64)
if perr2 != nil || offset < 0 {
continue
}
topic := rest[:i]
if out[topic] == nil {
out[topic] = map[uint32]int64{}
}
out[topic][uint32(part)] = offset
}
return out, nil
}
// PurgeAllOffsets deletes all committed offsets from the KV store
func (c *Client) PurgeAllOffsets() error {
kv, err := c.JS.KeyValue(offsetBucketName)
if err != nil {
return err
}
keys, err := kv.Keys()
if err != nil {
return err
}
for _, key := range keys {
log.Info("Purging offset key: %s", key)
_ = kv.Delete(key)
}
return nil
}