mirror of
https://github.com/hanzoai/studio-desktop.git
synced 2026-11-03 03:46:40 +00:00
3.8 KiB
3.8 KiB
Please update the version of ComfyUI to the latest:
- Reference this PR as an example. https://github.com/Comfy-Org/desktop/commit/7cba9c25b95b30050dfd6864088ca91493bfd00b
- Go to ComfyUI Github repo and see what the latest Github Release is
- If there is {a semver tag (prefixed with
v) without a release} OR {aprerelease} OR {a draft release} that is newer than the release marked aslatest, AND this new version is a either a single major, minor, or patch version increment on thelatestrelease, use that version instead of latest.
- If there is {a semver tag (prefixed with
- Read the
requirements.txtfile from that release - Update the ComfyUI version version in @package.json based on what is in the latest Github Release. If config.ComfyUI.optionalBranch is set in @package.json, change it to an empty string ("").
- Update the frontend version in @package.json (
frontendVersion) to the version specified inrequirements.txt - Update the versions in
scripts/core-requirements.patchto match those inrequirements.txtfrom the ComfyUI repo.- Context: The patch is used to removes the frontend package, as the desktop app includes it in the build process instead.
- Update
assets/requirements/windows_nvidia.compiledandassets/requirements/windows_cpu.compiled, andassets/requirements/macos.compiledaccordingly. You just need to update the comfycomfyui-frontend-package, comfyui-workflow-templates, comfyui-embedded-docs versions. - Please make a PR by checking out a new branch from main, adding a commit message and then use GH CLI to create a PR.
- Make the versions in the PR body as links to the relevant github releases
- Include only the PR body lines that were updated
- PR Title: Update ComfyUI core to v{VERSION}
- PR Body:
Updated versions
Component Version ComfyUI core COMFYUI_VERSION Frontend FRONTEND_VERSION Templates TEMPLATES_VERSION Embedded docs EMBEDDED_DOCS_VERSION
- Wait for all tests to pass, actively monitoring and checking the PR status periodically until tests complete, then squash-merge the PR (only if required, use the
--adminflag). - Switch to main branch and git pull
- Bump the version using
npm versionwith the--no-git-tag-versionarg - Create a version bump PR with the title
vVERSIONe.g.v0.4.10. It must have theReleaselabel, and no content in the PR description. - Squash-merge the PR (only if required, use the
--adminflag) - do not wait for tests, as bumping package version will not cause test breakage. - Publish a GitHub Release:
- Set to pre-release (not latest)
- The tag should be
vVERSIONe.g.v0.4.10 - Use GitHub's generate release notes option
- Remove merged local branches
Commit messages
- IMPORTANT When writing commit messages, they should be clean and simple. Never add any reference to being created by Claude Code, or add yourself as a co-author, as this can lead to confusion.
General
- Prefer
ghcommands over fetching websites - Use named
ghcommands to perform actions, e.g.gh release list, rather thangh apicommands. This is much faster as named commands can be approved automatically. - Use subagents to verify details or investigate any particular questions you may have.
- For maximum efficiency, whenever you need to perform multiple independent operations, invoke all relevant tools simultaneously rather than sequentially.
- After receiving tool results, carefully reflect on their quality and determine optimal next steps before proceeding. Use your thinking to plan and iterate based on this new information, and then take the best next action.