mirror of
https://github.com/hanzoai/tasks.git
synced 2026-10-30 14:56:19 +00:00
Chetan GowdaandRoey Berman
8305168145
## What changed? Migrating all the event definition's `Apply()` method from HSM to CHASM. Also migrated unit tests. ## Why? HSM to CHASM migration ## How did you test it? - [x] built - [ ] run locally and tested manually - [x] covered by existing tests - [ ] added new unit test(s) - [ ] added new functional test(s) --- > [!NOTE] > **Medium Risk** > Changes Nexus operation lifecycle handling by moving scheduling/cancellation and terminal event application into CHASM event definitions and adjusting state transition semantics; regressions could affect operation task emission, cancellation timing, and cleanup during replay/reset. > > **Overview** > Implements CHASM-based Nexus operation event `Apply()` handlers: scheduled/cancel-requested/started now create or update the in-memory operation component (including spawning/scheduling a cancellation child once an operation token exists), and terminal events (completed/failed/canceled/timed-out) transition the operation then remove it from the workflow. > > Refactors workflow Nexus operation storage to be keyed by `ScheduledEventId` (`int64`), simplifies command handlers to only emit history events (letting event definitions create/update components), and expands cancellation/operation state machines with concrete task emission and retry/backoff metadata. Updates `chasm.Transition.Apply` to run transition logic before mutating state (enabling source-state inspection) and adds new CHASM-focused unit tests for the migrated event definitions and updated transition behavior. > > <sup>Written by [Cursor Bugbot]() for commit c0f4e5599acbd62b887f1a4059d3e4701b0206f9. This will update automatically on new commits. Configure [here]().</sup>
61 lines
2.3 KiB
Go
61 lines
2.3 KiB
Go
package chasm
|
|
|
|
import (
|
|
"fmt"
|
|
"slices"
|
|
|
|
"go.temporal.io/api/serviceerror"
|
|
)
|
|
|
|
// ErrInvalidTransition is returned from [Transition.Apply] on an invalid state transition.
|
|
var ErrInvalidTransition = serviceerror.NewFailedPrecondition("invalid transition")
|
|
|
|
// A StateMachine is anything that can get and set a comparable state S and re-generate tasks based on current state.
|
|
// It is meant to be used with [Transition] objects to safely transition their state on a given event.
|
|
type StateMachine[S comparable] interface {
|
|
StateMachineState() S
|
|
SetStateMachineState(S)
|
|
}
|
|
|
|
// Transition represents a state machine transition for a machine of type SM with state S and event E.
|
|
type Transition[S comparable, SM StateMachine[S], E any] struct {
|
|
// Source states that are valid for this transition.
|
|
Sources []S
|
|
// Destination state to transition to.
|
|
Destination S
|
|
// Function to apply the transition. Mutate the state machine object here and schedule tasks.
|
|
apply func(SM, MutableContext, E) error
|
|
}
|
|
|
|
// NewTransition creates a new [Transition] from the given source states to a destination state for a given event.
|
|
// The apply function is called after verifying the transition is possible but before setting the destination state,
|
|
// so it can inspect the current (source) state.
|
|
func NewTransition[S comparable, SM StateMachine[S], E any](src []S, dst S, apply func(SM, MutableContext, E) error) Transition[S, SM, E] {
|
|
return Transition[S, SM, E]{
|
|
Sources: src,
|
|
Destination: dst,
|
|
apply: apply,
|
|
}
|
|
}
|
|
|
|
// Possible returns a boolean indicating whether the transition is possible for the current state.
|
|
func (t Transition[S, SM, E]) Possible(sm SM) bool {
|
|
return slices.Contains(t.Sources, sm.StateMachineState())
|
|
}
|
|
|
|
// Apply applies a transition event to the given state machine changing the state machine's state to the transition's
|
|
// Destination on success. The apply function is called before the state is changed, so it can inspect the current
|
|
// (source) state.
|
|
func (t Transition[S, SM, E]) Apply(sm SM, ctx MutableContext, event E) error {
|
|
prevState := sm.StateMachineState()
|
|
if !t.Possible(sm) {
|
|
return fmt.Errorf("%w from %v", ErrInvalidTransition, prevState)
|
|
}
|
|
|
|
if err := t.apply(sm, ctx, event); err != nil {
|
|
return err
|
|
}
|
|
sm.SetStateMachineState(t.Destination)
|
|
return nil
|
|
}
|