mirror of
https://github.com/hanzoai/tasks.git
synced 2026-10-30 14:56:19 +00:00
## What changed? Add client-side of dynamic partition scaling: `partitionCache`, `PartitionCounts`, `StalePartitionCounts` error, `invokeWithPartitionCounts`. The intended behavior is: For partition-aware calls (add+poll tasks), the client caches the partition count for active task queues, and uses those partition counts for load balancing (no change to load balancing algorithm yet). The client sends its cached partition counts to the server in a grpc header, and receives updated partition counts with the response in a grpc trailer. If the updated counts are different, it updates its cache it for subsequent requests. If the server indicates that the client's view of partition count is stale, it returns a special `StalePartitionCounts` error and then client makes one immediate retry with the newly received counts. With just this PR by itself, the server will never send counts, the cache will always be empty, and the client will always fall back to dynamic config for partition counts, so there's no change in behavior yet. ## Why? Implement half of dynamic partition scaling. ## How did you test it? - [ ] built - [ ] run locally and tested manually - [ ] covered by existing tests - [x] added new unit test(s) - [x] added new functional test(s) – tests are in future PRs
231 lines
6.9 KiB
Go
231 lines
6.9 KiB
Go
package matching
|
|
|
|
import (
|
|
"math/rand"
|
|
"sync"
|
|
|
|
"go.temporal.io/server/common/dynamicconfig"
|
|
"go.temporal.io/server/common/namespace"
|
|
"go.temporal.io/server/common/testing/testhooks"
|
|
"go.temporal.io/server/common/tqid"
|
|
)
|
|
|
|
type (
|
|
// LoadBalancer is the interface for implementers of
|
|
// component that distributes add/poll api calls across
|
|
// available task queue partitions when possible
|
|
LoadBalancer interface {
|
|
// PickWritePartition returns the task queue partition for adding
|
|
// an activity or workflow task. The input is the name of the
|
|
// original task queue (with no partition info). When forwardedFrom
|
|
// is non-empty, this call is forwardedFrom from a child partition
|
|
// to a parent partition in which case, no load balancing should be
|
|
// performed
|
|
PickWritePartition(
|
|
taskQueue *tqid.TaskQueue,
|
|
pc PartitionCounts,
|
|
) *tqid.NormalPartition
|
|
|
|
// PickReadPartition returns the task queue partition to send a poller to.
|
|
// Input is name of the original task queue as specified by caller. When
|
|
// forwardedFrom is non-empty, no load balancing should be done.
|
|
PickReadPartition(
|
|
taskQueue *tqid.TaskQueue,
|
|
pc PartitionCounts,
|
|
) *pollToken
|
|
}
|
|
|
|
defaultLoadBalancer struct {
|
|
namespaceIDToName func(id namespace.ID) (namespace.Name, error)
|
|
nReadPartitions dynamicconfig.IntPropertyFnWithTaskQueueFilter
|
|
nWritePartitions dynamicconfig.IntPropertyFnWithTaskQueueFilter
|
|
testHooks testhooks.TestHooks
|
|
|
|
lock sync.RWMutex
|
|
taskQueueLBs map[tqid.TaskQueue]*tqLoadBalancer
|
|
}
|
|
|
|
// Keeps track of polls per partition. Sends a poll to the partition with the fewest polls
|
|
tqLoadBalancer struct {
|
|
taskQueue *tqid.TaskQueue
|
|
pollerCounts []int // keep track of poller count of each partition
|
|
lock sync.Mutex
|
|
}
|
|
|
|
pollToken struct {
|
|
TQPartition *tqid.NormalPartition
|
|
balancer *tqLoadBalancer
|
|
}
|
|
)
|
|
|
|
// NewLoadBalancer returns an instance of matching load balancer that
|
|
// can help distribute api calls across task queue partitions
|
|
func NewLoadBalancer(
|
|
namespaceIDToName func(id namespace.ID) (namespace.Name, error),
|
|
dc *dynamicconfig.Collection,
|
|
testHooks testhooks.TestHooks,
|
|
) LoadBalancer {
|
|
lb := &defaultLoadBalancer{
|
|
namespaceIDToName: namespaceIDToName,
|
|
nReadPartitions: dynamicconfig.MatchingNumTaskqueueReadPartitions.Get(dc),
|
|
nWritePartitions: dynamicconfig.MatchingNumTaskqueueWritePartitions.Get(dc),
|
|
testHooks: testHooks,
|
|
taskQueueLBs: make(map[tqid.TaskQueue]*tqLoadBalancer),
|
|
}
|
|
return lb
|
|
}
|
|
|
|
func (lb *defaultLoadBalancer) PickWritePartition(
|
|
taskQueue *tqid.TaskQueue,
|
|
pc PartitionCounts,
|
|
) *tqid.NormalPartition {
|
|
if n, ok := testhooks.Get(lb.testHooks, testhooks.MatchingLBForceWritePartition, namespace.ID(taskQueue.NamespaceId())); ok {
|
|
return taskQueue.NormalPartition(n)
|
|
}
|
|
|
|
nsName, err := lb.namespaceIDToName(namespace.ID(taskQueue.NamespaceId()))
|
|
if err != nil {
|
|
return taskQueue.RootPartition()
|
|
}
|
|
|
|
var partitionCount int
|
|
if pc.Write > 0 {
|
|
partitionCount = int(pc.Write)
|
|
} else {
|
|
partitionCount = max(1, lb.nWritePartitions(nsName.String(), taskQueue.Name(), taskQueue.TaskType()))
|
|
}
|
|
|
|
return taskQueue.NormalPartition(rand.Intn(partitionCount))
|
|
}
|
|
|
|
// PickReadPartition picks a partition for poller to poll task from, and keeps load balanced between partitions.
|
|
// Caller is responsible to call pollToken.Release() after complete the poll.
|
|
func (lb *defaultLoadBalancer) PickReadPartition(
|
|
taskQueue *tqid.TaskQueue,
|
|
pc PartitionCounts,
|
|
) *pollToken {
|
|
tqlb := lb.getTaskQueueLoadBalancer(taskQueue)
|
|
|
|
// For read path it's safer to return global default partition count instead of root partition, when we fail to
|
|
// map namespace ID to name.
|
|
var partitionCount = dynamicconfig.GlobalDefaultNumTaskQueuePartitions
|
|
|
|
if pc.Read > 0 {
|
|
partitionCount = int(pc.Read)
|
|
} else {
|
|
namespaceName, err := lb.namespaceIDToName(namespace.ID(taskQueue.NamespaceId()))
|
|
if err == nil {
|
|
partitionCount = lb.nReadPartitions(string(namespaceName), taskQueue.Name(), taskQueue.TaskType())
|
|
}
|
|
}
|
|
|
|
if n, ok := testhooks.Get(lb.testHooks, testhooks.MatchingLBForceReadPartition, namespace.ID(taskQueue.NamespaceId())); ok {
|
|
return tqlb.forceReadPartition(partitionCount, n)
|
|
}
|
|
|
|
return tqlb.pickReadPartition(partitionCount)
|
|
}
|
|
|
|
func (lb *defaultLoadBalancer) getTaskQueueLoadBalancer(tq *tqid.TaskQueue) *tqLoadBalancer {
|
|
lb.lock.RLock()
|
|
tqlb, ok := lb.taskQueueLBs[*tq]
|
|
lb.lock.RUnlock()
|
|
if ok {
|
|
return tqlb
|
|
}
|
|
|
|
lb.lock.Lock()
|
|
tqlb, ok = lb.taskQueueLBs[*tq]
|
|
if !ok {
|
|
tqlb = newTaskQueueLoadBalancer(tq)
|
|
lb.taskQueueLBs[*tq] = tqlb
|
|
}
|
|
lb.lock.Unlock()
|
|
return tqlb
|
|
}
|
|
|
|
func newTaskQueueLoadBalancer(tq *tqid.TaskQueue) *tqLoadBalancer {
|
|
return &tqLoadBalancer{
|
|
taskQueue: tq,
|
|
}
|
|
}
|
|
|
|
func (b *tqLoadBalancer) pickReadPartition(partitionCount int) *pollToken {
|
|
b.lock.Lock()
|
|
defer b.lock.Unlock()
|
|
|
|
b.ensurePartitionCountLocked(partitionCount)
|
|
partitionID := b.pickReadPartitionWithFewestPolls(partitionCount)
|
|
|
|
b.pollerCounts[partitionID]++
|
|
|
|
return &pollToken{
|
|
TQPartition: b.taskQueue.NormalPartition(partitionID),
|
|
balancer: b,
|
|
}
|
|
}
|
|
|
|
func (b *tqLoadBalancer) forceReadPartition(partitionCount, partitionID int) *pollToken {
|
|
b.lock.Lock()
|
|
defer b.lock.Unlock()
|
|
|
|
b.ensurePartitionCountLocked(max(partitionCount, partitionID+1))
|
|
|
|
b.pollerCounts[partitionID]++
|
|
|
|
return &pollToken{
|
|
TQPartition: b.taskQueue.NormalPartition(partitionID),
|
|
balancer: b,
|
|
}
|
|
}
|
|
|
|
// caller to ensure that lock is obtained before call this function
|
|
func (b *tqLoadBalancer) pickReadPartitionWithFewestPolls(partitionCount int) int {
|
|
// pick a random partition to start with
|
|
startPartitionID := rand.Intn(partitionCount)
|
|
pickedPartitionID := startPartitionID
|
|
minPollerCount := b.pollerCounts[pickedPartitionID]
|
|
for i := 1; i < partitionCount && minPollerCount > 0; i++ {
|
|
currPartitionID := (startPartitionID + i) % int(partitionCount)
|
|
if b.pollerCounts[currPartitionID] < minPollerCount {
|
|
pickedPartitionID = currPartitionID
|
|
minPollerCount = b.pollerCounts[currPartitionID]
|
|
}
|
|
}
|
|
|
|
return pickedPartitionID
|
|
}
|
|
|
|
// caller to ensure that lock is obtained before call this function
|
|
func (b *tqLoadBalancer) ensurePartitionCountLocked(partitionCount int) {
|
|
if len(b.pollerCounts) == partitionCount {
|
|
return
|
|
}
|
|
|
|
if len(b.pollerCounts) < partitionCount {
|
|
// add more partition entries
|
|
for i := len(b.pollerCounts); i < partitionCount; i++ {
|
|
b.pollerCounts = append(b.pollerCounts, 0)
|
|
}
|
|
} else {
|
|
// truncate existing partition entries
|
|
b.pollerCounts = b.pollerCounts[:partitionCount]
|
|
}
|
|
}
|
|
|
|
func (b *tqLoadBalancer) Release(partitionID int) {
|
|
b.lock.Lock()
|
|
defer b.lock.Unlock()
|
|
// partitionID could be out of range if dynamic config reduce taskQueue partition count
|
|
if len(b.pollerCounts) > partitionID && b.pollerCounts[partitionID] > 0 {
|
|
b.pollerCounts[partitionID]--
|
|
}
|
|
}
|
|
|
|
func (t *pollToken) Release() {
|
|
if t.balancer != nil {
|
|
// t.balancer == nil is valid for example sticky task queue.
|
|
t.balancer.Release(t.TQPartition.PartitionId())
|
|
}
|
|
}
|