Files
tasks/common/serviceerror/sticky_worker_unavailable.go
Yimin ChenandGitHub f4bc33d24f Fix 5s delay on sticky queue (#2811)
Sticky worker mark workflows as running on sticky queue. But when sticky worker
is gone (gracefully shutdown or forcefully killed), they don't notify server. 
When new workflow task or query is scheduled, server still dispatch them to the 
old sticky queue which now has no worker working on and will only result in 5s 
sticky queue's schedule_to_start timeout. No mater how long after the old 
sticky worker is gone, there is always that 5s delay. This PR fix that by 
checking if if there is no inflight poller for the sticky queue, and no poller 
is seem within 10s. In that case, matching would return a new 
StickyWorkerUnavailable error and history would retry that by using original 
task queue.
2022-05-06 20:13:24 -07:00

72 lines
2.2 KiB
Go

// The MIT License
//
// Copyright (c) 2020 Temporal Technologies Inc. All rights reserved.
//
// Copyright (c) 2020 Uber Technologies, Inc.
//
// Permission is hereby granted, free of charge, to any person obtaining a copy
// of this software and associated documentation files (the "Software"), to deal
// in the Software without restriction, including without limitation the rights
// to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
// copies of the Software, and to permit persons to whom the Software is
// furnished to do so, subject to the following conditions:
//
// The above copyright notice and this permission notice shall be included in
// all copies or substantial portions of the Software.
//
// THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
// IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
// FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
// AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
// LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
// OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
// THE SOFTWARE.
package serviceerror
import (
"github.com/gogo/status"
"google.golang.org/grpc/codes"
"go.temporal.io/server/api/errordetails/v1"
)
type (
// StickyWorkerUnavailable represents sticky worker unavailable error.
StickyWorkerUnavailable struct {
Message string
st *status.Status
}
)
// NewStickyWorkerUnavailable returns new StickyWorkerUnavailable error.
func NewStickyWorkerUnavailable() error {
return &StickyWorkerUnavailable{
Message: "sticky worker unavailable, please use original task queue.",
}
}
// Error returns string message.
func (e *StickyWorkerUnavailable) Error() string {
return e.Message
}
func (e *StickyWorkerUnavailable) Status() *status.Status {
if e.st != nil {
return e.st
}
st := status.New(codes.Unavailable, e.Message)
st, _ = st.WithDetails(
&errordetails.StickyWorkerUnavailableFailure{},
)
return st
}
func newStickyWorkerUnavailable(st *status.Status) error {
return &StickyWorkerUnavailable{
Message: st.Message(),
st: st,
}
}