Files
tasks/common/dynamicconfig/shared_constants.go
pdoernerandGitHub 68a1d21755 Dynamic rate limiter (#4390)
* moving window average

* remove channel avg impl

* add signal aggregator

* adjust record fn

* add health signal clients

* inject signal aggregator

* fix tests

* add metric emission

* add health request rate limiter

* WIP

* race condition

* WIP

* add health request rate limiter

* bench test rate limiter

* WIP

* Revert "race condition"

This reverts commit e283bfb3dca7228d715cd28235e436caafb34fa6.

* Revert "add metric emission"

This reverts commit 859950ee2965b5ac2144f46930e1308d95890e69.

* emit per shard RPS metric

* cleanup

* merge metric and signal clients

* cleanup

* cleanup

* linting

* global dynamic rate limiter

* cleanup

* remove generics

* WIP

* cleanup

* fix deferred metric fn

* fix defer metric fn

* fix clients

* types

* simple dynamic rate limiter test

* linting

* tests

* tests

* acquire lock once

* locks

* array moving average

* Revert "array moving average"

This reverts commit 98f2b66b9b7a711c427d5f55de82bc55d135ddfc.

* cleanup

* emit per shard RPS

* array average

* feedback

* cleanup

* handle nil health signals

* tests

* uncomment signal collection

* refactor dynamic config properties

* cleanup

* add aggregation feature flag

* fix test

* cleanup

* avoid potential race condition

* feedback

* fix

* remove test
2023-06-02 15:30:01 -07:00

81 lines
4.0 KiB
Go

// The MIT License
//
// Copyright (c) 2020 Temporal Technologies Inc. All rights reserved.
//
// Copyright (c) 2020 Uber Technologies, Inc.
//
// Permission is hereby granted, free of charge, to any person obtaining a copy
// of this software and associated documentation files (the "Software"), to deal
// in the Software without restriction, including without limitation the rights
// to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
// copies of the Software, and to permit persons to whom the Software is
// furnished to do so, subject to the following conditions:
//
// The above copyright notice and this permission notice shall be included in
// all copies or substantial portions of the Software.
//
// THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
// IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
// FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
// AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
// LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
// OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
// THE SOFTWARE.
package dynamicconfig
import "go.temporal.io/server/common/primitives"
var defaultNumTaskQueuePartitions = []ConstrainedValue{
// The per-ns worker task queue in all namespaces should only have one partition, since
// we'll only run one worker per task queue.
{
Constraints: Constraints{
TaskQueueName: primitives.PerNSWorkerTaskQueue,
},
Value: 1,
},
// TODO: After we have a solution for ensuring no tasks are lost, add a constraint here for
// all task queues in SystemLocalNamespace to have one partition.
// Default for everything else:
{
Value: 4,
},
}
var DefaultPerShardNamespaceRPSMax = GetIntPropertyFilteredByNamespace(0)
const (
// dynamic config map keys and defaults for client.DynamicRateLimitingParams for controlling dynamic rate limiting options
// dynamicRateLimitEnabledKey toggles whether dynamic rate limiting is enabled
dynamicRateLimitEnabledKey = "enabled"
dynamicRateLimitEnabledDefault = false
// dynamicRateLimitRefreshIntervalKey is how often the rate limit and dynamic properties are refreshed. should be a string timestamp e.g. 10s
// even if the rate limiter is disabled, this property will still determine how often the dynamic config is reevaluated
dynamicRateLimitRefreshIntervalKey = "refreshInterval"
dynamicRateLimitRefreshIntervalDefault = "10s"
// dynamicRateLimitLatencyThresholdKey is the maximum average latency in ms before the rate limiter should backoff
dynamicRateLimitLatencyThresholdKey = "latencyThreshold"
dynamicRateLimitLatencyThresholdDefault = 0.0 // will not do backoff based on latency
// dynamicRateLimitErrorThresholdKey is the maximum ratio of errors:total_requests before the rate limiter should backoff. should be between 0 and 1
dynamicRateLimitErrorThresholdKey = "errorThreshold"
dynamicRateLimitErrorThresholdDefault = 0.0 // will not do backoff based on errors
// dynamicRateLimitBackoffStepSizeKey is the amount the rate limit multiplier is reduced when backing off. should be between 0 and 1
dynamicRateLimitBackoffStepSizeKey = "rateBackoffStepSize"
dynamicRateLimitBackoffStepSizeDefault = 0.3
// dynamicRateLimitIncreaseStepSizeKey the amount the rate limit multiplier is increased when the system is healthy. should be between 0 and 1
dynamicRateLimitIncreaseStepSizeKey = "rateIncreaseStepSize"
dynamicRateLimitIncreaseStepSizeDefault = 0.1
)
var DefaultDynamicRateLimitingParams = map[string]interface{}{
dynamicRateLimitEnabledKey: dynamicRateLimitEnabledDefault,
dynamicRateLimitRefreshIntervalKey: dynamicRateLimitRefreshIntervalDefault,
dynamicRateLimitLatencyThresholdKey: dynamicRateLimitLatencyThresholdDefault,
dynamicRateLimitErrorThresholdKey: dynamicRateLimitErrorThresholdDefault,
dynamicRateLimitBackoffStepSizeKey: dynamicRateLimitBackoffStepSizeDefault,
dynamicRateLimitIncreaseStepSizeKey: dynamicRateLimitIncreaseStepSizeDefault,
}