Files
pdoernerandGitHub 68a1d21755 Dynamic rate limiter (#4390)
* moving window average

* remove channel avg impl

* add signal aggregator

* adjust record fn

* add health signal clients

* inject signal aggregator

* fix tests

* add metric emission

* add health request rate limiter

* WIP

* race condition

* WIP

* add health request rate limiter

* bench test rate limiter

* WIP

* Revert "race condition"

This reverts commit e283bfb3dca7228d715cd28235e436caafb34fa6.

* Revert "add metric emission"

This reverts commit 859950ee2965b5ac2144f46930e1308d95890e69.

* emit per shard RPS metric

* cleanup

* merge metric and signal clients

* cleanup

* cleanup

* linting

* global dynamic rate limiter

* cleanup

* remove generics

* WIP

* cleanup

* fix deferred metric fn

* fix defer metric fn

* fix clients

* types

* simple dynamic rate limiter test

* linting

* tests

* tests

* acquire lock once

* locks

* array moving average

* Revert "array moving average"

This reverts commit 98f2b66b9b7a711c427d5f55de82bc55d135ddfc.

* cleanup

* emit per shard RPS

* array average

* feedback

* cleanup

* handle nil health signals

* tests

* uncomment signal collection

* refactor dynamic config properties

* cleanup

* add aggregation feature flag

* fix test

* cleanup

* avoid potential race condition

* feedback

* fix

* remove test
2023-06-02 15:30:01 -07:00

239 lines
8.0 KiB
Go

// The MIT License
//
// Copyright (c) 2020 Temporal Technologies Inc. All rights reserved.
//
// Copyright (c) 2020 Uber Technologies, Inc.
//
// Permission is hereby granted, free of charge, to any person obtaining a copy
// of this software and associated documentation files (the "Software"), to deal
// in the Software without restriction, including without limitation the rights
// to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
// copies of the Software, and to permit persons to whom the Software is
// furnished to do so, subject to the following conditions:
//
// The above copyright notice and this permission notice shall be included in
// all copies or substantial portions of the Software.
//
// THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
// IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
// FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
// AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
// LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
// OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
// THE SOFTWARE.
package client
import (
"go.temporal.io/server/common/headers"
"go.temporal.io/server/common/log"
p "go.temporal.io/server/common/persistence"
"go.temporal.io/server/common/quotas"
"go.temporal.io/server/service/history/tasks"
)
type (
perShardPerNamespaceKey struct {
namespaceID string
shardID int32
}
)
var (
CallerTypeDefaultPriority = map[string]int{
headers.CallerTypeAPI: 1,
headers.CallerTypeBackground: 3,
headers.CallerTypePreemptable: 4,
}
APITypeCallOriginPriorityOverride = map[string]int{
"StartWorkflowExecution": 0,
"SignalWithStartWorkflowExecution": 0,
"SignalWorkflowExecution": 0,
"RequestCancelWorkflowExecution": 0,
"TerminateWorkflowExecution": 0,
"GetWorkflowExecutionHistory": 0,
"UpdateWorkflowExecution": 0,
}
BackgroundTypeAPIPriorityOverride = map[string]int{
"GetOrCreateShard": 0,
"UpdateShard": 0,
// This is a preprequisite for checkpointing queue process progress
p.ConstructHistoryTaskAPI("RangeCompleteHistoryTasks", tasks.CategoryTransfer): 0,
p.ConstructHistoryTaskAPI("RangeCompleteHistoryTasks", tasks.CategoryTimer): 0,
p.ConstructHistoryTaskAPI("RangeCompleteHistoryTasks", tasks.CategoryVisibility): 0,
// Task resource isolation assumes task can always be loaded.
// When one namespace has high load, all task processing goroutines
// may be busy and consumes all persistence request tokens, preventing
// tasks for other namespaces to be loaded. So give task loading a higher
// priority than other background requests.
// NOTE: we also don't want task loading to consume all persistence request tokens,
// and blocks all other operations. This is done by setting the queue host rps limit
// dynamic config.
p.ConstructHistoryTaskAPI("GetHistoryTasks", tasks.CategoryTransfer): 2,
p.ConstructHistoryTaskAPI("GetHistoryTasks", tasks.CategoryTimer): 2,
p.ConstructHistoryTaskAPI("GetHistoryTasks", tasks.CategoryVisibility): 2,
}
RequestPrioritiesOrdered = []int{0, 1, 2, 3, 4}
)
func NewPriorityRateLimiter(
namespaceMaxQPS PersistenceNamespaceMaxQps,
hostMaxQPS PersistenceMaxQps,
perShardNamespaceMaxQPS PersistencePerShardNamespaceMaxQPS,
requestPriorityFn quotas.RequestPriorityFn,
healthSignals p.HealthSignalAggregator,
dynamicParams DynamicRateLimitingParams,
logger log.Logger,
) quotas.RequestRateLimiter {
hostRateFn := func() float64 { return float64(hostMaxQPS()) }
return quotas.NewMultiRequestRateLimiter(
// per shardID+namespaceID rate limiters
newPerShardPerNamespacePriorityRateLimiter(perShardNamespaceMaxQPS, hostMaxQPS, requestPriorityFn),
// per namespaceID rate limiters
newPriorityNamespaceRateLimiter(namespaceMaxQPS, hostMaxQPS, requestPriorityFn),
// host-level dynamic rate limiter
newPriorityDynamicRateLimiter(hostRateFn, requestPriorityFn, healthSignals, dynamicParams, logger),
// basic host-level rate limiter
newPriorityRateLimiter(hostRateFn, requestPriorityFn),
)
}
func newPerShardPerNamespacePriorityRateLimiter(
perShardNamespaceMaxQPS PersistencePerShardNamespaceMaxQPS,
hostMaxQPS PersistenceMaxQps,
requestPriorityFn quotas.RequestPriorityFn,
) quotas.RequestRateLimiter {
return quotas.NewMapRequestRateLimiter(func(req quotas.Request) quotas.RequestRateLimiter {
if hasCaller(req) && hasCallerSegment(req) {
return newPriorityRateLimiter(func() float64 {
if perShardNamespaceMaxQPS == nil || perShardNamespaceMaxQPS(req.Caller) <= 0 {
return float64(hostMaxQPS())
}
return float64(perShardNamespaceMaxQPS(req.Caller))
},
requestPriorityFn,
)
}
return quotas.NoopRequestRateLimiter
},
perShardPerNamespaceKeyFn,
)
}
func perShardPerNamespaceKeyFn(req quotas.Request) perShardPerNamespaceKey {
return perShardPerNamespaceKey{
namespaceID: req.Caller,
shardID: req.CallerSegment,
}
}
func newPriorityNamespaceRateLimiter(
namespaceMaxQPS PersistenceNamespaceMaxQps,
hostMaxQPS PersistenceMaxQps,
requestPriorityFn quotas.RequestPriorityFn,
) quotas.RequestRateLimiter {
return quotas.NewNamespaceRequestRateLimiter(func(req quotas.Request) quotas.RequestRateLimiter {
if hasCaller(req) {
return newPriorityRateLimiter(
func() float64 {
if namespaceMaxQPS == nil {
return float64(hostMaxQPS())
}
namespaceQPS := float64(namespaceMaxQPS(req.Caller))
if namespaceQPS <= 0 {
return float64(hostMaxQPS())
}
return namespaceQPS
},
requestPriorityFn,
)
}
return quotas.NoopRequestRateLimiter
})
}
func newPriorityRateLimiter(
rateFn quotas.RateFn,
requestPriorityFn quotas.RequestPriorityFn,
) quotas.RequestRateLimiter {
rateLimiters := make(map[int]quotas.RequestRateLimiter)
for priority := range RequestPrioritiesOrdered {
rateLimiters[priority] = quotas.NewRequestRateLimiterAdapter(quotas.NewDefaultOutgoingRateLimiter(rateFn))
}
return quotas.NewPriorityRateLimiter(
requestPriorityFn,
rateLimiters,
)
}
func newPriorityDynamicRateLimiter(
rateFn quotas.RateFn,
requestPriorityFn quotas.RequestPriorityFn,
healthSignals p.HealthSignalAggregator,
dynamicParams DynamicRateLimitingParams,
logger log.Logger,
) quotas.RequestRateLimiter {
rateLimiters := make(map[int]quotas.RequestRateLimiter)
for priority := range RequestPrioritiesOrdered {
// TODO: refactor this so dynamic rate adjustment is global for all priorities
rateLimiters[priority] = NewHealthRequestRateLimiterImpl(healthSignals, rateFn, dynamicParams, logger)
}
return quotas.NewPriorityRateLimiter(
requestPriorityFn,
rateLimiters,
)
}
func NewNoopPriorityRateLimiter(
maxQPS PersistenceMaxQps,
) quotas.RequestRateLimiter {
priority := RequestPrioritiesOrdered[0]
return quotas.NewPriorityRateLimiter(
func(_ quotas.Request) int { return priority },
map[int]quotas.RequestRateLimiter{
priority: quotas.NewRequestRateLimiterAdapter(quotas.NewDefaultOutgoingRateLimiter(
func() float64 { return float64(maxQPS()) },
)),
},
)
}
func RequestPriorityFn(req quotas.Request) int {
switch req.CallerType {
case headers.CallerTypeAPI:
if priority, ok := APITypeCallOriginPriorityOverride[req.Initiation]; ok {
return priority
}
return CallerTypeDefaultPriority[req.CallerType]
case headers.CallerTypeBackground:
if priority, ok := BackgroundTypeAPIPriorityOverride[req.API]; ok {
return priority
}
return CallerTypeDefaultPriority[req.CallerType]
case headers.CallerTypePreemptable:
return CallerTypeDefaultPriority[req.CallerType]
default:
// default requests to high priority to be consistent with existing behavior
return RequestPrioritiesOrdered[0]
}
}
func hasCaller(req quotas.Request) bool {
return req.Caller != "" && req.Caller != headers.CallerNameSystem
}
func hasCallerSegment(req quotas.Request) bool {
return req.CallerSegment > 0 && req.CallerSegment != p.CallerSegmentMissing
}