Files
tasks/service/fx.go
pdoernerandGitHub 68a1d21755 Dynamic rate limiter (#4390)
* moving window average

* remove channel avg impl

* add signal aggregator

* adjust record fn

* add health signal clients

* inject signal aggregator

* fix tests

* add metric emission

* add health request rate limiter

* WIP

* race condition

* WIP

* add health request rate limiter

* bench test rate limiter

* WIP

* Revert "race condition"

This reverts commit e283bfb3dca7228d715cd28235e436caafb34fa6.

* Revert "add metric emission"

This reverts commit 859950ee2965b5ac2144f46930e1308d95890e69.

* emit per shard RPS metric

* cleanup

* merge metric and signal clients

* cleanup

* cleanup

* linting

* global dynamic rate limiter

* cleanup

* remove generics

* WIP

* cleanup

* fix deferred metric fn

* fix defer metric fn

* fix clients

* types

* simple dynamic rate limiter test

* linting

* tests

* tests

* acquire lock once

* locks

* array moving average

* Revert "array moving average"

This reverts commit 98f2b66b9b7a711c427d5f55de82bc55d135ddfc.

* cleanup

* emit per shard RPS

* array average

* feedback

* cleanup

* handle nil health signals

* tests

* uncomment signal collection

* refactor dynamic config properties

* cleanup

* add aggregation feature flag

* fix test

* cleanup

* avoid potential race condition

* feedback

* fix

* remove test
2023-06-02 15:30:01 -07:00

120 lines
4.7 KiB
Go

// The MIT License
//
// Copyright (c) 2020 Temporal Technologies Inc. All rights reserved.
//
// Copyright (c) 2020 Uber Technologies, Inc.
//
// Permission is hereby granted, free of charge, to any person obtaining a copy
// of this software and associated documentation files (the "Software"), to deal
// in the Software without restriction, including without limitation the rights
// to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
// copies of the Software, and to permit persons to whom the Software is
// furnished to do so, subject to the following conditions:
//
// The above copyright notice and this permission notice shall be included in
// all copies or substantial portions of the Software.
//
// THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
// IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
// FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
// AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
// LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
// OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
// THE SOFTWARE.
package service
import (
"go.uber.org/fx"
"google.golang.org/grpc"
"go.temporal.io/server/common"
"go.temporal.io/server/common/dynamicconfig"
"go.temporal.io/server/common/log"
"go.temporal.io/server/common/log/tag"
"go.temporal.io/server/common/metrics"
persistenceClient "go.temporal.io/server/common/persistence/client"
"go.temporal.io/server/common/rpc"
"go.temporal.io/server/common/rpc/interceptor"
"go.temporal.io/server/common/telemetry"
)
type (
PersistenceRateLimitingParams struct {
fx.Out
PersistenceMaxQps persistenceClient.PersistenceMaxQps
PersistenceNamespaceMaxQps persistenceClient.PersistenceNamespaceMaxQps
PersistencePerShardNamespaceMaxQPS persistenceClient.PersistencePerShardNamespaceMaxQPS
EnablePriorityRateLimiting persistenceClient.EnablePriorityRateLimiting
DynamicRateLimitingParams persistenceClient.DynamicRateLimitingParams
}
)
func NewPersistenceRateLimitingParams(
maxQps dynamicconfig.IntPropertyFn,
globalMaxQps dynamicconfig.IntPropertyFn,
namespaceMaxQps dynamicconfig.IntPropertyFnWithNamespaceFilter,
perShardNamespaceMaxQps dynamicconfig.IntPropertyFnWithNamespaceFilter,
enablePriorityRateLimiting dynamicconfig.BoolPropertyFn,
dynamicRateLimitingParams dynamicconfig.MapPropertyFn,
) PersistenceRateLimitingParams {
return PersistenceRateLimitingParams{
PersistenceMaxQps: PersistenceMaxQpsFn(maxQps, globalMaxQps),
PersistenceNamespaceMaxQps: persistenceClient.PersistenceNamespaceMaxQps(namespaceMaxQps),
PersistencePerShardNamespaceMaxQPS: persistenceClient.PersistencePerShardNamespaceMaxQPS(perShardNamespaceMaxQps),
EnablePriorityRateLimiting: persistenceClient.EnablePriorityRateLimiting(enablePriorityRateLimiting),
DynamicRateLimitingParams: persistenceClient.DynamicRateLimitingParams(dynamicRateLimitingParams),
}
}
func PersistenceMaxQpsFn(
maxQps dynamicconfig.IntPropertyFn,
globalMaxQps dynamicconfig.IntPropertyFn,
) persistenceClient.PersistenceMaxQps {
return func() int {
// if globalMaxQps() > 0 {
// // TODO: We have a bootstrap issue to correctly find memberCount. Membership relies on
// // persistence to bootstrap membership ring, so we cannot have persistence rely on membership
// // as it will cause circular dependency.
// // ringSize, err := membershipMonitor.GetMemberCount(serviceName)
// // if err == nil && ringSize > 0 {
// // avgQuota := common.MaxInt(globalMaxQps()/ringSize, 1)
// // return common.MinInt(avgQuota, maxQps())
// // }
// }
return maxQps()
}
}
func GrpcServerOptionsProvider(
logger log.Logger,
rpcFactory common.RPCFactory,
retryableInterceptor *interceptor.RetryableInterceptor,
telemetryInterceptor *interceptor.TelemetryInterceptor,
rateLimitInterceptor *interceptor.RateLimitInterceptor,
tracingInterceptor telemetry.ServerTraceInterceptor,
) []grpc.ServerOption {
grpcServerOptions, err := rpcFactory.GetInternodeGRPCServerOptions()
if err != nil {
logger.Fatal("creating gRPC server options failed", tag.Error(err))
}
return append(
grpcServerOptions,
grpc.ChainUnaryInterceptor(
rpc.ServiceErrorInterceptor,
grpc.UnaryServerInterceptor(tracingInterceptor),
metrics.NewServerMetricsContextInjectorInterceptor(),
metrics.NewServerMetricsTrailerPropagatorInterceptor(logger),
telemetryInterceptor.UnaryIntercept,
rateLimitInterceptor.Intercept,
retryableInterceptor.Intercept,
),
grpc.ChainStreamInterceptor(
telemetryInterceptor.StreamIntercept,
),
)
}