mirror of
https://github.com/hanzoai/tasks.git
synced 2026-11-03 03:56:04 +00:00
Alfred Landrumandrodrigozhou
f5e9a0c509
<!-- Describe what has changed in this PR --> **What changed?** Edit: I moved this from "draft" to real PR. This adds a shard context factory, which returns a `ControllableContext` that is the existing context interface plus the Pingable & FinishStop methods that the controller needs (but api request handling doesn't). The shard controller uses that to create contexts, instead of calling `newContext` directly. This does not update the shard controller tests. The tests in controller_test.go should eventually change to test behavior at the new interface boundary, and some of the existing tests ought to be moved, likely to context's tests. <!-- Tell your future self why have you made these changes --> **Why?** It simplifies the shard controller, and removes the duplicate logic used to create a controller between the provider and `NewTestController`. <!-- How have you verified this change? Tested locally? Added a unit test? Checked in staging env? --> **How did you test it?** Unit & CI. <!-- Assuming the worst case, what can be broken when deploying this change to production? --> **Potential risks** None. <!-- Is this PR a hotfix candidate or require that a notification be sent to the broader community? (Yes/No) --> **Is hotfix candidate?** No.
41 lines
1.5 KiB
Go
41 lines
1.5 KiB
Go
// The MIT License
|
|
//
|
|
// Copyright (c) 2020 Temporal Technologies Inc. All rights reserved.
|
|
//
|
|
// Copyright (c) 2020 Uber Technologies, Inc.
|
|
//
|
|
// Permission is hereby granted, free of charge, to any person obtaining a copy
|
|
// of this software and associated documentation files (the "Software"), to deal
|
|
// in the Software without restriction, including without limitation the rights
|
|
// to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
|
|
// copies of the Software, and to permit persons to whom the Software is
|
|
// furnished to do so, subject to the following conditions:
|
|
//
|
|
// The above copyright notice and this permission notice shall be included in
|
|
// all copies or substantial portions of the Software.
|
|
//
|
|
// THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
|
|
// IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
|
|
// FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
|
|
// AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
|
|
// LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
|
|
// OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
|
|
// THE SOFTWARE.
|
|
|
|
package shard
|
|
|
|
import (
|
|
"go.uber.org/fx"
|
|
|
|
"go.temporal.io/server/common"
|
|
)
|
|
|
|
var Module = fx.Options(
|
|
fx.Provide(ControllerProvider),
|
|
fx.Provide(ContextFactoryProvider),
|
|
fx.Provide(fx.Annotate(
|
|
func(p Controller) common.Pingable { return p },
|
|
fx.ResultTags(`group:"deadlockDetectorRoots"`),
|
|
)),
|
|
)
|