Files
tasks/service/matching/matchingEngine.go
Yimin ChenandYichao Yang 88efdf35f4 Validate workflow task start time when complete (#4663)
<!-- Describe what has changed in this PR -->
**What changed?**
Add start time to workflow task token and validate it on close.

<!-- Tell your future self why have you made these changes -->
**Why?**
To reject concurrent speculative workflow task with same startedEventID.

<!-- How have you verified this change? Tested locally? Added a unit
test? Checked in staging env? -->
**How did you test it?**
Integration tests.

<!-- Assuming the worst case, what can be broken when deploying this
change to production? -->
**Potential risks**
No

<!-- Is this PR a hotfix candidate or require that a notification be
sent to the broader community? (Yes/No) -->
**Is hotfix candidate?**
Yes
2023-07-21 12:22:34 -07:00

1600 lines
58 KiB
Go

// The MIT License
//
// Copyright (c) 2020 Temporal Technologies Inc. All rights reserved.
//
// Copyright (c) 2020 Uber Technologies, Inc.
//
// Permission is hereby granted, free of charge, to any person obtaining a copy
// of this software and associated documentation files (the "Software"), to deal
// in the Software without restriction, including without limitation the rights
// to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
// copies of the Software, and to permit persons to whom the Software is
// furnished to do so, subject to the following conditions:
//
// The above copyright notice and this permission notice shall be included in
// all copies or substantial portions of the Software.
//
// THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
// IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
// FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
// AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
// LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
// OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
// THE SOFTWARE.
package matching
import (
"bytes"
"context"
"errors"
"fmt"
"math"
"sync"
"sync/atomic"
"time"
"github.com/pborman/uuid"
commonpb "go.temporal.io/api/common/v1"
enumspb "go.temporal.io/api/enums/v1"
"go.temporal.io/api/serviceerror"
taskqueuepb "go.temporal.io/api/taskqueue/v1"
"go.temporal.io/api/workflowservice/v1"
"go.temporal.io/server/api/historyservice/v1"
"go.temporal.io/server/api/matchingservice/v1"
enumsspb "go.temporal.io/server/api/enums/v1"
persistencespb "go.temporal.io/server/api/persistence/v1"
replicationspb "go.temporal.io/server/api/replication/v1"
taskqueuespb "go.temporal.io/server/api/taskqueue/v1"
tokenspb "go.temporal.io/server/api/token/v1"
"go.temporal.io/server/common"
"go.temporal.io/server/common/clock"
hlc "go.temporal.io/server/common/clock/hybrid_logical_clock"
"go.temporal.io/server/common/cluster"
"go.temporal.io/server/common/log"
"go.temporal.io/server/common/log/tag"
"go.temporal.io/server/common/membership"
"go.temporal.io/server/common/metrics"
"go.temporal.io/server/common/namespace"
"go.temporal.io/server/common/persistence"
"go.temporal.io/server/common/persistence/visibility/manager"
"go.temporal.io/server/common/primitives/timestamp"
serviceerrors "go.temporal.io/server/common/serviceerror"
"go.temporal.io/server/common/worker_versioning"
)
const (
// If sticky poller is not seem in last 10s, we treat it as sticky worker unavailable
// This seems aggressive, but the default sticky schedule_to_start timeout is 5s, so 10s seems reasonable.
stickyPollerUnavailableWindow = 10 * time.Second
recordTaskStartedDefaultTimeout = 10 * time.Second
recordTaskStartedSyncMatchTimeout = 1 * time.Second
)
type (
pollerIDCtxKey string
identityCtxKey string
// lockableQueryTaskMap maps query TaskID (which is a UUID generated in QueryWorkflow() call) to a channel
// that QueryWorkflow() will block on. The channel is unblocked either by worker sending response through
// RespondQueryTaskCompleted() or through an internal service error causing temporal to be unable to dispatch
// query task to workflow worker.
lockableQueryTaskMap struct {
sync.RWMutex
queryTaskMap map[string]chan *queryResult
}
lockablePollMap struct {
sync.Mutex
polls map[string]context.CancelFunc
}
taskQueueCounterKey struct {
namespaceID namespace.ID
taskType enumspb.TaskQueueType
kind enumspb.TaskQueueKind
}
pollMetadata struct {
ratePerSecond *float64
workerVersionCapabilities *commonpb.WorkerVersionCapabilities
}
namespaceUpdateLocks struct {
updateLock sync.Mutex
replicationLock sync.Mutex
}
// Implements matching.Engine
matchingEngineImpl struct {
status int32
taskManager persistence.TaskManager
historyClient historyservice.HistoryServiceClient
matchingClient matchingservice.MatchingServiceClient
tokenSerializer common.TaskTokenSerializer
logger log.Logger
namespaceRegistry namespace.Registry
keyResolver membership.ServiceResolver
clusterMeta cluster.Metadata
timeSource clock.TimeSource
visibilityManager manager.VisibilityManager
metricsHandler metrics.Handler
taskQueuesLock sync.RWMutex // locks mutation of taskQueues
taskQueues map[taskQueueID]taskQueueManager
taskQueueCount map[taskQueueCounterKey]int // per-namespace task queue counter
config *Config
lockableQueryTaskMap lockableQueryTaskMap
// pollMap is needed to keep track of all outstanding pollers for a particular
// taskqueue. PollerID generated by frontend is used as the key and CancelFunc is the
// value. This is used to cancel the context to unblock any outstanding poller when
// the frontend detects client connection is closed to prevent tasks being dispatched
// to zombie pollers.
pollMap lockablePollMap
// Only set if global namespaces are enabled on the cluster.
namespaceReplicationQueue persistence.NamespaceReplicationQueue
// Disables concurrent task queue user data updates and replication requests (due to a cassandra limitation)
namespaceUpdateLockMap map[string]*namespaceUpdateLocks
// Serializes access to the per namespace lock map
namespaceUpdateLockMapLock sync.Mutex
}
)
var (
// EmptyPollWorkflowTaskQueueResponse is the response when there are no workflow tasks to hand out
emptyPollWorkflowTaskQueueResponse = &matchingservice.PollWorkflowTaskQueueResponse{}
// EmptyPollActivityTaskQueueResponse is the response when there are no activity tasks to hand out
emptyPollActivityTaskQueueResponse = &matchingservice.PollActivityTaskQueueResponse{}
// ErrNoTasks is exported temporarily for integration test
ErrNoTasks = errors.New("no tasks")
errPumpClosed = errors.New("task queue pump closed its channel")
pollerIDKey pollerIDCtxKey = "pollerID"
identityKey identityCtxKey = "identity"
)
var _ Engine = (*matchingEngineImpl)(nil) // Asserts that interface is indeed implemented
// NewEngine creates an instance of matching engine
func NewEngine(
taskManager persistence.TaskManager,
historyClient historyservice.HistoryServiceClient,
matchingClient matchingservice.MatchingServiceClient,
config *Config,
logger log.Logger,
metricsHandler metrics.Handler,
namespaceRegistry namespace.Registry,
resolver membership.ServiceResolver,
clusterMeta cluster.Metadata,
namespaceReplicationQueue persistence.NamespaceReplicationQueue,
visibilityManager manager.VisibilityManager,
) Engine {
return &matchingEngineImpl{
status: common.DaemonStatusInitialized,
taskManager: taskManager,
historyClient: historyClient,
matchingClient: matchingClient,
tokenSerializer: common.NewProtoTaskTokenSerializer(),
logger: log.With(logger, tag.ComponentMatchingEngine),
namespaceRegistry: namespaceRegistry,
keyResolver: resolver,
clusterMeta: clusterMeta,
timeSource: clock.NewRealTimeSource(), // No need to mock this at the moment
visibilityManager: visibilityManager,
metricsHandler: metricsHandler.WithTags(metrics.OperationTag(metrics.MatchingEngineScope)),
taskQueues: make(map[taskQueueID]taskQueueManager),
taskQueueCount: make(map[taskQueueCounterKey]int),
config: config,
lockableQueryTaskMap: lockableQueryTaskMap{queryTaskMap: make(map[string]chan *queryResult)},
pollMap: lockablePollMap{polls: make(map[string]context.CancelFunc)},
namespaceReplicationQueue: namespaceReplicationQueue,
namespaceUpdateLockMap: make(map[string]*namespaceUpdateLocks),
}
}
func (e *matchingEngineImpl) Start() {
if !atomic.CompareAndSwapInt32(
&e.status,
common.DaemonStatusInitialized,
common.DaemonStatusStarted,
) {
return
}
}
func (e *matchingEngineImpl) Stop() {
if !atomic.CompareAndSwapInt32(
&e.status,
common.DaemonStatusStarted,
common.DaemonStatusStopped,
) {
return
}
for _, l := range e.getTaskQueues(math.MaxInt32) {
l.Stop()
}
}
func (e *matchingEngineImpl) getTaskQueues(maxCount int) (lists []taskQueueManager) {
e.taskQueuesLock.RLock()
defer e.taskQueuesLock.RUnlock()
lists = make([]taskQueueManager, 0, len(e.taskQueues))
count := 0
for _, tlMgr := range e.taskQueues {
lists = append(lists, tlMgr)
count++
if count >= maxCount {
break
}
}
return
}
func (e *matchingEngineImpl) String() string {
// Executes taskQueue.String() on each task queue outside of lock
buf := new(bytes.Buffer)
for _, l := range e.getTaskQueues(1000) {
fmt.Fprintf(buf, "\n%s", l.String())
}
return buf.String()
}
// Returns taskQueueManager for a task queue. If not already cached, and create is true, tries
// to get new range from DB and create one. This blocks (up to the context deadline) for the
// task queue to be initialized.
//
// Note that stickyInfo is not used as part of the task queue identity. That means that if
// getTaskQueueManager is called twice with the same taskQueue but different stickyInfo, the
// properties of the taskQueueManager will depend on which call came first. In general we can
// rely on kind being the same for all calls now, but normalName was a later addition to the
// protocol and is not always set consistently. normalName is only required when using
// versioning, and SDKs that support versioning will always set it. The current server version
// will also set it when adding tasks from history. So that particular inconsistency is okay.
func (e *matchingEngineImpl) getTaskQueueManager(
ctx context.Context,
taskQueue *taskQueueID,
stickyInfo stickyInfo,
create bool,
) (taskQueueManager, error) {
e.taskQueuesLock.RLock()
tqm, ok := e.taskQueues[*taskQueue]
e.taskQueuesLock.RUnlock()
if !ok {
if !create {
return nil, nil
}
// If it gets here, write lock and check again in case a task queue is created between the two locks
e.taskQueuesLock.Lock()
if tqm, ok = e.taskQueues[*taskQueue]; !ok {
var err error
tqm, err = newTaskQueueManager(e, taskQueue, stickyInfo, e.config, e.clusterMeta)
if err != nil {
e.taskQueuesLock.Unlock()
return nil, err
}
tqm.Start()
e.taskQueues[*taskQueue] = tqm
countKey := taskQueueCounterKey{
namespaceID: taskQueue.namespaceID,
taskType: taskQueue.taskType,
kind: stickyInfo.kind,
}
e.taskQueueCount[countKey]++
taskQueueCount := e.taskQueueCount[countKey]
e.updateTaskQueueGauge(countKey, taskQueueCount)
}
e.taskQueuesLock.Unlock()
}
if err := tqm.WaitUntilInitialized(ctx); err != nil {
return nil, err
}
return tqm, nil
}
// For use in tests
func (e *matchingEngineImpl) updateTaskQueue(taskQueue *taskQueueID, mgr taskQueueManager) {
e.taskQueuesLock.Lock()
defer e.taskQueuesLock.Unlock()
e.taskQueues[*taskQueue] = mgr
}
// AddWorkflowTask either delivers task directly to waiting poller or save it into task queue persistence.
func (e *matchingEngineImpl) AddWorkflowTask(
ctx context.Context,
addRequest *matchingservice.AddWorkflowTaskRequest,
) (bool, error) {
namespaceID := namespace.ID(addRequest.GetNamespaceId())
taskQueueName := addRequest.TaskQueue.GetName()
stickyInfo := stickyInfoFromTaskQueue(addRequest.TaskQueue)
origTaskQueue, err := newTaskQueueID(namespaceID, taskQueueName, enumspb.TASK_QUEUE_TYPE_WORKFLOW)
if err != nil {
return false, err
}
// We don't need the userDataChanged channel here because:
// - if we sync match or sticky worker unavailable, we're done
// - if we spool to db, we'll re-resolve when it comes out of the db
taskQueue, _, err := e.redirectToVersionedQueueForAdd(ctx, origTaskQueue, addRequest.VersionDirective, stickyInfo)
if err != nil {
if errors.Is(err, errUserDataDisabled) {
// When user data loading is disabled, we intentionally drop tasks for versioned workflows
// to avoid breaking versioning semantics and dispatching tasks to the wrong workers.
err = nil
}
return false, err
}
sticky := stickyInfo.kind == enumspb.TASK_QUEUE_KIND_STICKY
// do not load sticky task queue if it is not already loaded, which means it has no poller.
tqm, err := e.getTaskQueueManager(ctx, taskQueue, stickyInfo, !sticky)
if err != nil {
return false, err
} else if sticky && (tqm == nil || !tqm.HasPollerAfter(time.Now().Add(-stickyPollerUnavailableWindow))) {
return false, serviceerrors.NewStickyWorkerUnavailable()
}
// This needs to move to history see - https://go.temporal.io/server/issues/181
var expirationTime *time.Time
now := timestamp.TimePtr(time.Now().UTC())
expirationDuration := timestamp.DurationValue(addRequest.GetScheduleToStartTimeout())
if expirationDuration == 0 {
// noop
} else {
expirationTime = timestamp.TimePtr(now.Add(expirationDuration))
}
taskInfo := &persistencespb.TaskInfo{
NamespaceId: namespaceID.String(),
RunId: addRequest.Execution.GetRunId(),
WorkflowId: addRequest.Execution.GetWorkflowId(),
ScheduledEventId: addRequest.GetScheduledEventId(),
Clock: addRequest.GetClock(),
ExpiryTime: expirationTime,
CreateTime: now,
VersionDirective: addRequest.VersionDirective,
}
baseTqm, err := e.getTaskQueueManager(ctx, origTaskQueue, stickyInfo, true)
if err != nil {
return false, err
}
return tqm.AddTask(ctx, addTaskParams{
execution: addRequest.Execution,
taskInfo: taskInfo,
source: addRequest.GetSource(),
forwardedFrom: addRequest.GetForwardedSource(),
baseTqm: baseTqm,
})
}
// AddActivityTask either delivers task directly to waiting poller or save it into task queue persistence.
func (e *matchingEngineImpl) AddActivityTask(
ctx context.Context,
addRequest *matchingservice.AddActivityTaskRequest,
) (bool, error) {
namespaceID := namespace.ID(addRequest.GetNamespaceId())
runID := addRequest.Execution.GetRunId()
taskQueueName := addRequest.TaskQueue.GetName()
stickyInfo := stickyInfoFromTaskQueue(addRequest.TaskQueue)
origTaskQueue, err := newTaskQueueID(namespaceID, taskQueueName, enumspb.TASK_QUEUE_TYPE_ACTIVITY)
if err != nil {
return false, err
}
// We don't need the userDataChanged channel here because:
// - if we sync match, we're done
// - if we spool to db, we'll re-resolve when it comes out of the db
taskQueue, _, err := e.redirectToVersionedQueueForAdd(ctx, origTaskQueue, addRequest.VersionDirective, stickyInfo)
if err != nil {
if errors.Is(err, errUserDataDisabled) {
// When user data loading is disabled, we intentionally drop tasks for versioned workflows
// to avoid breaking versioning semantics and dispatching tasks to the wrong workers.
err = nil
}
return false, err
}
tlMgr, err := e.getTaskQueueManager(ctx, taskQueue, stickyInfo, true)
if err != nil {
return false, err
}
var expirationTime *time.Time
now := timestamp.TimePtr(time.Now().UTC())
expirationDuration := timestamp.DurationValue(addRequest.GetScheduleToStartTimeout())
if expirationDuration == 0 {
// noop
} else {
expirationTime = timestamp.TimePtr(now.Add(expirationDuration))
}
taskInfo := &persistencespb.TaskInfo{
NamespaceId: namespaceID.String(),
RunId: runID,
WorkflowId: addRequest.Execution.GetWorkflowId(),
ScheduledEventId: addRequest.GetScheduledEventId(),
Clock: addRequest.GetClock(),
CreateTime: now,
ExpiryTime: expirationTime,
VersionDirective: addRequest.VersionDirective,
}
baseTqm, err := e.getTaskQueueManager(ctx, origTaskQueue, stickyInfo, true)
if err != nil {
return false, err
}
return tlMgr.AddTask(ctx, addTaskParams{
execution: addRequest.Execution,
taskInfo: taskInfo,
source: addRequest.GetSource(),
forwardedFrom: addRequest.GetForwardedSource(),
baseTqm: baseTqm,
})
}
func (e *matchingEngineImpl) DispatchSpooledTask(
ctx context.Context,
task *internalTask,
origTaskQueue *taskQueueID,
stickyInfo stickyInfo,
) error {
taskInfo := task.event.GetData()
// This task came from taskReader so task.event is always set here.
directive := taskInfo.GetVersionDirective()
// If this came from a versioned queue, ignore the version and re-resolve, in case we're
// going to the default and the default changed.
unversionedOrigTaskQueue := newTaskQueueIDWithVersionSet(origTaskQueue, "")
// Redirect and re-resolve if we're blocked in matcher and user data changes.
for {
taskQueue, userDataChanged, err := e.redirectToVersionedQueueForAdd(
ctx, unversionedOrigTaskQueue, directive, stickyInfo)
if err != nil {
return err
}
sticky := stickyInfo.kind == enumspb.TASK_QUEUE_KIND_STICKY
tqm, err := e.getTaskQueueManager(ctx, taskQueue, stickyInfo, !sticky)
if err != nil {
return err
}
err = tqm.DispatchSpooledTask(ctx, task, userDataChanged)
if err != errInterrupted {
return err
}
}
}
// PollWorkflowTaskQueue tries to get the workflow task using exponential backoff.
func (e *matchingEngineImpl) PollWorkflowTaskQueue(
ctx context.Context,
req *matchingservice.PollWorkflowTaskQueueRequest,
opMetrics metrics.Handler,
) (*matchingservice.PollWorkflowTaskQueueResponse, error) {
namespaceID := namespace.ID(req.GetNamespaceId())
pollerID := req.GetPollerId()
request := req.PollRequest
taskQueueName := request.TaskQueue.GetName()
stickyInfo := stickyInfoFromTaskQueue(request.TaskQueue)
e.logger.Debug("Received PollWorkflowTaskQueue for taskQueue", tag.WorkflowTaskQueueName(taskQueueName))
pollLoop:
for {
err := common.IsValidContext(ctx)
if err != nil {
return nil, err
}
// Add frontend generated pollerID to context so taskqueueMgr can support cancellation of
// long-poll when frontend calls CancelOutstandingPoll API
pollerCtx := context.WithValue(ctx, pollerIDKey, pollerID)
pollerCtx = context.WithValue(pollerCtx, identityKey, request.GetIdentity())
taskQueue, err := newTaskQueueID(namespaceID, taskQueueName, enumspb.TASK_QUEUE_TYPE_WORKFLOW)
if err != nil {
return nil, err
}
pollMetadata := &pollMetadata{
workerVersionCapabilities: request.WorkerVersionCapabilities,
}
task, err := e.getTask(pollerCtx, taskQueue, stickyInfo, pollMetadata)
if err != nil {
// TODO: Is empty poll the best reply for errPumpClosed?
if err == ErrNoTasks || err == errPumpClosed {
return emptyPollWorkflowTaskQueueResponse, nil
}
return nil, err
}
e.emitForwardedSourceStats(opMetrics, task.isForwarded(), req.GetForwardedSource())
if task.isStarted() {
// tasks received from remote are already started. So, simply forward the response
return task.pollWorkflowTaskQueueResponse(), nil
}
if task.isQuery() {
task.finish(nil) // this only means query task sync match succeed.
// for query task, we don't need to update history to record workflow task started. but we need to know
// the NextEventID so front end knows what are the history events to load for this workflow task.
mutableStateResp, err := e.historyClient.GetMutableState(ctx, &historyservice.GetMutableStateRequest{
NamespaceId: req.GetNamespaceId(),
Execution: task.workflowExecution(),
})
if err != nil {
// will notify query client that the query task failed
_ = e.deliverQueryResult(task.query.taskID, &queryResult{internalError: err})
return emptyPollWorkflowTaskQueueResponse, nil
}
// A non-sticky poll may get task for a workflow that has sticky still set in its mutable state after
// their sticky worker is dead for longer than 10s. In such case, we should set this to false so that
// frontend returns full history.
isStickyEnabled := taskQueueName == mutableStateResp.StickyTaskQueue.GetName()
resp := &historyservice.RecordWorkflowTaskStartedResponse{
PreviousStartedEventId: mutableStateResp.PreviousStartedEventId,
NextEventId: mutableStateResp.NextEventId,
WorkflowType: mutableStateResp.WorkflowType,
StickyExecutionEnabled: isStickyEnabled,
WorkflowExecutionTaskQueue: mutableStateResp.TaskQueue,
BranchToken: mutableStateResp.CurrentBranchToken,
StartedEventId: common.EmptyEventID,
Attempt: 1,
}
return e.createPollWorkflowTaskQueueResponse(task, resp, opMetrics), nil
}
resp, err := e.recordWorkflowTaskStarted(ctx, request, task)
if err != nil {
switch err.(type) {
case *serviceerror.NotFound: // mutable state not found, workflow not running or workflow task not found
e.logger.Info("Workflow task not found",
tag.WorkflowTaskQueueName(taskQueueName),
tag.WorkflowNamespaceID(task.event.Data.GetNamespaceId()),
tag.WorkflowID(task.event.Data.GetWorkflowId()),
tag.WorkflowRunID(task.event.Data.GetRunId()),
tag.WorkflowTaskQueueName(taskQueueName),
tag.TaskID(task.event.GetTaskId()),
tag.TaskVisibilityTimestamp(timestamp.TimeValue(task.event.Data.GetCreateTime())),
tag.WorkflowEventID(task.event.Data.GetScheduledEventId()),
tag.Error(err),
)
task.finish(nil)
case *serviceerrors.TaskAlreadyStarted:
e.logger.Debug("Duplicated workflow task", tag.WorkflowTaskQueueName(taskQueueName), tag.TaskID(task.event.GetTaskId()))
task.finish(nil)
default:
task.finish(err)
if err.Error() == common.ErrNamespaceHandover.Error() {
// do not keep polling new tasks when namespace is in handover state
// as record start request will be rejected by history service
return nil, err
}
}
continue pollLoop
}
task.finish(nil)
return e.createPollWorkflowTaskQueueResponse(task, resp, opMetrics), nil
}
}
// PollActivityTaskQueue takes one task from the task manager, update workflow execution history, mark task as
// completed and return it to user. If a task from task manager is already started, return an empty response, without
// error. Timeouts handled by the timer queue.
func (e *matchingEngineImpl) PollActivityTaskQueue(
ctx context.Context,
req *matchingservice.PollActivityTaskQueueRequest,
opMetrics metrics.Handler,
) (*matchingservice.PollActivityTaskQueueResponse, error) {
namespaceID := namespace.ID(req.GetNamespaceId())
pollerID := req.GetPollerId()
request := req.PollRequest
taskQueueName := request.TaskQueue.GetName()
stickyInfo := stickyInfoFromTaskQueue(request.TaskQueue)
e.logger.Debug("Received PollActivityTaskQueue for taskQueue", tag.Name(taskQueueName))
pollLoop:
for {
err := common.IsValidContext(ctx)
if err != nil {
return nil, err
}
taskQueue, err := newTaskQueueID(namespaceID, taskQueueName, enumspb.TASK_QUEUE_TYPE_ACTIVITY)
if err != nil {
return nil, err
}
// Add frontend generated pollerID to context so taskqueueMgr can support cancellation of
// long-poll when frontend calls CancelOutstandingPoll API
pollerCtx := context.WithValue(ctx, pollerIDKey, pollerID)
pollerCtx = context.WithValue(pollerCtx, identityKey, request.GetIdentity())
pollMetadata := &pollMetadata{
workerVersionCapabilities: request.WorkerVersionCapabilities,
}
if request.TaskQueueMetadata != nil && request.TaskQueueMetadata.MaxTasksPerSecond != nil {
pollMetadata.ratePerSecond = &request.TaskQueueMetadata.MaxTasksPerSecond.Value
}
task, err := e.getTask(pollerCtx, taskQueue, stickyInfo, pollMetadata)
if err != nil {
// TODO: Is empty poll the best reply for errPumpClosed?
if err == ErrNoTasks || err == errPumpClosed {
return emptyPollActivityTaskQueueResponse, nil
}
return nil, err
}
e.emitForwardedSourceStats(opMetrics, task.isForwarded(), req.GetForwardedSource())
if task.isStarted() {
// tasks received from remote are already started. So, simply forward the response
return task.pollActivityTaskQueueResponse(), nil
}
resp, err := e.recordActivityTaskStarted(ctx, request, task)
if err != nil {
switch err.(type) {
case *serviceerror.NotFound: // mutable state not found, workflow not running or activity info not found
e.logger.Info("Activity task not found",
tag.WorkflowNamespaceID(task.event.Data.GetNamespaceId()),
tag.WorkflowID(task.event.Data.GetWorkflowId()),
tag.WorkflowRunID(task.event.Data.GetRunId()),
tag.WorkflowTaskQueueName(taskQueueName),
tag.TaskID(task.event.GetTaskId()),
tag.TaskVisibilityTimestamp(timestamp.TimeValue(task.event.Data.GetCreateTime())),
tag.WorkflowEventID(task.event.Data.GetScheduledEventId()),
tag.Error(err),
)
task.finish(nil)
case *serviceerrors.TaskAlreadyStarted:
e.logger.Debug("Duplicated activity task", tag.WorkflowTaskQueueName(taskQueueName), tag.TaskID(task.event.GetTaskId()))
task.finish(nil)
default:
task.finish(err)
if err.Error() == common.ErrNamespaceHandover.Error() {
// do not keep polling new tasks when namespace is in handover state
// as record start request will be rejected by history service
return nil, err
}
}
continue pollLoop
}
task.finish(nil)
return e.createPollActivityTaskQueueResponse(task, resp, opMetrics), nil
}
}
type queryResult struct {
workerResponse *matchingservice.RespondQueryTaskCompletedRequest
internalError error
}
// QueryWorkflow creates a WorkflowTask with query data, send it through sync match channel, wait for that WorkflowTask
// to be processed by worker, and then return the query result.
func (e *matchingEngineImpl) QueryWorkflow(
ctx context.Context,
queryRequest *matchingservice.QueryWorkflowRequest,
) (*matchingservice.QueryWorkflowResponse, error) {
namespaceID := namespace.ID(queryRequest.GetNamespaceId())
taskQueueName := queryRequest.TaskQueue.GetName()
stickyInfo := stickyInfoFromTaskQueue(queryRequest.TaskQueue)
origTaskQueue, err := newTaskQueueID(namespaceID, taskQueueName, enumspb.TASK_QUEUE_TYPE_WORKFLOW)
if err != nil {
return nil, err
}
// We don't need the userDataChanged channel here because we either do this sync (local or remote)
// or fail with a relatively short timeout.
taskQueue, _, err := e.redirectToVersionedQueueForAdd(ctx, origTaskQueue, queryRequest.VersionDirective, stickyInfo)
if err != nil {
if errors.Is(err, errUserDataDisabled) {
// Rewrite to nicer error message
err = serviceerror.NewFailedPrecondition("Operations on versioned workflows are disabled")
}
return nil, err
}
sticky := stickyInfo.kind == enumspb.TASK_QUEUE_KIND_STICKY
// do not load sticky task queue if it is not already loaded, which means it has no poller.
tqm, err := e.getTaskQueueManager(ctx, taskQueue, stickyInfo, !sticky)
if err != nil {
return nil, err
} else if sticky && (tqm == nil || !tqm.HasPollerAfter(time.Now().Add(-stickyPollerUnavailableWindow))) {
return nil, serviceerrors.NewStickyWorkerUnavailable()
}
taskID := uuid.New()
resp, err := tqm.DispatchQueryTask(ctx, taskID, queryRequest)
// if get response or error it means that query task was handled by forwarding to another matching host
// this remote host's result can be returned directly
if resp != nil || err != nil {
return resp, err
}
// if get here it means that dispatch of query task has occurred locally
// must wait on result channel to get query result
queryResultCh := make(chan *queryResult, 1)
e.lockableQueryTaskMap.put(taskID, queryResultCh)
defer e.lockableQueryTaskMap.delete(taskID)
select {
case result := <-queryResultCh:
if result.internalError != nil {
return nil, result.internalError
}
workerResponse := result.workerResponse
switch workerResponse.GetCompletedRequest().GetCompletedType() {
case enumspb.QUERY_RESULT_TYPE_ANSWERED:
return &matchingservice.QueryWorkflowResponse{QueryResult: workerResponse.GetCompletedRequest().GetQueryResult()}, nil
case enumspb.QUERY_RESULT_TYPE_FAILED:
return nil, serviceerror.NewQueryFailed(workerResponse.GetCompletedRequest().GetErrorMessage())
default:
return nil, serviceerror.NewInternal("unknown query completed type")
}
case <-ctx.Done():
return nil, ctx.Err()
}
}
func (e *matchingEngineImpl) RespondQueryTaskCompleted(
ctx context.Context,
request *matchingservice.RespondQueryTaskCompletedRequest,
opMetrics metrics.Handler,
) error {
if err := e.deliverQueryResult(request.GetTaskId(), &queryResult{workerResponse: request}); err != nil {
opMetrics.Counter(metrics.RespondQueryTaskFailedPerTaskQueueCounter.GetMetricName()).Record(1)
return err
}
return nil
}
func (e *matchingEngineImpl) deliverQueryResult(taskID string, queryResult *queryResult) error {
queryResultCh, ok := e.lockableQueryTaskMap.get(taskID)
if !ok {
return serviceerror.NewNotFound("query task not found, or already expired")
}
queryResultCh <- queryResult
return nil
}
func (e *matchingEngineImpl) CancelOutstandingPoll(
ctx context.Context,
request *matchingservice.CancelOutstandingPollRequest,
) error {
e.pollMap.cancel(request.PollerId)
return nil
}
func (e *matchingEngineImpl) DescribeTaskQueue(
ctx context.Context,
request *matchingservice.DescribeTaskQueueRequest,
) (*matchingservice.DescribeTaskQueueResponse, error) {
namespaceID := namespace.ID(request.GetNamespaceId())
taskQueueType := request.DescRequest.GetTaskQueueType()
taskQueueName := request.DescRequest.TaskQueue.GetName()
stickyInfo := stickyInfoFromTaskQueue(request.DescRequest.TaskQueue)
taskQueue, err := newTaskQueueID(namespaceID, taskQueueName, taskQueueType)
if err != nil {
return nil, err
}
tlMgr, err := e.getTaskQueueManager(ctx, taskQueue, stickyInfo, true)
if err != nil {
return nil, err
}
return tlMgr.DescribeTaskQueue(request.DescRequest.GetIncludeTaskQueueStatus()), nil
}
func (e *matchingEngineImpl) ListTaskQueuePartitions(
ctx context.Context,
request *matchingservice.ListTaskQueuePartitionsRequest,
) (*matchingservice.ListTaskQueuePartitionsResponse, error) {
activityTaskQueueInfo, err := e.listTaskQueuePartitions(request, enumspb.TASK_QUEUE_TYPE_ACTIVITY)
if err != nil {
return nil, err
}
workflowTaskQueueInfo, err := e.listTaskQueuePartitions(request, enumspb.TASK_QUEUE_TYPE_WORKFLOW)
if err != nil {
return nil, err
}
resp := matchingservice.ListTaskQueuePartitionsResponse{
ActivityTaskQueuePartitions: activityTaskQueueInfo,
WorkflowTaskQueuePartitions: workflowTaskQueueInfo,
}
return &resp, nil
}
func (e *matchingEngineImpl) listTaskQueuePartitions(request *matchingservice.ListTaskQueuePartitionsRequest, taskQueueType enumspb.TaskQueueType) ([]*taskqueuepb.TaskQueuePartitionMetadata, error) {
partitions, err := e.getAllPartitions(
namespace.Name(request.GetNamespace()),
*request.TaskQueue,
taskQueueType,
)
if err != nil {
return nil, err
}
partitionHostInfo := make([]*taskqueuepb.TaskQueuePartitionMetadata, len(partitions))
for i, partition := range partitions {
host, err := e.getHostInfo(partition)
if err != nil {
return nil, err
}
partitionHostInfo[i] = &taskqueuepb.TaskQueuePartitionMetadata{
Key: partition,
OwnerHostName: host,
}
}
return partitionHostInfo, nil
}
func (e *matchingEngineImpl) UpdateWorkerBuildIdCompatibility(
ctx context.Context,
req *matchingservice.UpdateWorkerBuildIdCompatibilityRequest,
) (*matchingservice.UpdateWorkerBuildIdCompatibilityResponse, error) {
namespaceID := namespace.ID(req.GetNamespaceId())
taskQueueName := req.GetTaskQueue()
taskQueue, err := newTaskQueueID(namespaceID, taskQueueName, enumspb.TASK_QUEUE_TYPE_WORKFLOW)
if err != nil {
return nil, err
}
tqMgr, err := e.getTaskQueueManager(ctx, taskQueue, normalStickyInfo, true)
if err != nil {
return nil, err
}
updateOptions := UserDataUpdateOptions{}
operationCreatedTombstones := false
switch req.GetOperation().(type) {
case *matchingservice.UpdateWorkerBuildIdCompatibilityRequest_ApplyPublicRequest_:
// Only apply the limit when request is initiated by a user.
updateOptions.TaskQueueLimitPerBuildId = e.config.TaskQueueLimitPerBuildId()
case *matchingservice.UpdateWorkerBuildIdCompatibilityRequest_RemoveBuildIds_:
updateOptions.KnownVersion = req.GetRemoveBuildIds().GetKnownUserDataVersion()
default:
return nil, serviceerror.NewInvalidArgument(fmt.Sprintf("invalid operation: %v", req.GetOperation()))
}
err = tqMgr.UpdateUserData(ctx, updateOptions, func(data *persistencespb.TaskQueueUserData) (*persistencespb.TaskQueueUserData, bool, error) {
clock := data.GetClock()
if clock == nil {
tmp := hlc.Zero(e.clusterMeta.GetClusterID())
clock = &tmp
}
updatedClock := hlc.Next(*clock, e.timeSource)
var versioningData *persistencespb.VersioningData
switch req.GetOperation().(type) {
case *matchingservice.UpdateWorkerBuildIdCompatibilityRequest_ApplyPublicRequest_:
var err error
versioningData, err = UpdateVersionSets(
updatedClock,
data.GetVersioningData(),
req.GetApplyPublicRequest().GetRequest(),
e.config.VersionCompatibleSetLimitPerQueue(),
e.config.VersionBuildIdLimitPerQueue(),
)
if err != nil {
return nil, false, err
}
case *matchingservice.UpdateWorkerBuildIdCompatibilityRequest_RemoveBuildIds_:
ns, err := e.namespaceRegistry.GetNamespaceByID(namespaceID)
if err != nil {
return nil, false, err
}
versioningData = RemoveBuildIds(
updatedClock,
data.GetVersioningData(),
req.GetRemoveBuildIds().GetBuildIds(),
)
if ns.ReplicationPolicy() == namespace.ReplicationPolicyMultiCluster {
operationCreatedTombstones = true
} else {
// We don't need to keep the tombstones around if we're not replicating them.
versioningData = ClearTombstones(versioningData)
}
default:
return nil, false, serviceerror.NewInvalidArgument(fmt.Sprintf("invalid operation: %v", req.GetOperation()))
}
// Avoid mutation
ret := *data
ret.Clock = &updatedClock
ret.VersioningData = versioningData
return &ret, true, nil
})
if err != nil {
return nil, err
}
// Only clear tombstones after they have been replicated.
if operationCreatedTombstones {
err = tqMgr.UpdateUserData(ctx, UserDataUpdateOptions{}, func(data *persistencespb.TaskQueueUserData) (*persistencespb.TaskQueueUserData, bool, error) {
updatedClock := hlc.Next(*data.GetClock(), e.timeSource)
// Avoid mutation
ret := *data
ret.Clock = &updatedClock
ret.VersioningData = ClearTombstones(data.VersioningData)
return &ret, false, nil // Do not replicate the deletion of tombstones
})
if err != nil {
return nil, err
}
}
return &matchingservice.UpdateWorkerBuildIdCompatibilityResponse{}, nil
}
func (e *matchingEngineImpl) GetWorkerBuildIdCompatibility(
ctx context.Context,
req *matchingservice.GetWorkerBuildIdCompatibilityRequest,
) (*matchingservice.GetWorkerBuildIdCompatibilityResponse, error) {
namespaceID := namespace.ID(req.GetNamespaceId())
taskQueueName := req.GetRequest().GetTaskQueue()
taskQueue, err := newTaskQueueID(namespaceID, taskQueueName, enumspb.TASK_QUEUE_TYPE_WORKFLOW)
if err != nil {
return nil, err
}
tqMgr, err := e.getTaskQueueManager(ctx, taskQueue, normalStickyInfo, true)
if err != nil {
if _, ok := err.(*serviceerror.NotFound); ok {
return &matchingservice.GetWorkerBuildIdCompatibilityResponse{}, nil
}
return nil, err
}
userData, _, err := tqMgr.GetUserData(ctx)
if err != nil {
return nil, err
}
return &matchingservice.GetWorkerBuildIdCompatibilityResponse{
Response: ToBuildIdOrderingResponse(userData.GetData().GetVersioningData(), int(req.GetRequest().GetMaxSets())),
}, nil
}
func (e *matchingEngineImpl) GetTaskQueueUserData(
ctx context.Context,
req *matchingservice.GetTaskQueueUserDataRequest,
) (*matchingservice.GetTaskQueueUserDataResponse, error) {
namespaceID := namespace.ID(req.GetNamespaceId())
taskQueue, err := newTaskQueueID(namespaceID, req.GetTaskQueue(), req.GetTaskQueueType())
if err != nil {
return nil, err
}
tqMgr, err := e.getTaskQueueManager(ctx, taskQueue, normalStickyInfo, true)
if err != nil {
return nil, err
}
version := req.GetLastKnownUserDataVersion()
if version < 0 {
return nil, serviceerror.NewInvalidArgument("last_known_user_data_version must not be negative")
}
if req.WaitNewData {
var cancel context.CancelFunc
ctx, cancel = newChildContext(ctx, e.config.GetUserDataLongPollTimeout(), returnEmptyTaskTimeBudget)
defer cancel()
}
for {
resp := &matchingservice.GetTaskQueueUserDataResponse{}
userData, userDataChanged, err := tqMgr.GetUserData(ctx)
if err != nil {
return nil, err
}
if req.WaitNewData && userData.GetVersion() == version {
// long-poll: wait for data to change/appear
select {
case <-ctx.Done():
resp.TaskQueueHasUserData = userData != nil
return resp, nil
case <-userDataChanged:
continue
}
}
if userData != nil {
resp.TaskQueueHasUserData = true
if userData.Version > version {
resp.UserData = userData
} else if userData.Version < version {
// This is highly unlikely but may happen due to an edge case in during ownership transfer.
// We rely on client retries in this case to let the system eventually self-heal.
return nil, serviceerror.NewInvalidArgument(
"requested task queue user data for version greater than known version")
}
}
return resp, nil
}
}
func (e *matchingEngineImpl) ApplyTaskQueueUserDataReplicationEvent(
ctx context.Context,
req *matchingservice.ApplyTaskQueueUserDataReplicationEventRequest,
) (*matchingservice.ApplyTaskQueueUserDataReplicationEventResponse, error) {
namespaceID := namespace.ID(req.GetNamespaceId())
ns, err := e.namespaceRegistry.GetNamespaceByID(namespaceID)
if err != nil {
return nil, err
}
taskQueueName := req.GetTaskQueue()
taskQueue, err := newTaskQueueID(namespaceID, taskQueueName, enumspb.TASK_QUEUE_TYPE_WORKFLOW)
if err != nil {
return nil, err
}
tqMgr, err := e.getTaskQueueManager(ctx, taskQueue, normalStickyInfo, true)
if err != nil {
return nil, err
}
updateOptions := UserDataUpdateOptions{
// Avoid setting a limit to allow the replication event to always be applied
TaskQueueLimitPerBuildId: 0,
}
err = tqMgr.UpdateUserData(ctx, updateOptions, func(current *persistencespb.TaskQueueUserData) (*persistencespb.TaskQueueUserData, bool, error) {
mergedUserData := *current
_, buildIdsRemoved := GetBuildIdDeltas(current.GetVersioningData(), req.GetUserData().GetVersioningData())
var buildIdsToRevive []string
for _, buildId := range buildIdsRemoved {
// We accept that the user data is locked for updates while running these visibility queries.
// Nothing else is _supposed_ to update it on follower (standby) clusters.
exists, err := worker_versioning.WorkflowsExistForBuildId(ctx, e.visibilityManager, ns, req.TaskQueue, buildId)
if err != nil {
return nil, false, err
}
if exists {
buildIdsToRevive = append(buildIdsToRevive, buildId)
}
}
mergedData := MergeVersioningData(current.GetVersioningData(), req.GetUserData().GetVersioningData())
for _, buildId := range buildIdsToRevive {
setIdx, buildIdIdx := worker_versioning.FindBuildId(mergedData, buildId)
if setIdx == -1 {
continue
}
set := mergedData.VersionSets[setIdx]
set.BuildIds[buildIdIdx] = e.reviveBuildId(ns, req.GetTaskQueue(), set.GetBuildIds()[buildIdIdx])
mergedUserData.Clock = hlc.Ptr(hlc.Max(*mergedUserData.Clock, *set.BuildIds[buildIdIdx].StateUpdateTimestamp))
setDefault := set.BuildIds[len(set.BuildIds)-1]
if setDefault.State == persistencespb.STATE_DELETED {
// We merged an update which removed (at least) two build ids: the default for set x and another one for set
// x. We discovered we're still using the other one, so we revive it. now we also have to revive the default
// for set x, or it will be left with the wrong default.
set.BuildIds[len(set.BuildIds)-1] = e.reviveBuildId(ns, req.GetTaskQueue(), setDefault)
mergedUserData.Clock = hlc.Ptr(hlc.Max(*mergedUserData.Clock, *setDefault.StateUpdateTimestamp))
}
}
// No need to keep the tombstones around after replication.
mergedUserData.VersioningData = ClearTombstones(mergedData)
return &mergedUserData, len(buildIdsToRevive) > 0, nil
})
return &matchingservice.ApplyTaskQueueUserDataReplicationEventResponse{}, err
}
func (e *matchingEngineImpl) GetBuildIdTaskQueueMapping(
ctx context.Context,
req *matchingservice.GetBuildIdTaskQueueMappingRequest,
) (*matchingservice.GetBuildIdTaskQueueMappingResponse, error) {
taskQueues, err := e.taskManager.GetTaskQueuesByBuildId(ctx, &persistence.GetTaskQueuesByBuildIdRequest{
NamespaceID: req.NamespaceId,
BuildID: req.BuildId,
})
if err != nil {
return nil, err
}
return &matchingservice.GetBuildIdTaskQueueMappingResponse{TaskQueues: taskQueues}, nil
}
func (e *matchingEngineImpl) ForceUnloadTaskQueue(
ctx context.Context,
req *matchingservice.ForceUnloadTaskQueueRequest,
) (*matchingservice.ForceUnloadTaskQueueResponse, error) {
namespaceID := namespace.ID(req.GetNamespaceId())
taskQueue, err := newTaskQueueID(namespaceID, req.TaskQueue, req.TaskQueueType)
if err != nil {
return nil, err
}
tqm, err := e.getTaskQueueManager(ctx, taskQueue, normalStickyInfo, false)
if err != nil {
return nil, err
}
if tqm == nil {
return &matchingservice.ForceUnloadTaskQueueResponse{WasLoaded: false}, nil
}
e.unloadTaskQueue(tqm)
return &matchingservice.ForceUnloadTaskQueueResponse{WasLoaded: true}, nil
}
func (e *matchingEngineImpl) UpdateTaskQueueUserData(ctx context.Context, request *matchingservice.UpdateTaskQueueUserDataRequest) (*matchingservice.UpdateTaskQueueUserDataResponse, error) {
locks := e.getNamespaceUpdateLocks(request.GetNamespaceId())
locks.updateLock.Lock()
defer locks.updateLock.Unlock()
err := e.taskManager.UpdateTaskQueueUserData(ctx, &persistence.UpdateTaskQueueUserDataRequest{
NamespaceID: request.GetNamespaceId(),
TaskQueue: request.GetTaskQueue(),
UserData: request.GetUserData(),
BuildIdsAdded: request.BuildIdsAdded,
BuildIdsRemoved: request.BuildIdsRemoved,
})
return &matchingservice.UpdateTaskQueueUserDataResponse{}, err
}
func (e *matchingEngineImpl) ReplicateTaskQueueUserData(ctx context.Context, request *matchingservice.ReplicateTaskQueueUserDataRequest) (*matchingservice.ReplicateTaskQueueUserDataResponse, error) {
if e.namespaceReplicationQueue == nil {
return &matchingservice.ReplicateTaskQueueUserDataResponse{}, nil
}
locks := e.getNamespaceUpdateLocks(request.GetNamespaceId())
locks.replicationLock.Lock()
defer locks.replicationLock.Unlock()
err := e.namespaceReplicationQueue.Publish(ctx, &replicationspb.ReplicationTask{
TaskType: enumsspb.REPLICATION_TASK_TYPE_TASK_QUEUE_USER_DATA,
Attributes: &replicationspb.ReplicationTask_TaskQueueUserDataAttributes{
TaskQueueUserDataAttributes: &replicationspb.TaskQueueUserDataAttributes{
NamespaceId: request.GetNamespaceId(),
TaskQueueName: request.GetTaskQueue(),
UserData: request.GetUserData(),
},
},
})
return &matchingservice.ReplicateTaskQueueUserDataResponse{}, err
}
func (e *matchingEngineImpl) getNamespaceUpdateLocks(namespaceId string) *namespaceUpdateLocks {
e.namespaceUpdateLockMapLock.Lock()
defer e.namespaceUpdateLockMapLock.Unlock()
locks, found := e.namespaceUpdateLockMap[namespaceId]
if !found {
locks = &namespaceUpdateLocks{}
e.namespaceUpdateLockMap[namespaceId] = locks
}
return locks
}
func (e *matchingEngineImpl) getHostInfo(partitionKey string) (string, error) {
host, err := e.keyResolver.Lookup(partitionKey)
if err != nil {
return "", err
}
return host.GetAddress(), nil
}
func (e *matchingEngineImpl) getAllPartitions(
namespace namespace.Name,
taskQueue taskqueuepb.TaskQueue,
taskQueueType enumspb.TaskQueueType,
) ([]string, error) {
var partitionKeys []string
namespaceID, err := e.namespaceRegistry.GetNamespaceID(namespace)
if err != nil {
return partitionKeys, err
}
taskQueueID, err := newTaskQueueID(namespaceID, taskQueue.GetName(), enumspb.TASK_QUEUE_TYPE_WORKFLOW)
if err != nil {
return partitionKeys, err
}
n := e.config.NumTaskqueueWritePartitions(namespace.String(), taskQueueID.BaseNameString(), taskQueueType)
for i := 0; i < n; i++ {
partitionKeys = append(partitionKeys, taskQueueID.WithPartition(i).FullName())
}
return partitionKeys, nil
}
func (e *matchingEngineImpl) getTask(
ctx context.Context,
origTaskQueue *taskQueueID,
stickyInfo stickyInfo,
pollMetadata *pollMetadata,
) (*internalTask, error) {
baseTqm, err := e.getTaskQueueManager(ctx, origTaskQueue, stickyInfo, true)
if err != nil {
return nil, err
}
taskQueue, err := e.redirectToVersionedQueueForPoll(
ctx,
baseTqm,
origTaskQueue,
pollMetadata.workerVersionCapabilities,
stickyInfo,
)
if err != nil {
if errors.Is(err, errUserDataDisabled) {
// Rewrite to nicer error message
err = serviceerror.NewFailedPrecondition("Operations on versioned workflows are disabled")
}
return nil, err
}
tqm, err := e.getTaskQueueManager(ctx, taskQueue, stickyInfo, true)
if err != nil {
return nil, err
}
// We need to set a shorter timeout than the original ctx; otherwise, by the time ctx deadline is
// reached, instead of emptyTask, context timeout error is returned to the frontend by the rpc stack,
// which counts against our SLO. By shortening the timeout by a very small amount, the emptyTask can be
// returned to the handler before a context timeout error is generated.
ctx, cancel := newChildContext(ctx, baseTqm.LongPollExpirationInterval(), returnEmptyTaskTimeBudget)
defer cancel()
if pollerID, ok := ctx.Value(pollerIDKey).(string); ok && pollerID != "" {
e.pollMap.add(pollerID, cancel)
defer e.pollMap.remove(pollerID)
}
if identity, ok := ctx.Value(identityKey).(string); ok && identity != "" {
baseTqm.UpdatePollerInfo(pollerIdentity(identity), pollMetadata)
// update timestamp when long poll ends
defer baseTqm.UpdatePollerInfo(pollerIdentity(identity), pollMetadata)
}
return tqm.GetTask(ctx, pollMetadata)
}
func (e *matchingEngineImpl) unloadTaskQueue(unloadTQM taskQueueManager) {
queueID := unloadTQM.QueueID()
e.taskQueuesLock.Lock()
foundTQM, ok := e.taskQueues[*queueID]
if !ok || foundTQM != unloadTQM {
e.taskQueuesLock.Unlock()
return
}
delete(e.taskQueues, *queueID)
countKey := taskQueueCounterKey{namespaceID: queueID.namespaceID, taskType: queueID.taskType, kind: foundTQM.TaskQueueKind()}
e.taskQueueCount[countKey]--
taskQueueCount := e.taskQueueCount[countKey]
e.taskQueuesLock.Unlock()
e.updateTaskQueueGauge(countKey, taskQueueCount)
foundTQM.Stop()
}
func (e *matchingEngineImpl) updateTaskQueueGauge(countKey taskQueueCounterKey, taskQueueCount int) {
nsEntry, err := e.namespaceRegistry.GetNamespaceByID(countKey.namespaceID)
namespace := namespace.Name("unknown")
if err == nil {
namespace = nsEntry.Name()
}
e.metricsHandler.Gauge(metrics.LoadedTaskQueueGauge.GetMetricName()).Record(
float64(taskQueueCount),
metrics.NamespaceTag(namespace.String()),
metrics.TaskTypeTag(countKey.taskType.String()),
metrics.QueueTypeTag(countKey.kind.String()),
)
}
// Populate the workflow task response based on context and scheduled/started events.
func (e *matchingEngineImpl) createPollWorkflowTaskQueueResponse(
task *internalTask,
historyResponse *historyservice.RecordWorkflowTaskStartedResponse,
metricsHandler metrics.Handler,
) *matchingservice.PollWorkflowTaskQueueResponse {
var serializedToken []byte
if task.isQuery() {
// for a query task
queryRequest := task.query.request
queryTaskToken := &tokenspb.QueryTask{
NamespaceId: queryRequest.GetNamespaceId(),
TaskQueue: queryRequest.TaskQueue.Name,
TaskId: task.query.taskID,
}
serializedToken, _ = e.tokenSerializer.SerializeQueryTaskToken(queryTaskToken)
} else {
taskToken := &tokenspb.Task{
NamespaceId: task.event.Data.GetNamespaceId(),
WorkflowId: task.event.Data.GetWorkflowId(),
RunId: task.event.Data.GetRunId(),
ScheduledEventId: historyResponse.GetScheduledEventId(),
StartedEventId: historyResponse.GetStartedEventId(),
StartedTime: historyResponse.GetStartedTime(),
Attempt: historyResponse.GetAttempt(),
Clock: historyResponse.GetClock(),
}
serializedToken, _ = e.tokenSerializer.Serialize(taskToken)
if task.responseC == nil {
ct := timestamp.TimeValue(task.event.Data.CreateTime)
metricsHandler.Timer(metrics.AsyncMatchLatencyPerTaskQueue.GetMetricName()).Record(time.Since(ct))
}
}
response := common.CreateMatchingPollWorkflowTaskQueueResponse(
historyResponse,
task.workflowExecution(),
serializedToken)
if task.query != nil {
response.Query = task.query.request.QueryRequest.Query
}
if task.backlogCountHint != nil {
response.BacklogCountHint = task.backlogCountHint()
}
return response
}
// Populate the activity task response based on context and scheduled/started events.
func (e *matchingEngineImpl) createPollActivityTaskQueueResponse(
task *internalTask,
historyResponse *historyservice.RecordActivityTaskStartedResponse,
metricsHandler metrics.Handler,
) *matchingservice.PollActivityTaskQueueResponse {
scheduledEvent := historyResponse.ScheduledEvent
if scheduledEvent.GetActivityTaskScheduledEventAttributes() == nil {
panic("GetActivityTaskScheduledEventAttributes is not set")
}
attributes := scheduledEvent.GetActivityTaskScheduledEventAttributes()
if attributes.ActivityId == "" {
panic("ActivityTaskScheduledEventAttributes.ActivityID is not set")
}
if task.responseC == nil {
ct := timestamp.TimeValue(task.event.Data.CreateTime)
metricsHandler.Timer(metrics.AsyncMatchLatencyPerTaskQueue.GetMetricName()).Record(time.Since(ct))
}
taskToken := &tokenspb.Task{
NamespaceId: task.event.Data.GetNamespaceId(),
WorkflowId: task.event.Data.GetWorkflowId(),
RunId: task.event.Data.GetRunId(),
ScheduledEventId: task.event.Data.GetScheduledEventId(),
Attempt: historyResponse.GetAttempt(),
ActivityId: attributes.GetActivityId(),
ActivityType: attributes.GetActivityType().GetName(),
Clock: historyResponse.GetClock(),
}
serializedToken, _ := e.tokenSerializer.Serialize(taskToken)
return &matchingservice.PollActivityTaskQueueResponse{
ActivityId: attributes.ActivityId,
ActivityType: attributes.ActivityType,
Header: attributes.Header,
Input: attributes.Input,
WorkflowExecution: task.workflowExecution(),
CurrentAttemptScheduledTime: historyResponse.CurrentAttemptScheduledTime,
ScheduledTime: scheduledEvent.EventTime,
ScheduleToCloseTimeout: attributes.ScheduleToCloseTimeout,
StartedTime: historyResponse.StartedTime,
StartToCloseTimeout: attributes.StartToCloseTimeout,
HeartbeatTimeout: attributes.HeartbeatTimeout,
TaskToken: serializedToken,
Attempt: taskToken.Attempt,
HeartbeatDetails: historyResponse.HeartbeatDetails,
WorkflowType: historyResponse.WorkflowType,
WorkflowNamespace: historyResponse.WorkflowNamespace,
}
}
func (e *matchingEngineImpl) recordWorkflowTaskStarted(
ctx context.Context,
pollReq *workflowservice.PollWorkflowTaskQueueRequest,
task *internalTask,
) (*historyservice.RecordWorkflowTaskStartedResponse, error) {
ctx, cancel := newRecordTaskStartedContext(ctx, task)
defer cancel()
return e.historyClient.RecordWorkflowTaskStarted(ctx, &historyservice.RecordWorkflowTaskStartedRequest{
NamespaceId: task.event.Data.GetNamespaceId(),
WorkflowExecution: task.workflowExecution(),
ScheduledEventId: task.event.Data.GetScheduledEventId(),
Clock: task.event.Data.GetClock(),
TaskId: task.event.GetTaskId(),
RequestId: uuid.New(),
PollRequest: pollReq,
})
}
func (e *matchingEngineImpl) recordActivityTaskStarted(
ctx context.Context,
pollReq *workflowservice.PollActivityTaskQueueRequest,
task *internalTask,
) (*historyservice.RecordActivityTaskStartedResponse, error) {
ctx, cancel := newRecordTaskStartedContext(ctx, task)
defer cancel()
return e.historyClient.RecordActivityTaskStarted(ctx, &historyservice.RecordActivityTaskStartedRequest{
NamespaceId: task.event.Data.GetNamespaceId(),
WorkflowExecution: task.workflowExecution(),
ScheduledEventId: task.event.Data.GetScheduledEventId(),
Clock: task.event.Data.GetClock(),
TaskId: task.event.GetTaskId(),
RequestId: uuid.New(),
PollRequest: pollReq,
})
}
func (e *matchingEngineImpl) emitForwardedSourceStats(
metricsHandler metrics.Handler,
isTaskForwarded bool,
pollForwardedSource string,
) {
isPollForwarded := len(pollForwardedSource) > 0
switch {
case isTaskForwarded && isPollForwarded:
metricsHandler.Counter(metrics.RemoteToRemoteMatchPerTaskQueueCounter.GetMetricName()).Record(1)
case isTaskForwarded:
metricsHandler.Counter(metrics.RemoteToLocalMatchPerTaskQueueCounter.GetMetricName()).Record(1)
case isPollForwarded:
metricsHandler.Counter(metrics.LocalToRemoteMatchPerTaskQueueCounter.GetMetricName()).Record(1)
default:
metricsHandler.Counter(metrics.LocalToLocalMatchPerTaskQueueCounter.GetMetricName()).Record(1)
}
}
func (e *matchingEngineImpl) redirectToVersionedQueueForPoll(
ctx context.Context,
baseTqm taskQueueManager,
taskQueue *taskQueueID,
workerVersionCapabilities *commonpb.WorkerVersionCapabilities,
stickyInfo stickyInfo,
) (*taskQueueID, error) {
if !workerVersionCapabilities.GetUseVersioning() {
// Either this task queue is versioned, or there are still some workflows running on
// the "unversioned" set.
return taskQueue, nil
}
// We don't need the userDataChanged channel here because polls have a timeout and the
// client will retry, so if we're blocked on the wrong matcher it'll just take one poll
// timeout to fix itself.
userData, _, err := baseTqm.GetUserData(ctx)
if err != nil {
return nil, err
}
data := userData.GetData().GetVersioningData()
if stickyInfo.kind == enumspb.TASK_QUEUE_KIND_STICKY {
// In the sticky case we don't redirect, but we may kick off this worker if there's a
// newer one.
err := checkVersionForStickyPoll(data, workerVersionCapabilities)
return taskQueue, err
}
versionSet, err := lookupVersionSetForPoll(data, workerVersionCapabilities)
if err != nil {
return nil, err
}
return newTaskQueueIDWithVersionSet(taskQueue, versionSet), nil
}
func (e *matchingEngineImpl) redirectToVersionedQueueForAdd(
ctx context.Context,
taskQueue *taskQueueID,
directive *taskqueuespb.TaskVersionDirective,
stickyInfo stickyInfo,
) (*taskQueueID, chan struct{}, error) {
var buildId string
switch dir := directive.GetValue().(type) {
case *taskqueuespb.TaskVersionDirective_UseDefault:
// leave buildId = "", lookupVersionSetForAdd understands that to mean "default"
case *taskqueuespb.TaskVersionDirective_BuildId:
buildId = dir.BuildId
default:
// Unversioned task, leave on unversioned queue.
return taskQueue, nil, nil
}
baseTqm, err := e.getTaskQueueManager(ctx, taskQueue, stickyInfo, true)
if err != nil {
return nil, nil, err
}
// Have to look up versioning data.
userData, userDataChanged, err := baseTqm.GetUserData(ctx)
if err != nil {
if errors.Is(err, errUserDataDisabled) && buildId == "" {
// When user data disabled, send "default" tasks to unversioned queue.
return taskQueue, userDataChanged, nil
}
return nil, nil, err
}
data := userData.GetData().GetVersioningData()
if stickyInfo.kind == enumspb.TASK_QUEUE_KIND_STICKY {
// In the sticky case we don't redirect, but we may kick off this worker if there's a
// newer one.
err := checkVersionForStickyAdd(data, buildId)
return taskQueue, userDataChanged, err
}
versionSet, err := lookupVersionSetForAdd(data, buildId)
if err == errEmptyVersioningData {
// default was requested for an unversioned queue
return taskQueue, userDataChanged, nil
} else if err != nil {
return nil, nil, err
}
return newTaskQueueIDWithVersionSet(taskQueue, versionSet), userDataChanged, nil
}
func (m *lockableQueryTaskMap) put(key string, value chan *queryResult) {
m.Lock()
defer m.Unlock()
m.queryTaskMap[key] = value
}
func (m *lockableQueryTaskMap) get(key string) (chan *queryResult, bool) {
m.RLock()
defer m.RUnlock()
result, ok := m.queryTaskMap[key]
return result, ok
}
func (m *lockableQueryTaskMap) delete(key string) {
m.Lock()
defer m.Unlock()
delete(m.queryTaskMap, key)
}
func (m *lockablePollMap) add(cancelId string, cancel context.CancelFunc) {
m.Lock()
defer m.Unlock()
m.polls[cancelId] = cancel
}
func (m *lockablePollMap) remove(cancelId string) {
m.Lock()
defer m.Unlock()
delete(m.polls, cancelId)
}
func (m *lockablePollMap) cancel(cancelId string) {
m.Lock()
defer m.Unlock()
if cancel, ok := m.polls[cancelId]; ok {
cancel()
delete(m.polls, cancelId)
}
}
// newRecordTaskStartedContext creates a context for recording
// activity or workflow task started. The parentCtx from
// pollActivity/WorkflowTaskQueue endpoint (which is a long poll
// API) has long timeout and unsuitable for recording task started,
// especially if the task is doing sync match and has caller
// (history transfer queue) waiting for response.
func newRecordTaskStartedContext(
parentCtx context.Context,
task *internalTask,
) (context.Context, context.CancelFunc) {
timeout := recordTaskStartedDefaultTimeout
if task.isSyncMatchTask() {
timeout = recordTaskStartedSyncMatchTimeout
}
return context.WithTimeout(parentCtx, timeout)
}
// Revives a deleted build id updating its HLC timestamp.
// Returns a new build id leaving the provided one untouched.
func (e *matchingEngineImpl) reviveBuildId(ns *namespace.Namespace, taskQueue string, buildId *persistencespb.BuildId) *persistencespb.BuildId {
// Bump the stamp and ensure it's newer than the deletion stamp.
prevStamp := *buildId.StateUpdateTimestamp
stamp := hlc.Next(prevStamp, e.timeSource)
stamp.ClusterId = e.clusterMeta.GetClusterID()
e.logger.Info("Revived build id while applying replication event",
tag.WorkflowNamespace(ns.Name().String()),
tag.WorkflowTaskQueueName(taskQueue),
tag.BuildId(buildId.Id))
return &persistencespb.BuildId{
Id: buildId.GetId(),
State: persistencespb.STATE_ACTIVE,
StateUpdateTimestamp: &stamp,
BecameDefaultTimestamp: buildId.BecameDefaultTimestamp,
}
}