Files
pdoernerandGitHub 68a1d21755 Dynamic rate limiter (#4390)
* moving window average

* remove channel avg impl

* add signal aggregator

* adjust record fn

* add health signal clients

* inject signal aggregator

* fix tests

* add metric emission

* add health request rate limiter

* WIP

* race condition

* WIP

* add health request rate limiter

* bench test rate limiter

* WIP

* Revert "race condition"

This reverts commit e283bfb3dca7228d715cd28235e436caafb34fa6.

* Revert "add metric emission"

This reverts commit 859950ee2965b5ac2144f46930e1308d95890e69.

* emit per shard RPS metric

* cleanup

* merge metric and signal clients

* cleanup

* cleanup

* linting

* global dynamic rate limiter

* cleanup

* remove generics

* WIP

* cleanup

* fix deferred metric fn

* fix defer metric fn

* fix clients

* types

* simple dynamic rate limiter test

* linting

* tests

* tests

* acquire lock once

* locks

* array moving average

* Revert "array moving average"

This reverts commit 98f2b66b9b7a711c427d5f55de82bc55d135ddfc.

* cleanup

* emit per shard RPS

* array average

* feedback

* cleanup

* handle nil health signals

* tests

* uncomment signal collection

* refactor dynamic config properties

* cleanup

* add aggregation feature flag

* fix test

* cleanup

* avoid potential race condition

* feedback

* fix

* remove test
2023-06-02 15:30:01 -07:00

149 lines
4.8 KiB
Go

// The MIT License
//
// Copyright (c) 2020 Temporal Technologies Inc. All rights reserved.
//
// Copyright (c) 2020 Uber Technologies, Inc.
//
// Permission is hereby granted, free of charge, to any person obtaining a copy
// of this software and associated documentation files (the "Software"), to deal
// in the Software without restriction, including without limitation the rights
// to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
// copies of the Software, and to permit persons to whom the Software is
// furnished to do so, subject to the following conditions:
//
// The above copyright notice and this permission notice shall be included in
// all copies or substantial portions of the Software.
//
// THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
// IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
// FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
// AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
// LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
// OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
// THE SOFTWARE.
package worker
import (
"context"
"go.uber.org/fx"
"go.temporal.io/server/common"
"go.temporal.io/server/common/config"
"go.temporal.io/server/common/dynamicconfig"
"go.temporal.io/server/common/log"
"go.temporal.io/server/common/metrics"
"go.temporal.io/server/common/persistence/visibility"
"go.temporal.io/server/common/persistence/visibility/manager"
esclient "go.temporal.io/server/common/persistence/visibility/store/elasticsearch/client"
"go.temporal.io/server/common/resolver"
"go.temporal.io/server/common/resource"
"go.temporal.io/server/common/searchattribute"
"go.temporal.io/server/service"
"go.temporal.io/server/service/worker/addsearchattributes"
"go.temporal.io/server/service/worker/batcher"
"go.temporal.io/server/service/worker/deletenamespace"
"go.temporal.io/server/service/worker/migration"
"go.temporal.io/server/service/worker/scheduler"
)
var Module = fx.Options(
migration.Module,
addsearchattributes.Module,
resource.Module,
deletenamespace.Module,
scheduler.Module,
batcher.Module,
fx.Provide(VisibilityManagerProvider),
fx.Provide(dynamicconfig.NewCollection),
fx.Provide(ThrottledLoggerRpsFnProvider),
fx.Provide(ConfigProvider),
fx.Provide(PersistenceRateLimitingParamsProvider),
fx.Provide(NewService),
fx.Provide(NewWorkerManager),
fx.Provide(NewPerNamespaceWorkerManager),
fx.Invoke(ServiceLifetimeHooks),
)
func ThrottledLoggerRpsFnProvider(serviceConfig *Config) resource.ThrottledLoggerRpsFn {
return func() float64 { return float64(serviceConfig.ThrottledLogRPS()) }
}
func PersistenceRateLimitingParamsProvider(
serviceConfig *Config,
) service.PersistenceRateLimitingParams {
return service.NewPersistenceRateLimitingParams(
serviceConfig.PersistenceMaxQPS,
serviceConfig.PersistenceGlobalMaxQPS,
serviceConfig.PersistenceNamespaceMaxQPS,
serviceConfig.PersistencePerShardNamespaceMaxQPS,
serviceConfig.EnablePersistencePriorityRateLimiting,
serviceConfig.PersistenceDynamicRateLimitingParams,
)
}
func ConfigProvider(
dc *dynamicconfig.Collection,
persistenceConfig *config.Persistence,
) *Config {
return NewConfig(
dc,
persistenceConfig,
persistenceConfig.StandardVisibilityConfigExist(),
persistenceConfig.AdvancedVisibilityConfigExist(),
)
}
func VisibilityManagerProvider(
logger log.Logger,
metricsHandler metrics.Handler,
persistenceConfig *config.Persistence,
serviceConfig *Config,
esClient esclient.Client,
persistenceServiceResolver resolver.ServiceResolver,
searchAttributesMapperProvider searchattribute.MapperProvider,
saProvider searchattribute.Provider,
) (manager.VisibilityManager, error) {
return visibility.NewManager(
*persistenceConfig,
persistenceServiceResolver,
esClient,
nil, // worker visibility never write
saProvider,
searchAttributesMapperProvider,
serviceConfig.VisibilityPersistenceMaxReadQPS,
serviceConfig.VisibilityPersistenceMaxWriteQPS,
serviceConfig.EnableReadFromSecondaryVisibility,
dynamicconfig.GetStringPropertyFn(visibility.SecondaryVisibilityWritingModeOff), // worker visibility never write
serviceConfig.VisibilityDisableOrderByClause,
serviceConfig.VisibilityEnableManualPagination,
metricsHandler,
logger,
)
}
func ServiceLifetimeHooks(
lc fx.Lifecycle,
svcStoppedCh chan struct{},
svc *Service,
) {
lc.Append(
fx.Hook{
OnStart: func(context.Context) error {
go func(svc common.Daemon, svcStoppedCh chan<- struct{}) {
// Start is blocked until Stop() is called.
svc.Start()
close(svcStoppedCh)
}(svc, svcStoppedCh)
return nil
},
OnStop: func(ctx context.Context) error {
svc.Stop()
return nil
},
},
)
}