mirror of
https://github.com/hanzoai/tasks.git
synced 2026-10-04 02:04:03 +00:00
<!-- Describe what has changed in this PR --> **What changed?** When merging map of payloads, if the `src` map contains `nil` value or an empty list, it should remove the key from the `dst` map. Fixing the comparison to check only the encoding type and the value instead of the proto value. This ensures that additional data in the metadata map won't affect the result. <!-- Tell your future self why have you made these changes --> **Why?** ^ <!-- How have you verified this change? Tested locally? Added a unit test? Checked in staging env? --> **How did you test it?** <!-- Assuming the worst case, what can be broken when deploying this change to production? --> **Potential risks** No. <!-- Is this PR a hotfix candidate or require that a notification be sent to the broader community? (Yes/No) --> **Is hotfix candidate?** No.
142 lines
3.8 KiB
Go
142 lines
3.8 KiB
Go
// The MIT License
|
|
//
|
|
// Copyright (c) 2020 Temporal Technologies Inc. All rights reserved.
|
|
//
|
|
// Copyright (c) 2020 Uber Technologies, Inc.
|
|
//
|
|
// Permission is hereby granted, free of charge, to any person obtaining a copy
|
|
// of this software and associated documentation files (the "Software"), to deal
|
|
// in the Software without restriction, including without limitation the rights
|
|
// to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
|
|
// copies of the Software, and to permit persons to whom the Software is
|
|
// furnished to do so, subject to the following conditions:
|
|
//
|
|
// The above copyright notice and this permission notice shall be included in
|
|
// all copies or substantial portions of the Software.
|
|
//
|
|
// THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
|
|
// IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
|
|
// FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
|
|
// AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
|
|
// LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
|
|
// OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
|
|
// THE SOFTWARE.
|
|
|
|
package payload
|
|
|
|
import (
|
|
"testing"
|
|
|
|
"github.com/stretchr/testify/assert"
|
|
commonpb "go.temporal.io/api/common/v1"
|
|
)
|
|
|
|
type testStruct struct {
|
|
Int int
|
|
String string
|
|
Bytes []byte
|
|
}
|
|
|
|
func TestToString(t *testing.T) {
|
|
s := assert.New(t)
|
|
var result string
|
|
|
|
p := EncodeString("str")
|
|
result = ToString(p)
|
|
s.Equal(`"str"`, result)
|
|
|
|
p, err := Encode(10)
|
|
s.NoError(err)
|
|
result = ToString(p)
|
|
s.Equal("10", result)
|
|
|
|
p, err = Encode([]byte{41, 42, 43})
|
|
s.NoError(err)
|
|
result = ToString(p)
|
|
s.Equal("KSor", result)
|
|
|
|
p, err = Encode(&testStruct{
|
|
Int: 10,
|
|
String: "str",
|
|
Bytes: []byte{51, 52, 53},
|
|
})
|
|
s.NoError(err)
|
|
result = ToString(p)
|
|
s.Equal(`{"Int":10,"String":"str","Bytes":"MzQ1"}`, result)
|
|
|
|
p, err = Encode(nil)
|
|
s.NoError(err)
|
|
result = ToString(p)
|
|
s.Equal("nil", result)
|
|
|
|
result = ToString(nil)
|
|
s.Equal("", result)
|
|
}
|
|
|
|
func TestMergeMapOfPayload(t *testing.T) {
|
|
s := assert.New(t)
|
|
|
|
var currentMap map[string]*commonpb.Payload
|
|
var newMap map[string]*commonpb.Payload
|
|
resultMap := MergeMapOfPayload(currentMap, newMap)
|
|
s.Equal(newMap, resultMap)
|
|
|
|
newMap = make(map[string]*commonpb.Payload)
|
|
resultMap = MergeMapOfPayload(currentMap, newMap)
|
|
s.Equal(newMap, resultMap)
|
|
|
|
newMap = map[string]*commonpb.Payload{"key": EncodeString("val")}
|
|
resultMap = MergeMapOfPayload(currentMap, newMap)
|
|
s.Equal(newMap, resultMap)
|
|
|
|
newMap = map[string]*commonpb.Payload{
|
|
"key": EncodeString("val"),
|
|
"nil": nilPayload,
|
|
"emptyArray": emptySlicePayload,
|
|
}
|
|
resultMap = MergeMapOfPayload(currentMap, newMap)
|
|
s.Equal(map[string]*commonpb.Payload{"key": EncodeString("val")}, resultMap)
|
|
|
|
currentMap = map[string]*commonpb.Payload{"number": EncodeString("1")}
|
|
resultMap = MergeMapOfPayload(currentMap, newMap)
|
|
s.Equal(
|
|
map[string]*commonpb.Payload{"number": EncodeString("1"), "key": EncodeString("val")},
|
|
resultMap,
|
|
)
|
|
|
|
newValue, _ := Encode(nil)
|
|
newMap = map[string]*commonpb.Payload{"number": newValue}
|
|
resultMap = MergeMapOfPayload(currentMap, newMap)
|
|
s.Equal(0, len(resultMap))
|
|
|
|
newValue, _ = Encode([]int{})
|
|
newValue.Metadata["key"] = []byte("foo")
|
|
newMap = map[string]*commonpb.Payload{"number": newValue}
|
|
resultMap = MergeMapOfPayload(currentMap, newMap)
|
|
s.Equal(0, len(resultMap))
|
|
}
|
|
|
|
func TestIsEqual(t *testing.T) {
|
|
s := assert.New(t)
|
|
|
|
a, _ := Encode(nil)
|
|
b, _ := Encode(nil)
|
|
s.True(isEqual(a, b))
|
|
|
|
a, _ = Encode([]string{})
|
|
b, _ = Encode([]string{})
|
|
s.True(isEqual(a, b))
|
|
|
|
a.Metadata["key"] = []byte("foo")
|
|
b.Metadata["key"] = []byte("bar")
|
|
s.True(isEqual(a, b))
|
|
|
|
a, _ = Encode(nil)
|
|
b, _ = Encode([]string{})
|
|
s.False(isEqual(a, b))
|
|
|
|
a, _ = Encode([]string{})
|
|
b, _ = Encode("foo")
|
|
s.False(isEqual(a, b))
|
|
}
|