Files
tasks/common/persistence/client/quotas_test.go
pdoernerandGitHub 065c83f8ec Prioritize UI/tctl when system is throttled (#4623)
<!-- Describe what has changed in this PR -->
**What changed?**
* Added a new possible value for the `caller-type` header: `operator`
* This header should be set by web UI and tctl to indicate that requests
should be given higher precedence
* Rate limiters for persistence, history, matching, and visibility were
updated with a new priority corresponding to `operator` requests
* These new priorities have a lower RPS limit to prevent abusing the
header to get high priority for all requests. Currently the operator
priority is allowed 20% of the rate of the existing rate limiters

<!-- Tell your future self why have you made these changes -->
**Why?**
When the system is being throttled, users would like to be able to debug
using the web UI and/or tctl without running into rate limit errors

<!-- How have you verified this change? Tested locally? Added a unit
test? Checked in staging env? -->
**How did you test it?**
New unit tests

<!-- Assuming the worst case, what can be broken when deploying this
change to production? -->
**Potential risks**
The operator RPS is set too low leading to new rate limit errors

<!-- Is this PR a hotfix candidate or require that a notification be
sent to the broader community? (Yes/No) -->
**Is hotfix candidate?**
No
2023-07-18 09:50:46 -07:00

195 lines
5.0 KiB
Go

// The MIT License
//
// Copyright (c) 2020 Temporal Technologies Inc. All rights reserved.
//
// Copyright (c) 2020 Uber Technologies, Inc.
//
// Permission is hereby granted, free of charge, to any person obtaining a copy
// of this software and associated documentation files (the "Software"), to deal
// in the Software without restriction, including without limitation the rights
// to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
// copies of the Software, and to permit persons to whom the Software is
// furnished to do so, subject to the following conditions:
//
// The above copyright notice and this permission notice shall be included in
// all copies or substantial portions of the Software.
//
// THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
// IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
// FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
// AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
// LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
// OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
// THE SOFTWARE.
package client
import (
"reflect"
"testing"
"time"
"github.com/stretchr/testify/require"
"github.com/stretchr/testify/suite"
"go.temporal.io/server/common/headers"
"go.temporal.io/server/common/quotas"
"golang.org/x/exp/slices"
"go.temporal.io/api/workflowservice/v1"
)
type (
quotasSuite struct {
suite.Suite
*require.Assertions
}
)
func TestQuotasSuite(t *testing.T) {
s := new(quotasSuite)
suite.Run(t, s)
}
func (s *quotasSuite) SetupSuite() {
}
func (s *quotasSuite) TearDownSuite() {
}
func (s *quotasSuite) SetupTest() {
s.Assertions = require.New(s.T())
}
func (s *quotasSuite) TearDownTest() {
}
func (s *quotasSuite) TestCallerTypeDefaultPriorityMapping() {
for _, priority := range CallerTypeDefaultPriority {
index := slices.Index(RequestPrioritiesOrdered, priority)
s.NotEqual(-1, index)
}
}
func (s *quotasSuite) TestAPITypeCallOriginPriorityOverrideMapping() {
for _, priority := range APITypeCallOriginPriorityOverride {
index := slices.Index(RequestPrioritiesOrdered, priority)
s.NotEqual(-1, index)
}
}
func (s *quotasSuite) TestBackgroundTypeAPIPriorityOverrideMapping() {
for _, priority := range BackgroundTypeAPIPriorityOverride {
index := slices.Index(RequestPrioritiesOrdered, priority)
s.NotEqual(-1, index)
}
}
func (s *quotasSuite) TestRequestPrioritiesOrdered() {
for idx := range RequestPrioritiesOrdered[1:] {
s.True(RequestPrioritiesOrdered[idx] < RequestPrioritiesOrdered[idx+1])
}
}
func (s *quotasSuite) TestCallOriginDefined() {
var service workflowservice.WorkflowServiceServer
t := reflect.TypeOf(&service).Elem()
definedAPIs := make(map[string]struct{}, t.NumMethod())
for i := 0; i < t.NumMethod(); i++ {
definedAPIs[t.Method(i).Name] = struct{}{}
}
for api := range APITypeCallOriginPriorityOverride {
_, ok := definedAPIs[api]
s.True(ok)
}
}
func (s *quotasSuite) TestPriorityNamespaceRateLimiter_DoesLimit() {
namespaceMaxRPS := func(namespace string) int { return 1 }
hostMaxRPS := func() int { return 1 }
operatorRPSRatioFn := func() float64 { return 0.2 }
limiter := newPriorityNamespaceRateLimiter(namespaceMaxRPS, hostMaxRPS, RequestPriorityFn, operatorRPSRatioFn)
request := quotas.NewRequest(
"test-api",
1,
"test-namespace",
"api",
-1,
"frontend",
)
requestTime := time.Now()
wasLimited := false
for i := 0; i < 2; i++ {
if !limiter.Allow(requestTime, request) {
wasLimited = true
}
}
s.True(wasLimited)
}
func (s *quotasSuite) TestPerShardNamespaceRateLimiter_DoesLimit() {
perShardNamespaceMaxRPS := func(namespace string) int { return 1 }
hostMaxRPS := func() int { return 1 }
operatorRPSRatioFn := func() float64 { return 0.2 }
limiter := newPerShardPerNamespacePriorityRateLimiter(perShardNamespaceMaxRPS, hostMaxRPS, RequestPriorityFn, operatorRPSRatioFn)
request := quotas.NewRequest(
"test-api",
1,
"test-namespace",
"api",
1,
"frontend",
)
requestTime := time.Now()
wasLimited := false
for i := 0; i < 2; i++ {
if !limiter.Allow(requestTime, request) {
wasLimited = true
}
}
s.True(wasLimited)
}
func (s *quotasSuite) TestOperatorPrioritized() {
rateFn := func() float64 { return 5 }
operatorRPSRatioFn := func() float64 { return 0.2 }
limiter := newPriorityRateLimiter(rateFn, RequestPriorityFn, operatorRPSRatioFn)
operatorRequest := quotas.NewRequest(
"DescribeWorkflowExecution",
1,
"test-namespace",
headers.CallerTypeOperator,
-1,
"DescribeWorkflowExecution")
apiRequest := quotas.NewRequest(
"DescribeWorkflowExecution",
1,
"test-namespace",
headers.CallerTypeAPI,
-1,
"DescribeWorkflowExecution")
requestTime := time.Now()
wasLimited := false
for i := 0; i < 6; i++ {
if !limiter.Allow(requestTime, apiRequest) {
wasLimited = true
s.True(limiter.Allow(requestTime, operatorRequest))
}
}
s.True(wasLimited)
}