Files
Rodrigo Zhouandrodrigozhou 098c12a669 Validate search attributes values in queries to ES (#5036)
<!-- Describe what has changed in this PR -->
**What changed?**
Validate search attribute values in the SQL query to ES visibility store

<!-- Tell your future self why have you made these changes -->
**Why?**
Better error handling for UX

<!-- How have you verified this change? Tested locally? Added a unit
test? Checked in staging env? -->
**How did you test it?**
Updated unit tests.

<!-- Assuming the worst case, what can be broken when deploying this
change to production? -->
**Potential risks**
No.

<!-- Is this PR a hotfix candidate or require that a notification be
sent to the broader community? (Yes/No) -->
**Is hotfix candidate?**
No.
2023-10-30 20:41:19 -05:00

354 lines
10 KiB
Go

// The MIT License
//
// Copyright (c) 2020 Temporal Technologies Inc. All rights reserved.
//
// Copyright (c) 2020 Uber Technologies, Inc.
//
// Permission is hereby granted, free of charge, to any person obtaining a copy
// of this software and associated documentation files (the "Software"), to deal
// in the Software without restriction, including without limitation the rights
// to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
// copies of the Software, and to permit persons to whom the Software is
// furnished to do so, subject to the following conditions:
//
// The above copyright notice and this permission notice shall be included in
// all copies or substantial portions of the Software.
//
// THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
// IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
// FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
// AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
// LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
// OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
// THE SOFTWARE.
package visibility
import (
"go.temporal.io/server/common/config"
"go.temporal.io/server/common/dynamicconfig"
"go.temporal.io/server/common/log"
"go.temporal.io/server/common/metrics"
"go.temporal.io/server/common/persistence/sql/sqlplugin/mysql"
"go.temporal.io/server/common/persistence/sql/sqlplugin/postgresql"
"go.temporal.io/server/common/persistence/sql/sqlplugin/sqlite"
"go.temporal.io/server/common/persistence/visibility/manager"
"go.temporal.io/server/common/persistence/visibility/store"
"go.temporal.io/server/common/persistence/visibility/store/elasticsearch"
esclient "go.temporal.io/server/common/persistence/visibility/store/elasticsearch/client"
"go.temporal.io/server/common/persistence/visibility/store/sql"
"go.temporal.io/server/common/persistence/visibility/store/standard"
"go.temporal.io/server/common/persistence/visibility/store/standard/cassandra"
standardSql "go.temporal.io/server/common/persistence/visibility/store/standard/sql"
"go.temporal.io/server/common/resolver"
"go.temporal.io/server/common/searchattribute"
)
func NewManager(
persistenceCfg config.Persistence,
persistenceResolver resolver.ServiceResolver,
esClient esclient.Client,
esProcessorConfig *elasticsearch.ProcessorConfig,
searchAttributesProvider searchattribute.Provider,
searchAttributesMapperProvider searchattribute.MapperProvider,
maxReadQPS dynamicconfig.IntPropertyFn,
maxWriteQPS dynamicconfig.IntPropertyFn,
operatorRPSRatio dynamicconfig.FloatPropertyFn,
enableReadFromSecondaryVisibility dynamicconfig.BoolPropertyFnWithNamespaceFilter,
secondaryVisibilityWritingMode dynamicconfig.StringPropertyFn,
visibilityDisableOrderByClause dynamicconfig.BoolPropertyFnWithNamespaceFilter,
visibilityEnableManualPagination dynamicconfig.BoolPropertyFnWithNamespaceFilter,
metricsHandler metrics.Handler,
logger log.Logger,
) (manager.VisibilityManager, error) {
visibilityManager, err := newVisibilityManagerFromDataStoreConfig(
persistenceCfg.GetVisibilityStoreConfig(),
persistenceResolver,
esClient,
esProcessorConfig,
searchAttributesProvider,
searchAttributesMapperProvider,
maxReadQPS,
maxWriteQPS,
operatorRPSRatio,
visibilityDisableOrderByClause,
visibilityEnableManualPagination,
metricsHandler,
logger,
)
if err != nil {
return nil, err
}
if visibilityManager == nil {
logger.Fatal("invalid config: visibility store must be configured")
return nil, nil
}
secondaryVisibilityManager, err := newVisibilityManagerFromDataStoreConfig(
persistenceCfg.GetSecondaryVisibilityStoreConfig(),
persistenceResolver,
esClient,
esProcessorConfig,
searchAttributesProvider,
searchAttributesMapperProvider,
maxReadQPS,
maxWriteQPS,
operatorRPSRatio,
visibilityDisableOrderByClause,
visibilityEnableManualPagination,
metricsHandler,
logger,
)
if err != nil {
return nil, err
}
if secondaryVisibilityManager != nil {
isPrimaryAdvancedSQL := false
isSecondaryAdvancedSQL := false
switch visibilityManager.GetStoreNames()[0] {
case mysql.PluginNameV8, postgresql.PluginNameV12, sqlite.PluginName:
isPrimaryAdvancedSQL = true
}
switch secondaryVisibilityManager.GetStoreNames()[0] {
case mysql.PluginNameV8, postgresql.PluginNameV12, sqlite.PluginName:
isSecondaryAdvancedSQL = true
}
if isPrimaryAdvancedSQL && !isSecondaryAdvancedSQL {
logger.Fatal("invalid config: dual visibility combination not supported")
return nil, nil
}
managerSelector := newDefaultManagerSelector(
visibilityManager,
secondaryVisibilityManager,
enableReadFromSecondaryVisibility,
secondaryVisibilityWritingMode,
)
return NewVisibilityManagerDual(
visibilityManager,
secondaryVisibilityManager,
managerSelector,
), nil
}
return visibilityManager, nil
}
func newVisibilityManager(
visStore store.VisibilityStore,
maxReadQPS dynamicconfig.IntPropertyFn,
maxWriteQPS dynamicconfig.IntPropertyFn,
operatorRPSRatio dynamicconfig.FloatPropertyFn,
metricsHandler metrics.Handler,
tag metrics.Tag,
logger log.Logger,
) manager.VisibilityManager {
if visStore == nil {
return nil
}
var visManager manager.VisibilityManager = newVisibilityManagerImpl(visStore, logger)
// wrap with rate limiter
visManager = NewVisibilityManagerRateLimited(
visManager,
maxReadQPS,
maxWriteQPS,
operatorRPSRatio)
// wrap with metrics client
visManager = NewVisibilityManagerMetrics(
visManager,
metricsHandler,
logger,
tag)
return visManager
}
//nolint:revive // too many arguments
func newVisibilityManagerFromDataStoreConfig(
dsConfig config.DataStore,
persistenceResolver resolver.ServiceResolver,
esClient esclient.Client,
esProcessorConfig *elasticsearch.ProcessorConfig,
searchAttributesProvider searchattribute.Provider,
searchAttributesMapperProvider searchattribute.MapperProvider,
maxReadQPS dynamicconfig.IntPropertyFn,
maxWriteQPS dynamicconfig.IntPropertyFn,
operatorRPSRatio dynamicconfig.FloatPropertyFn,
visibilityDisableOrderByClause dynamicconfig.BoolPropertyFnWithNamespaceFilter,
visibilityEnableManualPagination dynamicconfig.BoolPropertyFnWithNamespaceFilter,
metricsHandler metrics.Handler,
logger log.Logger,
) (manager.VisibilityManager, error) {
visStore, err := newVisibilityStoreFromDataStoreConfig(
dsConfig,
persistenceResolver,
esClient,
esProcessorConfig,
searchAttributesProvider,
searchAttributesMapperProvider,
visibilityDisableOrderByClause,
visibilityEnableManualPagination,
metricsHandler,
logger,
)
if err != nil {
return nil, err
}
if visStore == nil {
return nil, nil
}
return newVisibilityManager(
visStore,
maxReadQPS,
maxWriteQPS,
operatorRPSRatio,
metricsHandler,
metrics.AdvancedVisibilityTypeTag(),
logger,
), nil
}
func newVisibilityStoreFromDataStoreConfig(
dsConfig config.DataStore,
persistenceResolver resolver.ServiceResolver,
esClient esclient.Client,
esProcessorConfig *elasticsearch.ProcessorConfig,
searchAttributesProvider searchattribute.Provider,
searchAttributesMapperProvider searchattribute.MapperProvider,
visibilityDisableOrderByClause dynamicconfig.BoolPropertyFnWithNamespaceFilter,
visibilityEnableManualPagination dynamicconfig.BoolPropertyFnWithNamespaceFilter,
metricsHandler metrics.Handler,
logger log.Logger,
) (store.VisibilityStore, error) {
var (
visStore store.VisibilityStore
err error
)
if dsConfig.SQL != nil {
switch dsConfig.SQL.PluginName {
case mysql.PluginNameV8, postgresql.PluginNameV12, sqlite.PluginName:
visStore, err = sql.NewSQLVisibilityStore(
*dsConfig.SQL,
persistenceResolver,
searchAttributesProvider,
searchAttributesMapperProvider,
logger,
)
default:
visStore, err = newStandardVisibilityStore(
dsConfig,
persistenceResolver,
searchAttributesProvider,
searchAttributesMapperProvider,
logger,
)
}
} else if dsConfig.Cassandra != nil {
visStore, err = newStandardVisibilityStore(
dsConfig,
persistenceResolver,
searchAttributesProvider,
searchAttributesMapperProvider,
logger,
)
} else if dsConfig.Elasticsearch != nil {
visStore = newElasticsearchVisibilityStore(
dsConfig.Elasticsearch.GetVisibilityIndex(),
esClient,
esProcessorConfig,
searchAttributesProvider,
searchAttributesMapperProvider,
visibilityDisableOrderByClause,
visibilityEnableManualPagination,
metricsHandler,
logger,
)
}
return visStore, err
}
func newStandardVisibilityStore(
dsConfig config.DataStore,
persistenceResolver resolver.ServiceResolver,
searchAttributesProvider searchattribute.Provider,
searchAttributesMapperProvider searchattribute.MapperProvider,
logger log.Logger,
) (store.VisibilityStore, error) {
var (
visStore store.VisibilityStore
err error
)
if dsConfig.Cassandra != nil {
visStore, err = cassandra.NewVisibilityStore(
*dsConfig.Cassandra,
persistenceResolver,
logger,
)
} else if dsConfig.SQL != nil {
visStore, err = standardSql.NewSQLVisibilityStore(
*dsConfig.SQL,
persistenceResolver,
logger,
)
}
if err != nil {
return nil, err
}
if visStore == nil {
logger.Fatal("invalid config: one of cassandra or sql params must be specified for visibility store")
return nil, nil
}
return standard.NewVisibilityStore(
visStore,
searchAttributesProvider,
searchAttributesMapperProvider,
), nil
}
func newElasticsearchVisibilityStore(
defaultIndexName string,
esClient esclient.Client,
esProcessorConfig *elasticsearch.ProcessorConfig,
searchAttributesProvider searchattribute.Provider,
searchAttributesMapperProvider searchattribute.MapperProvider,
visibilityDisableOrderByClause dynamicconfig.BoolPropertyFnWithNamespaceFilter,
visibilityEnableManualPagination dynamicconfig.BoolPropertyFnWithNamespaceFilter,
metricsHandler metrics.Handler,
logger log.Logger,
) store.VisibilityStore {
if esClient == nil {
return nil
}
var (
esProcessor elasticsearch.Processor
esProcessorAckTimeout dynamicconfig.DurationPropertyFn
)
if esProcessorConfig != nil {
esProcessor = elasticsearch.NewProcessor(esProcessorConfig, esClient, logger, metricsHandler)
esProcessor.Start()
esProcessorAckTimeout = esProcessorConfig.ESProcessorAckTimeout
}
s := elasticsearch.NewVisibilityStore(
esClient,
defaultIndexName,
searchAttributesProvider,
searchAttributesMapperProvider,
esProcessor,
esProcessorAckTimeout,
visibilityDisableOrderByClause,
visibilityEnableManualPagination,
metricsHandler)
return s
}