Files
tasks/common/quotas/cluster_aware_quota_calculator.go
Michael SnowdenandGitHub da2f343898 Refactor CalculateEffectiveResourceLimit and NamespaceCountLimitInterceptor (#4665)
<!-- Describe what has changed in this PR -->
**What changed?**
I renamed and restructured the quotas.CalculateEffectiveResourceLimit
function and quotas. NamespaceCountLimitInterceptor struct.

<!-- Tell your future self why have you made these changes -->
**Why?**
For NamespaceCountLimitInterceptor , I think `NamespaceCount` doesn't
really explain what it does. For CalculateEffectiveResourceLimit, I
think this object is a bit easier to use.

<!-- How have you verified this change? Tested locally? Added a unit
test? Checked in staging env? -->
**How did you test it?**
Existing tests (which were also refactored).

<!-- Assuming the worst case, what can be broken when deploying this
change to production? -->
**Potential risks**
No behavioral changes.

<!-- Is this PR a hotfix candidate or require that a notification be
sent to the broader community? (Yes/No) -->
**Is hotfix candidate?**
2023-07-26 14:03:18 -07:00

70 lines
3.3 KiB
Go

// The MIT License
//
// Copyright (c) 2020 Temporal Technologies Inc. All rights reserved.
//
// Copyright (c) 2020 Uber Technologies, Inc.
//
// Permission is hereby granted, free of charge, to any person obtaining a copy
// of this software and associated documentation files (the "Software"), to deal
// in the Software without restriction, including without limitation the rights
// to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
// copies of the Software, and to permit persons to whom the Software is
// furnished to do so, subject to the following conditions:
//
// The above copyright notice and this permission notice shall be included in
// all copies or substantial portions of the Software.
//
// THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
// IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
// FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
// AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
// LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
// OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
// THE SOFTWARE.
package quotas
type (
// MemberCounter returns the total number of instances there are for a given service.
MemberCounter interface {
MemberCount() int
}
// ClusterAwareQuotaCalculator calculates the available quota for the current host based on the per instance and per
// cluster quota. The quota could represent requests per second, total number of active requests, etc. It works by
// dividing the per cluster quota by the total number of instances running the same service.
ClusterAwareQuotaCalculator quotaCalculator[func() int]
// ClusterAwareNamespaceSpecificQuotaCalculator is similar to ClusterAwareQuotaCalculator, but it uses quotas that
// are specific to a namespace.
ClusterAwareNamespaceSpecificQuotaCalculator quotaCalculator[func(namespace string) int]
// quotaCalculator is a generic type that we use because the quota functions could be namespace specific or not.
quotaCalculator[T any] struct {
MemberCounter MemberCounter
// PerInstanceQuota is a function that returns the per instance limit.
PerInstanceQuota T
// GlobalQuota is a function that returns the per cluster limit.
GlobalQuota T
}
)
// getQuota returns the effective resource limit for a host given the per instance and per cluster
// limits. The "resource" here could be requests per second, total number of active requests, etc. The cluster-wide
// limit is used if and only if it is configured to a value greater than zero and the number of instances that
// the memberCounter reports is greater than zero. Otherwise, the per-instance limit is used.
func getQuota(memberCounter MemberCounter, instanceLimit, clusterLimit int) float64 {
if clusterLimit > 0 && memberCounter != nil {
if clusterSize := memberCounter.MemberCount(); clusterSize > 0 {
return float64(clusterLimit) / float64(clusterSize)
}
}
return float64(instanceLimit)
}
func (l ClusterAwareQuotaCalculator) GetQuota() float64 {
return getQuota(l.MemberCounter, l.PerInstanceQuota(), l.GlobalQuota())
}
func (l ClusterAwareNamespaceSpecificQuotaCalculator) GetQuota(namespace string) float64 {
return getQuota(l.MemberCounter, l.PerInstanceQuota(namespace), l.GlobalQuota(namespace))
}