mirror of
https://github.com/hanzoai/tasks.git
synced 2026-11-03 03:56:04 +00:00
Michael SnowdenandGitHub
da2f343898
<!-- Describe what has changed in this PR --> **What changed?** I renamed and restructured the quotas.CalculateEffectiveResourceLimit function and quotas. NamespaceCountLimitInterceptor struct. <!-- Tell your future self why have you made these changes --> **Why?** For NamespaceCountLimitInterceptor , I think `NamespaceCount` doesn't really explain what it does. For CalculateEffectiveResourceLimit, I think this object is a bit easier to use. <!-- How have you verified this change? Tested locally? Added a unit test? Checked in staging env? --> **How did you test it?** Existing tests (which were also refactored). <!-- Assuming the worst case, what can be broken when deploying this change to production? --> **Potential risks** No behavioral changes. <!-- Is this PR a hotfix candidate or require that a notification be sent to the broader community? (Yes/No) --> **Is hotfix candidate?**
125 lines
3.5 KiB
Go
125 lines
3.5 KiB
Go
// The MIT License
|
|
//
|
|
// Copyright (c) 2020 Temporal Technologies Inc. All rights reserved.
|
|
//
|
|
// Copyright (c) 2020 Uber Technologies, Inc.
|
|
//
|
|
// Permission is hereby granted, free of charge, to any person obtaining a copy
|
|
// of this software and associated documentation files (the "Software"), to deal
|
|
// in the Software without restriction, including without limitation the rights
|
|
// to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
|
|
// copies of the Software, and to permit persons to whom the Software is
|
|
// furnished to do so, subject to the following conditions:
|
|
//
|
|
// The above copyright notice and this permission notice shall be included in
|
|
// all copies or substantial portions of the Software.
|
|
//
|
|
// THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
|
|
// IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
|
|
// FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
|
|
// AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
|
|
// LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
|
|
// OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
|
|
// THE SOFTWARE.
|
|
|
|
package quotas_test
|
|
|
|
import (
|
|
"testing"
|
|
|
|
"github.com/stretchr/testify/assert"
|
|
"go.temporal.io/server/common/dynamicconfig"
|
|
"go.temporal.io/server/common/quotas"
|
|
"go.temporal.io/server/common/quotas/quotastest"
|
|
)
|
|
|
|
type quotaCalculatorTestCase struct {
|
|
name string
|
|
memberCounter quotas.MemberCounter
|
|
instanceLimit int
|
|
clusterLimit int
|
|
expected float64
|
|
}
|
|
|
|
var quotaCalculatorTestCases = []quotaCalculatorTestCase{
|
|
{
|
|
name: "both limits set",
|
|
memberCounter: quotastest.NewFakeMemberCounter(4),
|
|
instanceLimit: 10,
|
|
clusterLimit: 20,
|
|
expected: 5.0,
|
|
},
|
|
{
|
|
name: "no per cluster limit",
|
|
memberCounter: quotastest.NewFakeMemberCounter(4),
|
|
instanceLimit: 10,
|
|
clusterLimit: 0,
|
|
expected: 10.0,
|
|
},
|
|
{
|
|
name: "no hosts",
|
|
memberCounter: quotastest.NewFakeMemberCounter(0),
|
|
instanceLimit: 10,
|
|
clusterLimit: 20,
|
|
expected: 10.0,
|
|
},
|
|
{
|
|
name: "nil member counter",
|
|
memberCounter: nil,
|
|
instanceLimit: 10,
|
|
clusterLimit: 20,
|
|
expected: 10.0,
|
|
},
|
|
}
|
|
|
|
func TestClusterAwareQuotaCalculator_GetQuota(t *testing.T) {
|
|
t.Parallel()
|
|
|
|
for _, tc := range quotaCalculatorTestCases {
|
|
tc := tc
|
|
t.Run(tc.name, func(t *testing.T) {
|
|
t.Parallel()
|
|
|
|
assert.Equal(t, tc.expected, quotas.ClusterAwareQuotaCalculator{
|
|
MemberCounter: tc.memberCounter,
|
|
PerInstanceQuota: dynamicconfig.GetIntPropertyFn(tc.instanceLimit),
|
|
GlobalQuota: dynamicconfig.GetIntPropertyFn(tc.clusterLimit),
|
|
}.GetQuota())
|
|
|
|
})
|
|
}
|
|
}
|
|
|
|
type perNamespaceQuota struct {
|
|
t *testing.T
|
|
quota int
|
|
}
|
|
|
|
func (l perNamespaceQuota) getQuota(ns string) int {
|
|
if ns != "test-namespace" {
|
|
l.t.Errorf("unexpected namespace: %s", ns)
|
|
}
|
|
return l.quota
|
|
}
|
|
|
|
func TestClusterAwareNamespaceSpecificQuotaCalculator_GetQuota(t *testing.T) {
|
|
t.Parallel()
|
|
|
|
for _, tc := range quotaCalculatorTestCases {
|
|
tc := tc
|
|
t.Run(tc.name, func(t *testing.T) {
|
|
t.Parallel()
|
|
|
|
instanceLimit := perNamespaceQuota{t: t, quota: tc.instanceLimit}
|
|
|
|
clusterLimit := perNamespaceQuota{t: t, quota: tc.clusterLimit}
|
|
|
|
assert.Equal(t, tc.expected, quotas.ClusterAwareNamespaceSpecificQuotaCalculator{
|
|
MemberCounter: tc.memberCounter,
|
|
PerInstanceQuota: instanceLimit.getQuota,
|
|
GlobalQuota: clusterLimit.getQuota,
|
|
}.GetQuota("test-namespace"))
|
|
})
|
|
}
|
|
}
|