mirror of
https://github.com/hanzoai/tasks.git
synced 2026-10-04 02:04:03 +00:00
Yimin Chenandrodrigozhou
a21a18b6e9
<!-- Describe what has changed in this PR --> **What changed?** Add more action metrics for schedules and updates <!-- Tell your future self why have you made these changes --> **Why?** Add more actions <!-- How have you verified this change? Tested locally? Added a unit test? Checked in staging env? --> **How did you test it?** eye_balls <!-- Assuming the worst case, what can be broken when deploying this change to production? --> **Potential risks** No <!-- Is this PR a hotfix candidate or require that a notification be sent to the broader community? (Yes/No) --> **Is hotfix candidate?** No
120 lines
3.5 KiB
Go
120 lines
3.5 KiB
Go
// The MIT License
|
|
//
|
|
// Copyright (c) 2020 Temporal Technologies Inc. All rights reserved.
|
|
//
|
|
// Copyright (c) 2020 Uber Technologies, Inc.
|
|
//
|
|
// Permission is hereby granted, free of charge, to any person obtaining a copy
|
|
// of this software and associated documentation files (the "Software"), to deal
|
|
// in the Software without restriction, including without limitation the rights
|
|
// to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
|
|
// copies of the Software, and to permit persons to whom the Software is
|
|
// furnished to do so, subject to the following conditions:
|
|
//
|
|
// The above copyright notice and this permission notice shall be included in
|
|
// all copies or substantial portions of the Software.
|
|
//
|
|
// THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
|
|
// IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
|
|
// FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
|
|
// AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
|
|
// LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
|
|
// OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
|
|
// THE SOFTWARE.
|
|
|
|
package interceptor
|
|
|
|
import (
|
|
"testing"
|
|
|
|
"github.com/golang/mock/gomock"
|
|
"github.com/stretchr/testify/assert"
|
|
|
|
"go.temporal.io/server/common/api"
|
|
"go.temporal.io/server/common/log"
|
|
"go.temporal.io/server/common/metrics"
|
|
"go.temporal.io/server/common/namespace"
|
|
)
|
|
|
|
const (
|
|
startWorkflow = "StartWorkflowExecution"
|
|
queryWorkflow = "QueryWorkflow"
|
|
)
|
|
|
|
func TestEmitActionMetric(t *testing.T) {
|
|
controller := gomock.NewController(t)
|
|
register := namespace.NewMockRegistry(controller)
|
|
metricsHandler := metrics.NewMockHandler(controller)
|
|
telemetry := NewTelemetryInterceptor(register, metricsHandler, log.NewNoopLogger())
|
|
|
|
testCases := []struct {
|
|
methodName string
|
|
fullName string
|
|
expectEmitMetrics bool
|
|
}{
|
|
{
|
|
queryWorkflow,
|
|
api.WorkflowServicePrefix + queryWorkflow,
|
|
true,
|
|
},
|
|
{
|
|
queryWorkflow,
|
|
api.AdminServicePrefix + queryWorkflow,
|
|
false,
|
|
},
|
|
{
|
|
metrics.MatchingClientAddWorkflowTaskScope,
|
|
api.WorkflowServicePrefix + queryWorkflow,
|
|
false,
|
|
},
|
|
}
|
|
|
|
for _, tt := range testCases {
|
|
t.Run(tt.methodName, func(t *testing.T) {
|
|
if tt.expectEmitMetrics {
|
|
metricsHandler.EXPECT().Counter(gomock.Any()).Return(metrics.NoopCounterMetricFunc).Times(1)
|
|
} else {
|
|
metricsHandler.EXPECT().Counter(gomock.Any()).Return(metrics.NoopCounterMetricFunc).Times(0)
|
|
}
|
|
telemetry.emitActionMetric(tt.methodName, tt.fullName, nil, metricsHandler, nil)
|
|
})
|
|
}
|
|
}
|
|
|
|
func TestOperationOverwrite(t *testing.T) {
|
|
controller := gomock.NewController(t)
|
|
register := namespace.NewMockRegistry(controller)
|
|
metricsHandler := metrics.NewMockHandler(controller)
|
|
telemetry := NewTelemetryInterceptor(register, metricsHandler, log.NewNoopLogger())
|
|
|
|
testCases := []struct {
|
|
methodName string
|
|
fullName string
|
|
expectedOperation string
|
|
}{
|
|
{
|
|
"DeleteWorkflowExecution",
|
|
api.AdminServicePrefix + "DeleteWorkflowExecution",
|
|
"AdminDeleteWorkflowExecution",
|
|
},
|
|
{
|
|
"DeleteNamespace",
|
|
api.OperatorServicePrefix + "DeleteNamespace",
|
|
"OperatorDeleteNamespace",
|
|
},
|
|
{
|
|
startWorkflow,
|
|
api.WorkflowServicePrefix + startWorkflow,
|
|
startWorkflow,
|
|
},
|
|
}
|
|
|
|
for _, tt := range testCases {
|
|
t.Run(tt.methodName, func(t *testing.T) {
|
|
operation := telemetry.overrideOperationTag(tt.fullName, tt.methodName)
|
|
assert.Equal(t, tt.expectedOperation, operation)
|
|
})
|
|
}
|
|
|
|
}
|