mirror of
https://github.com/hanzoai/tasks.git
synced 2026-10-30 14:56:19 +00:00
Yujie LiandGitHub
7bfa9585c8
<!-- Describe what has changed in this PR --> **What changed?** remove the cache initial size from lru cache and related configs. also refactor putInternal to better support different scenarios. and added more unittests for cache size. <!-- Tell your future self why have you made these changes --> **Why?** in https://github.com/temporalio/temporal/pull/4621 I change the history cache to use item bytes instead item count. However it accidentally touched default number of key when cache initialized <!-- How have you verified this change? Tested locally? Added a unit test? Checked in staging env? --> **How did you test it?** unittest <!-- Assuming the worst case, what can be broken when deploying this change to production? --> **Potential risks** Memory usage increase and pined mutable state will never leave the cache, which cause block workflow. <!-- Is this PR a hotfix candidate or require that a notification be sent to the broader community? (Yes/No) --> **Is hotfix candidate?**
98 lines
2.7 KiB
Go
98 lines
2.7 KiB
Go
// The MIT License
|
|
//
|
|
// Copyright (c) 2020 Temporal Technologies Inc. All rights reserved.
|
|
//
|
|
// Copyright (c) 2020 Uber Technologies, Inc.
|
|
//
|
|
// Permission is hereby granted, free of charge, to any person obtaining a copy
|
|
// of this software and associated documentation files (the "Software"), to deal
|
|
// in the Software without restriction, including without limitation the rights
|
|
// to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
|
|
// copies of the Software, and to permit persons to whom the Software is
|
|
// furnished to do so, subject to the following conditions:
|
|
//
|
|
// The above copyright notice and this permission notice shall be included in
|
|
// all copies or substantial portions of the Software.
|
|
//
|
|
// THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
|
|
// IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
|
|
// FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
|
|
// AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
|
|
// LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
|
|
// OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
|
|
// THE SOFTWARE.
|
|
|
|
package matching
|
|
|
|
import (
|
|
"time"
|
|
|
|
taskqueuepb "go.temporal.io/api/taskqueue/v1"
|
|
|
|
"go.temporal.io/server/common/cache"
|
|
)
|
|
|
|
const (
|
|
pollerHistoryInitMaxSize = 1000
|
|
pollerHistoryTTL = 5 * time.Minute
|
|
)
|
|
|
|
type (
|
|
pollerIdentity string
|
|
|
|
pollerInfo struct {
|
|
pollMetadata
|
|
}
|
|
)
|
|
|
|
type pollerHistory struct {
|
|
// poller ID -> pollerInfo
|
|
// pollers map[pollerID]pollerInfo
|
|
history cache.Cache
|
|
}
|
|
|
|
func newPollerHistory() *pollerHistory {
|
|
opts := &cache.Options{
|
|
TTL: pollerHistoryTTL,
|
|
Pin: false,
|
|
}
|
|
|
|
return &pollerHistory{
|
|
history: cache.New(pollerHistoryInitMaxSize, opts),
|
|
}
|
|
}
|
|
|
|
func (pollers *pollerHistory) updatePollerInfo(id pollerIdentity, pollMetadata *pollMetadata) {
|
|
pollers.history.Put(id, &pollerInfo{pollMetadata: *pollMetadata})
|
|
}
|
|
|
|
func (pollers *pollerHistory) getPollerInfo(earliestAccessTime time.Time) []*taskqueuepb.PollerInfo {
|
|
var result []*taskqueuepb.PollerInfo
|
|
|
|
ite := pollers.history.Iterator()
|
|
defer ite.Close()
|
|
for ite.HasNext() {
|
|
entry := ite.Next()
|
|
key := entry.Key().(pollerIdentity)
|
|
value := entry.Value().(*pollerInfo)
|
|
lastAccessTime := entry.CreateTime()
|
|
if earliestAccessTime.Before(lastAccessTime) {
|
|
result = append(result, &taskqueuepb.PollerInfo{
|
|
Identity: string(key),
|
|
LastAccessTime: &lastAccessTime,
|
|
RatePerSecond: defaultValue(value.ratePerSecond, defaultTaskDispatchRPS),
|
|
WorkerVersionCapabilities: value.workerVersionCapabilities,
|
|
})
|
|
}
|
|
}
|
|
|
|
return result
|
|
}
|
|
|
|
func defaultValue[T any, P ~*T](p P, def T) T {
|
|
if p == nil {
|
|
return def
|
|
}
|
|
return *p
|
|
}
|