mirror of
https://github.com/hanzoai/tasks.git
synced 2026-10-04 02:04:03 +00:00
David Reissandrodrigozhou
f173cdae2e
**What changed?** For workflows started by a schedule with "allow all" overlap policy, don't track them in running workflows in schedule info, and don't pass last completion result or continued failure. This means that "pause on failure", "last completion result", and "continued failure" won't be available for those workflows and their result/failure won't be tracked. Those features have somewhat confusing semantics in this case anyway since there's not an obvious "last" run when runs overlap. Note that the change is not enabled yet, this logic change will be included in a patch release to allow for downgrades, and enabled in 1.23.0. **Why?** The current implementation of schedules requires polling to get the open/closed status of tracked running workflows. With allow all, the number of running workflows is not bounded, and if the number grows very high, it would cause various system instability including overloading history and the schedule workflow itself being terminated due to event count. Ideally, we'd be able to offer bounded concurrent executions, but that will take more work so this is more of a quick fix. **How did you test it?** Updated existing tests **Potential risks** Users using that specific combination of features will have to find a new solution.