mirror of
https://github.com/hanzoai/tasks.git
synced 2026-10-04 02:04:03 +00:00
Rodrigo Zhouandrodrigozhou
cc5384dd74
## What changed? <!-- Describe what has changed in this PR --> Fix parse ExecutionDuration value as quoted integer. ## Why? <!-- Tell your future self why have you made these changes --> It used to work when querying `ExecutionDuration='123'`. ## How did you test it? <!-- How have you verified this change? Tested locally? Added a unit test? Checked in staging env? --> Added tests. ## Potential risks <!-- Assuming the worst case, what can be broken when deploying this change to production? --> ## Documentation <!-- Have you made sure this change doesn't falsify anything currently stated in `docs/`? If significant new behavior is added, have you described that in `docs/`? --> ## Is hotfix candidate? <!-- Is this PR a hotfix candidate or does it require a notification to be sent to the broader community? (Yes/No) -->
47 lines
1.9 KiB
Go
47 lines
1.9 KiB
Go
// The MIT License
|
|
//
|
|
// Copyright (c) 2024 Temporal Technologies Inc. All rights reserved.
|
|
//
|
|
// Permission is hereby granted, free of charge, to any person obtaining a copy
|
|
// of this software and associated documentation files (the "Software"), to deal
|
|
// in the Software without restriction, including without limitation the rights
|
|
// to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
|
|
// copies of the Software, and to permit persons to whom the Software is
|
|
// furnished to do so, subject to the following conditions:
|
|
//
|
|
// The above copyright notice and this permission notice shall be included in
|
|
// all copies or substantial portions of the Software.
|
|
//
|
|
// THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
|
|
// IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
|
|
// FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
|
|
// AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
|
|
// LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
|
|
// OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
|
|
// THE SOFTWARE.
|
|
|
|
package query
|
|
|
|
import (
|
|
"strconv"
|
|
"time"
|
|
|
|
"go.temporal.io/server/common/primitives/timestamp"
|
|
)
|
|
|
|
func ParseExecutionDurationStr(durationStr string) (time.Duration, error) {
|
|
if durationNanos, err := strconv.ParseInt(durationStr, 10, 64); err == nil {
|
|
return time.Duration(durationNanos), nil
|
|
}
|
|
|
|
// To support durations passed as golang durations such as "300ms", "-1.5h" or "2h45m".
|
|
// Valid time units are "ns", "us" (or "µs"), "ms", "s", "m", "h".
|
|
// Custom timestamp.ParseDuration also supports "d" as additional unit for days.
|
|
if duration, err := timestamp.ParseDuration(durationStr); err == nil {
|
|
return duration, nil
|
|
}
|
|
|
|
// To support "hh:mm:ss" durations.
|
|
return timestamp.ParseHHMMSSDuration(durationStr)
|
|
}
|