mirror of
https://github.com/hanzoai/tasks.git
synced 2026-10-04 02:04:03 +00:00
Rodrigo Zhouandrodrigozhou
86c2a15c43
## What changed? <!-- Describe what has changed in this PR --> Fix parse duration error type to be a ConverterError. ## Why? <!-- Tell your future self why have you made these changes --> If the parsing failed, it's an issue with user input, not an internal error. ## How did you test it? <!-- How have you verified this change? Tested locally? Added a unit test? Checked in staging env? --> Added tests to make sure errors returned by this function is always a ConverterError. ## Potential risks <!-- Assuming the worst case, what can be broken when deploying this change to production? --> ## Documentation <!-- Have you made sure this change doesn't falsify anything currently stated in `docs/`? If significant new behavior is added, have you described that in `docs/`? --> ## Is hotfix candidate? <!-- Is this PR a hotfix candidate or does it require a notification to be sent to the broader community? (Yes/No) -->
The primitives package is meant to contain definitions and constants that are widely used throughout this repository.
There should serve as the root package in that there should be no imports of any other Temporal package.