Files
tasks/common/quotas/rate_limiter_impl.go
Michael SnowdenandGitHub 1aa2cfd1bd Add a clocked rate limiter (#4591)
<!-- Describe what has changed in this PR -->
**What changed?**
Our RateLimiterImpl now uses a ClockedRateLimiter instead of a raw go
rate limiter which does not accept a clock.

<!-- Tell your future self why have you made these changes -->
**Why?**
To make unit testing / time skipping easier in the future, and to add
some test coverage.

<!-- How have you verified this change? Tested locally? Added a unit
test? Checked in staging env? -->
**How did you test it?**
I added a bunch of unit tests for the ClockedRateLimiter.

<!-- Assuming the worst case, what can be broken when deploying this
change to production? -->
**Potential risks**
1. If I missed something, we could be using system time instead of the
clock, and it would make downstream issues harder to debug
2. If there's a bug here, we could end up with a fauly rate limiter
which prevents any requests from going through
3. The tests aren't exactly trivial, so it could introduce a maintenance
burden

<!-- Is this PR a hotfix candidate or require that a notification be
sent to the broader community? (Yes/No) -->
**Is hotfix candidate?**
No
2023-09-05 17:30:26 -07:00

127 lines
3.3 KiB
Go

// The MIT License
//
// Copyright (c) 2020 Temporal Technologies Inc. All rights reserved.
//
// Copyright (c) 2020 Uber Technologies, Inc.
//
// Permission is hereby granted, free of charge, to any person obtaining a copy
// of this software and associated documentation files (the "Software"), to deal
// in the Software without restriction, including without limitation the rights
// to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
// copies of the Software, and to permit persons to whom the Software is
// furnished to do so, subject to the following conditions:
//
// The above copyright notice and this permission notice shall be included in
// all copies or substantial portions of the Software.
//
// THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
// IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
// FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
// AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
// LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
// OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
// THE SOFTWARE.
package quotas
import (
"sync"
"time"
"go.temporal.io/server/common/clock"
"golang.org/x/time/rate"
)
type (
// RateLimiterImpl is a wrapper around the golang rate limiter
RateLimiterImpl struct {
sync.RWMutex
rps float64
burst int
timeSource clock.TimeSource
ClockedRateLimiter
}
)
var _ RateLimiter = (*RateLimiterImpl)(nil)
// NewRateLimiter returns a new rate limiter that can handle dynamic
// configuration updates
func NewRateLimiter(newRPS float64, newBurst int) *RateLimiterImpl {
limiter := rate.NewLimiter(rate.Limit(newRPS), newBurst)
ts := clock.NewRealTimeSource()
rl := &RateLimiterImpl{
rps: newRPS,
burst: newBurst,
timeSource: ts,
ClockedRateLimiter: NewClockedRateLimiter(limiter, ts),
}
return rl
}
// SetRate set the rate of the rate limiter
func (rl *RateLimiterImpl) SetRPS(rps float64) {
rl.refreshInternalRateLimiterImpl(&rps, nil)
}
// SetBurst set the burst of the rate limiter
func (rl *RateLimiterImpl) SetBurst(burst int) {
rl.refreshInternalRateLimiterImpl(nil, &burst)
}
func (rl *RateLimiterImpl) Reserve() Reservation {
return rl.ClockedRateLimiter.Reserve()
}
func (rl *RateLimiterImpl) ReserveN(now time.Time, n int) Reservation {
return rl.ClockedRateLimiter.ReserveN(now, n)
}
// SetRateBurst set the rps & burst of the rate limiter
func (rl *RateLimiterImpl) SetRateBurst(rps float64, burst int) {
rl.refreshInternalRateLimiterImpl(&rps, &burst)
}
// Rate returns the rps for this rate limiter
func (rl *RateLimiterImpl) Rate() float64 {
rl.Lock()
defer rl.Unlock()
return rl.rps
}
// Burst returns the burst for this rate limiter
func (rl *RateLimiterImpl) Burst() int {
rl.Lock()
defer rl.Unlock()
return rl.burst
}
func (rl *RateLimiterImpl) refreshInternalRateLimiterImpl(
newRate *float64,
newBurst *int,
) {
rl.Lock()
defer rl.Unlock()
refresh := false
if newRate != nil && rl.rps != *newRate {
rl.rps = *newRate
refresh = true
}
if newBurst != nil && rl.burst != *newBurst {
rl.burst = *newBurst
refresh = true
}
if refresh {
now := rl.timeSource.Now()
rl.SetLimitAt(now, rate.Limit(rl.rps))
rl.SetBurstAt(now, rl.burst)
}
}