Files
tasks/common/rpc/interceptor/concurrent_request_limit.go
Michael SnowdenandGitHub c8668436e7 Add a With(Handler) method to all metricDefinition objects (#5187)
## What changed?
<!-- Describe what has changed in this PR -->
I created new structs that embed `metricDefinition` (e.g.
`histogramDefinition`), and I added a `With(Handler)` method to each of
them. I also added an example that migrates the usage of `Handler` to
this new approach, for one of each type of metric definition.

If this lands, I will also create an issue with the "good first issue"
tag to migrate all usage to the new approach. There's no need to do it
right away, though.

## Why?
<!-- Tell your future self why have you made these changes -->
Previously, usage of our `metrics.Handler` could be both redundant and
unsafe:
```
handler.Histogram( myHisto.Name(), myHisto.Unit() ).Record(...)
            │             │               └───┐
            │             │                   │
            └─────┐       └───────────┐       │
                  │                   │       │
   Redundant and Unsafe: 'Histogram'  │       │
   is specified despite knowing       │       │
   'myHisto' is a histogram. There's  │       │
   also a risk if 'myHisto.Name()'    │       │
   refers to a metric definition that │       │
   is not a histogram.                │       │
                                      └─── Redundant information
```

If you use the new `With(Handler)` method, there's no need to specify
redundant information.

## How did you test it?
<!-- How have you verified this change? Tested locally? Added a unit
test? Checked in staging env? -->
I added an `ExampleHandler` which tests all the new methods and also
serves as documentation on how to use the `Handler`, to encourage people
to use the new approach.

## Potential risks
<!-- Assuming the worst case, what can be broken when deploying this
change to production? -->
People can still use the old approach after this PR lands because we are
keeping the `Handler` interface as-is. However, we need to do that
because we can't break existing users / implementors.

## Is hotfix candidate?
<!-- Is this PR a hotfix candidate or does it require a notification to
be sent to the broader community? (Yes/No) -->
No.
2023-12-01 16:40:26 -08:00

147 lines
4.8 KiB
Go

// The MIT License
//
// Copyright (c) 2020 Temporal Technologies Inc. All rights reserved.
//
// Copyright (c) 2020 Uber Technologies, Inc.
//
// Permission is hereby granted, free of charge, to any person obtaining a copy
// of this software and associated documentation files (the "Software"), to deal
// in the Software without restriction, including without limitation the rights
// to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
// copies of the Software, and to permit persons to whom the Software is
// furnished to do so, subject to the following conditions:
//
// The above copyright notice and this permission notice shall be included in
// all copies or substantial portions of the Software.
//
// THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
// IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
// FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
// AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
// LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
// OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
// THE SOFTWARE.
package interceptor
import (
"context"
"sync"
"sync/atomic"
enumspb "go.temporal.io/api/enums/v1"
"go.temporal.io/api/serviceerror"
"go.temporal.io/api/workflowservice/v1"
"go.temporal.io/server/common/quotas"
"google.golang.org/grpc"
"go.temporal.io/server/common/log"
"go.temporal.io/server/common/metrics"
"go.temporal.io/server/common/namespace"
)
type (
// ConcurrentRequestLimitInterceptor intercepts requests to the server and enforces a limit on the number of
// requests that can be in-flight at any given time, according to the configured quotas.
ConcurrentRequestLimitInterceptor struct {
namespaceRegistry namespace.Registry
logger log.Logger
quotaCalculator quotas.ClusterAwareNamespaceSpecificQuotaCalculator
// tokens is a map of method name to the number of tokens that should be consumed for that method. If there is
// no entry for a method, then no tokens will be consumed, so the method will not be limited.
tokens map[string]int
sync.Mutex
activeTokensCount map[string]*int32
}
)
var (
_ grpc.UnaryServerInterceptor = (*ConcurrentRequestLimitInterceptor)(nil).Intercept
ErrNamespaceCountLimitServerBusy = serviceerror.NewResourceExhausted(enumspb.RESOURCE_EXHAUSTED_CAUSE_CONCURRENT_LIMIT, "namespace concurrent poller limit exceeded")
)
func NewConcurrentRequestLimitInterceptor(
namespaceRegistry namespace.Registry,
memberCounter quotas.MemberCounter,
logger log.Logger,
perInstanceQuota func(ns string) int,
globalQuota func(ns string) int,
tokens map[string]int,
) *ConcurrentRequestLimitInterceptor {
return &ConcurrentRequestLimitInterceptor{
namespaceRegistry: namespaceRegistry,
logger: logger,
quotaCalculator: quotas.ClusterAwareNamespaceSpecificQuotaCalculator{
MemberCounter: memberCounter,
PerInstanceQuota: perInstanceQuota,
GlobalQuota: globalQuota,
},
tokens: tokens,
activeTokensCount: make(map[string]*int32),
}
}
func (ni *ConcurrentRequestLimitInterceptor) Intercept(
ctx context.Context,
req interface{},
info *grpc.UnaryServerInfo,
handler grpc.UnaryHandler,
) (interface{}, error) {
_, methodName := SplitMethodName(info.FullMethod)
// token will default to 0
token := ni.tokens[methodName]
if token != 0 {
// for GetWorkflowExecutionHistoryRequest, we only care about long poll requests
longPollReq, ok := req.(*workflowservice.GetWorkflowExecutionHistoryRequest)
if ok && !longPollReq.WaitNewEvent {
// ignore non-long-poll GetHistory calls.
token = 0
}
}
if token != 0 {
nsName := MustGetNamespaceName(ni.namespaceRegistry, req)
counter := ni.counter(nsName, methodName)
count := atomic.AddInt32(counter, int32(token))
defer atomic.AddInt32(counter, -int32(token))
handler := GetMetricsHandlerFromContext(ctx, ni.logger)
metrics.ServicePendingRequests.With(handler).Record(float64(count))
// frontend.namespaceCount is applied per poller type temporarily to prevent
// one poller type to take all token waiting in the long poll.
if float64(count) > ni.quotaCalculator.GetQuota(nsName.String()) {
return nil, ErrNamespaceCountLimitServerBusy
}
}
return handler(ctx, req)
}
func (ni *ConcurrentRequestLimitInterceptor) counter(
namespace namespace.Name,
methodName string,
) *int32 {
key := ni.getTokenKey(namespace, methodName)
ni.Lock()
defer ni.Unlock()
counter, ok := ni.activeTokensCount[key]
if !ok {
counter = new(int32)
ni.activeTokensCount[key] = counter
}
return counter
}
func (ni *ConcurrentRequestLimitInterceptor) getTokenKey(
namespace namespace.Name,
methodName string,
) string {
return namespace.String() + "/" + methodName
}