Files
tasks/service/history/replication/dlq_writer_test.go
Prathyush PVandGitHub b27be0d446 Adding metrics when a task is enqueued to DLQ (#5120)
<!-- Describe what has changed in this PR -->
**What changed?**
Adding a metric when a task is written to DLQ.
Also added warning log with task details.

<!-- Tell your future self why have you made these changes -->
**Why?**
We will have to monitor this metric to see if there are any tasks in
DLQ.


<!-- How have you verified this change? Tested locally? Added a unit
test? Checked in staging env? -->
**How did you test it?**
Tested locally by making a workflow task fail.


<!-- Assuming the worst case, what can be broken when deploying this
change to production? -->
**Potential risks**


<!-- Is this PR a hotfix candidate or require that a notification be
sent to the broader community? (Yes/No) -->
**Is hotfix candidate?**
2023-11-15 23:19:24 +00:00

153 lines
5.3 KiB
Go

// The MIT License
//
// Copyright (c) 2020 Temporal Technologies Inc. All rights reserved.
//
// Copyright (c) 2020 Uber Technologies, Inc.
//
// Permission is hereby granted, free of charge, to any person obtaining a copy
// of this software and associated documentation files (the "Software"), to deal
// in the Software without restriction, including without limitation the rights
// to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
// copies of the Software, and to permit persons to whom the Software is
// furnished to do so, subject to the following conditions:
//
// The above copyright notice and this permission notice shall be included in
// all copies or substantial portions of the Software.
//
// THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
// IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
// FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
// AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
// LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
// OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
// THE SOFTWARE.
package replication_test
import (
"context"
"strings"
"testing"
"github.com/golang/mock/gomock"
"github.com/stretchr/testify/assert"
"github.com/stretchr/testify/require"
"go.temporal.io/server/common/log"
"go.temporal.io/server/common/metrics"
"go.temporal.io/server/common/namespace"
enumspb "go.temporal.io/server/api/enums/v1"
persistencespb "go.temporal.io/server/api/persistence/v1"
"go.temporal.io/server/common/cluster"
"go.temporal.io/server/common/persistence"
"go.temporal.io/server/common/persistence/serialization"
"go.temporal.io/server/service/history/queues"
"go.temporal.io/server/service/history/queues/queuestest"
"go.temporal.io/server/service/history/replication"
"go.temporal.io/server/service/history/tests"
)
type (
fakeExecutionManager struct {
requests []*persistence.PutReplicationTaskToDLQRequest
}
)
func TestNewExecutionManagerDLQWriter(t *testing.T) {
t.Parallel()
executionManager := &fakeExecutionManager{}
writer := replication.NewExecutionManagerDLQWriter(executionManager)
replicationTaskInfo := &persistencespb.ReplicationTaskInfo{
TaskId: 21,
}
err := writer.WriteTaskToDLQ(context.Background(), replication.DLQWriteRequest{
ShardID: 13,
SourceCluster: "test-source-cluster",
ReplicationTaskInfo: replicationTaskInfo,
})
require.NoError(t, err)
require.Len(t, executionManager.requests, 1)
request := executionManager.requests[0]
assert.Equal(t, 13, int(request.ShardID))
assert.Equal(t, "test-source-cluster", request.SourceClusterName)
assert.Equal(t, replicationTaskInfo, request.TaskInfo)
}
func TestNewDLQWriterAdapter(t *testing.T) {
t.Parallel()
for _, tc := range []struct {
name string
taskType enumspb.TaskType
expectErr bool
}{
{
name: "history replication task",
taskType: enumspb.TASK_TYPE_REPLICATION_HISTORY,
expectErr: false,
},
{
name: "unspecified task type",
taskType: enumspb.TASK_TYPE_UNSPECIFIED,
expectErr: true,
},
} {
tc := tc
t.Run(tc.name, func(t *testing.T) {
controller := gomock.NewController(t)
queueWriter := &queuestest.FakeQueueWriter{}
taskSerializer := serialization.NewTaskSerializer()
clusterMetadata := cluster.NewMockMetadata(controller)
clusterMetadata.EXPECT().GetAllClusterInfo().Return(map[string]cluster.ClusterInformation{
"test-source-cluster": {
ShardCount: 1,
},
}).AnyTimes()
namespaceRegistry := namespace.NewMockRegistry(controller)
namespaceRegistry.EXPECT().GetNamespaceByID(gomock.Any()).Return(&namespace.Namespace{}, nil).AnyTimes()
writer := replication.NewDLQWriterAdapter(
queues.NewDLQWriter(queueWriter, clusterMetadata, metrics.NoopMetricsHandler, log.NewTestLogger(), namespaceRegistry),
taskSerializer,
"test-current-cluster",
)
replicationTaskInfo := &persistencespb.ReplicationTaskInfo{
NamespaceId: string(tests.NamespaceID),
WorkflowId: tests.WorkflowID,
RunId: tests.RunID,
TaskType: tc.taskType,
TaskId: 21,
}
err := writer.WriteTaskToDLQ(context.Background(), replication.DLQWriteRequest{
ShardID: 13,
SourceCluster: "test-source-cluster",
ReplicationTaskInfo: replicationTaskInfo,
})
if tc.expectErr {
require.Error(t, err)
assert.Contains(t, strings.ToLower(err.Error()), "unknown replication task type")
assert.Empty(t, queueWriter.EnqueueTaskRequests)
} else {
require.NoError(t, err)
require.Len(t, queueWriter.EnqueueTaskRequests, 1)
request := queueWriter.EnqueueTaskRequests[0]
assert.Equal(t, string(tests.NamespaceID), request.Task.GetNamespaceID())
assert.Equal(t, tests.WorkflowID, request.Task.GetWorkflowID())
assert.Equal(t, tests.RunID, request.Task.GetRunID())
assert.Equal(t, 21, int(request.Task.GetTaskID()))
assert.Equal(t, "test-source-cluster", request.SourceCluster)
assert.Equal(t, "test-current-cluster", request.TargetCluster)
}
})
}
}
func (f *fakeExecutionManager) PutReplicationTaskToDLQ(
_ context.Context,
request *persistence.PutReplicationTaskToDLQRequest,
) error {
f.requests = append(f.requests, request)
return nil
}