mirror of
https://github.com/hanzoai/tasks.git
synced 2026-10-04 02:04:03 +00:00
Michael SnowdenandGitHub
936d4d14ad
<!-- Describe what has changed in this PR --> **What changed?** This PR adds support for re-enqueuing replication tasks from the DLQ back to their original queue for queue v2. <!-- Tell your future self why have you made these changes --> **Why?** Currently, we only support re-enqueuing history tasks for queue v2. Support wasn't added for replication tasks immediately for 2 reasons: 1. Testing it is *much* more complicated 2. It requires the ability to connect to a remote cluster <!-- How have you verified this change? Tested locally? Added a unit test? Checked in staging env? --> **How did you test it?** In addition to unit tests, there's an integration test which uses tdbg merge with queue v1, v2, and replication streaming enabled and disabled. It does this: 1. Execute a workflow with replication tasks that we override to return terminal errors 2. Verify that they all end up in the DLQ using tdbg dlq read 3. Use tdbg dlq merge to re-enqueue them all 4. Verify that the workflow now completes in the standby cluster <!-- Assuming the worst case, what can be broken when deploying this change to production? --> **Potential risks** This won't work if the original source cluster is no longer active, but I'll fix that in a follow-up PR because this isn't running in production yet, and I think that change will probably deserve its own dedicated review anyway. <!-- Is this PR a hotfix candidate or require that a notification be sent to the broader community? (Yes/No) --> **Is hotfix candidate?**
131 lines
4.1 KiB
Go
131 lines
4.1 KiB
Go
// The MIT License
|
|
//
|
|
// Copyright (c) 2020 Temporal Technologies Inc. All rights reserved.
|
|
//
|
|
// Copyright (c) 2020 Uber Technologies, Inc.
|
|
//
|
|
// Permission is hereby granted, free of charge, to any person obtaining a copy
|
|
// of this software and associated documentation files (the "Software"), to deal
|
|
// in the Software without restriction, including without limitation the rights
|
|
// to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
|
|
// copies of the Software, and to permit persons to whom the Software is
|
|
// furnished to do so, subject to the following conditions:
|
|
//
|
|
// The above copyright notice and this permission notice shall be included in
|
|
// all copies or substantial portions of the Software.
|
|
//
|
|
// THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
|
|
// IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
|
|
// FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
|
|
// AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
|
|
// LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
|
|
// OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
|
|
// THE SOFTWARE.
|
|
|
|
package replication
|
|
|
|
import (
|
|
"errors"
|
|
"math/rand"
|
|
"testing"
|
|
"time"
|
|
|
|
"github.com/golang/mock/gomock"
|
|
"github.com/stretchr/testify/require"
|
|
"github.com/stretchr/testify/suite"
|
|
"go.temporal.io/api/serviceerror"
|
|
|
|
"go.temporal.io/server/client"
|
|
"go.temporal.io/server/common/cluster"
|
|
"go.temporal.io/server/common/log"
|
|
"go.temporal.io/server/common/metrics"
|
|
"go.temporal.io/server/common/namespace"
|
|
"go.temporal.io/server/common/xdc"
|
|
"go.temporal.io/server/service/history/shard"
|
|
)
|
|
|
|
type (
|
|
executableUnknownTaskSuite struct {
|
|
suite.Suite
|
|
*require.Assertions
|
|
|
|
controller *gomock.Controller
|
|
clusterMetadata *cluster.MockMetadata
|
|
clientBean *client.MockBean
|
|
shardController *shard.MockController
|
|
namespaceCache *namespace.MockRegistry
|
|
ndcHistoryResender *xdc.MockNDCHistoryResender
|
|
metricsHandler metrics.Handler
|
|
logger log.Logger
|
|
eagerNamespaceRefresher *MockEagerNamespaceRefresher
|
|
|
|
taskID int64
|
|
task *ExecutableUnknownTask
|
|
}
|
|
)
|
|
|
|
func TestExecutableUnknownTaskSuite(t *testing.T) {
|
|
s := new(executableUnknownTaskSuite)
|
|
suite.Run(t, s)
|
|
}
|
|
|
|
func (s *executableUnknownTaskSuite) SetupSuite() {
|
|
s.Assertions = require.New(s.T())
|
|
}
|
|
|
|
func (s *executableUnknownTaskSuite) TearDownSuite() {
|
|
|
|
}
|
|
|
|
func (s *executableUnknownTaskSuite) SetupTest() {
|
|
s.controller = gomock.NewController(s.T())
|
|
s.clusterMetadata = cluster.NewMockMetadata(s.controller)
|
|
s.clientBean = client.NewMockBean(s.controller)
|
|
s.shardController = shard.NewMockController(s.controller)
|
|
s.namespaceCache = namespace.NewMockRegistry(s.controller)
|
|
s.ndcHistoryResender = xdc.NewMockNDCHistoryResender(s.controller)
|
|
s.metricsHandler = metrics.NoopMetricsHandler
|
|
s.logger = log.NewNoopLogger()
|
|
s.eagerNamespaceRefresher = NewMockEagerNamespaceRefresher(s.controller)
|
|
|
|
s.taskID = rand.Int63()
|
|
s.task = NewExecutableUnknownTask(
|
|
ProcessToolBox{
|
|
ClusterMetadata: s.clusterMetadata,
|
|
ClientBean: s.clientBean,
|
|
ShardController: s.shardController,
|
|
NamespaceCache: s.namespaceCache,
|
|
NDCHistoryResender: s.ndcHistoryResender,
|
|
MetricsHandler: s.metricsHandler,
|
|
Logger: s.logger,
|
|
EagerNamespaceRefresher: s.eagerNamespaceRefresher,
|
|
DLQWriter: NoopDLQWriter{},
|
|
},
|
|
s.taskID,
|
|
time.Unix(0, rand.Int63()),
|
|
nil,
|
|
)
|
|
}
|
|
|
|
func (s *executableUnknownTaskSuite) TearDownTest() {
|
|
s.controller.Finish()
|
|
}
|
|
|
|
func (s *executableUnknownTaskSuite) TestExecute() {
|
|
err := s.task.Execute()
|
|
s.IsType(serviceerror.NewInvalidArgument(""), err)
|
|
}
|
|
|
|
func (s *executableUnknownTaskSuite) TestHandleErr() {
|
|
err := errors.New("OwO")
|
|
s.Equal(err, s.task.HandleErr(err))
|
|
|
|
err = serviceerror.NewUnavailable("")
|
|
s.Equal(err, s.task.HandleErr(err))
|
|
}
|
|
|
|
func (s *executableUnknownTaskSuite) TestMarkPoisonPill() {
|
|
err := s.task.MarkPoisonPill()
|
|
s.NoError(err)
|
|
}
|