Files
tasks/service/history/service.go
Stephan BehnkeandGitHub 8d0f75baf1 🧹 remove calls to rand.Seed (#4954)
<!-- Describe what has changed in this PR -->
**What changed?**

Removed all calls to `rand.Seed` with a _random_ initialization value.

<!-- Tell your future self why have you made these changes -->
**Why?**

Less code is better.

[From the docs](https://pkg.go.dev/math/rand#Seed):

> If Seed is not called, the generator is seeded randomly at program
startup.

> Prior to Go 1.20, the generator was seeded like Seed(1) at program
startup. [...]

> Deprecated: **As of Go 1.20 there is no reason to call Seed with a
random value**. [...]

<!-- How have you verified this change? Tested locally? Added a unit
test? Checked in staging env? -->
**How did you test it?**

Existing tests.

<!-- Assuming the worst case, what can be broken when deploying this
change to production? -->
**Potential risks**

According to the docs, this is a no-op change in terms of behaviour.

<!-- Is this PR a hotfix candidate or require that a notification be
sent to the broader community? (Yes/No) -->
**Is hotfix candidate?**

No.
2023-10-10 14:34:15 -07:00

150 lines
5.2 KiB
Go

// The MIT License
//
// Copyright (c) 2020 Temporal Technologies Inc. All rights reserved.
//
// Copyright (c) 2020 Uber Technologies, Inc.
//
// Permission is hereby granted, free of charge, to any person obtaining a copy
// of this software and associated documentation files (the "Software"), to deal
// in the Software without restriction, including without limitation the rights
// to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
// copies of the Software, and to permit persons to whom the Software is
// furnished to do so, subject to the following conditions:
//
// The above copyright notice and this permission notice shall be included in
// all copies or substantial portions of the Software.
//
// THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
// IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
// FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
// AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
// LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
// OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
// THE SOFTWARE.
package history
import (
"net"
"time"
"google.golang.org/grpc"
"google.golang.org/grpc/health"
healthpb "google.golang.org/grpc/health/grpc_health_v1"
"go.temporal.io/server/api/historyservice/v1"
"go.temporal.io/server/common/log"
"go.temporal.io/server/common/log/tag"
"go.temporal.io/server/common/membership"
"go.temporal.io/server/common/metrics"
"go.temporal.io/server/common/persistence/client"
"go.temporal.io/server/common/persistence/visibility/manager"
"go.temporal.io/server/service/history/configs"
)
// Service represents the history service
type (
Service struct {
handler *Handler
visibilityManager manager.VisibilityManager
config *configs.Config
server *grpc.Server
logger log.Logger
grpcListener net.Listener
membershipMonitor membership.Monitor
faultInjectionDataStoreFactory *client.FaultInjectionDataStoreFactory
metricsHandler metrics.Handler
healthServer *health.Server
}
)
func NewService(
grpcServerOptions []grpc.ServerOption,
serviceConfig *configs.Config,
visibilityMgr manager.VisibilityManager,
handler *Handler,
logger log.Logger,
grpcListener net.Listener,
membershipMonitor membership.Monitor,
metricsHandler metrics.Handler,
faultInjectionDataStoreFactory *client.FaultInjectionDataStoreFactory,
healthServer *health.Server,
) *Service {
return &Service{
server: grpc.NewServer(grpcServerOptions...),
handler: handler,
visibilityManager: visibilityMgr,
config: serviceConfig,
logger: logger,
grpcListener: grpcListener,
membershipMonitor: membershipMonitor,
metricsHandler: metricsHandler,
faultInjectionDataStoreFactory: faultInjectionDataStoreFactory,
healthServer: healthServer,
}
}
// Start starts the service
func (s *Service) Start() {
s.logger.Info("history starting")
s.metricsHandler.Counter(metrics.RestartCount).Record(1)
s.handler.Start()
historyservice.RegisterHistoryServiceServer(s.server, s.handler)
healthpb.RegisterHealthServer(s.server, s.healthServer)
s.healthServer.SetServingStatus(serviceName, healthpb.HealthCheckResponse_SERVING)
go func() {
s.logger.Info("Starting to serve on history listener")
if err := s.server.Serve(s.grpcListener); err != nil {
s.logger.Fatal("Failed to serve on history listener", tag.Error(err))
}
}()
// As soon as we join membership, other hosts will send requests for shards that we own,
// so we should try to start this after starting the gRPC server.
go func() {
if delay := s.config.StartupMembershipJoinDelay(); delay > 0 {
// In some situations, like rolling upgrades of the history service,
// pausing before joining membership can help separate the shard movement
// caused by another history instance terminating with this instance starting.
s.logger.Info("history start: delaying before membership start",
tag.NewDurationTag("startupMembershipJoinDelay", delay))
time.Sleep(delay)
}
s.membershipMonitor.Start()
}()
}
// Stop stops the service
func (s *Service) Stop() {
s.logger.Info("ShutdownHandler: Evicting self from membership ring")
_ = s.membershipMonitor.EvictSelf()
if delay := s.config.ShutdownDrainDuration(); delay > 0 {
s.logger.Info("ShutdownHandler: delaying for shutdown drain",
tag.NewDurationTag("shutdownDrainDuration", delay))
time.Sleep(delay)
}
s.healthServer.SetServingStatus(serviceName, healthpb.HealthCheckResponse_NOT_SERVING)
s.logger.Info("ShutdownHandler: Initiating shardController shutdown")
s.handler.controller.Stop()
// TODO: Change this to GracefulStop when integration tests are refactored.
s.server.Stop()
s.handler.Stop()
s.visibilityManager.Close()
s.logger.Info("history stopped")
}
func (s *Service) GetFaultInjection() *client.FaultInjectionDataStoreFactory {
return s.faultInjectionDataStoreFactory
}