tasks

hanzoai/tasks

Fork 0

mirror of https://github.com/hanzoai/tasks.git synced 2026-10-30 14:56:19 +00:00

Files

T

History

Tim Deeb-SwihartandGitHub dae78a6d83 Rename metricDefinition getters to follow Go's guidelines (#5185 )

## What changed?
I renamed the getters on `metricDefinition` to follow go's guidelines.

## Why?
Not only does it save typing, it's better Go.

Quoth [Effective Go](https://go.dev/doc/effective_go#Getters):

> ...it's neither idiomatic nor necessary to put Get into the getter's
name. If you have a field called owner (lower case, unexported), the
getter method should be called Owner (upper case, exported), not
GetOwner.

## How did you test it?
Our current tests are sufficient

## Potential risks
None

## Is hotfix candidate?
No.

2023-11-30 16:34:29 -08:00

export_test.go

🧹 Update Workflow nits (#4964 )

2023-10-13 14:08:28 -07:00

README.md

Update APIs: server-imposed deadline expiry and non-blocking Update Poll (#5114 )

2023-11-16 17:48:49 -05:00

registry_test.go

Update APIs: server-imposed deadline expiry and non-blocking Update Poll (#5114 )

2023-11-16 17:48:49 -05:00

registry.go

🧹 Update Workflow nits (#4964 )

2023-10-13 14:08:28 -07:00

state.go

Update APIs: server-imposed deadline expiry and non-blocking Update Poll (#5114 )

2023-11-16 17:48:49 -05:00

update_test.go

Replace gogo/protobuf with google/protobuf (#5032 )

2023-11-21 15:19:37 -08:00

update.go

Replace gogo/protobuf with google/protobuf (#5032 )

2023-11-21 15:19:37 -08:00

util.go

Rename metricDefinition getters to follow Go's guidelines (#5185 )

2023-11-30 16:34:29 -08:00

validation.go

Replace gogo/protobuf with google/protobuf (#5032 )

2023-11-21 15:19:37 -08:00

version.go

Handle ProtocolMessageCommands in WFT completion (#4328 )

2023-05-15 14:37:54 -07:00

README.md

Update State Machine

The diagram below depicts the state machine implemented in update.go.

stateDiagram-v2
    [*] --> Admitted: New

    Admitted --> ProvisionallyRequested: onRequestMsg
    ProvisionallyRequested --> Requested: commit

    Requested --> ProvisionallyAccepted: onAcceptanceMsg
    ProvisionallyAccepted --> Accepted: commit

    Requested --> ProvisionallyCompleted: onRejectionMsg
    ProvisionallyCompleted --> Completed: commit

    ProvisionallyAccepted --> ProvisionallyCompleted: onResponse
    Accepted --> ProvisionallyCompleted: onResponse