Files
Anton RomanovichandGitHub e0e7da233d Add the ability to implement and test custom advanced visibility stores (#4871)
**What changed?**

Two things:
* `common/persistence/tests/visibility_persistence_suite_test.go`
renamed to `visibility_persistence_suite.go`, so that its
`VisibilityPersistenceSuite` could be imported and run by the
third-party package;
* `VisibilityStoreFactory` interface introduced. The server now accepts
`customVisibilityStoreFactory` and invokes it if visibility store
configuration points to `CustomDataStoreConfig`.

**Why?**

To be have an ability to implement and test custom advanced visibility
stores.

**How did you test it?**
Ran Temporal tests.
Also built and ran a Temporal server with
`temporal.WithCustomVisibilityStoreFactory(mypackage.NewMyVisibilityStoreFactory())`
option passed.

<!-- Assuming the worst case, what can be broken when deploying this
change to production? -->
**Potential risks**
None.

<!-- Is this PR a hotfix candidate or require that a notification be
sent to the broader community? (Yes/No) -->
**Is hotfix candidate?**
No.
2023-11-22 16:23:36 -06:00

217 lines
7.5 KiB
Go

// The MIT License
//
// Copyright (c) 2020 Temporal Technologies Inc. All rights reserved.
//
// Copyright (c) 2020 Uber Technologies, Inc.
//
// Permission is hereby granted, free of charge, to any person obtaining a copy
// of this software and associated documentation files (the "Software"), to deal
// in the Software without restriction, including without limitation the rights
// to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
// copies of the Software, and to permit persons to whom the Software is
// furnished to do so, subject to the following conditions:
//
// The above copyright notice and this permission notice shall be included in
// all copies or substantial portions of the Software.
//
// THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
// IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
// FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
// AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
// LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
// OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
// THE SOFTWARE.
package matching
import (
"go.uber.org/fx"
"go.temporal.io/server/common"
"go.temporal.io/server/common/cluster"
"go.temporal.io/server/common/config"
"go.temporal.io/server/common/dynamicconfig"
"go.temporal.io/server/common/log"
"go.temporal.io/server/common/membership"
"go.temporal.io/server/common/metrics"
"go.temporal.io/server/common/namespace"
"go.temporal.io/server/common/persistence"
"go.temporal.io/server/common/persistence/visibility"
"go.temporal.io/server/common/persistence/visibility/manager"
esclient "go.temporal.io/server/common/persistence/visibility/store/elasticsearch/client"
"go.temporal.io/server/common/primitives"
"go.temporal.io/server/common/resolver"
"go.temporal.io/server/common/resource"
"go.temporal.io/server/common/rpc/interceptor"
"go.temporal.io/server/common/searchattribute"
"go.temporal.io/server/service"
"go.temporal.io/server/service/matching/configs"
)
var Module = fx.Options(
resource.Module,
fx.Provide(dynamicconfig.NewCollection),
fx.Provide(ConfigProvider),
fx.Provide(PersistenceRateLimitingParamsProvider),
service.PersistenceLazyLoadedServiceResolverModule,
fx.Provide(ThrottledLoggerRpsFnProvider),
fx.Provide(RetryableInterceptorProvider),
fx.Provide(TelemetryInterceptorProvider),
fx.Provide(RateLimitInterceptorProvider),
fx.Provide(VisibilityManagerProvider),
fx.Provide(HandlerProvider),
fx.Provide(service.GrpcServerOptionsProvider),
fx.Provide(NamespaceReplicationQueueProvider),
fx.Provide(ServiceResolverProvider),
fx.Provide(NewService),
fx.Invoke(ServiceLifetimeHooks),
)
func ConfigProvider(
dc *dynamicconfig.Collection,
persistenceConfig config.Persistence,
) *Config {
return NewConfig(
dc,
persistenceConfig.StandardVisibilityConfigExist(),
persistenceConfig.AdvancedVisibilityConfigExist(),
)
}
func RetryableInterceptorProvider() *interceptor.RetryableInterceptor {
return interceptor.NewRetryableInterceptor(
common.CreateMatchingHandlerRetryPolicy(),
common.IsServiceHandlerRetryableError,
)
}
func TelemetryInterceptorProvider(
logger log.Logger,
namespaceRegistry namespace.Registry,
metricsHandler metrics.Handler,
) *interceptor.TelemetryInterceptor {
return interceptor.NewTelemetryInterceptor(
namespaceRegistry,
metricsHandler,
logger,
)
}
func ThrottledLoggerRpsFnProvider(serviceConfig *Config) resource.ThrottledLoggerRpsFn {
return func() float64 { return float64(serviceConfig.ThrottledLogRPS()) }
}
func RateLimitInterceptorProvider(
serviceConfig *Config,
) *interceptor.RateLimitInterceptor {
return interceptor.NewRateLimitInterceptor(
configs.NewPriorityRateLimiter(func() float64 { return float64(serviceConfig.RPS()) }, serviceConfig.OperatorRPSRatio),
map[string]int{},
)
}
// PersistenceRateLimitingParamsProvider is the same between services but uses different config sources.
// if-case comes from resourceImpl.New.
func PersistenceRateLimitingParamsProvider(
serviceConfig *Config,
persistenceLazyLoadedServiceResolver service.PersistenceLazyLoadedServiceResolver,
) service.PersistenceRateLimitingParams {
return service.NewPersistenceRateLimitingParams(
serviceConfig.PersistenceMaxQPS,
serviceConfig.PersistenceGlobalMaxQPS,
serviceConfig.PersistenceNamespaceMaxQPS,
serviceConfig.PersistenceGlobalNamespaceMaxQPS,
serviceConfig.PersistencePerShardNamespaceMaxQPS,
serviceConfig.EnablePersistencePriorityRateLimiting,
serviceConfig.OperatorRPSRatio,
serviceConfig.PersistenceDynamicRateLimitingParams,
persistenceLazyLoadedServiceResolver,
)
}
func ServiceResolverProvider(
membershipMonitor membership.Monitor,
) (membership.ServiceResolver, error) {
return membershipMonitor.GetResolver(primitives.MatchingService)
}
// TaskQueueReplicatorNamespaceReplicationQueue is used to ensure the replicator only gets set if global namespaces are
// enabled on this cluster. See NamespaceReplicationQueueProvider below.
type TaskQueueReplicatorNamespaceReplicationQueue persistence.NamespaceReplicationQueue
func NamespaceReplicationQueueProvider(
namespaceReplicationQueue persistence.NamespaceReplicationQueue,
clusterMetadata cluster.Metadata,
) TaskQueueReplicatorNamespaceReplicationQueue {
var replicatorNamespaceReplicationQueue persistence.NamespaceReplicationQueue
if clusterMetadata.IsGlobalNamespaceEnabled() {
replicatorNamespaceReplicationQueue = namespaceReplicationQueue
}
return replicatorNamespaceReplicationQueue
}
func VisibilityManagerProvider(
logger log.Logger,
persistenceConfig *config.Persistence,
customVisibilityStoreFactory visibility.VisibilityStoreFactory,
metricsHandler metrics.Handler,
serviceConfig *Config,
esClient esclient.Client,
persistenceServiceResolver resolver.ServiceResolver,
searchAttributesMapperProvider searchattribute.MapperProvider,
saProvider searchattribute.Provider,
) (manager.VisibilityManager, error) {
return visibility.NewManager(
*persistenceConfig,
persistenceServiceResolver,
customVisibilityStoreFactory,
esClient,
nil, // matching visibility never writes
saProvider,
searchAttributesMapperProvider,
serviceConfig.VisibilityPersistenceMaxReadQPS,
serviceConfig.VisibilityPersistenceMaxWriteQPS,
serviceConfig.OperatorRPSRatio,
serviceConfig.EnableReadFromSecondaryVisibility,
dynamicconfig.GetStringPropertyFn(visibility.SecondaryVisibilityWritingModeOff), // matching visibility never writes
serviceConfig.VisibilityDisableOrderByClause,
serviceConfig.VisibilityEnableManualPagination,
metricsHandler,
logger,
)
}
func HandlerProvider(
config *Config,
logger log.SnTaggedLogger,
throttledLogger log.ThrottledLogger,
taskManager persistence.TaskManager,
historyClient resource.HistoryClient,
matchingRawClient resource.MatchingRawClient,
matchingServiceResolver membership.ServiceResolver,
metricsHandler metrics.Handler,
namespaceRegistry namespace.Registry,
clusterMetadata cluster.Metadata,
namespaceReplicationQueue TaskQueueReplicatorNamespaceReplicationQueue,
visibilityManager manager.VisibilityManager,
) *Handler {
return NewHandler(
config,
logger,
throttledLogger,
taskManager,
historyClient,
matchingRawClient,
matchingServiceResolver,
metricsHandler,
namespaceRegistry,
clusterMetadata,
namespaceReplicationQueue,
visibilityManager,
)
}
func ServiceLifetimeHooks(lc fx.Lifecycle, svc *Service) {
lc.Append(fx.StartStopHook(svc.Start, svc.Stop))
}