Files
Tim Deeb-SwihartandGitHub 95169a53c3 Replace gogo/protobuf with google/protobuf (#5032)
**What changed?**

gogo/protobuf has been replaced with Google's official go compiler. 

**Why?**

gogo/protobuf has been deprecated for some time and the community is
moving on, building new tools (like vtproto) atop google's v2 compiler.

**How did you test it?**

`make test`

**Potential risks**

1. The change from embedded gogo-generated-structs to
google-generated-pointers-to-structs created a risk of nil pointer
exceptions. I've fixed all the ones our tests found but it's possible
there are more lurking in the new code.
2. This change may cause our performance to decrease. Certainly
encoding/deconding of proto objects will become slower, but the overuse
of pointers by the google compiler may negatively affect our overall
performance. We'll need to keep an eye on the GC stats
3. This breaks the HTTP API. We will not support [shortand payload
encoding](https://github.com/temporalio/proposals/blob/master/api/http-api.md#payload-formatting)
in this first pass; that will come once this initial work is in testing.

**Breaking changes for developers**

- `*time.Time` in proto structs will now be
[timestamppb.Timestamp](https://pkg.go.dev/google.golang.org/[email protected]/types/known/timestamppb#section-documentation)
- `*time.Duration` will now be
[durationpb.Duration](https://pkg.go.dev/google.golang.org/protobuf/types/known/durationpb)
- V2-generated structs embed locks, so you cannot dereference them. `go
vet` will scream at you about this. If you need a copy, use
`proto.Clone`.
- If the performance of this sucks then I will either update our code
generator to add shallow-clone methods or hand-roll the ones we need
- Proto enums will, when formatted to JSON, now be in
`SCREAMING_SNAKE_CASE` rather than `PascalCase`. We decided (in
discussion with the SDK team) that now was as good a time as any to rip
the bandage off.
- Proto objects, or objects embedding protos, cannot be compared using
`reflect.DeepEqual` or _anything_ that uses it. This includes `testify`
and `mock` equality testers!
- You will need to use the `common/testing/protorequire`,
`common/testing/protoassert`, or `common/testing/protomock` packages
instead. I've implemented proto-compatible matchers and assertions there
for all cases I've encountered
- If you need `reflect.DeepEqual` for any reason you can use
`go.temporal.io/api/temporalproto.DeepEqual` instead

Note that history loading will not be impacted by the JSON changes: I
rewrote history loading to dynamically fix incoming history JSON data
(like all our other sdks); you can find this code in [my fork of our go
API](https://github.com/tdeebswihart/temporal-api-go/blob/master/internal/temporalhistoryv1/load.go)
alongside its tests.

**🚨Sharp Edges Introduced🚨**

Beware `*timestamppb.Timestamp.AsTime()`. If you need to extract a time
value from a proto time (timestamppb) **always** make sure to check
whether it's nil first. When the proto object is `nil` `AsTime()` will
return a non-zero time at the proto epoch: UTC midnight on January 1,
1970.

I've made this mistake multiple times during this transition and each
time it's been a pain to debug

**Is hotfix candidate?**

No.
2023-11-21 15:19:37 -08:00

366 lines
10 KiB
Go

// The MIT License
//
// Copyright (c) 2020 Temporal Technologies Inc. All rights reserved.
//
// Copyright (c) 2020 Uber Technologies, Inc.
//
// Permission is hereby granted, free of charge, to any person obtaining a copy
// of this software and associated documentation files (the "Software"), to deal
// in the Software without restriction, including without limitation the rights
// to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
// copies of the Software, and to permit persons to whom the Software is
// furnished to do so, subject to the following conditions:
//
// The above copyright notice and this permission notice shall be included in
// all copies or substantial portions of the Software.
//
// THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
// IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
// FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
// AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
// LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
// OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
// THE SOFTWARE.
package scheduler
import (
"errors"
"fmt"
"math"
"strings"
"time"
"github.com/dgryski/go-farm"
schedpb "go.temporal.io/api/schedule/v1"
"go.temporal.io/server/common"
"go.temporal.io/server/common/primitives/timestamp"
)
type (
CompiledSpec struct {
spec *schedpb.ScheduleSpec
tz *time.Location
calendar []*compiledCalendar
excludes []*compiledCalendar
}
getNextTimeResult struct {
Nominal time.Time // scheduled time before adding jitter
Next time.Time // scheduled time after adding jitter
}
)
func NewCompiledSpec(spec *schedpb.ScheduleSpec) (*CompiledSpec, error) {
spec, err := canonicalizeSpec(spec)
if err != nil {
return nil, err
}
// load timezone
tz, err := loadTimezone(spec)
if err != nil {
return nil, err
}
// compile StructuredCalendarSpecs
ccs := make([]*compiledCalendar, len(spec.StructuredCalendar))
for i, structured := range spec.StructuredCalendar {
ccs[i] = newCompiledCalendar(structured, tz)
}
// compile excludes
excludes := make([]*compiledCalendar, len(spec.ExcludeStructuredCalendar))
for i, excal := range spec.ExcludeStructuredCalendar {
excludes[i] = newCompiledCalendar(excal, tz)
}
cspec := &CompiledSpec{
spec: spec,
tz: tz,
calendar: ccs,
excludes: excludes,
}
return cspec, nil
}
// CleanSpec sets default values in ranges.
func CleanSpec(spec *schedpb.ScheduleSpec) {
cleanRanges := func(ranges []*schedpb.Range) {
for _, r := range ranges {
if r.End < r.Start {
r.End = r.Start
}
if r.Step == 0 {
r.Step = 1
}
}
}
cleanCal := func(structured *schedpb.StructuredCalendarSpec) {
cleanRanges(structured.Second)
cleanRanges(structured.Minute)
cleanRanges(structured.Hour)
cleanRanges(structured.DayOfMonth)
cleanRanges(structured.Month)
cleanRanges(structured.Year)
cleanRanges(structured.DayOfWeek)
}
for _, structured := range spec.StructuredCalendar {
cleanCal(structured)
}
for _, structured := range spec.ExcludeStructuredCalendar {
cleanCal(structured)
}
}
func canonicalizeSpec(spec *schedpb.ScheduleSpec) (*schedpb.ScheduleSpec, error) {
// make copy so we can change some fields
spec = common.CloneProto(spec)
// parse CalendarSpecs to StructuredCalendarSpecs
for _, cal := range spec.Calendar {
structured, err := parseCalendarToStructured(cal)
if err != nil {
return nil, err
}
spec.StructuredCalendar = append(spec.StructuredCalendar, structured)
}
spec.Calendar = nil
// parse ExcludeCalendars
for _, cal := range spec.ExcludeCalendar {
structured, err := parseCalendarToStructured(cal)
if err != nil {
return nil, err
}
spec.ExcludeStructuredCalendar = append(spec.ExcludeStructuredCalendar, structured)
}
spec.ExcludeCalendar = nil
// parse CronStrings
const unset = "__unset__"
cronTZ := unset
for _, cs := range spec.CronString {
structured, interval, tz, err := parseCronString(cs)
if err != nil {
return nil, err
}
if cronTZ != unset && tz != cronTZ {
// all cron strings must agree on timezone (whether present or not)
return nil, errConflictingTimezoneNames
}
cronTZ = tz
if structured != nil {
spec.StructuredCalendar = append(spec.StructuredCalendar, structured)
}
if interval != nil {
spec.Interval = append(spec.Interval, interval)
}
}
spec.CronString = nil
// if we have cron string(s), copy the timezone to spec, checking for conflict first.
// if cron string timezone is empty string, don't copy, let the one in spec be used.
if cronTZ != unset && cronTZ != "" {
if spec.TimezoneName != "" && spec.TimezoneName != cronTZ || spec.TimezoneData != nil {
return nil, errConflictingTimezoneNames
} else if spec.TimezoneName == "" {
spec.TimezoneName = cronTZ
}
}
// validate structured calendar
for _, structured := range spec.StructuredCalendar {
if err := validateStructuredCalendar(structured); err != nil {
return nil, err
}
}
// validate intervals
for _, interval := range spec.Interval {
if err := validateInterval(interval); err != nil {
return nil, err
}
}
return spec, nil
}
func validateStructuredCalendar(scs *schedpb.StructuredCalendarSpec) error {
var errs []string
checkRanges := func(ranges []*schedpb.Range, field string, min, max int32) {
for _, r := range ranges {
if r == nil { // shouldn't happen
errs = append(errs, "range is nil")
continue
}
if r.Start < min || r.Start > max {
errs = append(errs, fmt.Sprintf("%s Start is not in range [%d-%d]", field, min, max))
}
if r.End != 0 && (r.End < r.Start || r.End > max) {
errs = append(errs, fmt.Sprintf("%s End is before Start or not in range [%d-%d]", field, min, max))
}
if r.Step < 0 {
errs = append(errs, fmt.Sprintf("%s has invalid Step", field))
}
}
}
checkRanges(scs.Second, "Second", 0, 59)
checkRanges(scs.Minute, "Minute", 0, 59)
checkRanges(scs.Hour, "Hour", 0, 23)
checkRanges(scs.DayOfMonth, "DayOfMonth", 1, 31)
checkRanges(scs.Month, "Month", 1, 12)
checkRanges(scs.Year, "Year", minCalendarYear, maxCalendarYear)
checkRanges(scs.DayOfWeek, "DayOfWeek", 0, 6)
if len(scs.Comment) > maxCommentLen {
errs = append(errs, "comment is too long")
}
if len(errs) > 0 {
return errors.New("invalid calendar spec: " + strings.Join(errs, ", "))
}
return nil
}
func validateInterval(i *schedpb.IntervalSpec) error {
if i == nil {
return errors.New("interval is nil")
}
iv, phase := timestamp.DurationValue(i.Interval), timestamp.DurationValue(i.Phase)
if iv < time.Second {
return errors.New("interval is too small")
} else if phase < 0 {
return errors.New("phase is negative")
} else if phase >= iv {
return errors.New("phase cannot be greater than Interval")
}
return nil
}
func loadTimezone(spec *schedpb.ScheduleSpec) (*time.Location, error) {
if spec.TimezoneData != nil {
return time.LoadLocationFromTZData(spec.TimezoneName, spec.TimezoneData)
}
return time.LoadLocation(spec.TimezoneName)
}
func (cs *CompiledSpec) CanonicalForm() *schedpb.ScheduleSpec {
return cs.spec
}
// Returns the earliest time that matches the schedule spec that is after the given time.
// Returns: Nominal is the time that matches, pre-jitter. Next is the nominal time with
// jitter applied. If there is no matching time, Nominal and Next will be the zero time.
func (cs *CompiledSpec) getNextTime(jitterSeed string, after time.Time) getNextTimeResult {
// If we're starting before the schedule's allowed time range, jump up to right before
// it (so that we can still return the first second of the range if it happens to match).
if cs.spec.StartTime != nil && after.Before(timestamp.TimeValue(cs.spec.StartTime)) {
after = cs.spec.StartTime.AsTime().Add(-time.Second)
}
var nominal time.Time
for {
nominal = cs.rawNextTime(after)
if nominal.IsZero() || (cs.spec.EndTime != nil && nominal.After(cs.spec.EndTime.AsTime())) {
return getNextTimeResult{}
}
// check against excludes
if !cs.excluded(nominal) {
break
}
after = nominal
}
maxJitter := timestamp.DurationValue(cs.spec.Jitter)
// Ensure that jitter doesn't push this time past the _next_ nominal start time
if following := cs.rawNextTime(nominal); !following.IsZero() {
maxJitter = min(maxJitter, following.Sub(nominal))
}
next := cs.addJitter(jitterSeed, nominal, maxJitter)
return getNextTimeResult{Nominal: nominal, Next: next}
}
// Returns the next matching time (without jitter), or the zero value if no time matches.
func (cs *CompiledSpec) rawNextTime(after time.Time) (nominal time.Time) {
var minTimestamp int64 = math.MaxInt64 // unix seconds-since-epoch as int64
for _, cal := range cs.calendar {
if next := cal.next(after); !next.IsZero() {
nextTs := next.Unix()
if nextTs < minTimestamp {
minTimestamp = nextTs
}
}
}
ts := after.Unix()
for _, iv := range cs.spec.Interval {
next := cs.nextIntervalTime(iv, ts)
if next < minTimestamp {
minTimestamp = next
}
}
if minTimestamp == math.MaxInt64 {
return time.Time{}
}
return time.Unix(minTimestamp, 0).UTC()
}
// Returns the next matching time for a single interval spec.
func (cs *CompiledSpec) nextIntervalTime(iv *schedpb.IntervalSpec, ts int64) int64 {
interval := int64(timestamp.DurationValue(iv.Interval) / time.Second)
if interval < 1 {
interval = 1
}
phase := int64(timestamp.DurationValue(iv.Phase) / time.Second)
if phase < 0 {
phase = 0
}
return (((ts-phase)/interval)+1)*interval + phase
}
// Returns true if any exclude spec matches the time.
func (cs *CompiledSpec) excluded(nominal time.Time) bool {
for _, excal := range cs.excludes {
if excal.matches(nominal) {
return true
}
}
return false
}
// Adds jitter to a nominal time, deterministically (by hashing the given time and a seed).
func (cs *CompiledSpec) addJitter(seed string, nominal time.Time, maxJitter time.Duration) time.Time {
if maxJitter < 0 {
maxJitter = 0
}
bin, err := nominal.MarshalBinary()
if err != nil {
return nominal
}
bin = append(bin, []byte(seed)...)
// we want to fit the result of a multiply in 64 bits, and use 32 bits of hash, which
// leaves 32 bits for the range. if we use nanoseconds or microseconds, our range is
// limited to only a few seconds or hours. using milliseconds supports up to 49 days.
fp := uint64(farm.Fingerprint32(bin))
ms := uint64(maxJitter.Milliseconds())
if ms > math.MaxUint32 {
ms = math.MaxUint32
}
jitter := time.Duration((fp*ms)>>32) * time.Millisecond
return nominal.Add(jitter)
}