Files
tasks/tools/common/schema/handler.go
Carly de FrondevilleandGitHub 68fe1f306a support embedded schema for cassandra and sql update-schema and setup-schema (#5195)
## What changed?


This change adds a flag to `temporal-sql-tool` and
`temporal-cassandra-tool`'s `update-schema` and `setup-schema` to
specify an embedded schema instead of a path to the schema directory or
schema file.

```
NAME:
   temporal-cassandra-tool update-schema - update cassandra schema to a specific version

USAGE:
   temporal-cassandra-tool update-schema [command options] [arguments...]

OPTIONS:
   --version value, -v value      target version for the schema update, defaults to latest
   --schema-dir value, -d value   path to directory containing versioned schema
   --schema-name value, -s value  name of embedded versioned schema, one of: [cassandra/temporal cassandra/visibility]
```

```
NAME:
   temporal-sql-tool update-schema - update sql schema to a specific version

USAGE:
   temporal-sql-tool update-schema [command options] [arguments...]

OPTIONS:
   --version value, -v value      target version for the schema update, defaults to latest
   --schema-dir value, -d value   path to directory containing versioned schema
   --schema-name value, -s value  name of embedded versioned schema, one of: [mysql/v57/temporal mysql/v57/visibility mysql/v8/temporal mysql/v8/visibility postgresql/v96/temporal postgresql/v96/visibility postgresql/v12/temporal postgresql/v12/visibility]
```


## Why?
We want to embed the db schemas in the `temporal-sql-tool` and
`temporal-cassandra-tool` with `go:embed` so that customers can simply
specify which schema they want using a flag instead of having to copy
the schema files to wherever they're running the db tool and passing the
path to the schema.

https://github.com/temporalio/temporal/issues/2059

## How did you test it?
I wrote a new unit test for reading the embedded file system, and the
existing codepath of the changed functions are all tested by the
existing unit tests. I also updated the unit test for config validation
to reflect the new changes.

I tested this locally with a locally running Postgres. Since the more
complex changes are in `updatetask.go`, which is shared by the sql and
the cassandra tool, I think there is no need to also test with a real
cassandra db. I also built the cassandra command line tool and confirmed
that the flags and validation checks behaved as expected.

## Potential risks
Schema updates could fail. But the changes are pretty contained to the
new `-s` flag which isn't used anywhere in production yet, so the risk
is very low. The code for the `-d` flag remained basically the same.

## Is hotfix candidate?
No
2023-12-05 12:22:06 -08:00

146 lines
4.9 KiB
Go

// The MIT License
//
// Copyright (c) 2020 Temporal Technologies Inc. All rights reserved.
//
// Copyright (c) 2020 Uber Technologies, Inc.
//
// Permission is hereby granted, free of charge, to any person obtaining a copy
// of this software and associated documentation files (the "Software"), to deal
// in the Software without restriction, including without limitation the rights
// to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
// copies of the Software, and to permit persons to whom the Software is
// furnished to do so, subject to the following conditions:
//
// The above copyright notice and this permission notice shall be included in
// all copies or substantial portions of the Software.
//
// THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
// IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
// FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
// AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
// LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
// OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
// THE SOFTWARE.
package schema
import (
"fmt"
"slices"
"strings"
"github.com/urfave/cli"
"go.temporal.io/server/common/log"
dbschemas "go.temporal.io/server/schema"
)
// Setup sets up schema tables
func Setup(cli *cli.Context, db DB, logger log.Logger) error {
cfg, err := newSetupConfig(cli, db)
if err != nil {
return err
}
return newSetupSchemaTask(db, cfg, logger).Run()
}
// Update updates the schema for the specified database
func Update(cli *cli.Context, db DB, logger log.Logger) error {
cfg, err := newUpdateConfig(cli, db)
if err != nil {
return err
}
return newUpdateSchemaTask(db, cfg, logger).Run()
}
func newUpdateConfig(cli *cli.Context, db DB) (*UpdateConfig, error) {
config := new(UpdateConfig)
config.SchemaDir = cli.String(CLIOptSchemaDir)
config.SchemaName = cli.String(CLIOptSchemaName)
config.TargetVersion = cli.String(CLIOptTargetVersion)
if err := validateUpdateConfig(config, db); err != nil {
return nil, err
}
return config, nil
}
func newSetupConfig(cli *cli.Context, db DB) (*SetupConfig, error) {
config := new(SetupConfig)
config.SchemaFilePath = cli.String(CLIOptSchemaFile)
config.SchemaName = cli.String(CLIOptSchemaName)
config.InitialVersion = cli.String(CLIOptVersion)
config.DisableVersioning = cli.Bool(CLIOptDisableVersioning)
config.Overwrite = cli.Bool(CLIOptOverwrite)
if err := validateSetupConfig(config, db); err != nil {
return nil, err
}
return config, nil
}
func validateSetupConfig(config *SetupConfig, db DB) error {
if len(config.SchemaFilePath) == 0 && len(config.SchemaName) == 0 && config.DisableVersioning {
return NewConfigError("needs either " + flag(CLIOptSchemaFile) + " or " + flag(CLIOptSchemaName))
}
if (config.DisableVersioning && len(config.InitialVersion) > 0) ||
(!config.DisableVersioning && len(config.InitialVersion) == 0) {
return NewConfigError("missing argument; either " + flag(CLIOptDisableVersioning) + " or " +
flag(CLIOptVersion) + " but not both must be specified")
}
if len(config.SchemaFilePath) > 0 && len(config.SchemaName) > 0 {
return NewConfigError("either" + flag(CLIOptSchemaFile) + " or " +
flag(CLIOptSchemaName) + " must be specified")
}
if len(config.SchemaName) > 0 {
if !slices.Contains(dbschemas.PathsByDB(db.Type()), config.SchemaName) {
return NewConfigError(fmt.Sprintf("%s must be one of: %v",
flag(CLIOptSchemaName), dbschemas.PathsByDB(db.Type())))
}
}
if !config.DisableVersioning {
ver, err := normalizeVersionString(config.InitialVersion)
if err != nil {
return NewConfigError("invalid " + flag(CLIOptVersion) + " argument:" + err.Error())
}
config.InitialVersion = ver
}
return nil
}
func validateUpdateConfig(config *UpdateConfig, db DB) error {
if len(config.SchemaDir) == 0 && len(config.SchemaName) == 0 {
return NewConfigError("missing argument; either" + flag(CLIOptSchemaDir) + " or " +
flag(CLIOptSchemaName) + " must be specified")
}
if len(config.SchemaDir) > 0 && len(config.SchemaName) > 0 {
return NewConfigError("either" + flag(CLIOptSchemaDir) + " or " +
flag(CLIOptSchemaName) + " must be specified")
}
if len(config.SchemaName) > 0 {
if !slices.Contains(dbschemas.PathsByDB(db.Type()), config.SchemaName) {
return NewConfigError(fmt.Sprintf("%s must be one of: %v",
flag(CLIOptSchemaName), dbschemas.PathsByDB(db.Type())))
}
}
if len(config.TargetVersion) > 0 {
ver, err := normalizeVersionString(config.TargetVersion)
if err != nil {
return NewConfigError("invalid " + flag(CLIOptTargetVersion) + " argument:" + err.Error())
}
config.TargetVersion = ver
}
return nil
}
func flag(opt string) string {
return "(-" + opt + ")"
}
func schemaFileEnding(schemaName string) string {
if strings.Contains(schemaName, "cassandra") {
return ".cql"
}
return ".sql"
}