mirror of
https://github.com/hanzoai/tasks.git
synced 2026-10-04 02:04:03 +00:00
## What changed? This change adds a flag to `temporal-sql-tool` and `temporal-cassandra-tool`'s `update-schema` and `setup-schema` to specify an embedded schema instead of a path to the schema directory or schema file. ``` NAME: temporal-cassandra-tool update-schema - update cassandra schema to a specific version USAGE: temporal-cassandra-tool update-schema [command options] [arguments...] OPTIONS: --version value, -v value target version for the schema update, defaults to latest --schema-dir value, -d value path to directory containing versioned schema --schema-name value, -s value name of embedded versioned schema, one of: [cassandra/temporal cassandra/visibility] ``` ``` NAME: temporal-sql-tool update-schema - update sql schema to a specific version USAGE: temporal-sql-tool update-schema [command options] [arguments...] OPTIONS: --version value, -v value target version for the schema update, defaults to latest --schema-dir value, -d value path to directory containing versioned schema --schema-name value, -s value name of embedded versioned schema, one of: [mysql/v57/temporal mysql/v57/visibility mysql/v8/temporal mysql/v8/visibility postgresql/v96/temporal postgresql/v96/visibility postgresql/v12/temporal postgresql/v12/visibility] ``` ## Why? We want to embed the db schemas in the `temporal-sql-tool` and `temporal-cassandra-tool` with `go:embed` so that customers can simply specify which schema they want using a flag instead of having to copy the schema files to wherever they're running the db tool and passing the path to the schema. https://github.com/temporalio/temporal/issues/2059 ## How did you test it? I wrote a new unit test for reading the embedded file system, and the existing codepath of the changed functions are all tested by the existing unit tests. I also updated the unit test for config validation to reflect the new changes. I tested this locally with a locally running Postgres. Since the more complex changes are in `updatetask.go`, which is shared by the sql and the cassandra tool, I think there is no need to also test with a real cassandra db. I also built the cassandra command line tool and confirmed that the flags and validation checks behaved as expected. ## Potential risks Schema updates could fail. But the changes are pretty contained to the new `-s` flag which isn't used anywhere in production yet, so the risk is very low. The code for the `-d` flag remained basically the same. ## Is hotfix candidate? No
208 lines
6.3 KiB
Go
208 lines
6.3 KiB
Go
// The MIT License
|
|
//
|
|
// Copyright (c) 2020 Temporal Technologies Inc. All rights reserved.
|
|
//
|
|
// Copyright (c) 2020 Uber Technologies, Inc.
|
|
//
|
|
// Permission is hereby granted, free of charge, to any person obtaining a copy
|
|
// of this software and associated documentation files (the "Software"), to deal
|
|
// in the Software without restriction, including without limitation the rights
|
|
// to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
|
|
// copies of the Software, and to permit persons to whom the Software is
|
|
// furnished to do so, subject to the following conditions:
|
|
//
|
|
// The above copyright notice and this permission notice shall be included in
|
|
// all copies or substantial portions of the Software.
|
|
//
|
|
// THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
|
|
// IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
|
|
// FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
|
|
// AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
|
|
// LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
|
|
// OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
|
|
// THE SOFTWARE.
|
|
|
|
package sql
|
|
|
|
import (
|
|
"fmt"
|
|
"net"
|
|
"net/url"
|
|
|
|
"github.com/urfave/cli"
|
|
|
|
"go.temporal.io/server/common/auth"
|
|
"go.temporal.io/server/common/config"
|
|
"go.temporal.io/server/common/log"
|
|
"go.temporal.io/server/common/log/tag"
|
|
"go.temporal.io/server/tools/common/schema"
|
|
)
|
|
|
|
// setupSchema executes the setupSchemaTask
|
|
// using the given command line arguments
|
|
// as input
|
|
func setupSchema(cli *cli.Context, logger log.Logger) error {
|
|
cfg, err := parseConnectConfig(cli)
|
|
if err != nil {
|
|
logger.Error("Unable to read config.", tag.Error(schema.NewConfigError(err.Error())))
|
|
return err
|
|
}
|
|
conn, err := NewConnection(cfg)
|
|
if err != nil {
|
|
logger.Error("Unable to connect to SQL database.", tag.Error(err))
|
|
return err
|
|
}
|
|
defer conn.Close()
|
|
if err := schema.Setup(cli, conn, logger); err != nil {
|
|
logger.Error("Unable to setup SQL schema.", tag.Error(err))
|
|
return err
|
|
}
|
|
return nil
|
|
}
|
|
|
|
// updateSchema executes the updateSchemaTask
|
|
// using the given command line args as input
|
|
func updateSchema(cli *cli.Context, logger log.Logger) error {
|
|
cfg, err := parseConnectConfig(cli)
|
|
if err != nil {
|
|
logger.Error("Unable to read config.", tag.Error(schema.NewConfigError(err.Error())))
|
|
return err
|
|
}
|
|
conn, err := NewConnection(cfg)
|
|
if err != nil {
|
|
logger.Error("Unable to connect to SQL database.", tag.Error(err))
|
|
return err
|
|
}
|
|
defer conn.Close()
|
|
if err := schema.Update(cli, conn, logger); err != nil {
|
|
logger.Error("Unable to update SQL schema.", tag.Error(err))
|
|
return err
|
|
}
|
|
return nil
|
|
}
|
|
|
|
// createDatabase creates a sql database
|
|
func createDatabase(cli *cli.Context, logger log.Logger) error {
|
|
cfg, err := parseConnectConfig(cli)
|
|
if err != nil {
|
|
logger.Error("Unable to read config.", tag.Error(schema.NewConfigError(err.Error())))
|
|
return err
|
|
}
|
|
defaultDb := cli.String(schema.CLIOptDefaultDb)
|
|
err = DoCreateDatabase(cfg, defaultDb)
|
|
if err != nil {
|
|
logger.Error("Unable to create SQL database.", tag.Error(err))
|
|
return err
|
|
}
|
|
return nil
|
|
}
|
|
|
|
func DoCreateDatabase(cfg *config.SQL, defaultDb string) error {
|
|
dbToCreate := cfg.DatabaseName
|
|
cfg.DatabaseName = defaultDb
|
|
conn, err := NewConnection(cfg)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
defer conn.Close()
|
|
return conn.CreateDatabase(dbToCreate)
|
|
}
|
|
|
|
// dropDatabase drops a sql database
|
|
func dropDatabase(cli *cli.Context, logger log.Logger) error {
|
|
cfg, err := parseConnectConfig(cli)
|
|
if err != nil {
|
|
logger.Error("Unable to read config.", tag.Error(schema.NewConfigError(err.Error())))
|
|
return err
|
|
}
|
|
defaultDb := cli.String(schema.CLIOptDefaultDb)
|
|
err = DoDropDatabase(cfg, defaultDb)
|
|
if err != nil {
|
|
logger.Error("Unable to drop SQL database.", tag.Error(err))
|
|
return err
|
|
}
|
|
return nil
|
|
}
|
|
|
|
func DoDropDatabase(cfg *config.SQL, defaultDb string) error {
|
|
dbToDrop := cfg.DatabaseName
|
|
cfg.DatabaseName = defaultDb
|
|
conn, err := NewConnection(cfg)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
err = conn.DropDatabase(dbToDrop)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
conn.Close()
|
|
return nil
|
|
}
|
|
|
|
func parseConnectConfig(cli *cli.Context) (*config.SQL, error) {
|
|
cfg := new(config.SQL)
|
|
|
|
host := cli.GlobalString(schema.CLIOptEndpoint)
|
|
port := cli.GlobalInt(schema.CLIOptPort)
|
|
cfg.ConnectAddr = fmt.Sprintf("%s:%v", host, port)
|
|
cfg.User = cli.GlobalString(schema.CLIOptUser)
|
|
cfg.Password = cli.GlobalString(schema.CLIOptPassword)
|
|
cfg.DatabaseName = cli.GlobalString(schema.CLIOptDatabase)
|
|
cfg.PluginName = cli.GlobalString(schema.CLIOptPluginName)
|
|
|
|
if cfg.ConnectAttributes == nil {
|
|
cfg.ConnectAttributes = map[string]string{}
|
|
}
|
|
connectAttributesQueryString := cli.GlobalString(schema.CLIOptConnectAttributes)
|
|
if connectAttributesQueryString != "" {
|
|
values, err := url.ParseQuery(connectAttributesQueryString)
|
|
if err != nil {
|
|
return nil, fmt.Errorf("invalid connect attributes: %v", err)
|
|
}
|
|
for key, vals := range values {
|
|
// check to ensure only one value is provider per key
|
|
if len(vals) > 1 {
|
|
return nil, fmt.Errorf("invalid connect attribute %v, only 1 value allowed: %v", key, vals)
|
|
}
|
|
cfg.ConnectAttributes[key] = vals[0]
|
|
}
|
|
}
|
|
|
|
if cli.GlobalBool(schema.CLIFlagEnableTLS) {
|
|
cfg.TLS = &auth.TLS{
|
|
Enabled: true,
|
|
CertFile: cli.GlobalString(schema.CLIFlagTLSCertFile),
|
|
KeyFile: cli.GlobalString(schema.CLIFlagTLSKeyFile),
|
|
CaFile: cli.GlobalString(schema.CLIFlagTLSCaFile),
|
|
ServerName: cli.GlobalString(schema.CLIFlagTLSHostName),
|
|
EnableHostVerification: !cli.GlobalBool(schema.CLIFlagTLSDisableHostVerification),
|
|
}
|
|
}
|
|
|
|
if err := ValidateConnectConfig(cfg); err != nil {
|
|
return nil, err
|
|
}
|
|
|
|
return cfg, nil
|
|
}
|
|
|
|
// ValidateConnectConfig validates params
|
|
func ValidateConnectConfig(cfg *config.SQL) error {
|
|
host, _, err := net.SplitHostPort(cfg.ConnectAddr)
|
|
if err != nil {
|
|
return schema.NewConfigError("invalid host and port " + cfg.ConnectAddr)
|
|
}
|
|
if len(host) == 0 {
|
|
return schema.NewConfigError("missing sql endpoint argument " + flag(schema.CLIOptEndpoint))
|
|
}
|
|
if cfg.DatabaseName == "" {
|
|
return schema.NewConfigError("missing " + flag(schema.CLIOptDatabase) + " argument")
|
|
}
|
|
|
|
return nil
|
|
}
|
|
|
|
func flag(opt string) string {
|
|
return "(-" + opt + ")"
|
|
}
|