mirror of
https://github.com/hanzoai/tasks.git
synced 2026-10-04 02:04:03 +00:00
3451e82a1f
## What changed? I've upgraded the version of our Go API in order to allow invalid UTF-8 data in our proto strings. Please review https://github.com/temporalio/temporal/pull/5476/commits/5cf979058d0897638f0cf80efea5dbfd737c4a97 only ## Why? The version of gogo/protobuf we used allowed invalid UTF-8 in strings which is a violation of the proto3 spec. We were unaware of this until our new google/protobuf based structs began failing to deserialize data we'd used previously ## How did you test it? I added a new end-to-end test to verify that we can create, describe, and delete a namespace that contains invalid UTF-8 in multiple attributes ## Potential risks This is lower risk than commits prior to this as temporal DBs may already contain invalid UTF-8 data ## Documentation I adjusted our docs to mention this behavior and the `protolegacy` tag ## Is hotfix candidate? Yes: this will be going out as part of our 1.23.0 release. In fact, the release is blocked on it! --------- Co-authored-by: David Reiss <[email protected]>