Files
tasks/common/persistence/cassandra/nexus_incoming_service_store.go
pdoernerandGitHub 7954e01734 Implement Nexus incoming service operator APIs (#5621)
## What changed?
<!-- Describe what has changed in this PR -->
Added implementations for Operator service CRUD APIs for Nexus incoming
services
Some details:
* Create, Update, and Delete requests are forwarded to matching
* Read (Get and List) requests are sent directly to persistence
* Frontend does not do any caching of services

Depends on https://github.com/temporalio/temporal/pull/5616

## Why?
<!-- Tell your future self why have you made these changes -->
So users can interact with Nexus incoming services

## How did you test it?
<!-- How have you verified this change? Tested locally? Added a unit
test? Checked in staging env? -->
New functional tests
2024-03-29 11:36:12 -07:00

383 lines
12 KiB
Go

// The MIT License
//
// Copyright (c) 2020 Temporal Technologies Inc. All rights reserved.
//
// Copyright (c) 2020 Uber Technologies, Inc.
//
// Permission is hereby granted, free of charge, to any person obtaining a copy
// of this software and associated documentation files (the "Software"), to deal
// in the Software without restriction, including without limitation the rights
// to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
// copies of the Software, and to permit persons to whom the Software is
// furnished to do so, subject to the following conditions:
//
// The above copyright notice and this permission notice shall be included in
// all copies or substantial portions of the Software.
//
// THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
// IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
// FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
// AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
// LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
// OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
// THE SOFTWARE.
package cassandra
import (
"context"
"fmt"
"go.temporal.io/api/serviceerror"
"go.temporal.io/server/common/log"
p "go.temporal.io/server/common/persistence"
"go.temporal.io/server/common/persistence/nosql/nosqlplugin/cassandra/gocql"
)
const (
tableVersionServiceID = `00000000-0000-0000-0000-000000000000`
)
const (
rowTypePartitionStatus = iota
rowTypeIncomingNexusService
)
const (
// table templates
templateCreateTableVersion = `INSERT INTO nexus_incoming_services(partition, type, service_id, version) VALUES (0, ?, ?, ?) IF NOT EXISTS`
templateGetTableVersion = `SELECT version FROM nexus_incoming_services WHERE partition = 0 AND type = ? AND service_id = ?`
templateUpdateTableVersion = `UPDATE nexus_incoming_services SET version = ? WHERE partition = 0 AND type = ? AND service_id = ? IF version = ?`
// incoming service templates
templateCreateIncomingServiceQuery = `INSERT INTO nexus_incoming_services(partition, type, service_id, data, data_encoding, version) VALUES(0, ?, ?, ?, ?, ?) IF NOT EXISTS`
templateUpdateIncomingServiceQuery = `UPDATE nexus_incoming_services SET data = ?, data_encoding = ?, version = ? WHERE partition = 0 AND type = ? AND service_id = ? IF version = ?`
templateDeleteIncomingServiceQuery = `DELETE FROM nexus_incoming_services WHERE partition = 0 AND type = ? AND service_id = ? IF EXISTS`
templateGetIncomingServiceByIdQuery = `SELECT data, data_encoding, version FROM nexus_incoming_services WHERE partition = 0 AND type = ? AND service_id = ? LIMIT 1`
templateBaseListIncomingServicesQuery = `SELECT service_id, data, data_encoding, version FROM nexus_incoming_services WHERE partition = 0`
templateListIncomingServicesQuery = templateBaseListIncomingServicesQuery + ` AND type = ?`
templateListIncomingServicesFirstPageQuery = templateBaseListIncomingServicesQuery + ` ORDER BY type ASC`
)
type (
NexusIncomingServiceStore struct {
session gocql.Session
logger log.Logger
}
)
func NewNexusIncomingServiceStore(
session gocql.Session,
logger log.Logger,
) p.NexusIncomingServiceStore {
return &NexusIncomingServiceStore{
session: session,
logger: logger,
}
}
func (s *NexusIncomingServiceStore) GetName() string {
return cassandraPersistenceName
}
func (s *NexusIncomingServiceStore) Close() {
if s.session != nil {
s.session.Close()
}
}
func (s *NexusIncomingServiceStore) CreateOrUpdateNexusIncomingService(
ctx context.Context,
request *p.InternalCreateOrUpdateNexusIncomingServiceRequest,
) error {
batch := s.session.NewBatch(gocql.LoggedBatch).WithContext(ctx)
if request.Service.Version == 0 {
batch.Query(templateCreateIncomingServiceQuery,
rowTypeIncomingNexusService,
request.Service.ServiceID,
request.Service.Data.Data,
request.Service.Data.EncodingType.String(),
1,
)
} else {
batch.Query(templateUpdateIncomingServiceQuery,
request.Service.Data.Data,
request.Service.Data.EncodingType.String(),
request.Service.Version+1,
rowTypeIncomingNexusService,
request.Service.ServiceID,
request.Service.Version,
)
}
if request.LastKnownTableVersion == 0 {
batch.Query(templateCreateTableVersion,
rowTypePartitionStatus,
tableVersionServiceID,
1)
} else {
batch.Query(templateUpdateTableVersion,
request.LastKnownTableVersion+1,
rowTypePartitionStatus,
tableVersionServiceID,
request.LastKnownTableVersion)
}
previousPartitionStatus := make(map[string]interface{})
applied, iter, err := s.session.MapExecuteBatchCAS(batch, previousPartitionStatus)
if err != nil {
return gocql.ConvertError("CreateOrUpdateNexusIncomingService", err)
}
previousService := make(map[string]interface{})
iter.MapScan(previousService)
err = iter.Close()
if err != nil {
return gocql.ConvertError("CreateOrUpdateNexusIncomingService", err)
}
if !applied {
currentTableVersion, err := getTypedFieldFromRow[int64]("version", previousPartitionStatus)
if err != nil {
return fmt.Errorf("error retrieving current table version: %w", err)
}
if currentTableVersion != request.LastKnownTableVersion {
return fmt.Errorf("%w. provided table version: %v current table version: %v",
p.ErrNexusTableVersionConflict,
request.LastKnownTableVersion,
currentTableVersion)
}
currentServiceVersion, err := getTypedFieldFromRow[int64]("version", previousService)
if err != nil {
return fmt.Errorf("error retrieving current service version: %w", err)
}
if currentServiceVersion != request.Service.Version {
return fmt.Errorf("%w. provided service version: %v current service version: %v",
p.ErrNexusIncomingServiceVersionConflict,
request.Service.Version,
currentServiceVersion)
}
// This should never happen. This means the request had the correct versions and gocql did not
// return an error but for some reason the update was not applied.
return serviceerror.NewInternal("CreateOrUpdateNexusIncomingService failed.")
}
return nil
}
func (s *NexusIncomingServiceStore) GetNexusIncomingService(
ctx context.Context,
request *p.GetNexusIncomingServiceRequest,
) (*p.InternalNexusIncomingService, error) {
query := s.session.Query(templateGetIncomingServiceByIdQuery, rowTypeIncomingNexusService, request.ServiceID).WithContext(ctx)
var data []byte
var dataEncoding string
var version int64
err := query.Scan(&data, &dataEncoding, &version)
if gocql.IsNotFoundError(err) {
return nil, serviceerror.NewNotFound(fmt.Sprintf("Nexus incoming service with ID `%v` not found", request.ServiceID))
}
if err != nil {
return nil, gocql.ConvertError("GetNexusIncomingService", err)
}
return &p.InternalNexusIncomingService{
ServiceID: request.ServiceID,
Version: version,
Data: p.NewDataBlob(data, dataEncoding),
}, nil
}
func (s *NexusIncomingServiceStore) ListNexusIncomingServices(
ctx context.Context,
request *p.ListNexusIncomingServicesRequest,
) (*p.InternalListNexusIncomingServicesResponse, error) {
if request.LastKnownTableVersion == 0 && request.NextPageToken == nil {
return s.listFirstPageWithVersion(ctx, request)
}
response := &p.InternalListNexusIncomingServicesResponse{}
query := s.session.Query(templateListIncomingServicesQuery, rowTypeIncomingNexusService).WithContext(ctx)
iter := query.PageSize(request.PageSize).PageState(request.NextPageToken).Iter()
services, err := s.getServiceList(iter)
if err != nil {
return nil, err
}
response.Services = services
if len(iter.PageState()) > 0 {
response.NextPageToken = iter.PageState()
}
if err := iter.Close(); err != nil {
return nil, serviceerror.NewUnavailable(fmt.Sprintf("ListNexusIncomingServices operation failed: %v", err))
}
currentTableVersion, err := s.getTableVersion(ctx)
if err != nil {
return nil, err
}
response.TableVersion = currentTableVersion
if request.LastKnownTableVersion != 0 && request.LastKnownTableVersion != currentTableVersion {
// If request.LastKnownTableVersion == 0 then caller does not care about checking whether they have the most
// current view while paginating.
// Otherwise, if there is a version mismatch, then the table has been updated during pagination, and throw
// error to indicate caller must start over.
return nil, fmt.Errorf("%w. provided table version: %v current table version: %v",
p.ErrNexusTableVersionConflict,
request.LastKnownTableVersion,
currentTableVersion)
}
return response, nil
}
func (s *NexusIncomingServiceStore) DeleteNexusIncomingService(
ctx context.Context,
request *p.DeleteNexusIncomingServiceRequest,
) error {
batch := s.session.NewBatch(gocql.LoggedBatch).WithContext(ctx)
batch.Query(templateDeleteIncomingServiceQuery,
rowTypeIncomingNexusService,
request.ServiceID)
batch.Query(templateUpdateTableVersion,
request.LastKnownTableVersion+1,
rowTypePartitionStatus,
tableVersionServiceID,
request.LastKnownTableVersion)
previousPartitionStatus := make(map[string]interface{})
applied, iter, err := s.session.MapExecuteBatchCAS(batch, previousPartitionStatus)
if err != nil {
return gocql.ConvertError("DeleteNexusIncomingService", err)
}
err = iter.Close()
if err != nil {
return gocql.ConvertError("DeleteNexusIncomingService", err)
}
if !applied {
currentTableVersion, err := getTypedFieldFromRow[int64]("version", previousPartitionStatus)
if err != nil {
return fmt.Errorf("error retrieving current table version: %w", err)
}
if currentTableVersion != request.LastKnownTableVersion {
return fmt.Errorf("%w. provided table version: %v current table version: %v",
p.ErrNexusTableVersionConflict,
request.LastKnownTableVersion,
currentTableVersion)
}
return fmt.Errorf("%w. provided serviceID: %v",
p.ErrNexusIncomingServiceNotFound,
request.ServiceID)
}
return nil
}
func (s *NexusIncomingServiceStore) listFirstPageWithVersion(
ctx context.Context,
request *p.ListNexusIncomingServicesRequest,
) (*p.InternalListNexusIncomingServicesResponse, error) {
response := &p.InternalListNexusIncomingServicesResponse{}
query := s.session.Query(templateListIncomingServicesFirstPageQuery).WithContext(ctx)
iter := query.PageSize(request.PageSize + 1).PageState(nil).Iter() // Use PageSize+1 to account for partitionStatus row
partitionStateRow := make(map[string]interface{})
found := iter.MapScan(partitionStateRow)
if !found {
cassErr := iter.Close()
if cassErr != nil && !gocql.IsNotFoundError(cassErr) {
return nil, gocql.ConvertError("ListNexusIncomingServices", cassErr)
}
// No result and no error means no services have been inserted yet, so return empty response.
response.TableVersion = 0
return response, nil
}
tableVersion, err := getTypedFieldFromRow[int64]("version", partitionStateRow)
if err != nil {
return nil, err
}
response.TableVersion = tableVersion
services, err := s.getServiceList(iter)
if err != nil {
return nil, err
}
response.Services = services
if len(iter.PageState()) > 0 {
response.NextPageToken = iter.PageState()
}
if err := iter.Close(); err != nil {
return nil, gocql.ConvertError("ListNexusIncomingServices", err)
}
return response, nil
}
func (s *NexusIncomingServiceStore) getTableVersion(ctx context.Context) (int64, error) {
query := s.session.Query(templateGetTableVersion, rowTypePartitionStatus, tableVersionServiceID).WithContext(ctx)
var version int64
if err := query.Scan(&version); err != nil {
return 0, gocql.ConvertError("GetNexusIncomingServicesTableVersion", err)
}
return version, nil
}
func (s *NexusIncomingServiceStore) getServiceList(iter gocql.Iter) ([]p.InternalNexusIncomingService, error) {
var services []p.InternalNexusIncomingService
row := make(map[string]interface{})
for iter.MapScan(row) {
serviceID, err := getTypedFieldFromRow[interface{}]("service_id", row)
if err != nil {
return nil, err
}
version, err := getTypedFieldFromRow[int64]("version", row)
if err != nil {
return nil, err
}
data, err := getTypedFieldFromRow[[]byte]("data", row)
if err != nil {
return nil, err
}
dataEncoding, err := getTypedFieldFromRow[string]("data_encoding", row)
if err != nil {
return nil, err
}
services = append(services, p.InternalNexusIncomingService{
ServiceID: gocql.UUIDToString(serviceID),
Version: version,
Data: p.NewDataBlob(data, dataEncoding),
})
row = make(map[string]interface{})
}
return services, nil
}