mirror of
https://github.com/hanzoai/tasks.git
synced 2026-10-04 02:04:03 +00:00
David ReissandGitHub
765cad2242
## What changed? Move some code around to avoid import cycles with future changes: - `common` depends on `common/dynamicconfig` (not changing) - I want to move dynamic config default values from all over into `common/dynamicconfig` - Some constants in `common` are used as default values. Moving them into `common/dynamicconfig` would create an import cycle. - So move the constants into `common/primitives` instead and reference them there. Also move `GetDefaultRetryPolicyConfigOptions`, `DefaultRetrySettings`, `FromConfigToDefaultRetrySettings`, `EnsureRetryPolicyDefaults`, `ValidateRetryPolicy` and associated unit test into new package `common/retrypolicy` with shorter names. Arguably more constants should move out of `common`, that package is too big. But these are the only ones that needed to be moved for now. ## Why? Split off from future PR to make reviews easier. ## How did you test it? existing tests
The primitives package is meant to contain definitions and constants that are widely used throughout this repository.
There should serve as the root package in that there should be no imports of any other Temporal package.